[Lldb-commits] [lldb] 28c3380 - Remove unnecessary std::moves [NFC]

2023-07-13 Thread Sterling Augustine via lldb-commits 

Author: Sterling Augustine
Date: 2023-07-13T19:24:01-07:00
New Revision: 28c33805d49366b5ef22c60b32df62f123adc3bb

URL: 
https://github.com/llvm/llvm-project/commit/28c33805d49366b5ef22c60b32df62f123adc3bb
DIFF: 
https://github.com/llvm/llvm-project/commit/28c33805d49366b5ef22c60b32df62f123adc3bb.diff

LOG: Remove unnecessary std::moves [NFC]

These trigger the following error:

error: moving a temporary object prevents copy elision 
[-Werror,-Wpessimizing-move]

Added: 


Modified: 
lldb/bindings/python/python-wrapper.swig

Removed: 




diff  --git a/lldb/bindings/python/python-wrapper.swig 
b/lldb/bindings/python/python-wrapper.swig
index c25fa0c4d9b5b1..cb54901e66d03c 100644
--- a/lldb/bindings/python/python-wrapper.swig
+++ b/lldb/bindings/python/python-wrapper.swig
@@ -1126,11 +1126,11 @@ static SBError LLDBSwigPythonCallLocateModuleCallback(
 
   PyErr_Cleaner py_err_cleaner(true);
   PythonObject module_spec_arg = SWIGBridge::ToSWIGWrapper(
-  std::move(std::make_unique(module_spec_sb)));
+  std::make_unique(module_spec_sb));
   PythonObject module_file_spec_arg = SWIGBridge::ToSWIGWrapper(
-  std::move(std::make_unique(module_file_spec_sb)));
+  std::make_unique(module_file_spec_sb));
   PythonObject symbol_file_spec_arg = SWIGBridge::ToSWIGWrapper(
-  std::move(std::make_unique(symbol_file_spec_sb)));
+  std::make_unique(symbol_file_spec_sb));
 
   PythonCallable callable =
   Retain(reinterpret_cast(callback_baton));



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 53862b5 - RenderScript still exists as a clang language, so handle as invalid

2023-02-16 Thread Sterling Augustine via lldb-commits 

Author: Sterling Augustine
Date: 2023-02-16T12:23:05-08:00
New Revision: 53862b5658dd2dd5a38ecd0b4476cd22920d8f2a

URL: 
https://github.com/llvm/llvm-project/commit/53862b5658dd2dd5a38ecd0b4476cd22920d8f2a
DIFF: 
https://github.com/llvm/llvm-project/commit/53862b5658dd2dd5a38ecd0b4476cd22920d8f2a.diff

LOG: RenderScript still exists as a clang language, so handle as invalid

Added: 


Modified: 
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

Removed: 




diff  --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp 
b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index fbbea3407d18b..af897a70bd094 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -474,6 +474,7 @@ static void ParseLangArgs(LangOptions , InputKind IK, 
const char *triple) {
 switch (IK.getLanguage()) {
 case clang::Language::Unknown:
 case clang::Language::LLVM_IR:
+case clang::Language::RenderScript:
   llvm_unreachable("Invalid input kind!");
 case clang::Language::OpenCL:
   LangStd = LangStandard::lang_opencl10;



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b8d3d02 - Remove now unused enum.

2023-02-16 Thread Sterling Augustine via lldb-commits 

Author: Sterling Augustine
Date: 2023-02-16T11:54:35-08:00
New Revision: b8d3d02d7c8c67ba50c4e9508c435365317def9c

URL: 
https://github.com/llvm/llvm-project/commit/b8d3d02d7c8c67ba50c4e9508c435365317def9c
DIFF: 
https://github.com/llvm/llvm-project/commit/b8d3d02d7c8c67ba50c4e9508c435365317def9c.diff

LOG: Remove now unused enum.

Added: 


Modified: 
lldb/include/lldb/lldb-enumerations.h

Removed: 




diff  --git a/lldb/include/lldb/lldb-enumerations.h 
b/lldb/include/lldb/lldb-enumerations.h
index f92e63cc45f4..10c35fb45078 100644
--- a/lldb/include/lldb/lldb-enumerations.h
+++ b/lldb/include/lldb/lldb-enumerations.h
@@ -485,7 +485,6 @@ enum LanguageType {
   // Language::SetLanguageFromCString and Language::AsCString assume these can
   // be used as indexes into array g_languages.
   eLanguageTypeMipsAssembler = 0x0024,   ///< Mips_Assembler.
-  eLanguageTypeExtRenderScript = 0x0025, ///< RenderScript.
   eNumLanguageTypes
 };
 



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5402110 - Revert "[lldb] Use portable format string PRIx64"

2023-02-13 Thread Sterling Augustine via lldb-commits 

Author: Pranav Kant
Date: 2023-02-13T15:51:36-08:00
New Revision: 5402110e0123ca323a5f6eaa3ed225027ce0179b

URL: 
https://github.com/llvm/llvm-project/commit/5402110e0123ca323a5f6eaa3ed225027ce0179b
DIFF: 
https://github.com/llvm/llvm-project/commit/5402110e0123ca323a5f6eaa3ed225027ce0179b.diff

LOG: Revert "[lldb] Use portable format string PRIx64"

This reverts commit be7d7ca1101840fc8e19e0e48f9dc395da569d23.

This commit was made to fix be7d7ca1101840fc8e19e0e48f9dc395da569d23
which got reverted in 620b3d9ba3343d7bc5bab2340174a20952fcd00f. We need
to revert this commit as well because types in log statements are 32 bit again.

Added: 


Modified: 
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp

Removed: 




diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp 
b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
index 113a8b352b66..a37499175858 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
@@ -76,8 +76,8 @@ void DWARFDebugAranges::Dump(Log *log) const {
   for (size_t i = 0; i < num_entries; ++i) {
 const RangeToDIE::Entry *entry = m_aranges.GetEntryAtIndex(i);
 if (entry)
-  LLDB_LOGF(log, "0x%8.8" PRIx64 ": [0x%" PRIx64 " - 0x%" PRIx64 ")",
-entry->data, entry->GetRangeBase(), entry->GetRangeEnd());
+  LLDB_LOGF(log, "0x%8.8x: [0x%" PRIx64 " - 0x%" PRIx64 ")", entry->data,
+entry->GetRangeBase(), entry->GetRangeEnd());
   }
 }
 



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7518e0f - Avoid using a variable-sized array for a tiny allocation.

2022-03-15 Thread Sterling Augustine via lldb-commits 

Author: Sterling Augustine
Date: 2022-03-15T13:00:14-07:00
New Revision: 7518e0ff63cdee4b4082e918e1b5603115777d9b

URL: 
https://github.com/llvm/llvm-project/commit/7518e0ff63cdee4b4082e918e1b5603115777d9b
DIFF: 
https://github.com/llvm/llvm-project/commit/7518e0ff63cdee4b4082e918e1b5603115777d9b.diff

LOG: Avoid using a variable-sized array for a tiny allocation.

Differential Revision: https://reviews.llvm.org/D121732

Added: 


Modified: 
lldb/source/Expression/DWARFExpression.cpp

Removed: 




diff  --git a/lldb/source/Expression/DWARFExpression.cpp 
b/lldb/source/Expression/DWARFExpression.cpp
index 0f6c380fe0357..5ee62fb4376b8 100644
--- a/lldb/source/Expression/DWARFExpression.cpp
+++ b/lldb/source/Expression/DWARFExpression.cpp
@@ -1297,7 +1297,7 @@ bool DWARFExpression::Evaluate(
 addr_t load_addr = *maybe_load_addr;
 
 if (load_addr == LLDB_INVALID_ADDRESS && so_addr.IsSectionOffset()) {
-  uint8_t addr_bytes[size];
+  uint8_t addr_bytes[8];
   Status error;
 
   if (exe_ctx->GetTargetRef().ReadMemory(
@@ -1306,7 +1306,7 @@ bool DWARFExpression::Evaluate(
 ObjectFile *objfile = module_sp->GetObjectFile();
 
 stack.back().GetScalar() = DerefSizeExtractDataHelper(
-addr_bytes, sizeof(addr_bytes), objfile->GetByteOrder(), size);
+addr_bytes, size, objfile->GetByteOrder(), size);
 stack.back().ClearContext();
 break;
   } else {



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4e5af6e - Revert "[lldb] Upstream support for Foundation constant classes"

2021-08-06 Thread Sterling Augustine via lldb-commits 

Author: Sterling Augustine
Date: 2021-08-06T16:56:59-07:00
New Revision: 4e5af6ef48590e7248e344ddabf245bb3de71c51

URL: 
https://github.com/llvm/llvm-project/commit/4e5af6ef48590e7248e344ddabf245bb3de71c51
DIFF: 
https://github.com/llvm/llvm-project/commit/4e5af6ef48590e7248e344ddabf245bb3de71c51.diff

LOG: Revert "[lldb] Upstream support for Foundation constant classes"

This reverts commit 34d78b6a6755946e547afc47d38b59b6a2854457.

This breaks build bots witha  missing file:
/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/source/Plugins/Language/ObjC/Cocoa.cpp:10:10:
 fatal error: 'objc/runtime.h' file not found

Added: 


Modified: 
lldb/source/Plugins/Language/ObjC/Cocoa.cpp
lldb/source/Plugins/Language/ObjC/NSArray.cpp
lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp

lldb/test/API/functionalities/data-formatter/data-formatter-objc/ObjCDataFormatterTestCase.py

lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSBundle.py

lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSContainer.py

lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSData.py

lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py

lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSError.py

lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSURL.py

lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjNSException.py
lldb/test/API/functionalities/data-formatter/data-formatter-objc/main.m

lldb/test/API/functionalities/data-formatter/nsdictionarysynth/TestNSDictionarySynthetic.py

lldb/test/API/functionalities/data-formatter/nssetsynth/TestNSSetSynthetic.py
lldb/test/API/functionalities/data-formatter/poarray/TestPrintObjectArray.py
lldb/test/API/lang/objc/orderedset/TestOrderedSet.py

lldb/test/API/lang/objc/single-entry-dictionary/TestObjCSingleEntryDictionary.py

Removed: 

lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSNumber.py



diff  --git a/lldb/source/Plugins/Language/ObjC/Cocoa.cpp 
b/lldb/source/Plugins/Language/ObjC/Cocoa.cpp
index e5dcf8441bb6..1479f4f0c151 100644
--- a/lldb/source/Plugins/Language/ObjC/Cocoa.cpp
+++ b/lldb/source/Plugins/Language/ObjC/Cocoa.cpp
@@ -7,7 +7,6 @@
 
//===--===//
 
 #include "Cocoa.h"
-#include "objc/runtime.h"
 
 #include "Plugins/TypeSystem/Clang/TypeSystemClang.h"
 #include "lldb/Core/Mangled.h"
@@ -457,72 +456,6 @@ bool lldb_private::formatters::NSNumberSummaryProvider(
   if (class_name == "NSDecimalNumber")
 return NSDecimalNumberSummaryProvider(valobj, stream, options);
 
-  if (class_name == "NSConstantIntegerNumber") {
-Status error;
-int64_t value = process_sp->ReadSignedIntegerFromMemory(
-valobj_addr + 2 * ptr_size, 8, 0, error);
-if (error.Fail())
-  return false;
-uint64_t encoding_addr = process_sp->ReadUnsignedIntegerFromMemory(
-valobj_addr + ptr_size, ptr_size, 0, error);
-if (error.Fail())
-  return false;
-char encoding =
-process_sp->ReadUnsignedIntegerFromMemory(encoding_addr, 1, 0, error);
-if (error.Fail())
-  return false;
-
-switch (encoding) {
-case _C_CHR:
-  NSNumber_FormatChar(valobj, stream, (char)value, options.GetLanguage());
-  return true;
-case _C_SHT:
-  NSNumber_FormatShort(valobj, stream, (short)value, 
options.GetLanguage());
-  return true;
-case _C_INT:
-  NSNumber_FormatInt(valobj, stream, (int)value, options.GetLanguage());
-  return true;
-case _C_LNG:
-case _C_LNG_LNG:
-  NSNumber_FormatLong(valobj, stream, value, options.GetLanguage());
-  return true;
-
-case _C_UCHR:
-case _C_USHT:
-case _C_UINT:
-case _C_ULNG:
-case _C_ULNG_LNG:
-  stream.Printf("%" PRIu64, value);
-  return true;
-}
-
-return false;
-  }
-
-  if (class_name == "NSConstantFloatNumber") {
-Status error;
-uint32_t flt_as_int = process_sp->ReadUnsignedIntegerFromMemory(
-valobj_addr + ptr_size, 4, 0, error);
-if (error.Fail())
-  return false;
-float flt_value = 0.0f;
-memcpy(_value, _as_int, sizeof(flt_as_int));
-NSNumber_FormatFloat(valobj, stream, flt_value, options.GetLanguage());
-return true;
-  }
-
-  if (class_name == "NSConstantDoubleNumber") {
-Status error;
-uint64_t dbl_as_lng = process_sp->ReadUnsignedIntegerFromMemory(
-valobj_addr + ptr_size, 8, 0, error);
-if (error.Fail())
-  return false;
-double dbl_value = 0.0;
-memcpy(_value, _as_lng,

[Lldb-commits] [lldb] 9dbdaea - Remove unused variable "saved_opts".

2020-08-06 Thread Sterling Augustine via lldb-commits 

Author: Sterling Augustine
Date: 2020-08-06T10:20:21-07:00
New Revision: 9dbdaea9a0e6f58417b5bd8980e7ea6723fd1783

URL: 
https://github.com/llvm/llvm-project/commit/9dbdaea9a0e6f58417b5bd8980e7ea6723fd1783
DIFF: 
https://github.com/llvm/llvm-project/commit/9dbdaea9a0e6f58417b5bd8980e7ea6723fd1783.diff

LOG: Remove unused variable "saved_opts".

wattr_get is a macro, and the documentation states:
"The parameter opts is reserved for  future use,
applications must supply a null pointer."

In practice, passing a variable there is harmless, except
that it is unused inside the macro, which causes unused
variable warnings.

The various places where

Added: 


Modified: 
lldb/source/Core/IOHandlerCursesGUI.cpp

Removed: 




diff  --git a/lldb/source/Core/IOHandlerCursesGUI.cpp 
b/lldb/source/Core/IOHandlerCursesGUI.cpp
index 931ddb2ea9e3..6a24625fc7eb 100644
--- a/lldb/source/Core/IOHandlerCursesGUI.cpp
+++ b/lldb/source/Core/IOHandlerCursesGUI.cpp
@@ -485,8 +485,7 @@ class Window {
 bool use_blue_background) {
 attr_t saved_attr;
 short saved_pair;
-int saved_opts;
-wattr_get(m_window, _attr, _pair, _opts);
+wattr_get(m_window, _attr, _pair, nullptr);
 if (use_blue_background)
   ::wattron(m_window, COLOR_PAIR(WhiteOnBlue));
 while (!string.empty()) {
@@ -522,7 +521,7 @@ class Window {
 continue;
   }
   if (value == 0) { // Reset.
-wattr_set(m_window, saved_attr, saved_pair, _opts);
+wattr_set(m_window, saved_attr, saved_pair, nullptr);
 if (use_blue_background)
   ::wattron(m_window, COLOR_PAIR(WhiteOnBlue));
   } else {
@@ -531,7 +530,7 @@ class Window {
   COLOR_PAIR(value - 30 + 1 + (use_blue_background ? 8 : 0)));
   }
 }
-wattr_set(m_window, saved_attr, saved_pair, _opts);
+wattr_set(m_window, saved_attr, saved_pair, nullptr);
   }
 
   void Touch() {



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5de4ba1 - Cleanup the plumbing for DILineInfoSpecifier. [NFC - Try 2]

2020-03-20 Thread Sterling Augustine via lldb-commits 

Author: Sterling Augustine
Date: 2020-03-20T10:29:57-07:00
New Revision: 5de4ba1770f4815dd36d449a9b64b0aec783159d

URL: 
https://github.com/llvm/llvm-project/commit/5de4ba1770f4815dd36d449a9b64b0aec783159d
DIFF: 
https://github.com/llvm/llvm-project/commit/5de4ba1770f4815dd36d449a9b64b0aec783159d.diff

LOG: Cleanup the plumbing for DILineInfoSpecifier. [NFC - Try 2]

Added: 


Modified: 
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
llvm/include/llvm/DebugInfo/DIContext.h
llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
llvm/include/llvm/DebugInfo/Symbolize/SymbolizableModule.h
llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h
llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

Removed: 




diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp 
b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
index 1e149d89153a..a703b1e1217d 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -185,7 +185,7 @@ GetFileByIndex(const llvm::DWARFDebugLine::Prologue 
, size_t idx,
 
   // Otherwise ask for a relative path.
   std::string rel_path;
-  auto relative = llvm::DILineInfoSpecifier::FileLineInfoKind::Default;
+  auto relative = llvm::DILineInfoSpecifier::FileLineInfoKind::RawValue;
   if (!prologue.getFileNameByIndex(idx, compile_dir, relative, rel_path, 
style))
 return {};
   return std::move(rel_path);

diff  --git a/llvm/include/llvm/DebugInfo/DIContext.h 
b/llvm/include/llvm/DebugInfo/DIContext.h
index 0bad415f6bfd..29e62f24b49a 100644
--- a/llvm/include/llvm/DebugInfo/DIContext.h
+++ b/llvm/include/llvm/DebugInfo/DIContext.h
@@ -136,7 +136,11 @@ enum class DINameKind { None, ShortName, LinkageName };
 struct DILineInfoSpecifier {
   enum class FileLineInfoKind {
 None,
-Default,
+// RawValue is whatever the compiler stored in the filename table.  Could 
be
+// a full path, could be something else.
+RawValue,
+BaseNameOnly,
+// Relative to the compilation directory.
 RelativeFilePath,
 AbsoluteFilePath
   };
@@ -145,7 +149,7 @@ struct DILineInfoSpecifier {
   FileLineInfoKind FLIKind;
   FunctionNameKind FNKind;
 
-  DILineInfoSpecifier(FileLineInfoKind FLIKind = FileLineInfoKind::Default,
+  DILineInfoSpecifier(FileLineInfoKind FLIKind = FileLineInfoKind::RawValue,
   FunctionNameKind FNKind = FunctionNameKind::None)
   : FLIKind(FLIKind), FNKind(FNKind) {}
 };

diff  --git a/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h 
b/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
index db7a61a8f160..8d4c64915ffd 100644
--- a/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
+++ b/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
@@ -14,6 +14,7 @@
 #ifndef LLVM_DEBUGINFO_SYMBOLIZE_DIPRINTER_H
 #define LLVM_DEBUGINFO_SYMBOLIZE_DIPRINTER_H
 
+#include "llvm/DebugInfo/DIContext.h"
 #include "llvm/Support/raw_ostream.h"
 
 namespace llvm {
@@ -34,7 +35,6 @@ class DIPrinter {
   bool PrintPretty;
   int PrintSourceContext;
   bool Verbose;
-  bool Basenames;
   OutputStyle Style;
 
   void print(const DILineInfo , bool Inlined);
@@ -43,11 +43,10 @@ class DIPrinter {
 public:
   DIPrinter(raw_ostream , bool PrintFunctionNames = true,
 bool PrintPretty = false, int PrintSourceContext = 0,
-bool Verbose = false, bool Basenames = false,
-OutputStyle Style = OutputStyle::LLVM)
+bool Verbose = false, OutputStyle Style = OutputStyle::LLVM)
   : OS(OS), PrintFunctionNames(PrintFunctionNames),
 PrintPretty(PrintPretty), PrintSourceContext(PrintSourceContext),
-Verbose(Verbose), Basenames(Basenames), Style(Style) {}
+Verbose(Verbose), Style(Style) {}
 
   DIPrinter <<(const DILineInfo );
   DIPrinter <<(const DIInliningInfo );
@@ -58,4 +57,3 @@ class DIPrinter {
 }
 
 #endif
-

diff  --git a/llvm/include/llvm/DebugInfo/Symbolize/SymbolizableModule.h 
b/llvm/include/llvm/DebugInfo/Symbolize/SymbolizableModule.h
index 506ecc424b4c..51e92b83eadb 100644
--- a/llvm/include/llvm/DebugInfo/Symbolize/SymbolizableModule.h
+++ b/llvm/include/llvm/DebugInfo/Symbolize/SymbolizableModule.h
@@ -25,11 +25,12 @@ class SymbolizableModule {
   virtual ~SymbolizableModule() = default;
 
   virtual DILineInfo symbolizeCode(object::SectionedAddress ModuleOffset,
-   FunctionNameKind FNKind,
+   DILineInfoSpecifier LineInfoSpecifier,
bool UseSymbolTable) const = 0;
   virtual

[Lldb-commits] [lldb] r375174 - (NFC) Delete variable made unused by llvm-svn: 375160

2019-10-17 Thread Sterling Augustine via lldb-commits 
Author: saugustine
Date: Thu Oct 17 14:40:12 2019
New Revision: 375174

URL: http://llvm.org/viewvc/llvm-project?rev=375174=rev
Log:
(NFC) Delete variable made unused by llvm-svn: 375160

Reviewers: aprantl

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69143

Modified:
lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp?rev=375174=375173=375174=diff
==
--- lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Thu Oct 17 
14:40:12 2019
@@ -1352,7 +1352,6 @@ void SymbolFilePDB::FindFunctions(const
   if (!regex.IsValid())
 return;
 
-  auto old_size = sc_list.GetSize();
   CacheFunctionNames();
 
   std::set resolved_ids;


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r337070 - Update ClangASTContext for the new DependentVector type.

2019-10-04 Thread Sterling Augustine via lldb-commits 
Author: saugustine
Date: Fri Jul 13 15:54:41 2018
New Revision: 337070

URL: http://llvm.org/viewvc/llvm-project?rev=337070=rev
Log:
Update ClangASTContext for the new DependentVector type.

https://reviews.llvm.org/D49326

Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp

Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=337070=337069=337070=diff
==
--- lldb/trunk/source/Symbol/ClangASTContext.cpp (original)
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp Fri Jul 13 15:54:41 2018
@@ -5105,6 +5105,7 @@ lldb::Encoding ClangASTContext::GetEncod
 .GetEncoding(count);
   case clang::Type::DependentSizedArray:
   case clang::Type::DependentSizedExtVector:
+  case clang::Type::DependentVector:
   case clang::Type::UnresolvedUsing:
   case clang::Type::Attributed:
   case clang::Type::TemplateTypeParm:
@@ -5272,6 +5273,7 @@ lldb::Format ClangASTContext::GetFormat(
 .GetFormat();
   case clang::Type::DependentSizedArray:
   case clang::Type::DependentSizedExtVector:
+  case clang::Type::DependentVector:
   case clang::Type::UnresolvedUsing:
   case clang::Type::Attributed:
   case clang::Type::TemplateTypeParm:


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r337071 - Rollback r337070.

2019-10-04 Thread Sterling Augustine via lldb-commits 
Author: saugustine
Date: Fri Jul 13 16:03:15 2018
New Revision: 337071

URL: http://llvm.org/viewvc/llvm-project?rev=337071=rev
Log:
Rollback r337070.

Someone simultaneously fixed the breakage it was designed to fix.


Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp

Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=337071=337070=337071=diff
==
--- lldb/trunk/source/Symbol/ClangASTContext.cpp (original)
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp Fri Jul 13 16:03:15 2018
@@ -5105,7 +5105,6 @@ lldb::Encoding ClangASTContext::GetEncod
 .GetEncoding(count);
   case clang::Type::DependentSizedArray:
   case clang::Type::DependentSizedExtVector:
-  case clang::Type::DependentVector:
   case clang::Type::UnresolvedUsing:
   case clang::Type::Attributed:
   case clang::Type::TemplateTypeParm:
@@ -5273,7 +5272,6 @@ lldb::Format ClangASTContext::GetFormat(
 .GetFormat();
   case clang::Type::DependentSizedArray:
   case clang::Type::DependentSizedExtVector:
-  case clang::Type::DependentVector:
   case clang::Type::UnresolvedUsing:
   case clang::Type::Attributed:
   case clang::Type::TemplateTypeParm:


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits