[Lldb-commits] [PATCH] D121487: [lldb] Require native for command-thread-siginfo.test
This revision was automatically updated to reflect the committed changes. Closed by commit rGd506a9ef2b32: [lldb] Require native for command-thread-siginfo.test (authored by asahay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121487/new/ https://reviews.llvm.org/D121487 Files: lldb/test/Shell/Commands/command-thread-siginfo.test Index: lldb/test/Shell/Commands/command-thread-siginfo.test === --- lldb/test/Shell/Commands/command-thread-siginfo.test +++ lldb/test/Shell/Commands/command-thread-siginfo.test @@ -1,4 +1,4 @@ -# REQUIRES: system-linux +# REQUIRES: native && system-linux # RUN: %clang_host -g %S/Inputs/sigchld.c -o %t # RUN: %lldb %t -b -s %s | FileCheck %s Index: lldb/test/Shell/Commands/command-thread-siginfo.test === --- lldb/test/Shell/Commands/command-thread-siginfo.test +++ lldb/test/Shell/Commands/command-thread-siginfo.test @@ -1,4 +1,4 @@ -# REQUIRES: system-linux +# REQUIRES: native && system-linux # RUN: %clang_host -g %S/Inputs/sigchld.c -o %t # RUN: %lldb %t -b -s %s | FileCheck %s ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D121487: [lldb] Require native for command-thread-siginfo.test
mgorny accepted this revision. mgorny added a comment. Thanks for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121487/new/ https://reviews.llvm.org/D121487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D121487: [lldb] Require native for command-thread-siginfo.test
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, although I would be surprised if this was the only test which suffered from the same problem. Another possibility would be to make the %clang_host substitution smarter and have it always build for the host, regardless of the value of llvm's default target triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121487/new/ https://reviews.llvm.org/D121487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D121487: [lldb] Require native for command-thread-siginfo.test
asahay created this revision. Herald added a project: All. asahay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. command-thread-siginfo.test employs a subject with a call to wait, and thus requires system-linux. However, it's possible to target non-Linux platforms despite operating on Linux hosts. So, have it require native too. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121487 Files: lldb/test/Shell/Commands/command-thread-siginfo.test Index: lldb/test/Shell/Commands/command-thread-siginfo.test === --- lldb/test/Shell/Commands/command-thread-siginfo.test +++ lldb/test/Shell/Commands/command-thread-siginfo.test @@ -1,4 +1,4 @@ -# REQUIRES: system-linux +# REQUIRES: native && system-linux # RUN: %clang_host -g %S/Inputs/sigchld.c -o %t # RUN: %lldb %t -b -s %s | FileCheck %s Index: lldb/test/Shell/Commands/command-thread-siginfo.test === --- lldb/test/Shell/Commands/command-thread-siginfo.test +++ lldb/test/Shell/Commands/command-thread-siginfo.test @@ -1,4 +1,4 @@ -# REQUIRES: system-linux +# REQUIRES: native && system-linux # RUN: %clang_host -g %S/Inputs/sigchld.c -o %t # RUN: %lldb %t -b -s %s | FileCheck %s ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
