[Lldb-commits] [PATCH] D123205: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). NFC.
This revision was automatically updated to reflect the committed changes. Closed by commit rG6e38824221db: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123205/new/ https://reviews.llvm.org/D123205 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp === --- lldb/source/Core/Debugger.cpp +++ lldb/source/Core/Debugger.cpp @@ -893,7 +893,8 @@ return result; } - write(fds[WRITE], data, size); + int r = write(fds[WRITE], data, size); + (void)r; // Close the write end of the pipe, so that the command interpreter will exit // when it consumes all the data. llvm::sys::Process::SafelyCloseFileDescriptor(fds[WRITE]); Index: lldb/source/Core/Debugger.cpp === --- lldb/source/Core/Debugger.cpp +++ lldb/source/Core/Debugger.cpp @@ -893,7 +893,8 @@ return result; } - write(fds[WRITE], data, size); + int r = write(fds[WRITE], data, size); + (void)r; // Close the write end of the pipe, so that the command interpreter will exit // when it consumes all the data. llvm::sys::Process::SafelyCloseFileDescriptor(fds[WRITE]); ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D123205: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). NFC.
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. The gcc behavior is quite annoying here... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123205/new/ https://reviews.llvm.org/D123205 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D123205: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). NFC.
mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This matches how another similar warning is silenced in Host/posix/ProcessLauncherPosixFork.cpp. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123205 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp === --- lldb/source/Core/Debugger.cpp +++ lldb/source/Core/Debugger.cpp @@ -893,7 +893,8 @@ return result; } - write(fds[WRITE], data, size); + int r = write(fds[WRITE], data, size); + (void)r; // Close the write end of the pipe, so that the command interpreter will exit // when it consumes all the data. llvm::sys::Process::SafelyCloseFileDescriptor(fds[WRITE]); Index: lldb/source/Core/Debugger.cpp === --- lldb/source/Core/Debugger.cpp +++ lldb/source/Core/Debugger.cpp @@ -893,7 +893,8 @@ return result; } - write(fds[WRITE], data, size); + int r = write(fds[WRITE], data, size); + (void)r; // Close the write end of the pipe, so that the command interpreter will exit // when it consumes all the data. llvm::sys::Process::SafelyCloseFileDescriptor(fds[WRITE]); ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
