[Lldb-commits] [PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

[Fangrui Song via Phabricator via lldb-commits]

MaskRay added a comment.

In D128465#3660733 , @ckissane wrote:

> In D128465#3660714 , @MaskRay wrote:
>
>> Instead of marking a differential `[OLD] ` (which may confuse readers 
>> whether this is to be abandoned), you can mark a differential `Request 
>> Reviews`/`Request Changes`. Then it will not be in the green state.
>>
>> I clicked "Reopen" to make it clear the patch hasn't relanded.
>
> Oh, sorry about that!

That's fine :) We need to learn the web UI.

> I had actually created https://reviews.llvm.org/D129786 instead of reopening 
> this one because at the time I tried, reopening didn't seem to work.

A reverted patch by default is still in the "Closed" state. You can "reopen" it 
so that people know it hasn't relanded.
When repairing a differential, just reuse the existing patch. It keeps all 
discussions (including past suggestions and issues a previous commit did not 
address) in one thread.
If the new patch is very similar to this one, you probably need to abandon it 
in favor of this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128465/new/

https://reviews.llvm.org/D128465

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

[Cole Kissane via Phabricator via lldb-commits]

ckissane added a comment.

In D128465#3660714 , @MaskRay wrote:

> Instead of marking a differential `[OLD] ` (which may confuse readers whether 
> this is to be abandoned), you can mark a differential `Request 
> Reviews`/`Request Changes`. Then it will not be in the green state.
>
> I clicked "Reopen" to make it clear the patch hasn't relanded.

Oh, sorry about that!
I had actually created https://reviews.llvm.org/D129786 instead of reopening 
this one because at the time I tried, reopening didn't seem to work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128465/new/

https://reviews.llvm.org/D128465

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

[Fangrui Song via Phabricator via lldb-commits]

MaskRay added a comment.

Instead of marking a differential `[OLD] ` (which may confuse readers whether 
this is to be abandoned), you can mark a differential `Request 
Reviews`/`Request Changes`. Then it will not be in the green state.

I clicked "Reopen" to make it clear the patch hasn't relanded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128465/new/

https://reviews.llvm.org/D128465

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits