Re: [Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

2015-10-23 Thread Tamas Berghammer via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251107: Disable the strict-aliasing warnings produced by gcc 
(authored by tberghammer).

Changed prior to commit:
  http://reviews.llvm.org/D13981?vs=38115&id=38226#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D13981

Files:
  lldb/trunk/cmake/modules/LLDBConfig.cmake

Index: lldb/trunk/cmake/modules/LLDBConfig.cmake
===
--- lldb/trunk/cmake/modules/LLDBConfig.cmake
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake
@@ -210,6 +210,12 @@
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas")
 endif ()
 
+check_cxx_compiler_flag("-Wno-strict-aliasing"
+CXX_SUPPORTS_NO_STRICT_ALIASING)
+if (CXX_SUPPORTS_NO_STRICT_ALIASING)
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-strict-aliasing")
+endif ()
+
 # Disable Clang warnings
 check_cxx_compiler_flag("-Wno-deprecated-register"
 CXX_SUPPORTS_NO_DEPRECATED_REGISTER)


Index: lldb/trunk/cmake/modules/LLDBConfig.cmake
===
--- lldb/trunk/cmake/modules/LLDBConfig.cmake
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake
@@ -210,6 +210,12 @@
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas")
 endif ()
 
+check_cxx_compiler_flag("-Wno-strict-aliasing"
+CXX_SUPPORTS_NO_STRICT_ALIASING)
+if (CXX_SUPPORTS_NO_STRICT_ALIASING)
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-strict-aliasing")
+endif ()
+
 # Disable Clang warnings
 check_cxx_compiler_flag("-Wno-deprecated-register"
 CXX_SUPPORTS_NO_DEPRECATED_REGISTER)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

2015-10-23 Thread Tamas Berghammer via lldb-commits 
tberghammer added a comment.

I created a bug for it as https://llvm.org/bugs/show_bug.cgi?id=25296

I don't see too much value in creating a "janitor" mode because I think when 
people want to do some cleanup, they will focus on one specific area where they 
enable the necessary warnings manually. Enabling the "janitor" mode will most 
likely create too much noise at once to handle it especially if we hide more 
and more "feature" behind it over the time


http://reviews.llvm.org/D13981



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

2015-10-22 Thread Bruce Mitchener via lldb-commits 
brucem added a comment.

It might be worthwhile to have a "janitor" where we can not enable things like 
this so that it is more clear that this is something we'd like to clean up over 
time.

It would be pretty easy to just have a `if (NOT LLDB_JANITOR_MODE AND 
CXX_SUPPORTS_NO_STRICT_ALIASING)` check probably, but then we'd need docs to 
discuss `LLDB_JANITOR_MODE`.

Don't know.


http://reviews.llvm.org/D13981



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

2015-10-22 Thread Pavel Labath via lldb-commits 
labath added a subscriber: labath.
labath added a comment.

Could you also file a bug about that? most of these are real problems I think, 
and we should not forget them...


http://reviews.llvm.org/D13981



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

2015-10-22 Thread Tamas Berghammer via lldb-commits 
tberghammer created this revision.
tberghammer added reviewers: clayborg, brucem.
tberghammer added a subscriber: lldb-commits.

Disable the strict-aliasing warnings produced by gcc

GCC produce a lot of strict-aliasing warning for the LLDB codebase
what makes reading the compile output very difficult. This change
disable these warnings to reduce the noise as we already ignore them.

We should consider re-enabling the warning if we fix all (or most)
strict-aliasing violation first.

http://reviews.llvm.org/D13981

Files:
  cmake/modules/LLDBConfig.cmake

Index: cmake/modules/LLDBConfig.cmake
===
--- cmake/modules/LLDBConfig.cmake
+++ cmake/modules/LLDBConfig.cmake
@@ -210,6 +210,12 @@
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas")
 endif ()
 
+check_cxx_compiler_flag("-Wno-strict-aliasing"
+CXX_SUPPORTS_NO_STRICT_ALIASING)
+if (CXX_SUPPORTS_NO_STRICT_ALIASING)
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-strict-aliasing")
+endif ()
+
 # Disable Clang warnings
 check_cxx_compiler_flag("-Wno-deprecated-register"
 CXX_SUPPORTS_NO_DEPRECATED_REGISTER)


Index: cmake/modules/LLDBConfig.cmake
===
--- cmake/modules/LLDBConfig.cmake
+++ cmake/modules/LLDBConfig.cmake
@@ -210,6 +210,12 @@
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas")
 endif ()
 
+check_cxx_compiler_flag("-Wno-strict-aliasing"
+CXX_SUPPORTS_NO_STRICT_ALIASING)
+if (CXX_SUPPORTS_NO_STRICT_ALIASING)
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-strict-aliasing")
+endif ()
+
 # Disable Clang warnings
 check_cxx_compiler_flag("-Wno-deprecated-register"
 CXX_SUPPORTS_NO_DEPRECATED_REGISTER)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits