Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

2015-10-26 Thread Pavel Labath via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251277: Port the python api decorator to use test categories 
(authored by labath).

Changed prior to commit:
  http://reviews.llvm.org/D14020?vs=38235=38383#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D14020

Files:
  lldb/trunk/test/dotest.py
  lldb/trunk/test/dotest_args.py
  lldb/trunk/test/expression_command/test/TestExprs.py
  
lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommandsFromPython.py
  
lldb/trunk/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py
  
lldb/trunk/test/functionalities/breakpoint/breakpoint_ignore_count/TestBreakpointIgnoreCount.py
  
lldb/trunk/test/functionalities/breakpoint/cpp_exception/TestCPPExceptionBreakpoint.py
  lldb/trunk/test/functionalities/command_script/import/TestImport.py
  
lldb/trunk/test/functionalities/command_script/import/rdar-12586188/TestRdar12586188.py
  lldb/trunk/test/functionalities/conditional_break/TestConditionalBreak.py
  
lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libcxx/list/loop/TestDataFormatterLibcxxListLoop.py
  
lldb/trunk/test/functionalities/dynamic_value_child_count/TestDynamicValueChildCount.py
  lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py
  lldb/trunk/test/functionalities/inferior-crashing/TestInferiorCrashing.py
  
lldb/trunk/test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
  lldb/trunk/test/functionalities/inline-stepping/TestInlineStepping.py
  lldb/trunk/test/functionalities/return-value/TestReturnValue.py
  lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
  
lldb/trunk/test/functionalities/thread/thread_specific_break/TestThreadSpecificBreakpoint.py
  
lldb/trunk/test/functionalities/watchpoint/watchpoint_events/TestWatchpointEvents.py
  lldb/trunk/test/lang/c/array_types/TestArrayTypes.py
  lldb/trunk/test/lang/c/bitfields/TestBitfields.py
  lldb/trunk/test/lang/c/stepping/TestStepAndBreakpoints.py
  lldb/trunk/test/lang/cpp/class_static/TestStaticVariables.py
  lldb/trunk/test/lang/cpp/class_types/TestClassTypes.py
  lldb/trunk/test/lang/cpp/class_types/TestClassTypesDisassembly.py
  lldb/trunk/test/lang/cpp/dynamic-value/TestCppValueCast.py
  lldb/trunk/test/lang/cpp/dynamic-value/TestDynamicValue.py
  lldb/trunk/test/lang/cpp/stl/TestSTL.py
  lldb/trunk/test/lang/go/goroutines/TestGoroutines.py
  lldb/trunk/test/lang/go/types/TestGoASTContext.py
  lldb/trunk/test/lang/objc/blocks/TestObjCIvarsInBlocks.py
  lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py
  lldb/trunk/test/lang/objc/foundation/TestObjectDescriptionAPI.py
  lldb/trunk/test/lang/objc/foundation/TestSymbolTable.py
  lldb/trunk/test/lang/objc/objc-baseclass-sbtype/TestObjCBaseClassSBType.py
  lldb/trunk/test/lang/objc/objc-builtin-types/TestObjCBuiltinTypes.py
  lldb/trunk/test/lang/objc/objc-checker/TestObjCCheckers.py
  lldb/trunk/test/lang/objc/objc-class-method/TestObjCClassMethod.py
  lldb/trunk/test/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py
  lldb/trunk/test/lang/objc/objc-ivar-offsets/TestObjCIvarOffsets.py
  lldb/trunk/test/lang/objc/objc-ivar-stripped/TestObjCIvarStripped.py
  lldb/trunk/test/lang/objc/objc-property/TestObjCProperty.py
  
lldb/trunk/test/lang/objc/objc-static-method-stripped/TestObjCStaticMethodStripped.py
  lldb/trunk/test/lang/objc/objc-static-method/TestObjCStaticMethod.py
  lldb/trunk/test/lang/objc/objc-stepping/TestObjCStepping.py
  lldb/trunk/test/lang/objc/objc-struct-argument/TestObjCStructArgument.py
  lldb/trunk/test/lang/objc/objc-struct-return/TestObjCStructReturn.py
  lldb/trunk/test/lang/objc/objc-super/TestObjCSuper.py
  lldb/trunk/test/lldbtest.py
  lldb/trunk/test/macosx/indirect_symbol/TestIndirectSymbols.py
  lldb/trunk/test/macosx/queues/TestQueues.py
  lldb/trunk/test/macosx/safe-to-func-call/TestSafeFuncCalls.py
  lldb/trunk/test/macosx/universal/TestUniversal.py
  lldb/trunk/test/python_api/breakpoint/TestBreakpointAPI.py
  lldb/trunk/test/python_api/class_members/TestSBTypeClassMembers.py
  lldb/trunk/test/python_api/debugger/TestDebuggerAPI.py
  
lldb/trunk/test/python_api/default-constructor/TestDefaultConstructorForAPIObjects.py
  lldb/trunk/test/python_api/disassemble-raw-data/TestDisassembleRawData.py
  lldb/trunk/test/python_api/disassemble-raw-data/TestDisassemble_VST1_64.py
  lldb/trunk/test/python_api/event/TestEvents.py
  lldb/trunk/test/python_api/findvalue_duplist/TestSBFrameFindValue.py
  lldb/trunk/test/python_api/formatters/TestFormattersSBAPI.py
  lldb/trunk/test/python_api/frame/TestFrames.py
  lldb/trunk/test/python_api/frame/inlines/TestInlinedFrame.py
  lldb/trunk/test/python_api/function_symbol/TestDisasmAPI.py
  lldb/trunk/test/python_api/function_symbol/TestSymbolAPI.py
  lldb/trunk/test/python_api/hello_world/TestHelloWorld.py
  lldb/trunk/test/python_api/interpreter/TestCommandInterpreterAPI.py

Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

2015-10-23 Thread Zachary Turner via lldb-commits 
Yea that sounds good too.

On Fri, Oct 23, 2015 at 10:12 AM Pavel Labath  wrote:

> labath added a comment.
>
> test_categories is the name of .py file. :/ How about
> `add_test_categories` ?
>
>
> http://reviews.llvm.org/D14020
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

2015-10-23 Thread Zachary Turner via lldb-commits 
zturner added a comment.

Could you call this something less generic than `categories`?  The name of the 
decorator should be descriptive enough to hint that it can only be applied to 
test methods.  `test_categories` even.


http://reviews.llvm.org/D14020



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

2015-10-23 Thread Pavel Labath via lldb-commits 
labath added a comment.

test_categories is the name of .py file. :/ How about `add_test_categories` ?


http://reviews.llvm.org/D14020



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

2015-10-23 Thread Pavel Labath via lldb-commits 
labath created this revision.
labath added reviewers: tberghammer, tfiala, granata.enrico, zturner.
labath added a subscriber: lldb-commits.

Per discussions on the mailing list, I have implemented a decorator which 
annotates individual
test methods with categories. I have used this framework to replace the '-a' 
and '+a'
command-line switches (now '-G pyapi' and '--skip-category pyapi') and the 
@python_api_test
decorator (now @categories('pyapi')). The test suite now gives an error message 
suggesting the
new options if the user specifies the deprecated +/-a switches. If the general 
direction is good,
I will follow this up with other switches.

http://reviews.llvm.org/D14020

Files:
  test/dotest.py
  test/dotest_args.py
  test/expression_command/test/TestExprs.py
  
test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommandsFromPython.py
  
test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py
  
test/functionalities/breakpoint/breakpoint_ignore_count/TestBreakpointIgnoreCount.py
  test/functionalities/breakpoint/cpp_exception/TestCPPExceptionBreakpoint.py
  test/functionalities/command_script/import/TestImport.py
  test/functionalities/command_script/import/rdar-12586188/TestRdar12586188.py
  test/functionalities/conditional_break/TestConditionalBreak.py
  
test/functionalities/data-formatter/data-formatter-stl/libcxx/list/loop/TestDataFormatterLibcxxListLoop.py
  test/functionalities/dynamic_value_child_count/TestDynamicValueChildCount.py
  test/functionalities/inferior-assert/TestInferiorAssert.py
  test/functionalities/inferior-crashing/TestInferiorCrashing.py
  
test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
  test/functionalities/inline-stepping/TestInlineStepping.py
  test/functionalities/return-value/TestReturnValue.py
  test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
  
test/functionalities/thread/thread_specific_break/TestThreadSpecificBreakpoint.py
  test/functionalities/watchpoint/watchpoint_events/TestWatchpointEvents.py
  test/lang/c/array_types/TestArrayTypes.py
  test/lang/c/bitfields/TestBitfields.py
  test/lang/c/stepping/TestStepAndBreakpoints.py
  test/lang/cpp/class_static/TestStaticVariables.py
  test/lang/cpp/class_types/TestClassTypes.py
  test/lang/cpp/class_types/TestClassTypesDisassembly.py
  test/lang/cpp/dynamic-value/TestCppValueCast.py
  test/lang/cpp/dynamic-value/TestDynamicValue.py
  test/lang/cpp/stl/TestSTL.py
  test/lang/go/goroutines/TestGoroutines.py
  test/lang/go/types/TestGoASTContext.py
  test/lang/objc/blocks/TestObjCIvarsInBlocks.py
  test/lang/objc/foundation/TestObjCMethods.py
  test/lang/objc/foundation/TestObjectDescriptionAPI.py
  test/lang/objc/foundation/TestSymbolTable.py
  test/lang/objc/objc-baseclass-sbtype/TestObjCBaseClassSBType.py
  test/lang/objc/objc-builtin-types/TestObjCBuiltinTypes.py
  test/lang/objc/objc-checker/TestObjCCheckers.py
  test/lang/objc/objc-class-method/TestObjCClassMethod.py
  test/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py
  test/lang/objc/objc-ivar-offsets/TestObjCIvarOffsets.py
  test/lang/objc/objc-ivar-stripped/TestObjCIvarStripped.py
  test/lang/objc/objc-property/TestObjCProperty.py
  test/lang/objc/objc-static-method-stripped/TestObjCStaticMethodStripped.py
  test/lang/objc/objc-static-method/TestObjCStaticMethod.py
  test/lang/objc/objc-stepping/TestObjCStepping.py
  test/lang/objc/objc-struct-argument/TestObjCStructArgument.py
  test/lang/objc/objc-struct-return/TestObjCStructReturn.py
  test/lang/objc/objc-super/TestObjCSuper.py
  test/lldbtest.py
  test/macosx/indirect_symbol/TestIndirectSymbols.py
  test/macosx/queues/TestQueues.py
  test/macosx/safe-to-func-call/TestSafeFuncCalls.py
  test/macosx/universal/TestUniversal.py
  test/python_api/breakpoint/TestBreakpointAPI.py
  test/python_api/class_members/TestSBTypeClassMembers.py
  test/python_api/debugger/TestDebuggerAPI.py
  test/python_api/default-constructor/TestDefaultConstructorForAPIObjects.py
  test/python_api/disassemble-raw-data/TestDisassembleRawData.py
  test/python_api/disassemble-raw-data/TestDisassemble_VST1_64.py
  test/python_api/event/TestEvents.py
  test/python_api/findvalue_duplist/TestSBFrameFindValue.py
  test/python_api/formatters/TestFormattersSBAPI.py
  test/python_api/frame/TestFrames.py
  test/python_api/frame/inlines/TestInlinedFrame.py
  test/python_api/function_symbol/TestDisasmAPI.py
  test/python_api/function_symbol/TestSymbolAPI.py
  test/python_api/hello_world/TestHelloWorld.py
  test/python_api/interpreter/TestCommandInterpreterAPI.py
  test/python_api/lldbutil/frame/TestFrameUtils.py
  test/python_api/lldbutil/iter/TestLLDBIterator.py
  test/python_api/lldbutil/iter/TestRegistersIterator.py
  test/python_api/lldbutil/process/TestPrintStackTraces.py
  test/python_api/module_section/TestModuleAndSection.py
  test/python_api/objc_type/TestObjCType.py
  test/python_api/process/TestProcessAPI.py