Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

2015-12-14 Thread Kamil Rytarowski via lldb-commits
krytarowski added inline comments.


Comment at: source/Target/UnixSignals.cpp:66
@@ -64,4 +65,3 @@
 case llvm::Triple::FreeBSD:
 case llvm::Triple::OpenBSD:
 return std::make_shared();

emaste wrote:
> Not part of your change, but just spotted it during this review; The default 
> case should probably be used for OpenBSD. We can change it later.
I will leave it as it is.


Repository:
  rL LLVM

http://reviews.llvm.org/D15482



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

2015-12-14 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 42800.
krytarowski added a comment.

Improve abc order of source files


Repository:
  rL LLVM

http://reviews.llvm.org/D15482

Files:
  source/Plugins/Process/Utility/CMakeLists.txt
  source/Plugins/Process/Utility/NetBSDSignals.cpp
  source/Plugins/Process/Utility/NetBSDSignals.h
  source/Target/UnixSignals.cpp

Index: source/Target/UnixSignals.cpp
===
--- source/Target/UnixSignals.cpp
+++ source/Target/UnixSignals.cpp
@@ -19,6 +19,7 @@
 #include "Plugins/Process/Utility/FreeBSDSignals.h"
 #include "Plugins/Process/Utility/LinuxSignals.h"
 #include "Plugins/Process/Utility/MipsLinuxSignals.h"
+#include "Plugins/Process/Utility/NetBSDSignals.h"
 
 using namespace lldb_private;
 
@@ -63,8 +64,9 @@
 }
 case llvm::Triple::FreeBSD:
 case llvm::Triple::OpenBSD:
-case llvm::Triple::NetBSD:
 return std::make_shared();
+case llvm::Triple::NetBSD:
+return std::make_shared();
 default:
 return std::make_shared();
 }
Index: source/Plugins/Process/Utility/NetBSDSignals.h
===
--- /dev/null
+++ source/Plugins/Process/Utility/NetBSDSignals.h
@@ -0,0 +1,31 @@
+//===-- NetBSDSignals.h *- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#ifndef liblldb_NetBSDSignals_H_
+#define liblldb_NetBSDSignals_H_
+
+// Project includes
+#include "lldb/Target/UnixSignals.h"
+
+namespace lldb_private {
+
+/// NetBSD specific set of Unix signals.
+class NetBSDSignals : public UnixSignals
+{
+public:
+NetBSDSignals();
+
+private:
+void
+Reset() override;
+};
+
+} // namespace lldb_private
+
+#endif // liblldb_NetBSDSignals_H_
Index: source/Plugins/Process/Utility/NetBSDSignals.cpp
===
--- /dev/null
+++ source/Plugins/Process/Utility/NetBSDSignals.cpp
@@ -0,0 +1,34 @@
+//===-- NetBSDSignals.cpp --*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+// C Includes
+// C++ Includes
+// Other libraries and framework includes
+// Project includes
+#include "NetBSDSignals.h"
+
+using namespace lldb_private;
+
+NetBSDSignals::NetBSDSignals()
+: UnixSignals()
+{
+Reset();
+}
+
+void
+NetBSDSignals::Reset()
+{
+UnixSignals::Reset();
+//SIGNO  NAME  SUPPRESS STOP   NOTIFY DESCRIPTION
+//==    == == ===
+AddSignal (32,   "SIGPWR", false,   true , true , "power fail/restart (not reset when caught)");
+#ifdef SIGRTMIN /* SIGRTMAX */
+/* Kernel only; not exposed to userland yet */
+#endif
+}
Index: source/Plugins/Process/Utility/CMakeLists.txt
===
--- source/Plugins/Process/Utility/CMakeLists.txt
+++ source/Plugins/Process/Utility/CMakeLists.txt
@@ -9,6 +9,7 @@
   InferiorCallPOSIX.cpp
   LinuxSignals.cpp
   MipsLinuxSignals.cpp
+  NetBSDSignals.cpp
   RegisterContextDarwin_arm.cpp
   RegisterContextDarwin_arm64.cpp
   RegisterContextDarwin_i386.cpp
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

2015-12-14 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment.

Thank you. After fixing the order I'm going to land this diff.



Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6
@@ -5,2 +5,3 @@
   FreeBSDSignals.cpp
+  NetBSDSignals.cpp
   GDBRemoteSignals.cpp

emaste wrote:
> Should keep these in alpha order
Good catch.


Repository:
  rL LLVM

http://reviews.llvm.org/D15482



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

2015-12-14 Thread Ed Maste via lldb-commits
emaste added inline comments.


Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6
@@ -5,2 +5,3 @@
   FreeBSDSignals.cpp
+  NetBSDSignals.cpp
   GDBRemoteSignals.cpp

Should keep these in alpha order


Comment at: source/Target/UnixSignals.cpp:66
@@ -64,4 +65,3 @@
 case llvm::Triple::FreeBSD:
 case llvm::Triple::OpenBSD:
 return std::make_shared();

Not part of your change, but just spotted it during this review; The default 
case should probably be used for OpenBSD. We can change it later.


Repository:
  rL LLVM

http://reviews.llvm.org/D15482



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

2015-12-14 Thread Joerg Sonnenberger via lldb-commits
joerg accepted this revision.
joerg added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rL LLVM

http://reviews.llvm.org/D15482



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits