[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-19 Thread Michał Górny via lldb-commits 
mgorny abandoned this revision.
mgorny added a comment.

Now handled as a followup of https://reviews.llvm.org/D25724.


https://reviews.llvm.org/D25668



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-18 Thread Michał Górny via lldb-commits 
mgorny planned changes to this revision.
mgorny added a comment.

`LLVM_CMAKE_PATH` posted as https://reviews.llvm.org/D25724.


https://reviews.llvm.org/D25668



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-17 Thread Kamil Rytarowski via lldb-commits 
krytarowski added a comment.

This change makes sense for stand-alone builds, but if it's possible to remove 
branching in this CMake file - please go for it.


https://reviews.llvm.org/D25668



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-17 Thread Chris Bieneman via lldb-commits 
beanz added a comment.

Maybe we should define `LLVM_CMAKE_PATH` in llvm's CMakeLists.txt so that we 
don't need a condition here or in clang where we do the same thing?


https://reviews.llvm.org/D25668



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-17 Thread Michał Górny via lldb-commits 
mgorny created this revision.
mgorny added reviewers: beanz, krytarowski.
mgorny added a subscriber: lldb-commits.

Use LLVM_CMAKE_PATH to spawn GetSVN.cmake rather than the source path
when stand-alone build is performed, to remove the unnecessary
dependency on LLVM sources and use the installed version instead.
Non-standalone builds retain the old behavior.


https://reviews.llvm.org/D25668

Files:
  source/CMakeLists.txt


Index: source/CMakeLists.txt
===
--- source/CMakeLists.txt
+++ source/CMakeLists.txt
@@ -53,7 +53,11 @@
 
 if(DEFINED lldb_vc)
   set(version_inc "${CMAKE_CURRENT_BINARY_DIR}/SVNVersion.inc")
-  set(get_svn_script "${LLVM_MAIN_SRC_DIR}/cmake/modules/GetSVN.cmake")
+  if(LLDB_BUILT_STANDALONE)
+set(get_svn_script "${LLVM_CMAKE_PATH}/GetSVN.cmake")
+  else()
+set(get_svn_script "${LLVM_MAIN_SRC_DIR}/cmake/modules/GetSVN.cmake")
+  endif()
 
   # Create custom target to generate the VC revision include.
   add_custom_command(OUTPUT "${version_inc}"


Index: source/CMakeLists.txt
===
--- source/CMakeLists.txt
+++ source/CMakeLists.txt
@@ -53,7 +53,11 @@
 
 if(DEFINED lldb_vc)
   set(version_inc "${CMAKE_CURRENT_BINARY_DIR}/SVNVersion.inc")
-  set(get_svn_script "${LLVM_MAIN_SRC_DIR}/cmake/modules/GetSVN.cmake")
+  if(LLDB_BUILT_STANDALONE)
+set(get_svn_script "${LLVM_CMAKE_PATH}/GetSVN.cmake")
+  else()
+set(get_svn_script "${LLVM_MAIN_SRC_DIR}/cmake/modules/GetSVN.cmake")
+  endif()
 
   # Create custom target to generate the VC revision include.
   add_custom_command(OUTPUT "${version_inc}"
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits