[Lldb-commits] [PATCH] D40022: Corrected two typos and removed unused variable

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added a comment.

I have not commit access, that is why I've decided to group all typos in one 
patch...


Repository:
  rL LLVM

https://reviews.llvm.org/D40022



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D40022: Corrected two typos and removed unused variable

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.

The "--set-pc-to-entry" change is fine. No need for review when removing unused 
variables or clang formatting, but it would be nice to do those commits 
separately.


Repository:
  rL LLVM

https://reviews.llvm.org/D40022



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D40022: Corrected two typos and removed unused variable

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added inline comments.



Comment at: source/Commands/CommandObjectTarget.cpp:2589
   "Write file contents to the memory.", false, true),
-m_pc_option(LLDB_OPT_SET_1, false, "--set-pc-to-entry", 'p',
 "Set PC to the entry point."

Removed these minuses, otherwise user should type option "set-pc-to-entry"


Repository:
  rL LLVM

https://reviews.llvm.org/D40022



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D40022: Corrected two typos and removed unused variable

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha created this revision.
Herald added a subscriber: ki.stfu.

+ clang-format


Repository:
  rL LLVM

https://reviews.llvm.org/D40022

Files:
  include/lldb/Core/Architecture.h
  source/Commands/CommandObjectTarget.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp


Index: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
===
--- source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
+++ source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
@@ -178,7 +178,6 @@
 const RegisterInfo *reg_info, GDBRemoteCommunicationClient _comm) {
   const uint32_t lldb_reg = reg_info->kinds[eRegisterKindLLDB];
   const uint32_t remote_reg = reg_info->kinds[eRegisterKindProcessPlugin];
-  StringExtractorGDBRemote response;
   if (DataBufferSP buffer_sp =
   gdb_comm.ReadRegister(m_thread.GetProtocolID(), remote_reg))
 return PrivateSetRegisterValue(
Index: source/Commands/CommandObjectTarget.cpp
===
--- source/Commands/CommandObjectTarget.cpp
+++ source/Commands/CommandObjectTarget.cpp
@@ -109,7 +109,7 @@
 const uint32_t start_frame = 0;
 const uint32_t num_frames = 1;
 const uint32_t num_frames_with_source = 1;
-const bool stop_format = false;
+const bool stop_format = false;
 process_sp->GetStatus(strm);
 process_sp->GetThreadStatus(strm, only_threads_with_stop_reason,
 start_frame, num_frames,
@@ -2576,9 +2576,10 @@
 public:
   CommandObjectTargetModulesLoad(CommandInterpreter )
   : CommandObjectTargetModulesModuleAutoComplete(
-interpreter, "target modules load", "Set the load addresses for "
-"one or more sections in a "
-"target module.",
+interpreter, "target modules load",
+"Set the load addresses for "
+"one or more sections in a "
+"target module.",
 "target modules load [--file  --uuid ]  "
 " [  ]"),
 m_option_group(),
@@ -2586,7 +2587,7 @@
   "Fullpath or basename for module to load.", ""),
 m_load_option(LLDB_OPT_SET_1, false, "load", 'l',
   "Write file contents to the memory.", false, true),
-m_pc_option(LLDB_OPT_SET_1, false, "--set-pc-to-entry", 'p',
+m_pc_option(LLDB_OPT_SET_1, false, "set-pc-to-entry", 'p',
 "Set PC to the entry point."
 " Only applicable with '--load' option.",
 false, true),
Index: include/lldb/Core/Architecture.h
===
--- include/lldb/Core/Architecture.h
+++ include/lldb/Core/Architecture.h
@@ -22,7 +22,7 @@
   //--
   /// This is currently intended to handle cases where a
   /// program stops at an instruction that won't get executed and it
-  /// allows the stop reasonm, like "breakpoint hit", to be replaced
+  /// allows the stop reason, like "breakpoint hit", to be replaced
   /// with a different stop reason like "no stop reason".
   ///
   /// This is specifically used for ARM in Thumb code when we stop in


Index: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
===
--- source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
+++ source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
@@ -178,7 +178,6 @@
 const RegisterInfo *reg_info, GDBRemoteCommunicationClient _comm) {
   const uint32_t lldb_reg = reg_info->kinds[eRegisterKindLLDB];
   const uint32_t remote_reg = reg_info->kinds[eRegisterKindProcessPlugin];
-  StringExtractorGDBRemote response;
   if (DataBufferSP buffer_sp =
   gdb_comm.ReadRegister(m_thread.GetProtocolID(), remote_reg))
 return PrivateSetRegisterValue(
Index: source/Commands/CommandObjectTarget.cpp
===
--- source/Commands/CommandObjectTarget.cpp
+++ source/Commands/CommandObjectTarget.cpp
@@ -109,7 +109,7 @@
 const uint32_t start_frame = 0;
 const uint32_t num_frames = 1;
 const uint32_t num_frames_with_source = 1;
-const bool stop_format = false;
+const bool stop_format = false;
 process_sp->GetStatus(strm);
 process_sp->GetThreadStatus(strm, only_threads_with_stop_reason,
 start_frame, num_frames,
@@ -2576,9 +2576,10 @@
 public:
   CommandObjectTargetModulesLoad(CommandInterpreter )
   : CommandObjectTargetModulesModuleAutoComplete(
-interpreter, "target modules load", "Set the load addresses for "
-"one or more sections in a "
-