[Lldb-commits] [PATCH] D44455: [SymbolFilePDB] Remove a few null pointer checks by passing ref

[Zachary Turner via Phabricator via lldb-commits]

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

Feel free to use your own judgement, and if you think it doesn't pass some 
complexity threshold, you can just submit without review and we can do 
post-commit review.


Repository:
  rL LLVM

https://reviews.llvm.org/D44455



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44455: [SymbolFilePDB] Remove a few null pointer checks by passing ref

[Aaron Smith via Phabricator via lldb-commits]

asmith created this revision.
asmith added reviewers: zturner, rnk, lldb-commits.
Herald added a subscriber: llvm-commits.

Repository:
  rL LLVM

https://reviews.llvm.org/D44455

Files:
  source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.h

Index: source/Plugins/SymbolFile/PDB/SymbolFilePDB.h
===
--- source/Plugins/SymbolFile/PDB/SymbolFilePDB.h
+++ source/Plugins/SymbolFile/PDB/SymbolFilePDB.h
@@ -188,14 +188,14 @@
   typedef std::vector TypeCollection;
 
   void
-  GetTypesForPDBSymbol(const llvm::pdb::PDBSymbol *pdb_symbol,
+  GetTypesForPDBSymbol(const llvm::pdb::PDBSymbol _symbol,
uint32_t type_mask, TypeCollection _collection);
 
   lldb_private::Function* ParseCompileUnitFunctionForPDBFunc(
-  const llvm::pdb::PDBSymbolFunc *pdb_func,
+  const llvm::pdb::PDBSymbolFunc _func,
   const lldb_private::SymbolContext );
 
-  void GetCompileUnitIndex(const llvm::pdb::PDBSymbolCompiland *pdb_compiland,
+  void GetCompileUnitIndex(const llvm::pdb::PDBSymbolCompiland _compiland,
uint32_t );
 
   std::string GetSourceFileNameForPDBCompiland(
@@ -205,9 +205,9 @@
   GetPDBCompilandByUID(uint32_t uid);
 
   lldb_private::Mangled
-  GetMangledForPDBFunc(const llvm::pdb::PDBSymbolFunc *pdb_func);
+  GetMangledForPDBFunc(const llvm::pdb::PDBSymbolFunc _func);
 
-  bool ResolveFunction(llvm::pdb::PDBSymbolFunc *pdb_func,
+  bool ResolveFunction(const llvm::pdb::PDBSymbolFunc _func,
bool include_inlines,
lldb_private::SymbolContextList _list);
 
Index: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
===
--- source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
+++ source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
@@ -205,15 +205,12 @@
 }
 
 void SymbolFilePDB::GetCompileUnitIndex(
-const llvm::pdb::PDBSymbolCompiland *pdb_compiland,
+const llvm::pdb::PDBSymbolCompiland _compiland,
 uint32_t ) {
-  if (!pdb_compiland)
-return;
-
   auto results_up = m_global_scope_up->findAllChildren();
   if (!results_up)
 return;
-  auto uid = pdb_compiland->getSymIndexId();
+  auto uid = pdb_compiland.getSymIndexId();
   for (uint32_t cu_idx = 0; cu_idx < GetNumCompileUnits(); ++cu_idx) {
 auto compiland_up = results_up->getChildAtIndex(cu_idx);
 if (!compiland_up)
@@ -266,32 +263,31 @@
 
 lldb_private::Function *
 SymbolFilePDB::ParseCompileUnitFunctionForPDBFunc(
-const PDBSymbolFunc *pdb_func,
+const PDBSymbolFunc _func,
 const lldb_private::SymbolContext ) {
-  assert(pdb_func != nullptr);
   lldbassert(sc.comp_unit && sc.module_sp.get());
 
-  auto file_vm_addr = pdb_func->getVirtualAddress();
+  auto file_vm_addr = pdb_func.getVirtualAddress();
   if (file_vm_addr == LLDB_INVALID_ADDRESS)
 return nullptr;
 
-  auto func_length = pdb_func->getLength();
+  auto func_length = pdb_func.getLength();
   AddressRange func_range = AddressRange(file_vm_addr,
  func_length,
  sc.module_sp->GetSectionList());
   if (!func_range.GetBaseAddress().IsValid())
 return nullptr;
 
-  lldb_private::Type* func_type = ResolveTypeUID(pdb_func->getSymIndexId());
+  lldb_private::Type* func_type = ResolveTypeUID(pdb_func.getSymIndexId());
   if (!func_type)
 return nullptr;
 
-  user_id_t func_type_uid = pdb_func->getSignatureId();
+  user_id_t func_type_uid = pdb_func.getSignatureId();
 
   Mangled mangled = GetMangledForPDBFunc(pdb_func);
 
   FunctionSP func_sp = std::make_shared(sc.comp_unit,
-  pdb_func->getSymIndexId(),
+  pdb_func.getSymIndexId(),
   func_type_uid,
   mangled,
   func_type,
@@ -315,7 +311,7 @@
 auto func_sp =
 sc.comp_unit->FindFunctionByUID(pdb_func_up->getSymIndexId());
 if (!func_sp) {
-  if (ParseCompileUnitFunctionForPDBFunc(pdb_func_up.get(), sc))
+  if (ParseCompileUnitFunctionForPDBFunc(*pdb_func_up, sc))
 ++func_added;
 }
   }
@@ -562,7 +558,7 @@
 auto func_uid = pdb_func->getSymIndexId();
 sc.function = sc.comp_unit->FindFunctionByUID(func_uid).get();
 if (sc.function == nullptr)
-  sc.function = ParseCompileUnitFunctionForPDBFunc(pdb_func, sc);
+  sc.function = ParseCompileUnitFunctionForPDBFunc(*pdb_func, sc);
 if (sc.function) {
   resolved_flags |= eSymbolContextFunction;
   if (resolve_scope & eSymbolContextBlock) {
@@ -736,7 +732,7 @@
   if (sc.function == nullptr) {
 auto