subject:"\[Lldb\-commits\] \[PATCH\] D68661\: StopInfo\/Mach\: Delete PPC support"

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

2019-10-08 Thread Vedant Kumar via Phabricator via lldb-commits

This revision was automatically updated to reflect the committed changes.
vsk marked an inline comment as done.
Closed by commit rG4805c817c3fa: StopInfo/Mach: Delete PPC support (authored by 
vsk).
Herald added a project: LLDB.

Changed prior to commit:
  https://reviews.llvm.org/D68661?vs=223924=223936#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68661/new/

https://reviews.llvm.org/D68661

Files:
  lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp

Index: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp
===
--- lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp
+++ lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp
@@ -78,21 +78,6 @@
   }
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (m_exc_code) {
-  case 0x101:
-code_desc = "EXC_PPC_VM_PROT_READ";
-break;
-  case 0x102:
-code_desc = "EXC_PPC_BADSPACE";
-break;
-  case 0x103:
-code_desc = "EXC_PPC_UNALIGNED";
-break;
-  }
-  break;
-
 default:
   break;
 }
@@ -107,30 +92,6 @@
 code_desc = "EXC_I386_INVOP";
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (m_exc_code) {
-  case 1:
-code_desc = "EXC_PPC_INVALID_SYSCALL";
-break;
-  case 2:
-code_desc = "EXC_PPC_UNIPL_INST";
-break;
-  case 3:
-code_desc = "EXC_PPC_PRIVINST";
-break;
-  case 4:
-code_desc = "EXC_PPC_PRIVREG";
-break;
-  case 5:
-code_desc = "EXC_PPC_TRACE";
-break;
-  case 6:
-code_desc = "EXC_PPC_PERFMON";
-break;
-  }
-  break;
-
 case llvm::Triple::arm:
 case llvm::Triple::thumb:
   if (m_exc_code == 1)
@@ -175,33 +136,6 @@
   }
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (m_exc_code) {
-  case 1:
-code_desc = "EXC_PPC_OVERFLOW";
-break;
-  case 2:
-code_desc = "EXC_PPC_ZERO_DIVIDE";
-break;
-  case 3:
-code_desc = "EXC_PPC_FLT_INEXACT";
-break;
-  case 4:
-code_desc = "EXC_PPC_FLT_ZERO_DIVIDE";
-break;
-  case 5:
-code_desc = "EXC_PPC_FLT_UNDERFLOW";
-break;
-  case 6:
-code_desc = "EXC_PPC_FLT_OVERFLOW";
-break;
-  case 7:
-code_desc = "EXC_PPC_FLT_NOT_A_NUMBER";
-break;
-  }
-  break;
-
 default:
   break;
 }
@@ -235,15 +169,6 @@
   }
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (m_exc_code) {
-  case 1:
-code_desc = "EXC_PPC_BREAKPOINT";
-break;
-  }
-  break;
-
 case llvm::Triple::arm:
 case llvm::Triple::thumb:
   switch (m_exc_code) {
@@ -384,30 +309,7 @@
 
   switch (exc_type) {
   case 1: // EXC_BAD_ACCESS
-break;
-
   case 2: // EXC_BAD_INSTRUCTION
-switch (cpu) {
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (exc_code) {
-  case 1: // EXC_PPC_INVALID_SYSCALL
-  case 2: // EXC_PPC_UNIPL_INST
-  case 3: // EXC_PPC_PRIVINST
-  case 4: // EXC_PPC_PRIVREG
-break;
-  case 5: // EXC_PPC_TRACE
-return StopInfo::CreateStopReasonToTrace(thread);
-  case 6: // EXC_PPC_PERFMON
-break;
-  }
-  break;
-
-default:
-  break;
-}
-break;
-
   case 3: // EXC_ARITHMETIC
   case 4: // EXC_EMULATION
 break;
@@ -478,11 +380,6 @@
   }
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  is_actual_breakpoint = exc_code == 1; // EXC_PPC_BREAKPOINT
-  break;
-
 case llvm::Triple::arm:
 case llvm::Triple::thumb:
   if (exc_code == 0x102) // EXC_ARM_DA_DEBUG
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

2019-10-08 Thread Jim Ingham via Phabricator via lldb-commits

jingham added a comment.

Yes, I don't think we need to support this anymore.




Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:387
   case 1: // EXC_BAD_ACCESS
 break;
 

Might as well remove this break too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68661/new/

https://reviews.llvm.org/D68661



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

2019-10-08 Thread Vedant Kumar via Phabricator via lldb-commits

vsk created this revision.
vsk added reviewers: jingham, jasonmolenda, JDevlieghere.

LLDB appears to have at least partial support for PPC, but PPC on Mach isn't a 
thing AFAIK.


https://reviews.llvm.org/D68661

Files:
  lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp

Index: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp
===
--- lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp
+++ lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp
@@ -78,21 +78,6 @@
   }
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (m_exc_code) {
-  case 0x101:
-code_desc = "EXC_PPC_VM_PROT_READ";
-break;
-  case 0x102:
-code_desc = "EXC_PPC_BADSPACE";
-break;
-  case 0x103:
-code_desc = "EXC_PPC_UNALIGNED";
-break;
-  }
-  break;
-
 default:
   break;
 }
@@ -107,30 +92,6 @@
 code_desc = "EXC_I386_INVOP";
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (m_exc_code) {
-  case 1:
-code_desc = "EXC_PPC_INVALID_SYSCALL";
-break;
-  case 2:
-code_desc = "EXC_PPC_UNIPL_INST";
-break;
-  case 3:
-code_desc = "EXC_PPC_PRIVINST";
-break;
-  case 4:
-code_desc = "EXC_PPC_PRIVREG";
-break;
-  case 5:
-code_desc = "EXC_PPC_TRACE";
-break;
-  case 6:
-code_desc = "EXC_PPC_PERFMON";
-break;
-  }
-  break;
-
 case llvm::Triple::arm:
 case llvm::Triple::thumb:
   if (m_exc_code == 1)
@@ -175,33 +136,6 @@
   }
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (m_exc_code) {
-  case 1:
-code_desc = "EXC_PPC_OVERFLOW";
-break;
-  case 2:
-code_desc = "EXC_PPC_ZERO_DIVIDE";
-break;
-  case 3:
-code_desc = "EXC_PPC_FLT_INEXACT";
-break;
-  case 4:
-code_desc = "EXC_PPC_FLT_ZERO_DIVIDE";
-break;
-  case 5:
-code_desc = "EXC_PPC_FLT_UNDERFLOW";
-break;
-  case 6:
-code_desc = "EXC_PPC_FLT_OVERFLOW";
-break;
-  case 7:
-code_desc = "EXC_PPC_FLT_NOT_A_NUMBER";
-break;
-  }
-  break;
-
 default:
   break;
 }
@@ -235,15 +169,6 @@
   }
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (m_exc_code) {
-  case 1:
-code_desc = "EXC_PPC_BREAKPOINT";
-break;
-  }
-  break;
-
 case llvm::Triple::arm:
 case llvm::Triple::thumb:
   switch (m_exc_code) {
@@ -387,27 +312,6 @@
 break;
 
   case 2: // EXC_BAD_INSTRUCTION
-switch (cpu) {
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  switch (exc_code) {
-  case 1: // EXC_PPC_INVALID_SYSCALL
-  case 2: // EXC_PPC_UNIPL_INST
-  case 3: // EXC_PPC_PRIVINST
-  case 4: // EXC_PPC_PRIVREG
-break;
-  case 5: // EXC_PPC_TRACE
-return StopInfo::CreateStopReasonToTrace(thread);
-  case 6: // EXC_PPC_PERFMON
-break;
-  }
-  break;
-
-default:
-  break;
-}
-break;
-
   case 3: // EXC_ARITHMETIC
   case 4: // EXC_EMULATION
 break;
@@ -478,11 +382,6 @@
   }
   break;
 
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-  is_actual_breakpoint = exc_code == 1; // EXC_PPC_BREAKPOINT
-  break;
-
 case llvm::Triple::arm:
 case llvm::Triple::thumb:
   if (exc_code == 0x102) // EXC_ARM_DA_DEBUG
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

3 matches

Site Navigation

Mail list logo

Footer information