[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-21 Thread Martin Storsjö via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rGae14f3fdbfa8: [LLDB] [docs] Update the list of supported 
architectures on Windows (authored by mstorsjo).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96840/new/

https://reviews.llvm.org/D96840

Files:
  lldb/docs/index.rst


Index: lldb/docs/index.rst
===
--- lldb/docs/index.rst
+++ lldb/docs/index.rst
@@ -74,10 +74,11 @@
 * iOS, tvOS, and watchOS device debugging on ARM and AArch64
 * Linux user-space debugging for i386, x86_64 and PPC64le
 * FreeBSD user-space debugging for i386 and x86_64
-* Windows user-space debugging for i386 (*)
+* Windows user-space debugging for i386, x86_64, ARM and AArch64 (*)
 
 (*) Support for Windows is under active development. Basic functionality is
-expected to work, with functionality improving rapidly.
+expected to work, with functionality improving rapidly. ARM and AArch64 support
+is more experimental, with more known issues than the others.
 
 Get Involved
 


Index: lldb/docs/index.rst
===
--- lldb/docs/index.rst
+++ lldb/docs/index.rst
@@ -74,10 +74,11 @@
 * iOS, tvOS, and watchOS device debugging on ARM and AArch64
 * Linux user-space debugging for i386, x86_64 and PPC64le
 * FreeBSD user-space debugging for i386 and x86_64
-* Windows user-space debugging for i386 (*)
+* Windows user-space debugging for i386, x86_64, ARM and AArch64 (*)
 
 (*) Support for Windows is under active development. Basic functionality is
-expected to work, with functionality improving rapidly.
+expected to work, with functionality improving rapidly. ARM and AArch64 support
+is more experimental, with more known issues than the others.
 
 Get Involved
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-21 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Sounds reasonable. I'm sure x86_64 is in at least as good as shape as i386.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96840/new/

https://reviews.llvm.org/D96840

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-19 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth added a comment.

I'm in no position to evaluate the functionality of lldb on Windows.  I've 
spent the last few months trying to understand why 900+ tests spontaneously 
started failing on Windows.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96840/new/

https://reviews.llvm.org/D96840

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-19 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment.

Ping, does this form look acceptable?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96840/new/

https://reviews.llvm.org/D96840

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-17 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo updated this revision to Diff 324250.
mstorsjo added a comment.

Fixed the typo, labeling the AArch64 support experimental too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96840/new/

https://reviews.llvm.org/D96840

Files:
  lldb/docs/index.rst


Index: lldb/docs/index.rst
===
--- lldb/docs/index.rst
+++ lldb/docs/index.rst
@@ -74,10 +74,11 @@
 * iOS, tvOS, and watchOS device debugging on ARM and AArch64
 * Linux user-space debugging for i386, x86_64 and PPC64le
 * FreeBSD user-space debugging for i386 and x86_64
-* Windows user-space debugging for i386 (*)
+* Windows user-space debugging for i386, x86_64, ARM and AArch64 (*)
 
 (*) Support for Windows is under active development. Basic functionality is
-expected to work, with functionality improving rapidly.
+expected to work, with functionality improving rapidly. ARM and AArch64 support
+is more experimental, with more known issues than the others.
 
 Get Involved
 


Index: lldb/docs/index.rst
===
--- lldb/docs/index.rst
+++ lldb/docs/index.rst
@@ -74,10 +74,11 @@
 * iOS, tvOS, and watchOS device debugging on ARM and AArch64
 * Linux user-space debugging for i386, x86_64 and PPC64le
 * FreeBSD user-space debugging for i386 and x86_64
-* Windows user-space debugging for i386 (*)
+* Windows user-space debugging for i386, x86_64, ARM and AArch64 (*)
 
 (*) Support for Windows is under active development. Basic functionality is
-expected to work, with functionality improving rapidly.
+expected to work, with functionality improving rapidly. ARM and AArch64 support
+is more experimental, with more known issues than the others.
 
 Get Involved
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-17 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added inline comments.



Comment at: lldb/docs/index.rst:80
 (*) Support for Windows is under active development. Basic functionality is
-expected to work, with functionality improving rapidly.
+expected to work, with functionality improving rapidly. ARM support is
+more experimmental, with more known issues than the others.

omjavaid wrote:
> s/ARM/ARM and AArch64/ 
> 
> Also add a line to reflect lack of python support.
Sure, I can label the AArch64 bit experimental too.

I wouldn't include comments about python here though. The fact that it's not 
easy to build LLDB with python for windows/aarch64 isn't an intrinsic feature 
of LLDB or something that is missing in LLDB, that's just python.

It is actually possible to cross compile LLDB with python support for 
windows/aarch64, at least for the mingw target. Python itself is a bit tricky 
to cross compile, but once that cross compilation itself works, building it for 
windows/aarch64 isn't any worse than for x86. In 
https://github.com/mstorsjo/llvm-mingw/issues/73 there's ongoing efforts in 
building and packaging LLDB for windows with python enabled. As it's primarily 
cross compiled, it's a bit tricky for running tests though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96840/new/

https://reviews.llvm.org/D96840

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-17 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added inline comments.



Comment at: lldb/docs/index.rst:80
 (*) Support for Windows is under active development. Basic functionality is
-expected to work, with functionality improving rapidly.
+expected to work, with functionality improving rapidly. ARM support is
+more experimmental, with more known issues than the others.

s/ARM/ARM and AArch64/ 

Also add a line to reflect lack of python support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96840/new/

https://reviews.llvm.org/D96840

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-17 Thread Omair Javaid via lldb-commits
On Wed, 17 Feb 2021 at 15:26, Martin Storsjö  wrote:

> On Wed, 17 Feb 2021, Omair Javaid wrote:
>
> > HI  mstorsjo, did you manage to run LLDB testsuite with python support
> > enabled on windows. Can you please share steps to build and test LLDB on
> > windows on Arm/AArch64 if you have them handy somewhere. I ll check if
> there
> > is something missing on our part which needs to be done to get LLDB in
> > reasonable shape on windows on Arm/AArch64.
> >
> > IMO, the biggest hurdle right now is swig/API generation and python
> support
> > enablement. If you think that is working already with some hack, then
> please
> > share it with me. I am using MS Surface Arm64 for the build.
>
> Hi,
>
> I never ran the full testsuite, and I built with python disabled.
>
> I did manage to run some testcases, but I'm cross compiling (building on
> x86_64 linux, targeting aarch64 windows), so I transplanted parts of the
> testsuite to the target system and ran it via WSL - not very smooth, but
> it helped create and verify some test cases like
> test/Shell/Register/aarch64-fp-read.test at least.
>

Yes this was what I expected.

>
> // Martin
>


-- 
Omair Javaid
www.linaro.org
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-17 Thread Martin Storsjö via lldb-commits

On Wed, 17 Feb 2021, Omair Javaid wrote:


HI  mstorsjo, did you manage to run LLDB testsuite with python support
enabled on windows. Can you please share steps to build and test LLDB on
windows on Arm/AArch64 if you have them handy somewhere. I ll check if there
is something missing on our part which needs to be done to get LLDB in
reasonable shape on windows on Arm/AArch64.

IMO, the biggest hurdle right now is swig/API generation and python support
enablement. If you think that is working already with some hack, then please
share it with me. I am using MS Surface Arm64 for the build.


Hi,

I never ran the full testsuite, and I built with python disabled.

I did manage to run some testcases, but I'm cross compiling (building on 
x86_64 linux, targeting aarch64 windows), so I transplanted parts of the 
testsuite to the target system and ran it via WSL - not very smooth, but 
it helped create and verify some test cases like 
test/Shell/Register/aarch64-fp-read.test at least.


// Martin
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-17 Thread Omair Javaid via lldb-commits
On Wed, 17 Feb 2021 at 15:10, Martin Storsjö via Phabricator <
revi...@reviews.llvm.org> wrote:

> mstorsjo added a comment.
>
> In D96840#2567890 ,
> @DavidSpickett wrote:
>
> > Do we support 32 bit Arm specifically? (I'm not very familiar with
> Windows targets)
>
> Yes, I implemented support for both ARM and AArch64 in late 2019.
>
> > @omjavaid Has done some testing on the latest Windows On Arm which is
> AArch64. I think you should probably say "ARM and AArch64 support is more"
> but he can comment on how well it works.
>
> Possibly yes. I was referring to an issue for the ARM part that I never
> got time to fix properly, see D70840 .
> Other than that, I don't know of any issues with the AArch64 part, but I
> haven't used it very much either, fwiw.
>

HI  mstorsjo, did you manage to run LLDB testsuite with python support
enabled on windows. Can you please share steps to build and test LLDB on
windows on Arm/AArch64 if you have them handy somewhere. I ll check if
there is something missing on our part which needs to be done to get LLDB
in reasonable shape on windows on Arm/AArch64.

IMO, the biggest hurdle right now is swig/API generation and python support
enablement. If you think that is working already with some hack, then
please share it with me. I am using MS Surface Arm64 for the build.


>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D96840/new/
>
> https://reviews.llvm.org/D96840
>
>

-- 
Omair Javaid
www.linaro.org
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-17 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment.

In D96840#2567890 , @DavidSpickett 
wrote:

> Do we support 32 bit Arm specifically? (I'm not very familiar with Windows 
> targets)

Yes, I implemented support for both ARM and AArch64 in late 2019.

> @omjavaid Has done some testing on the latest Windows On Arm which is 
> AArch64. I think you should probably say "ARM and AArch64 support is more" 
> but he can comment on how well it works.

Possibly yes. I was referring to an issue for the ARM part that I never got 
time to fix properly, see D70840 . Other than 
that, I don't know of any issues with the AArch64 part, but I haven't used it 
very much either, fwiw.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96840/new/

https://reviews.llvm.org/D96840

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-17 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added subscribers: omjavaid, DavidSpickett.
DavidSpickett added a reviewer: omjavaid.
DavidSpickett added a comment.

Do we support 32 bit Arm specifically? (I'm not very familiar with Windows 
targets)

@omjavaid Has done some testing on the latest Windows On Arm which is AArch64. 
I think you should probably say "ARM and AArch64 support is more" but he can 
comment on how well it works.




Comment at: lldb/docs/index.rst:81
+expected to work, with functionality improving rapidly. ARM support is
+more experimmental, with more known issues than the others.
 

"experimental"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96840/new/

https://reviews.llvm.org/D96840

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

2021-02-16 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision.
mstorsjo added reviewers: labath, amccarth.
Herald added subscribers: pengfei, arphaman, kristof.beyls.
mstorsjo requested review of this revision.
Herald added a project: LLDB.

It was pointed out to me that the docs previously only said i386 was supported, 
while I'd expect that at least x86_64 is on the same level, and AArch64 should 
work pretty well for basic things at least.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96840

Files:
  lldb/docs/index.rst


Index: lldb/docs/index.rst
===
--- lldb/docs/index.rst
+++ lldb/docs/index.rst
@@ -74,10 +74,11 @@
 * iOS, tvOS, and watchOS device debugging on ARM and AArch64
 * Linux user-space debugging for i386, x86_64 and PPC64le
 * FreeBSD user-space debugging for i386 and x86_64
-* Windows user-space debugging for i386 (*)
+* Windows user-space debugging for i386, x86_64, ARM and AArch64 (*)
 
 (*) Support for Windows is under active development. Basic functionality is
-expected to work, with functionality improving rapidly.
+expected to work, with functionality improving rapidly. ARM support is
+more experimmental, with more known issues than the others.
 
 Get Involved
 


Index: lldb/docs/index.rst
===
--- lldb/docs/index.rst
+++ lldb/docs/index.rst
@@ -74,10 +74,11 @@
 * iOS, tvOS, and watchOS device debugging on ARM and AArch64
 * Linux user-space debugging for i386, x86_64 and PPC64le
 * FreeBSD user-space debugging for i386 and x86_64
-* Windows user-space debugging for i386 (*)
+* Windows user-space debugging for i386, x86_64, ARM and AArch64 (*)
 
 (*) Support for Windows is under active development. Basic functionality is
-expected to work, with functionality improving rapidly.
+expected to work, with functionality improving rapidly. ARM support is
+more experimmental, with more known issues than the others.
 
 Get Involved
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits