[Lldb-commits] [lldb] [lldb] Fixed the TestCompletion test on the Linux AArch64 target (PR #93345)

2024-05-24 Thread Dmitry Vasilyev via lldb-commits 

https://github.com/slydiman updated 
https://github.com/llvm/llvm-project/pull/93345

>From 76a35a6ca5302aef5033d5ae297667e416921d7d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev 
Date: Sat, 25 May 2024 00:39:05 +0400
Subject: [PATCH] [lldb] Fixed PlatformPOSIX::DoLoadImage() in case of the
 Windows host

Do not denormalize the path. This patch fixes #93092.

BTW, it would be great to be able to pass the style or triple to SBFileSpec. 
Currently it is impossible to create a posix FileSpec on the Windows host.
---
 lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp 
b/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
index b4f1b76c39dbe..edad606e2e105 100644
--- a/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
+++ b/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
@@ -678,7 +678,7 @@ uint32_t PlatformPOSIX::DoLoadImage(lldb_private::Process 
*process,
 loaded_image->Clear();
 
   std::string path;
-  path = remote_file.GetPath();
+  path = remote_file.GetPath(false);
   
   ThreadSP thread_sp = process->GetThreadList().GetExpressionExecutionThread();
   if (!thread_sp) {

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the TestCompletion test on the Linux AArch64 target (PR #93345)

2024-05-24 Thread via lldb-commits 

llvmbot wrote:




@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)


Changes

PlatformPOSIX::DoLoadImage() failed on the Linux AArch64 target. It is related 
to the issue #93092. Disable the TestCompletion.test_process_unload 
test for now.

---
Full diff: https://github.com/llvm/llvm-project/pull/93345.diff


1 Files Affected:

- (modified) lldb/test/API/functionalities/completion/TestCompletion.py (+3) 


``diff
diff --git a/lldb/test/API/functionalities/completion/TestCompletion.py 
b/lldb/test/API/functionalities/completion/TestCompletion.py
index 15aeaf8d0e897..eadb510a3df26 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -97,6 +97,9 @@ def test_process_load(self):
 self.complete_from_to("process load Makef", "process load Makefile")
 
 @skipUnlessPlatform(["linux"])
+@expectedFailureAll(
+archs=["aarch64"], 
bugnumber="github.com/llvm/llvm-project/issues/93092"
+)
 def test_process_unload(self):
 """Test the completion for "process unload " """
 # This tab completion should not work without a running process.

``




https://github.com/llvm/llvm-project/pull/93345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the TestCompletion test on the Linux AArch64 target (PR #93345)

2024-05-24 Thread Dmitry Vasilyev via lldb-commits 

https://github.com/slydiman created 
https://github.com/llvm/llvm-project/pull/93345

PlatformPOSIX::DoLoadImage() failed on the Linux AArch64 target. It is related 
to the issue #93092. Disable the TestCompletion.test_process_unload test for 
now.

>From 3dcd6665052b1090cb5365732a92aef0b7fa0915 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev 
Date: Sat, 25 May 2024 00:39:05 +0400
Subject: [PATCH] [lldb] Fixed the TestCompletion test on the Linux AArch64
 target

PlatformPOSIX::DoLoadImage() failed on the Linux AArch64 target. It is related 
to the issue #93092. Disable the TestCompletion.test_process_unload test for 
now.
---
 lldb/test/API/functionalities/completion/TestCompletion.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lldb/test/API/functionalities/completion/TestCompletion.py 
b/lldb/test/API/functionalities/completion/TestCompletion.py
index 15aeaf8d0e897..eadb510a3df26 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -97,6 +97,9 @@ def test_process_load(self):
 self.complete_from_to("process load Makef", "process load Makefile")
 
 @skipUnlessPlatform(["linux"])
+@expectedFailureAll(
+archs=["aarch64"], 
bugnumber="github.com/llvm/llvm-project/issues/93092"
+)
 def test_process_unload(self):
 """Test the completion for "process unload " """
 # This tab completion should not work without a running process.

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits