Re: [Lldb-commits] [lldb] 58473d8 - [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

2021-12-13 Thread Jonas Devlieghere via lldb-commits 
This is NFC

On Mon, Dec 13, 2021 at 5:00 PM David Blaikie  wrote:

> Any chance of test coverage?
>
> On Mon, Dec 13, 2021 at 4:58 PM Jonas Devlieghere via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>>
>> Author: Jonas Devlieghere
>> Date: 2021-12-13T16:58:39-08:00
>> New Revision: 58473d84e0c7796de5dcfd3153e5d5cc8ad034b3
>>
>> URL:
>> https://github.com/llvm/llvm-project/commit/58473d84e0c7796de5dcfd3153e5d5cc8ad034b3
>> DIFF:
>> https://github.com/llvm/llvm-project/commit/58473d84e0c7796de5dcfd3153e5d5cc8ad034b3.diff
>>
>> LOG: [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING
>>
>> Added:
>>
>>
>> Modified:
>> lldb/source/Version/Version.cpp
>>
>> Removed:
>>
>>
>>
>>
>> 
>> diff  --git a/lldb/source/Version/Version.cpp
>> b/lldb/source/Version/Version.cpp
>> index ae2d83bd3e5f8..b391fe1eacd80 100644
>> --- a/lldb/source/Version/Version.cpp
>> +++ b/lldb/source/Version/Version.cpp
>> @@ -15,7 +15,7 @@ static const char *GetLLDBVersion() {
>>  #ifdef LLDB_FULL_VERSION_STRING
>>return LLDB_FULL_VERSION_STRING;
>>  #else
>> -  return "lldb version " CLANG_VERSION_STRING;
>> +  return "lldb version " LLDB_VERSION_STRING;
>>  #endif
>>  }
>>
>>
>>
>>
>> ___
>> lldb-commits mailing list
>> lldb-commits@lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] 58473d8 - [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

2021-12-13 Thread David Blaikie via lldb-commits 
Any chance of test coverage?

On Mon, Dec 13, 2021 at 4:58 PM Jonas Devlieghere via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

>
> Author: Jonas Devlieghere
> Date: 2021-12-13T16:58:39-08:00
> New Revision: 58473d84e0c7796de5dcfd3153e5d5cc8ad034b3
>
> URL:
> https://github.com/llvm/llvm-project/commit/58473d84e0c7796de5dcfd3153e5d5cc8ad034b3
> DIFF:
> https://github.com/llvm/llvm-project/commit/58473d84e0c7796de5dcfd3153e5d5cc8ad034b3.diff
>
> LOG: [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING
>
> Added:
>
>
> Modified:
> lldb/source/Version/Version.cpp
>
> Removed:
>
>
>
>
> 
> diff  --git a/lldb/source/Version/Version.cpp
> b/lldb/source/Version/Version.cpp
> index ae2d83bd3e5f8..b391fe1eacd80 100644
> --- a/lldb/source/Version/Version.cpp
> +++ b/lldb/source/Version/Version.cpp
> @@ -15,7 +15,7 @@ static const char *GetLLDBVersion() {
>  #ifdef LLDB_FULL_VERSION_STRING
>return LLDB_FULL_VERSION_STRING;
>  #else
> -  return "lldb version " CLANG_VERSION_STRING;
> +  return "lldb version " LLDB_VERSION_STRING;
>  #endif
>  }
>
>
>
>
> ___
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 58473d8 - [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

2021-12-13 Thread Jonas Devlieghere via lldb-commits 

Author: Jonas Devlieghere
Date: 2021-12-13T16:58:39-08:00
New Revision: 58473d84e0c7796de5dcfd3153e5d5cc8ad034b3

URL: 
https://github.com/llvm/llvm-project/commit/58473d84e0c7796de5dcfd3153e5d5cc8ad034b3
DIFF: 
https://github.com/llvm/llvm-project/commit/58473d84e0c7796de5dcfd3153e5d5cc8ad034b3.diff

LOG: [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

Added: 


Modified: 
lldb/source/Version/Version.cpp

Removed: 




diff  --git a/lldb/source/Version/Version.cpp b/lldb/source/Version/Version.cpp
index ae2d83bd3e5f8..b391fe1eacd80 100644
--- a/lldb/source/Version/Version.cpp
+++ b/lldb/source/Version/Version.cpp
@@ -15,7 +15,7 @@ static const char *GetLLDBVersion() {
 #ifdef LLDB_FULL_VERSION_STRING
   return LLDB_FULL_VERSION_STRING;
 #else
-  return "lldb version " CLANG_VERSION_STRING;
+  return "lldb version " LLDB_VERSION_STRING;
 #endif
 }
 



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits