Re: [Lldb-commits] [lldb] 6438a52 - Revert "[clang] retain type sugar in auto / template argument deduction"
Oops, my bad! The reason for reverting this is that this is a recent commit, and there are reports of breakage building libANGLE which have not been investigated. See https://reviews.llvm.org/D110216 for details / future developments. Thanks! On Mon, Nov 15, 2021 at 12:33 AM David Blaikie wrote: > > > > On Sun, Nov 14, 2021 at 3:30 PM Matheus Izvekov via lldb-commits > wrote: >> >> >> Author: Matheus Izvekov >> Date: 2021-11-15T00:29:05+01:00 >> New Revision: 6438a52df1c7f36952b6126ff7b978861b76ad45 >> >> URL: >> https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45 >> DIFF: >> https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45.diff >> >> LOG: Revert "[clang] retain type sugar in auto / template argument deduction" >> >> This reverts commit 4d8fff477e024698facd89741cc6cf996708d598. > > > Would be good to include some details about the reason for reverting patches > in the commit message - helps folks identify whether a particular revert will > address issues they might be investigating, and increases the chance folks > might avoid the same mistakes if they're pursuing a similar direction in the > future. ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] 6438a52 - Revert "[clang] retain type sugar in auto / template argument deduction"
Thanks for the details! On Sun, Nov 14, 2021 at 3:39 PM Matheus Izvekov wrote: > Oops, my bad! > > The reason for reverting this is that this is a recent commit, and > there are reports of breakage building libANGLE which have not been > investigated. > > See https://reviews.llvm.org/D110216 for details / future developments. > > Thanks! > > On Mon, Nov 15, 2021 at 12:33 AM David Blaikie wrote: > > > > > > > > On Sun, Nov 14, 2021 at 3:30 PM Matheus Izvekov via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> > >> > >> Author: Matheus Izvekov > >> Date: 2021-11-15T00:29:05+01:00 > >> New Revision: 6438a52df1c7f36952b6126ff7b978861b76ad45 > >> > >> URL: > https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45 > >> DIFF: > https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45.diff > >> > >> LOG: Revert "[clang] retain type sugar in auto / template argument > deduction" > >> > >> This reverts commit 4d8fff477e024698facd89741cc6cf996708d598. > > > > > > Would be good to include some details about the reason for reverting > patches in the commit message - helps folks identify whether a particular > revert will address issues they might be investigating, and increases the > chance folks might avoid the same mistakes if they're pursuing a similar > direction in the future. > ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] 6438a52 - Revert "[clang] retain type sugar in auto / template argument deduction"
On Sun, Nov 14, 2021 at 3:30 PM Matheus Izvekov via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Matheus Izvekov > Date: 2021-11-15T00:29:05+01:00 > New Revision: 6438a52df1c7f36952b6126ff7b978861b76ad45 > > URL: > https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45 > DIFF: > https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45.diff > > LOG: Revert "[clang] retain type sugar in auto / template argument > deduction" > > This reverts commit 4d8fff477e024698facd89741cc6cf996708d598. > Would be good to include some details about the reason for reverting patches in the commit message - helps folks identify whether a particular revert will address issues they might be investigating, and increases the chance folks might avoid the same mistakes if they're pursuing a similar direction in the future. ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
