Re: [Lldb-commits] [lldb] r282111 - Fix -Wcovered-switch-default warning in StackFrame.cpp

2016-09-21 Thread Ed Maste via lldb-commits 
On 21 September 2016 at 17:08, Ed Maste via lldb-commits
 wrote:
> Author: emaste
> Date: Wed Sep 21 16:08:30 2016
> New Revision: 282111
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282111=rev
> Log:
> Fix -Wcovered-switch-default warning in StackFrame.cpp
>
> The switch coveres all possible values. If a new one is added in the
> future the compiler will start warning, providing a notification that
> the switch needs updating.

For example, the warning shows a missing enum in ClangASTContext.cpp:

../tools/lldb/source/Symbol/ClangASTContext.cpp:4209:11: warning:
enumeration value 'ObjCTypeParam' not handled in switch [-Wswitch]
  switch (qual_type->getTypeClass()) {
  ^
../tools/lldb/source/Symbol/ClangASTContext.cpp:4922:11: warning:
enumeration value 'ObjCTypeParam' not handled in switch [-Wswitch]
  switch (qual_type->getTypeClass()) {
  ^
../tools/lldb/source/Symbol/ClangASTContext.cpp:5131:11: warning:
enumeration value 'ObjCTypeParam' not handled in switch [-Wswitch]
  switch (qual_type->getTypeClass()) {
  ^
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r282111 - Fix -Wcovered-switch-default warning in StackFrame.cpp

2016-09-21 Thread Ed Maste via lldb-commits 
Author: emaste
Date: Wed Sep 21 16:08:30 2016
New Revision: 282111

URL: http://llvm.org/viewvc/llvm-project?rev=282111=rev
Log:
Fix -Wcovered-switch-default warning in StackFrame.cpp

The switch coveres all possible values. If a new one is added in the
future the compiler will start warning, providing a notification that
the switch needs updating.

Modified:
lldb/trunk/source/Target/StackFrame.cpp

Modified: lldb/trunk/source/Target/StackFrame.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrame.cpp?rev=282111=282110=282111=diff
==
--- lldb/trunk/source/Target/StackFrame.cpp (original)
+++ lldb/trunk/source/Target/StackFrame.cpp Wed Sep 21 16:08:30 2016
@@ -1278,8 +1278,6 @@ GetBaseExplainingValue(const Instruction
   return std::make_pair(nullptr, 0);
 }
   }
-  default:
-return std::make_pair(nullptr, 0);
   }
 }
 


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits