Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

2018-03-15 Thread Vedant Kumar via lldb-commits 
All right, I've configured greendragon's cmake/xcode builds to become unstable 
when there are test failures. I've also enabled email notifications for the 
'default set of recipients'. From what I've gathered, Jenkins determines this 
set by looking at the changelist.

Let me know if there continue to be issues with failure notifications.

thanks,
vedant

> On Mar 15, 2018, at 11:02 AM, Vedant Kumar  wrote:
> 
> I haven't received any greendragon bot failure notifications. I'll look into 
> that.
> 
> vedant
> 
>> On Mar 15, 2018, at 8:32 AM, Davide Italiano  wrote:
>> 
>> On Thu, Mar 15, 2018 at 8:28 AM, Pavel Labath  wrote:
>>> Yea, this is strange. The bot does not even appear to be red. It's just
>>> yellow.
>>> 
>> 
>> This is historical. We ought to change this. We just delayed this
>> because we wanted to be *really sure* things were green for a while.
>> Also, UNEXPECTED SUCCESSES should be failures (we ought to change that as 
>> well).
>> 
>>> Anyway, r327633 ought to fix the breakage. As I said in the commit message,
>>> the cause is different treatment of relative paths to "process launch
>>> --stdin". Do you guys have any opinion on which behavior makes more sense?
>>> 
>> 
>> I don't have strong opinion on this, your fix seems reasonable.
>> 
>> Thanks,
>> 
>> --
>> Davide
> 

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

2018-03-15 Thread Vedant Kumar via lldb-commits 
I haven't received any greendragon bot failure notifications. I'll look into 
that.

vedant

> On Mar 15, 2018, at 8:32 AM, Davide Italiano  wrote:
> 
> On Thu, Mar 15, 2018 at 8:28 AM, Pavel Labath  wrote:
>> Yea, this is strange. The bot does not even appear to be red. It's just
>> yellow.
>> 
> 
> This is historical. We ought to change this. We just delayed this
> because we wanted to be *really sure* things were green for a while.
> Also, UNEXPECTED SUCCESSES should be failures (we ought to change that as 
> well).
> 
>> Anyway, r327633 ought to fix the breakage. As I said in the commit message,
>> the cause is different treatment of relative paths to "process launch
>> --stdin". Do you guys have any opinion on which behavior makes more sense?
>> 
> 
> I don't have strong opinion on this, your fix seems reasonable.
> 
> Thanks,
> 
> --
> Davide

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

2018-03-15 Thread Davide Italiano via lldb-commits 
On Thu, Mar 15, 2018 at 8:28 AM, Pavel Labath  wrote:
> Yea, this is strange. The bot does not even appear to be red. It's just
> yellow.
>

This is historical. We ought to change this. We just delayed this
because we wanted to be *really sure* things were green for a while.
Also, UNEXPECTED SUCCESSES should be failures (we ought to change that as well).

> Anyway, r327633 ought to fix the breakage. As I said in the commit message,
> the cause is different treatment of relative paths to "process launch
> --stdin". Do you guys have any opinion on which behavior makes more sense?
>

I don't have strong opinion on this, your fix seems reasonable.

Thanks,

--
Davide
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

2018-03-15 Thread Pavel Labath via lldb-commits 
Yea, this is strange. The bot does not even appear to be red. It's just
yellow.

Anyway, r327633 ought to fix the breakage. As I said in the commit message,
the cause is different treatment of relative paths to "process launch
--stdin". Do you guys have any opinion on which behavior makes more sense?

On Thu, 15 Mar 2018 at 15:21, Davide Italiano  wrote:

> I don't seem to receive mails either (although I should).
> Vedant is babysitting the bots this week. Vedant, are you receiving
> blame mails or the mail notification is disabled altogether?
>
> On Thu, Mar 15, 2018 at 8:06 AM, Pavel Labath  wrote:
> > Yes, it certainly looks that way. Taking a look now.
> >
> > PS: I didn't get any email about this.
> >
> > On Thu, 15 Mar 2018 at 15:04, Davide Italiano 
> wrote:
> >>
> >> This is the most likely cause for the failures we're starting to see
> >> on both our bots on greendragon.
> >> Can you please take a look?
> >>
> >> http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/5791/
> >>
> >>
> >> Thanks!
> >>
> >> --
> >> Davide
> >>
> >> On Thu, Mar 15, 2018 at 6:47 AM, Pavel Labath via lldb-commits
> >>  wrote:
> >> > Author: labath
> >> > Date: Thu Mar 15 06:47:09 2018
> >> > New Revision: 327625
> >> >
> >> > URL: http://llvm.org/viewvc/llvm-project?rev=327625=rev
> >> > Log:
> >> > Next batch of test-tree-cleaning changes
> >> >
> >> > Summary:
> >> > The changes here fall into several categories.
> >> >
> >> > - some tests were redirecting inferior stdout/err to a file. For
> these I
> >> >   make sure we use an absolute path for the file. I also create a
> >> >   lldbutil.read_file_on_target helper function to encapsulate the
> >> >   differences between reading a file locally and remotely.
> >> > - some tests were redirecting the pexpect I/O into a file. For these I
> >> >   use a python StringIO object to avoid creating a file altogether.
> >> > - the TestSettings inferior was creating a file. Here, I make sure the
> >> >   inferior is launched with pwd=build-dir so that the files end up
> >> >   created there.
> >> > - lldb-mi --log (used by some tests) creates a log file in PWD without
> >> >   the ability say differently. To make this work I make sure to run
> >> >   lldb-mi with PWD=build_dir. This in turn necessitated a couple of
> >> >   changes in other lldb-mi tests, which were using relative paths to
> >> >   access the source tree.
> >> >
> >> > Reviewers: aprantl
> >> >
> >> > Subscribers: ki.stfu, mehdi_amini, lldb-commits
> >> >
> >> > Differential Revision: https://reviews.llvm.org/D44159
> >> >
> >> > Modified:
> >> >
> >> >
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> >> >
> >> >
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/single-quote-in-filename-to-lldb/TestSingleQuoteInFilename.py
> >> > lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
> >> > lldb/trunk/packages/Python/lldbsuite/test/settings/TestSettings.py
> >> >
> >> >
> lldb/trunk/packages/Python/lldbsuite/test/terminal/TestSTTYBeforeAndAfter.py
> >> >
> >> > lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/TestMiFile.py
> >> >
> >> >
> lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py
> >> >
> >> >
> lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/startup_options/TestMiStartupOptions.py
> >> >
> >> >
> lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py
> >> >
> >> > Modified:
> >> >
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> >> > URL:
> >> >
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py?rev=327625=327624=327625=diff
> >> >
> >> >
> ==
> >> > ---
> >> >
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> >> > (original)
> >> > +++
> >> >
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> >> > Thu Mar 15 06:47:09 2018
> >> > @@ -19,6 +19,7 @@ import six
> >> >  class ProcessLaunchTestCase(TestBase):
> >> >
> >> >  mydir = TestBase.compute_mydir(__file__)
> >> > +NO_DEBUG_INFO_TESTCASE = True
> >> >
> >> >  def setUp(self):
> >> >  # Call super's setUp().
> >> > @@ -38,8 +39,8 @@ class ProcessLaunchTestCase(TestBase):
> >> >  patterns=["Current executable set to .*a.out"])
> >> >
> >> >  in_file = "input-file.txt"
> >> > -out_file = "output-test.out"
> >> > -err_file = "output-test.err"
> >> > +out_file = lldbutil.append_to_process_working_directory(self,
> >> > "output-test.out")
> >> > +err_file = lldbutil.append_to_process_working_directory(self,
> >> > "output-test.err")
> >> >
> >> >  #

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

2018-03-15 Thread Davide Italiano via lldb-commits 
I don't seem to receive mails either (although I should).
Vedant is babysitting the bots this week. Vedant, are you receiving
blame mails or the mail notification is disabled altogether?

On Thu, Mar 15, 2018 at 8:06 AM, Pavel Labath  wrote:
> Yes, it certainly looks that way. Taking a look now.
>
> PS: I didn't get any email about this.
>
> On Thu, 15 Mar 2018 at 15:04, Davide Italiano  wrote:
>>
>> This is the most likely cause for the failures we're starting to see
>> on both our bots on greendragon.
>> Can you please take a look?
>>
>> http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/5791/
>>
>>
>> Thanks!
>>
>> --
>> Davide
>>
>> On Thu, Mar 15, 2018 at 6:47 AM, Pavel Labath via lldb-commits
>>  wrote:
>> > Author: labath
>> > Date: Thu Mar 15 06:47:09 2018
>> > New Revision: 327625
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=327625=rev
>> > Log:
>> > Next batch of test-tree-cleaning changes
>> >
>> > Summary:
>> > The changes here fall into several categories.
>> >
>> > - some tests were redirecting inferior stdout/err to a file. For these I
>> >   make sure we use an absolute path for the file. I also create a
>> >   lldbutil.read_file_on_target helper function to encapsulate the
>> >   differences between reading a file locally and remotely.
>> > - some tests were redirecting the pexpect I/O into a file. For these I
>> >   use a python StringIO object to avoid creating a file altogether.
>> > - the TestSettings inferior was creating a file. Here, I make sure the
>> >   inferior is launched with pwd=build-dir so that the files end up
>> >   created there.
>> > - lldb-mi --log (used by some tests) creates a log file in PWD without
>> >   the ability say differently. To make this work I make sure to run
>> >   lldb-mi with PWD=build_dir. This in turn necessitated a couple of
>> >   changes in other lldb-mi tests, which were using relative paths to
>> >   access the source tree.
>> >
>> > Reviewers: aprantl
>> >
>> > Subscribers: ki.stfu, mehdi_amini, lldb-commits
>> >
>> > Differential Revision: https://reviews.llvm.org/D44159
>> >
>> > Modified:
>> >
>> > lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
>> >
>> > lldb/trunk/packages/Python/lldbsuite/test/functionalities/single-quote-in-filename-to-lldb/TestSingleQuoteInFilename.py
>> > lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
>> > lldb/trunk/packages/Python/lldbsuite/test/settings/TestSettings.py
>> >
>> > lldb/trunk/packages/Python/lldbsuite/test/terminal/TestSTTYBeforeAndAfter.py
>> >
>> > lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/TestMiFile.py
>> >
>> > lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py
>> >
>> > lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/startup_options/TestMiStartupOptions.py
>> >
>> > lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py
>> >
>> > Modified:
>> > lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py?rev=327625=327624=327625=diff
>> >
>> > ==
>> > ---
>> > lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
>> > (original)
>> > +++
>> > lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
>> > Thu Mar 15 06:47:09 2018
>> > @@ -19,6 +19,7 @@ import six
>> >  class ProcessLaunchTestCase(TestBase):
>> >
>> >  mydir = TestBase.compute_mydir(__file__)
>> > +NO_DEBUG_INFO_TESTCASE = True
>> >
>> >  def setUp(self):
>> >  # Call super's setUp().
>> > @@ -38,8 +39,8 @@ class ProcessLaunchTestCase(TestBase):
>> >  patterns=["Current executable set to .*a.out"])
>> >
>> >  in_file = "input-file.txt"
>> > -out_file = "output-test.out"
>> > -err_file = "output-test.err"
>> > +out_file = lldbutil.append_to_process_working_directory(self,
>> > "output-test.out")
>> > +err_file = lldbutil.append_to_process_working_directory(self,
>> > "output-test.err")
>> >
>> >  # Make sure the output files do not exist before launching the
>> > process
>> >  try:
>> > @@ -52,8 +53,8 @@ class ProcessLaunchTestCase(TestBase):
>> >  except OSError:
>> >  pass
>> >
>> > -launch_command = "process launch -i " + \
>> > -in_file + " -o " + out_file + " -e " + err_file
>> > +launch_command = "process launch -i '{0}' -o '{1}' -e '{2}' -w
>> > '{3}'".format(
>> > +in_file, out_file, err_file,
>> > self.get_process_working_directory())
>> >
>> >  if lldb.remote_platform:
>> >  self.runCmd('platform put-file

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

2018-03-15 Thread Pavel Labath via lldb-commits 
Yes, it certainly looks that way. Taking a look now.

PS: I didn't get any email about this.

On Thu, 15 Mar 2018 at 15:04, Davide Italiano  wrote:

> This is the most likely cause for the failures we're starting to see
> on both our bots on greendragon.
> Can you please take a look?
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/5791/
>
>
> Thanks!
>
> --
> Davide
>
> On Thu, Mar 15, 2018 at 6:47 AM, Pavel Labath via lldb-commits
>  wrote:
> > Author: labath
> > Date: Thu Mar 15 06:47:09 2018
> > New Revision: 327625
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=327625=rev
> > Log:
> > Next batch of test-tree-cleaning changes
> >
> > Summary:
> > The changes here fall into several categories.
> >
> > - some tests were redirecting inferior stdout/err to a file. For these I
> >   make sure we use an absolute path for the file. I also create a
> >   lldbutil.read_file_on_target helper function to encapsulate the
> >   differences between reading a file locally and remotely.
> > - some tests were redirecting the pexpect I/O into a file. For these I
> >   use a python StringIO object to avoid creating a file altogether.
> > - the TestSettings inferior was creating a file. Here, I make sure the
> >   inferior is launched with pwd=build-dir so that the files end up
> >   created there.
> > - lldb-mi --log (used by some tests) creates a log file in PWD without
> >   the ability say differently. To make this work I make sure to run
> >   lldb-mi with PWD=build_dir. This in turn necessitated a couple of
> >   changes in other lldb-mi tests, which were using relative paths to
> >   access the source tree.
> >
> > Reviewers: aprantl
> >
> > Subscribers: ki.stfu, mehdi_amini, lldb-commits
> >
> > Differential Revision: https://reviews.llvm.org/D44159
> >
> > Modified:
> >
>  
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> >
>  
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/single-quote-in-filename-to-lldb/TestSingleQuoteInFilename.py
> > lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
> > lldb/trunk/packages/Python/lldbsuite/test/settings/TestSettings.py
> >
>  lldb/trunk/packages/Python/lldbsuite/test/terminal/TestSTTYBeforeAndAfter.py
> > lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/TestMiFile.py
> >
>  lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py
> >
>  
> lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/startup_options/TestMiStartupOptions.py
> >
>  
> lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py
> >
> > Modified:
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> > URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py?rev=327625=327624=327625=diff
> >
> ==
> > ---
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> (original)
> > +++
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> Thu Mar 15 06:47:09 2018
> > @@ -19,6 +19,7 @@ import six
> >  class ProcessLaunchTestCase(TestBase):
> >
> >  mydir = TestBase.compute_mydir(__file__)
> > +NO_DEBUG_INFO_TESTCASE = True
> >
> >  def setUp(self):
> >  # Call super's setUp().
> > @@ -38,8 +39,8 @@ class ProcessLaunchTestCase(TestBase):
> >  patterns=["Current executable set to .*a.out"])
> >
> >  in_file = "input-file.txt"
> > -out_file = "output-test.out"
> > -err_file = "output-test.err"
> > +out_file = lldbutil.append_to_process_working_directory(self,
> "output-test.out")
> > +err_file = lldbutil.append_to_process_working_directory(self,
> "output-test.err")
> >
> >  # Make sure the output files do not exist before launching the
> process
> >  try:
> > @@ -52,8 +53,8 @@ class ProcessLaunchTestCase(TestBase):
> >  except OSError:
> >  pass
> >
> > -launch_command = "process launch -i " + \
> > -in_file + " -o " + out_file + " -e " + err_file
> > +launch_command = "process launch -i '{0}' -o '{1}' -e '{2}' -w
> '{3}'".format(
> > +in_file, out_file, err_file,
> self.get_process_working_directory())
> >
> >  if lldb.remote_platform:
> >  self.runCmd('platform put-file "{local}" "{remote}"'.format(
> > @@ -62,55 +63,19 @@ class ProcessLaunchTestCase(TestBase):
> >  self.expect(launch_command,
> >  patterns=["Process .* launched: .*a.out"])
> >
> > -if lldb.remote_platform:
> > -self.runCmd('platform get-file "{remote}" "{local}"'.format(
> > -remote=out_file, local=out_file))
> > -

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

2018-03-15 Thread Davide Italiano via lldb-commits 
This is the most likely cause for the failures we're starting to see
on both our bots on greendragon.
Can you please take a look?

http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/5791/


Thanks!

--
Davide

On Thu, Mar 15, 2018 at 6:47 AM, Pavel Labath via lldb-commits
 wrote:
> Author: labath
> Date: Thu Mar 15 06:47:09 2018
> New Revision: 327625
>
> URL: http://llvm.org/viewvc/llvm-project?rev=327625=rev
> Log:
> Next batch of test-tree-cleaning changes
>
> Summary:
> The changes here fall into several categories.
>
> - some tests were redirecting inferior stdout/err to a file. For these I
>   make sure we use an absolute path for the file. I also create a
>   lldbutil.read_file_on_target helper function to encapsulate the
>   differences between reading a file locally and remotely.
> - some tests were redirecting the pexpect I/O into a file. For these I
>   use a python StringIO object to avoid creating a file altogether.
> - the TestSettings inferior was creating a file. Here, I make sure the
>   inferior is launched with pwd=build-dir so that the files end up
>   created there.
> - lldb-mi --log (used by some tests) creates a log file in PWD without
>   the ability say differently. To make this work I make sure to run
>   lldb-mi with PWD=build_dir. This in turn necessitated a couple of
>   changes in other lldb-mi tests, which were using relative paths to
>   access the source tree.
>
> Reviewers: aprantl
>
> Subscribers: ki.stfu, mehdi_amini, lldb-commits
>
> Differential Revision: https://reviews.llvm.org/D44159
>
> Modified:
> 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/single-quote-in-filename-to-lldb/TestSingleQuoteInFilename.py
> lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
> lldb/trunk/packages/Python/lldbsuite/test/settings/TestSettings.py
> 
> lldb/trunk/packages/Python/lldbsuite/test/terminal/TestSTTYBeforeAndAfter.py
> lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/TestMiFile.py
> lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py
> 
> lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/startup_options/TestMiStartupOptions.py
> 
> lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py
>
> Modified: 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
> URL: 
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py?rev=327625=327624=327625=diff
> ==
> --- 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
>  (original)
> +++ 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py
>  Thu Mar 15 06:47:09 2018
> @@ -19,6 +19,7 @@ import six
>  class ProcessLaunchTestCase(TestBase):
>
>  mydir = TestBase.compute_mydir(__file__)
> +NO_DEBUG_INFO_TESTCASE = True
>
>  def setUp(self):
>  # Call super's setUp().
> @@ -38,8 +39,8 @@ class ProcessLaunchTestCase(TestBase):
>  patterns=["Current executable set to .*a.out"])
>
>  in_file = "input-file.txt"
> -out_file = "output-test.out"
> -err_file = "output-test.err"
> +out_file = lldbutil.append_to_process_working_directory(self, 
> "output-test.out")
> +err_file = lldbutil.append_to_process_working_directory(self, 
> "output-test.err")
>
>  # Make sure the output files do not exist before launching the 
> process
>  try:
> @@ -52,8 +53,8 @@ class ProcessLaunchTestCase(TestBase):
>  except OSError:
>  pass
>
> -launch_command = "process launch -i " + \
> -in_file + " -o " + out_file + " -e " + err_file
> +launch_command = "process launch -i '{0}' -o '{1}' -e '{2}' -w 
> '{3}'".format(
> +in_file, out_file, err_file, 
> self.get_process_working_directory())
>
>  if lldb.remote_platform:
>  self.runCmd('platform put-file "{local}" "{remote}"'.format(
> @@ -62,55 +63,19 @@ class ProcessLaunchTestCase(TestBase):
>  self.expect(launch_command,
>  patterns=["Process .* launched: .*a.out"])
>
> -if lldb.remote_platform:
> -self.runCmd('platform get-file "{remote}" "{local}"'.format(
> -remote=out_file, local=out_file))
> -self.runCmd('platform get-file "{remote}" "{local}"'.format(
> -remote=err_file, local=err_file))
> -
>  success = True
>  err_msg = ""
>
> -# Check to see if the 'stdout' file was created
> -try:
> -out_f = open(out_file)
> -except IOError:
> +out =