Re: [lldb-dev] Bot failure with new "in tree compiler" changes (r316728) in llvm.org bot

[Zachary Turner via lldb-dev]

Yea, adding a FORCE for a day or two and then removing the FORCE several
days later is a good way to handle this kind of thing.

On Tue, Nov 7, 2017 at 10:42 AM Reid Kleckner via lldb-dev <
lldb-dev@lists.llvm.org> wrote:

> In general, please try to structure changes so that CMake cache clobbers
> aren't necessary. If you introduce changes that require clobbers by
> accident, consider adding some temporary CMake logic to help buildbots
> recover on their own. Some temporary CMake hacks can save a lot of time
> across all the folks that have to discover and debug this problem.
>
> On Tue, Nov 7, 2017 at 10:28 AM, Pavel Labath via lldb-dev <
> lldb-dev@lists.llvm.org> wrote:
>
>> You probably just need to nuke the build folder.
>>
>> The reason for that is that before the patch the LLDB_TEST_C_COMPILER
>> variable was used for a different purpose (and usually empty), where
>> as now it's set by default to the in-tree clang. However, cmake will
>> not overwrite the cached value by design. (I could have worked around
>> that in cmake, but I only noticed that issue after landing the
>> change.)
>>
>> Erasing the build folder should let the new and correct default kick
>> in. If you run the check-lldb target then it will now use the in-tree
>> clang instead of the system compiler for using tests.
>>
>> sorry about the trouble,
>> pl
>>
>>
>>
>> On 7 November 2017 at 18:21, Jim Ingham via lldb-dev
>>  wrote:
>> > The lldb_cmake GreenDragon bot is now failing, e.g.:
>> >
>> >
>> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_cmake/1703/consoleFull#589016626e9a0fee5-ebcc-4238-a641-c5aa112c323e
>> >
>> > This looks related to Pavel's change:
>> >
>> >> r316728 | labath | 2017-10-26 19:24:04 -0700 (Thu, 26 Oct 2017) | 18
>> lines
>> >>
>> >> Default to using in-tree clang for building test executables
>> >>
>> >> Summary:
>> >> Using the in-tree clang should be the default test configuration as
>> that
>> >> is the one compiler that we can be sure everyone has (better
>> >> reproducibility of test results). Also, it should hopefully reduce the
>> >> impact of pr35040.
>> >>
>> >> This also reduces the number of settings which control the compiler
>> >> used. LLDB_TEST_C_COMPILER is used for C files and
>> >> LLDB_TEST_CXX_COMPILER for C++ files. Both of the settings default to
>> >> the in-tree clang.
>> >>
>> >> Reviewers: zturner
>> >>
>> >> Subscribers: mgorny, davide, lldb-commits
>> >>
>> >> Differential Revision: https://reviews.llvm.org/D39215
>> >>
>> >
>> > The error is:
>> >
>> > CMake Error at tools/lldb/CMakeLists.txt:78 (message):
>> >
>> >   LLDB test compilers not specified.  Tests will not run
>> >
>> >
>> > Does the bot need to be reconfigured for these changes?
>> >
>> > Jim
>> >
>> > ___
>> > lldb-dev mailing list
>> > lldb-dev@lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>> ___
>> lldb-dev mailing list
>> lldb-dev@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>
>
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Bot failure with new "in tree compiler" changes (r316728) in llvm.org bot

[Reid Kleckner via lldb-dev]

In general, please try to structure changes so that CMake cache clobbers
aren't necessary. If you introduce changes that require clobbers by
accident, consider adding some temporary CMake logic to help buildbots
recover on their own. Some temporary CMake hacks can save a lot of time
across all the folks that have to discover and debug this problem.

On Tue, Nov 7, 2017 at 10:28 AM, Pavel Labath via lldb-dev <
lldb-dev@lists.llvm.org> wrote:

> You probably just need to nuke the build folder.
>
> The reason for that is that before the patch the LLDB_TEST_C_COMPILER
> variable was used for a different purpose (and usually empty), where
> as now it's set by default to the in-tree clang. However, cmake will
> not overwrite the cached value by design. (I could have worked around
> that in cmake, but I only noticed that issue after landing the
> change.)
>
> Erasing the build folder should let the new and correct default kick
> in. If you run the check-lldb target then it will now use the in-tree
> clang instead of the system compiler for using tests.
>
> sorry about the trouble,
> pl
>
>
>
> On 7 November 2017 at 18:21, Jim Ingham via lldb-dev
>  wrote:
> > The lldb_cmake GreenDragon bot is now failing, e.g.:
> >
> > http://lab.llvm.org:8080/green/view/LLDB/job/lldb_
> cmake/1703/consoleFull#589016626e9a0fee5-ebcc-4238-a641-c5aa112c323e
> >
> > This looks related to Pavel's change:
> >
> >> r316728 | labath | 2017-10-26 19:24:04 -0700 (Thu, 26 Oct 2017) | 18
> lines
> >>
> >> Default to using in-tree clang for building test executables
> >>
> >> Summary:
> >> Using the in-tree clang should be the default test configuration as that
> >> is the one compiler that we can be sure everyone has (better
> >> reproducibility of test results). Also, it should hopefully reduce the
> >> impact of pr35040.
> >>
> >> This also reduces the number of settings which control the compiler
> >> used. LLDB_TEST_C_COMPILER is used for C files and
> >> LLDB_TEST_CXX_COMPILER for C++ files. Both of the settings default to
> >> the in-tree clang.
> >>
> >> Reviewers: zturner
> >>
> >> Subscribers: mgorny, davide, lldb-commits
> >>
> >> Differential Revision: https://reviews.llvm.org/D39215
> >>
> >
> > The error is:
> >
> > CMake Error at tools/lldb/CMakeLists.txt:78 (message):
> >
> >   LLDB test compilers not specified.  Tests will not run
> >
> >
> > Does the bot need to be reconfigured for these changes?
> >
> > Jim
> >
> > ___
> > lldb-dev mailing list
> > lldb-dev@lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Bot failure with new "in tree compiler" changes (r316728) in llvm.org bot

[Jim Ingham via lldb-dev]

Good news.  I got somebody to kick the llvm.org bots, so sounds like this 
should solve the problem.

Jim


> On Nov 7, 2017, at 10:36 AM, Ted Woodward <ted.woodw...@codeaurora.org> wrote:
> 
> We had the same problem internally on our bots. A clean build blew away the 
> cmake caches and fixed the problem.
>  
> Ted
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
> Linux Foundation Collaborative Project
>  
> From: lldb-dev [mailto:lldb-dev-boun...@lists.llvm.org] On Behalf Of Don 
> Hinton via lldb-dev
> Sent: Tuesday, November 07, 2017 12:28 PM
> To: Jim Ingham <jing...@apple.com>
> Cc: LLDB <lldb-dev@lists.llvm.org>
> Subject: Re: [lldb-dev] Bot failure with new "in tree compiler" changes 
> (r316728) in llvm.org bot
>  
> I hit the same problem last week.  I ended up blowing away my build 
> directory, and the problem went away.  
>  
> Probably a cache issue, but I was unable to reproduce...
>  
> On Tue, Nov 7, 2017 at 10:21 AM, Jim Ingham via lldb-dev 
> <lldb-dev@lists.llvm.org> wrote:
>> The lldb_cmake GreenDragon bot is now failing, e.g.:
>> 
>> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_cmake/1703/consoleFull#589016626e9a0fee5-ebcc-4238-a641-c5aa112c323e
>> 
>> This looks related to Pavel's change:
>> 
>> > r316728 | labath | 2017-10-26 19:24:04 -0700 (Thu, 26 Oct 2017) | 18 lines
>> >
>> > Default to using in-tree clang for building test executables
>> >
>> > Summary:
>> > Using the in-tree clang should be the default test configuration as that
>> > is the one compiler that we can be sure everyone has (better
>> > reproducibility of test results). Also, it should hopefully reduce the
>> > impact of pr35040.
>> >
>> > This also reduces the number of settings which control the compiler
>> > used. LLDB_TEST_C_COMPILER is used for C files and
>> > LLDB_TEST_CXX_COMPILER for C++ files. Both of the settings default to
>> > the in-tree clang.
>> >
>> > Reviewers: zturner
>> >
>> > Subscribers: mgorny, davide, lldb-commits
>> >
>> > Differential Revision: https://reviews.llvm.org/D39215
>> >
>> 
>> The error is:
>> 
>> CMake Error at tools/lldb/CMakeLists.txt:78 (message):
>> 
>>   LLDB test compilers not specified.  Tests will not run
>> 
>> 
>> Does the bot need to be reconfigured for these changes?
>> 
>> Jim
>> 
>> ___
>> lldb-dev mailing list
>> lldb-dev@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Bot failure with new "in tree compiler" changes (r316728) in llvm.org bot

[Ted Woodward via lldb-dev]

We had the same problem internally on our bots. A clean build blew away the 
cmake caches and fixed the problem.

 

Ted

--

Qualcomm Innovation Center, Inc.

The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux 
Foundation Collaborative Project

 

From: lldb-dev [mailto:lldb-dev-boun...@lists.llvm.org] On Behalf Of Don Hinton 
via lldb-dev
Sent: Tuesday, November 07, 2017 12:28 PM
To: Jim Ingham <jing...@apple.com>
Cc: LLDB <lldb-dev@lists.llvm.org>
Subject: Re: [lldb-dev] Bot failure with new "in tree compiler" changes 
(r316728) in llvm.org bot

 

I hit the same problem last week.  I ended up blowing away my build directory, 
and the problem went away.  

 

Probably a cache issue, but I was unable to reproduce...

 

On Tue, Nov 7, 2017 at 10:21 AM, Jim Ingham via lldb-dev 
<lldb-dev@lists.llvm.org <mailto:lldb-dev@lists.llvm.org> > wrote:

The lldb_cmake GreenDragon bot is now failing, e.g.:

http://lab.llvm.org:8080/green/view/LLDB/job/lldb_cmake/1703/consoleFull#589016626e9a0fee5-ebcc-4238-a641-c5aa112c323e

This looks related to Pavel's change:

> r316728 | labath | 2017-10-26 19:24:04 -0700 (Thu, 26 Oct 2017) | 18 lines
>
> Default to using in-tree clang for building test executables
>
> Summary:
> Using the in-tree clang should be the default test configuration as that
> is the one compiler that we can be sure everyone has (better
> reproducibility of test results). Also, it should hopefully reduce the
> impact of pr35040.
>
> This also reduces the number of settings which control the compiler
> used. LLDB_TEST_C_COMPILER is used for C files and
> LLDB_TEST_CXX_COMPILER for C++ files. Both of the settings default to
> the in-tree clang.
>
> Reviewers: zturner
>
> Subscribers: mgorny, davide, lldb-commits
>
> Differential Revision: https://reviews.llvm.org/D39215
>

The error is:

CMake Error at tools/lldb/CMakeLists.txt:78 (message):

  LLDB test compilers not specified.  Tests will not run


Does the bot need to be reconfigured for these changes?

Jim

___
lldb-dev mailing list
lldb-dev@lists.llvm.org <mailto:lldb-dev@lists.llvm.org> 
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

 

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Bot failure with new "in tree compiler" changes (r316728) in llvm.org bot

[Jim Ingham via lldb-dev]

NP, I'll find somebody who can initiate a clean rebuild.

Jim


> On Nov 7, 2017, at 10:28 AM, Pavel Labath  wrote:
> 
> You probably just need to nuke the build folder.
> 
> The reason for that is that before the patch the LLDB_TEST_C_COMPILER
> variable was used for a different purpose (and usually empty), where
> as now it's set by default to the in-tree clang. However, cmake will
> not overwrite the cached value by design. (I could have worked around
> that in cmake, but I only noticed that issue after landing the
> change.)
> 
> Erasing the build folder should let the new and correct default kick
> in. If you run the check-lldb target then it will now use the in-tree
> clang instead of the system compiler for using tests.
> 
> sorry about the trouble,
> pl
> 
> 
> 
> On 7 November 2017 at 18:21, Jim Ingham via lldb-dev
>  wrote:
>> The lldb_cmake GreenDragon bot is now failing, e.g.:
>> 
>> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_cmake/1703/consoleFull#589016626e9a0fee5-ebcc-4238-a641-c5aa112c323e
>> 
>> This looks related to Pavel's change:
>> 
>>> r316728 | labath | 2017-10-26 19:24:04 -0700 (Thu, 26 Oct 2017) | 18 lines
>>> 
>>> Default to using in-tree clang for building test executables
>>> 
>>> Summary:
>>> Using the in-tree clang should be the default test configuration as that
>>> is the one compiler that we can be sure everyone has (better
>>> reproducibility of test results). Also, it should hopefully reduce the
>>> impact of pr35040.
>>> 
>>> This also reduces the number of settings which control the compiler
>>> used. LLDB_TEST_C_COMPILER is used for C files and
>>> LLDB_TEST_CXX_COMPILER for C++ files. Both of the settings default to
>>> the in-tree clang.
>>> 
>>> Reviewers: zturner
>>> 
>>> Subscribers: mgorny, davide, lldb-commits
>>> 
>>> Differential Revision: https://reviews.llvm.org/D39215
>>> 
>> 
>> The error is:
>> 
>> CMake Error at tools/lldb/CMakeLists.txt:78 (message):
>> 
>>  LLDB test compilers not specified.  Tests will not run
>> 
>> 
>> Does the bot need to be reconfigured for these changes?
>> 
>> Jim
>> 
>> ___
>> lldb-dev mailing list
>> lldb-dev@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Bot failure with new "in tree compiler" changes (r316728) in llvm.org bot

[Pavel Labath via lldb-dev]

You probably just need to nuke the build folder.

The reason for that is that before the patch the LLDB_TEST_C_COMPILER
variable was used for a different purpose (and usually empty), where
as now it's set by default to the in-tree clang. However, cmake will
not overwrite the cached value by design. (I could have worked around
that in cmake, but I only noticed that issue after landing the
change.)

Erasing the build folder should let the new and correct default kick
in. If you run the check-lldb target then it will now use the in-tree
clang instead of the system compiler for using tests.

sorry about the trouble,
pl



On 7 November 2017 at 18:21, Jim Ingham via lldb-dev
 wrote:
> The lldb_cmake GreenDragon bot is now failing, e.g.:
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_cmake/1703/consoleFull#589016626e9a0fee5-ebcc-4238-a641-c5aa112c323e
>
> This looks related to Pavel's change:
>
>> r316728 | labath | 2017-10-26 19:24:04 -0700 (Thu, 26 Oct 2017) | 18 lines
>>
>> Default to using in-tree clang for building test executables
>>
>> Summary:
>> Using the in-tree clang should be the default test configuration as that
>> is the one compiler that we can be sure everyone has (better
>> reproducibility of test results). Also, it should hopefully reduce the
>> impact of pr35040.
>>
>> This also reduces the number of settings which control the compiler
>> used. LLDB_TEST_C_COMPILER is used for C files and
>> LLDB_TEST_CXX_COMPILER for C++ files. Both of the settings default to
>> the in-tree clang.
>>
>> Reviewers: zturner
>>
>> Subscribers: mgorny, davide, lldb-commits
>>
>> Differential Revision: https://reviews.llvm.org/D39215
>>
>
> The error is:
>
> CMake Error at tools/lldb/CMakeLists.txt:78 (message):
>
>   LLDB test compilers not specified.  Tests will not run
>
>
> Does the bot need to be reconfigured for these changes?
>
> Jim
>
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Bot failure with new "in tree compiler" changes (r316728) in llvm.org bot

[Don Hinton via lldb-dev]

I hit the same problem last week.  I ended up blowing away my build
directory, and the problem went away.

Probably a cache issue, but I was unable to reproduce...

On Tue, Nov 7, 2017 at 10:21 AM, Jim Ingham via lldb-dev <
lldb-dev@lists.llvm.org> wrote:

> The lldb_cmake GreenDragon bot is now failing, e.g.:
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_cmake/1703/consoleFull#
> 589016626e9a0fee5-ebcc-4238-a641-c5aa112c323e
>
> This looks related to Pavel's change:
>
> > r316728 | labath | 2017-10-26 19:24:04 -0700 (Thu, 26 Oct 2017) | 18
> lines
> >
> > Default to using in-tree clang for building test executables
> >
> > Summary:
> > Using the in-tree clang should be the default test configuration as that
> > is the one compiler that we can be sure everyone has (better
> > reproducibility of test results). Also, it should hopefully reduce the
> > impact of pr35040.
> >
> > This also reduces the number of settings which control the compiler
> > used. LLDB_TEST_C_COMPILER is used for C files and
> > LLDB_TEST_CXX_COMPILER for C++ files. Both of the settings default to
> > the in-tree clang.
> >
> > Reviewers: zturner
> >
> > Subscribers: mgorny, davide, lldb-commits
> >
> > Differential Revision: https://reviews.llvm.org/D39215
> >
>
> The error is:
>
> CMake Error at tools/lldb/CMakeLists.txt:78 (message):
>
>   LLDB test compilers not specified.  Tests will not run
>
>
> Does the bot need to be reconfigured for these changes?
>
> Jim
>
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

[lldb-dev] Bot failure with new "in tree compiler" changes (r316728) in llvm.org bot

[Jim Ingham via lldb-dev]

The lldb_cmake GreenDragon bot is now failing, e.g.:

http://lab.llvm.org:8080/green/view/LLDB/job/lldb_cmake/1703/consoleFull#589016626e9a0fee5-ebcc-4238-a641-c5aa112c323e

This looks related to Pavel's change:

> r316728 | labath | 2017-10-26 19:24:04 -0700 (Thu, 26 Oct 2017) | 18 lines
> 
> Default to using in-tree clang for building test executables
> 
> Summary:
> Using the in-tree clang should be the default test configuration as that
> is the one compiler that we can be sure everyone has (better
> reproducibility of test results). Also, it should hopefully reduce the
> impact of pr35040.
> 
> This also reduces the number of settings which control the compiler
> used. LLDB_TEST_C_COMPILER is used for C files and
> LLDB_TEST_CXX_COMPILER for C++ files. Both of the settings default to
> the in-tree clang.
> 
> Reviewers: zturner
> 
> Subscribers: mgorny, davide, lldb-commits
> 
> Differential Revision: https://reviews.llvm.org/D39215
> 

The error is:

CMake Error at tools/lldb/CMakeLists.txt:78 (message):

  LLDB test compilers not specified.  Tests will not run


Does the bot need to be reconfigured for these changes?

Jim

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev