[llvm-branch-commits] [clang] [CIR] Refactor floating point type constraints (PR #138112)

[Andy Kaylor via llvm-branch-commits]

https://github.com/andykaylor approved this pull request.

Looks good, with one minor request.

https://github.com/llvm/llvm-project/pull/138112
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [CIR] Refactor floating point type constraints (PR #138112)

[Andy Kaylor via llvm-branch-commits]

https://github.com/andykaylor edited 
https://github.com/llvm/llvm-project/pull/138112
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [CIR] Refactor floating point type constraints (PR #138112)

[Andy Kaylor via llvm-branch-commits]

@@ -155,21 +153,14 @@ def CIR_LongDouble : CIR_FloatType<"LongDouble", 
"long_double"> {
 format are all in use.
   }];
 
-  let parameters = (ins "mlir::Type":$underlying);
+  let parameters = (ins AnyTypeOf<[CIR_Double, CIR_FP80, CIR_FP128],
+"expects !cir.double, !cir.fp80 or !cir.fp128">:$underlying);

andykaylor wrote:

Can you add a test for this? It looks like the wording of the reported error 
will change, so we must not have a test now.

https://github.com/llvm/llvm-project/pull/138112
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [CIR] Refactor floating point type constraints (PR #138112)

[Andy Kaylor via llvm-branch-commits]

@@ -110,4 +110,35 @@ def CIR_AnyFundamentalSIntType
 let cppFunctionName = "isFundamentalSIntType";
 }
 
+//===--===//
+// Float Type predicates
+//===--===//
+
+def CIR_AnySingleType : CIR_TypeBase<"::cir::SingleType", "single float type">;

andykaylor wrote:

Is there a reason for the explicit global scope?

https://github.com/llvm/llvm-project/pull/138112
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [CIR] Let ConstantOp builder infer its type automatically (PR #136606)

[Andy Kaylor via llvm-branch-commits]

https://github.com/andykaylor approved this pull request.

lgtm

https://github.com/llvm/llvm-project/pull/136606
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [CIR] Make UndefAttr use AttrBuilderWithInferredContext (PR #136605)

[Andy Kaylor via llvm-branch-commits]

https://github.com/andykaylor approved this pull request.

lgtm

https://github.com/llvm/llvm-project/pull/136605
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [CIR] Remove implicit options from tablegen files (PR #138860)

[Andy Kaylor via llvm-branch-commits]

https://github.com/andykaylor approved this pull request.

lgtm

https://github.com/llvm/llvm-project/pull/138860
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [CIR] Remove implicit options from tablegen files (PR #138860)

[Andy Kaylor via llvm-branch-commits]

https://github.com/andykaylor approved this pull request.

lgtm

https://github.com/llvm/llvm-project/pull/138860
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits