Re: [llvm-commits] [llvm-gcc-4.2] r47205 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

2008-02-16 Thread Chris Lattner 
 I am going to temporarily disable this if that's the case. Please  
 take
 a look.

 Yes please do.  Until ppc has support for memory.barrier, that file
 won't compile.  The builtin was just being ignored before.  I'll see
 about ppc support tomorrow.

Please set it to expand by default (in the TargetLowering ctor).   
Targets that implement it can set it to legal.

Expand for this intrinsic should lower it to a libgcc libcall.

-Chris
___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

[llvm-commits] [llvm-gcc-4.2] r47205 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

2008-02-15 Thread Andrew Lenharth 
Author: alenhar2
Date: Fri Feb 15 19:27:28 2008
New Revision: 47205

URL: http://llvm.org/viewvc/llvm-project?rev=47205view=rev
Log:
llvm.memory.barrier for __sync_syncronize

Modified:
llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

Modified: llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp
URL: 
http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp?rev=47205r1=47204r2=47205view=diff

==
--- llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp (original)
+++ llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp Fri Feb 15 19:27:28 2008
@@ -4293,6 +4293,18 @@
 return true;
   }
 
+  case BUILT_IN_SYNCHRONIZE: {
+// We assume like gcc appears to, that this only applies to cached memory.
+Value* C[5];
+C[0] = C[1] = C[2] = C[3] = ConstantInt::get(Type::Int1Ty, 1);
+C[4] = ConstantInt::get(Type::Int1Ty, 0);
+   
+Builder.CreateCall(Intrinsic::getDeclaration(TheModule, 
+ Intrinsic::memory_barrier),
+   C, C + 5);
+return true;
+  }
+
 #if 1  // FIXME: Should handle these GCC extensions eventually.
 case BUILT_IN_APPLY_ARGS:
 case BUILT_IN_APPLY:


___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Re: [llvm-commits] [llvm-gcc-4.2] r47205 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

2008-02-15 Thread Chris Lattner 
nice!

On Feb 15, 2008, at 5:27 PM, Andrew Lenharth wrote:

 Author: alenhar2
 Date: Fri Feb 15 19:27:28 2008
 New Revision: 47205

 URL: http://llvm.org/viewvc/llvm-project?rev=47205view=rev
 Log:
 llvm.memory.barrier for __sync_syncronize

 Modified:
llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

 Modified: llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp
 URL: 
 http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp?rev=47205r1=47204r2=47205view=diff

 =
 =
 =
 =
 =
 =
 =
 =
 ==
 --- llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp (original)
 +++ llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp Fri Feb 15 19:27:28 2008
 @@ -4293,6 +4293,18 @@
 return true;
   }

 +  case BUILT_IN_SYNCHRONIZE: {
 +// We assume like gcc appears to, that this only applies to  
 cached memory.
 +Value* C[5];
 +C[0] = C[1] = C[2] = C[3] = ConstantInt::get(Type::Int1Ty, 1);
 +C[4] = ConstantInt::get(Type::Int1Ty, 0);
 +
 +Builder.CreateCall(Intrinsic::getDeclaration(TheModule,
 +  
 Intrinsic::memory_barrier),
 +   C, C + 5);
 +return true;
 +  }
 +
 #if 1  // FIXME: Should handle these GCC extensions eventually.
 case BUILT_IN_APPLY_ARGS:
 case BUILT_IN_APPLY:


 ___
 llvm-commits mailing list
 llvm-commits@cs.uiuc.edu
 http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Re: [llvm-commits] [llvm-gcc-4.2] r47205 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

2008-02-15 Thread Evan Cheng 
Hi Andrew,

I think this might be breaking ppc build.

/tmp/llvmgcc42.roots/llvmgcc42~obj/obj-i686-powerpc/./gcc/xgcc -B/ 
tmp/llvmgcc42.roots/llvmgcc42~obj/obj-i686-powerpc/./gcc/ -B/ 
Developer/usr/llvm-gcc-4.2/powerpc-apple-darwin9/bin/ -B/Developer/usr/ 
llvm-gc\
c-4.2/powerpc-apple-darwin9/lib/ -isystem /Developer/usr/llvm-gcc-4.2/ 
powerpc-apple-darwin9/include -isystem /Developer/usr/llvm-gcc-4.2/ 
powerpc-apple-darwin9/sys-include -DHAVE_CONFIG_H -I. -I/tmp/ 
llvmgcc42.\
roots/llvmgcc42~obj/src/libgomp -I. -I/tmp/llvmgcc42.roots/ 
llvmgcc42~obj/src/libgomp/config/posix -I/tmp/llvmgcc42.roots/ 
llvmgcc42~obj/src/libgomp -Wall -pthread -Werror -O2 -g -O2 -MT  
critical.lo -MD -MP\
  -MF .deps/critical.Tpo -c /tmp/llvmgcc42.roots/llvmgcc42~obj/src/ 
libgomp/critical.c  -fno-common -DPIC -o .libs/critical.o
checking for mempcpy... Cannot yet select: 0x40c1a0c0: ch =  
 MemBarrier 0x40c18b70:1, 0x40c18840, 0x40c18840, 0x40c18840,  
0x40c18840, 0x40c1a2c0
/tmp/llvmgcc42.roots/llvmgcc42~obj/src/libgomp/critical.c:148:  
internal compiler error: Abort trap
Please submit a full bug report,
with preprocessed source if appropriate.
See URL:http://developer.apple.com/bugreporter for instructions.

I am going to temporarily disable this if that's the case. Please take  
a look.

Thanks,

Evan

On Feb 15, 2008, at 5:27 PM, Andrew Lenharth wrote:

 Author: alenhar2
 Date: Fri Feb 15 19:27:28 2008
 New Revision: 47205

 URL: http://llvm.org/viewvc/llvm-project?rev=47205view=rev
 Log:
 llvm.memory.barrier for __sync_syncronize

 Modified:
llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

 Modified: llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp
 URL: 
 http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp?rev=47205r1=47204r2=47205view=diff

 = 
 = 
 = 
 = 
 = 
 = 
 = 
 = 
 ==
 --- llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp (original)
 +++ llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp Fri Feb 15 19:27:28 2008
 @@ -4293,6 +4293,18 @@
 return true;
   }

 +  case BUILT_IN_SYNCHRONIZE: {
 +// We assume like gcc appears to, that this only applies to  
 cached memory.
 +Value* C[5];
 +C[0] = C[1] = C[2] = C[3] = ConstantInt::get(Type::Int1Ty, 1);
 +C[4] = ConstantInt::get(Type::Int1Ty, 0);
 +
 +Builder.CreateCall(Intrinsic::getDeclaration(TheModule,
 +  
 Intrinsic::memory_barrier),
 +   C, C + 5);
 +return true;
 +  }
 +
 #if 1  // FIXME: Should handle these GCC extensions eventually.
 case BUILT_IN_APPLY_ARGS:
 case BUILT_IN_APPLY:


 ___
 llvm-commits mailing list
 llvm-commits@cs.uiuc.edu
 http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Re: [llvm-commits] [llvm-gcc-4.2] r47205 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

2008-02-15 Thread Andrew Lenharth 
On 2/15/08, Evan Cheng [EMAIL PROTECTED] wrote:
 Hi Andrew,

  I think this might be breaking ppc build.

  /tmp/llvmgcc42.roots/llvmgcc42~obj/obj-i686-powerpc/./gcc/xgcc -B/
  tmp/llvmgcc42.roots/llvmgcc42~obj/obj-i686-powerpc/./gcc/ -B/
  Developer/usr/llvm-gcc-4.2/powerpc-apple-darwin9/bin/ -B/Developer/usr/
  llvm-gc\
  c-4.2/powerpc-apple-darwin9/lib/ -isystem /Developer/usr/llvm-gcc-4.2/
  powerpc-apple-darwin9/include -isystem /Developer/usr/llvm-gcc-4.2/
  powerpc-apple-darwin9/sys-include -DHAVE_CONFIG_H -I. -I/tmp/
  llvmgcc42.\
  roots/llvmgcc42~obj/src/libgomp -I. -I/tmp/llvmgcc42.roots/
  llvmgcc42~obj/src/libgomp/config/posix -I/tmp/llvmgcc42.roots/
  llvmgcc42~obj/src/libgomp -Wall -pthread -Werror -O2 -g -O2 -MT
  critical.lo -MD -MP\
   -MF .deps/critical.Tpo -c /tmp/llvmgcc42.roots/llvmgcc42~obj/src/
  libgomp/critical.c  -fno-common -DPIC -o .libs/critical.o
  checking for mempcpy... Cannot yet select: 0x40c1a0c0: ch =
   MemBarrier 0x40c18b70:1, 0x40c18840, 0x40c18840, 0x40c18840,
  0x40c18840, 0x40c1a2c0
  /tmp/llvmgcc42.roots/llvmgcc42~obj/src/libgomp/critical.c:148:
  internal compiler error: Abort trap
  Please submit a full bug report,
  with preprocessed source if appropriate.
  See URL:http://developer.apple.com/bugreporter for instructions.

  I am going to temporarily disable this if that's the case. Please take
  a look.

Yes please do.  Until ppc has support for memory.barrier, that file
won't compile.  The builtin was just being ignored before.  I'll see
about ppc support tomorrow.

Andrew
___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits