[lng-odp] [Bug 3249] odp_cpu_hz() does not work on all Linux distros

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3249

--- Comment #7 from Maxim Uvarov  ---
https://github.com/Linaro/odp/commit/a08dba6c24af81142efc6176eae2bdd561b478e3
refs/heads/api-next
2017-10-11T18:37:11+03:00
Ilias Apalodimas ilias.apalodi...@linaro.org
linux-gen: use /proc/cpuinfo if sysfs is not available to get cpu info

PR#171 broke some of the functionality we had on getting cpu speed.
This patch reverts parts of that commit adding a fallback when
/sys/devices/system/cpu/cpuX/cpufreq/ is not available.

Solves https://bugs.linaro.org/show_bug.cgi?id=3249

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Bill Fischofer 
Signed-off-by: Maxim Uvarov 

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[lng-odp] [Bug 3249] odp_cpu_hz() does not work on all Linux distros

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3249

Ilias Apalodimas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[lng-odp] [Bug 3249] odp_cpu_hz() does not work on all Linux distros

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3249

--- Comment #6 from Maxim Uvarov  ---
https://github.com/Linaro/odp/commit/a08dba6c24af81142efc6176eae2bdd561b478e3
refs/heads/master
2017-10-11T18:37:11+03:00
Ilias Apalodimas ilias.apalodi...@linaro.org
linux-gen: use /proc/cpuinfo if sysfs is not available to get cpu info

PR#171 broke some of the functionality we had on getting cpu speed.
This patch reverts parts of that commit adding a fallback when
/sys/devices/system/cpu/cpuX/cpufreq/ is not available.

Solves https://bugs.linaro.org/show_bug.cgi?id=3249

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Bill Fischofer 
Signed-off-by: Maxim Uvarov 

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[lng-odp] [Bug 3249] odp_cpu_hz() does not work on all Linux distros

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3249

--- Comment #5 from Mikko Kurikka  ---
Hello,

Tested patch provided by Ilias
(https://patch-diff.githubusercontent.com/raw/Linaro/odp/pull/214.patch). With
this patch odp_cpu_hz() works also in x86 machine without support for
/sys/devices/system/cpu/cpuX/cpufreq/ entry in sysfs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[lng-odp] [Bug 3249] odp_cpu_hz() does not work on all Linux distros

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3249

Bill Fischofer  changed:

   What|Removed |Added

   Assignee|maxim.uva...@linaro.org |ilias.apalodi...@linaro.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[lng-odp] [Bug 3249] odp_cpu_hz() does not work on all Linux distros

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3249

Bill Fischofer  changed:

   What|Removed |Added

 CC||bill.fischo...@linaro.org

--- Comment #4 from Bill Fischofer  ---
This is a MUSTFIX for Tiger Moth

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[lng-odp] [Bug 3249] odp_cpu_hz() does not work on all Linux distros

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3249

--- Comment #3 from Ilias Apalodimas  ---
Hello Mikko, 

The point of the change was to avoid exactly what you mentioned, modifying _hz
related functions per CPU. In the long run this is going to end up a huge pain
to maintain.

I haven't noticed any distributions not supporting cpufreq the past year or so.
Maybe we should add a fallback in case this isn't supported.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[lng-odp] [Bug 3249] odp_cpu_hz() does not work on all Linux distros

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3249

--- Comment #2 from Mikko Kurikka  ---
Hello,

Yes, you are right, I forgot to mention we have modified odp_cpu_hz_current()
and cpuinfo_parser() to return correct frequency. Of course this is not
portable solution and each ARM target requires own modification. After this new
change similar modification is not that easy to make. And we have seen problem
also with x86 Centos.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[lng-odp] [Bug 3249] odp_cpu_hz() does not work on all Linux distros

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3249

Ilias Apalodimas  changed:

   What|Removed |Added

 CC||ilias.apalodi...@linaro.org

--- Comment #1 from Ilias Apalodimas  ---
Hello Mikko, 

This was added on PR#171 on github. Up to that point ODP was reading current
CPU frequency from /proc/cpuinfo, but only for x86 platforms. You arm Arria10
would still report 0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.