Re: [lng-odp] [PATCH] helper: iplookuptable: fix prefix_entry_t member order

[Elo, Matias (Nokia - FI/Espoo)]

> On 31 Mar 2017, at 16:54, Maxim Uvarov  wrote:
> 
> On 03/31/17 10:43, Matias Elo wrote:
>> Fixes https://bugs.linaro.org/show_bug.cgi?id=2910
>> 
> 
> Matias please add some description here. Link to problem is good
> but people like to read only git logs.
> 
> Maxim.

Sure, fixed in v2.

-Matias

Re: [lng-odp] [PATCH] helper: iplookuptable: fix prefix_entry_t member order

[Maxim Uvarov]

On 03/31/17 10:43, Matias Elo wrote:
> Fixes https://bugs.linaro.org/show_bug.cgi?id=2910
> 

Matias please add some description here. Link to problem is good
but people like to read only git logs.

Maxim.

> Signed-off-by: Matias Elo 
> ---
>  helper/iplookuptable.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/helper/iplookuptable.c b/helper/iplookuptable.c
> index aae2199..37d31e3 100644
> --- a/helper/iplookuptable.c
> +++ b/helper/iplookuptable.c
> @@ -42,6 +42,10 @@
>   */
>  typedef struct {
>   union {
> + odp_buffer_t nexthop;
> + void *ptr;
> + };
> + union {
>   uint8_t u8;
>   struct {
>  #if ODP_BYTE_ORDER == ODP_BIG_ENDIAN
> @@ -53,10 +57,6 @@ typedef struct {
>  #endif
>   };
>   };
> - union {
> - odp_buffer_t nexthop;
> - void *ptr;
> - };
>  } prefix_entry_t;
>  
>  #define ENTRY_SIZE (sizeof(prefix_entry_t) + sizeof(odp_buffer_t))
> 

[lng-odp] [PATCH] helper: iplookuptable: fix prefix_entry_t member order

[Matias Elo]

Fixes https://bugs.linaro.org/show_bug.cgi?id=2910

Signed-off-by: Matias Elo 
---
 helper/iplookuptable.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/helper/iplookuptable.c b/helper/iplookuptable.c
index aae2199..37d31e3 100644
--- a/helper/iplookuptable.c
+++ b/helper/iplookuptable.c
@@ -42,6 +42,10 @@
  */
 typedef struct {
union {
+   odp_buffer_t nexthop;
+   void *ptr;
+   };
+   union {
uint8_t u8;
struct {
 #if ODP_BYTE_ORDER == ODP_BIG_ENDIAN
@@ -53,10 +57,6 @@ typedef struct {
 #endif
};
};
-   union {
-   odp_buffer_t nexthop;
-   void *ptr;
-   };
 } prefix_entry_t;
 
 #define ENTRY_SIZE (sizeof(prefix_entry_t) + sizeof(odp_buffer_t))
-- 
2.7.4