Re: [lng-odp] [PATCH] test: bench_packet: add tests for reference functions

[Bill Fischofer]

On Tue, Mar 14, 2017 at 1:52 AM, Elo, Matias (Nokia - FI/Espoo) <
matias@nokia-bell-labs.com> wrote:

>
> > On 13 Mar 2017, at 19:58, Bill Fischofer 
> wrote:
> >
> > This is a good start and I have no problem merging this as-is if we want
> to do this in stages, but I think a bit more is needed. For one, this is
> using a fixed offset for all references. I'd like to see references created
> with a couple of different offsets (e.g., 0 and packet_len/2) to get a
> better feel for any variability in performance due to different offsets,
> especially as we expect most references to be created with relatively small
> offsets covering packet headers rather than payload.
> >
> > Aside from that, for completeness we really should measure all of the
> other ODP packet APIs when the input argument is a reference. That would
> allow us to verify that there are no meaningful performance differences
> between using references vs. non-references in these other APIs.
> >
>
> I agree with this but it will take a while until I actually have time to
> implement this. So I would suggest merging this simple patch first before
> implementing a more comprehensive test suite for the packet references.
>
> Testing with zero offset would be a  trivial change and could be added
> already to this patch if required.
>

Sure. I've added my review to v2 and you can look to add the extra stuff as
time permits.


>
> -Matias
>

Re: [lng-odp] [PATCH] test: bench_packet: add tests for reference functions

[Elo, Matias (Nokia - FI/Espoo)]

> On 13 Mar 2017, at 19:58, Bill Fischofer  wrote:
> 
> This is a good start and I have no problem merging this as-is if we want to 
> do this in stages, but I think a bit more is needed. For one, this is using a 
> fixed offset for all references. I'd like to see references created with a 
> couple of different offsets (e.g., 0 and packet_len/2) to get a better feel 
> for any variability in performance due to different offsets, especially as we 
> expect most references to be created with relatively small offsets covering 
> packet headers rather than payload.
> 
> Aside from that, for completeness we really should measure all of the other 
> ODP packet APIs when the input argument is a reference. That would allow us 
> to verify that there are no meaningful performance differences between using 
> references vs. non-references in these other APIs. 
> 

I agree with this but it will take a while until I actually have time to 
implement this. So I would suggest merging this simple patch first before 
implementing a more comprehensive test suite for the packet references.

Testing with zero offset would be a  trivial change and could be added already 
to this patch if required.

-Matias
 

Re: [lng-odp] [PATCH] test: bench_packet: add tests for reference functions

[Bill Fischofer]

This is a good start and I have no problem merging this as-is if we want to
do this in stages, but I think a bit more is needed. For one, this is using
a fixed offset for all references. I'd like to see references created with
a couple of different offsets (e.g., 0 and packet_len/2) to get a better
feel for any variability in performance due to different offsets,
especially as we expect most references to be created with relatively small
offsets covering packet headers rather than payload.

Aside from that, for completeness we really should measure all of the other
ODP packet APIs when the input argument is a reference. That would allow us
to verify that there are no meaningful performance differences between
using references vs. non-references in these other APIs.

On Mon, Mar 13, 2017 at 9:56 AM, Matias Elo  wrote:

> Add microbenchmarks for the new packet reference functions.
>
> Signed-off-by: Matias Elo 
> ---
>  test/common_plat/performance/odp_bench_packet.c | 86
> +
>  1 file changed, 86 insertions(+)
>
> diff --git a/test/common_plat/performance/odp_bench_packet.c
> b/test/common_plat/performance/odp_bench_packet.c
> index 1aa9d81..d9aec76 100644
> --- a/test/common_plat/performance/odp_bench_packet.c
> +++ b/test/common_plat/performance/odp_bench_packet.c
> @@ -338,6 +338,21 @@ static void alloc_concat_packets(void)
>   TEST_REPEAT_COUNT);
>  }
>
> +static void alloc_ref_packets(void)
> +{
> +   int i;
> +   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
> +   odp_packet_t *ref_tbl = gbl_args->pkt2_tbl;
> +
> +   allocate_test_packets(gbl_args->pkt.len, pkt_tbl,
> TEST_REPEAT_COUNT);
> +
> +   for (i = 0; i < TEST_REPEAT_COUNT; i++) {
> +   ref_tbl[i] = odp_packet_ref(pkt_tbl[i], gbl_args->pkt.len
> / 2);
> +   if (ref_tbl[i] == ODP_PACKET_INVALID)
> +   LOG_ABORT("Allocating packet reference failed\n");
> +   }
> +}
> +
>  static void alloc_packets_twice(void)
>  {
> allocate_test_packets(gbl_args->pkt.len, gbl_args->pkt_tbl,
> @@ -1212,6 +1227,67 @@ static int bench_packet_ts_set(void)
> return i;
>  }
>
> +static int bench_packet_ref_static(void)
> +{
> +   int i;
> +   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
> +   odp_packet_t *ref_tbl = gbl_args->pkt2_tbl;
> +
> +   for (i = 0; i < TEST_REPEAT_COUNT; i++)
> +   ref_tbl[i] = odp_packet_ref_static(pkt_tbl[i]);
> +
> +   return i;
> +}
> +
> +static int bench_packet_ref(void)
> +{
> +   int i;
> +   uint32_t offset = gbl_args->pkt.len / 2;
> +   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
> +   odp_packet_t *ref_tbl = gbl_args->pkt2_tbl;
> +
> +   for (i = 0; i < TEST_REPEAT_COUNT; i++)
> +   ref_tbl[i] = odp_packet_ref(pkt_tbl[i], offset);
> +
> +   return i;
> +}
> +
> +static int bench_packet_ref_pkt(void)
> +{
> +   int i;
> +   uint32_t offset = gbl_args->pkt.len / 2;
> +   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
> +   odp_packet_t *hdr_tbl = gbl_args->pkt2_tbl;
> +
> +   for (i = 0; i < TEST_REPEAT_COUNT; i++)
> +   hdr_tbl[i] = odp_packet_ref_pkt(pkt_tbl[i], offset,
> hdr_tbl[i]);
> +
> +   return i;
> +}
> +
> +static int bench_packet_unshared_len(void)
> +{
> +   int i;
> +   uint32_t ret = 0;
> +
> +   for (i = 0; i < TEST_REPEAT_COUNT; i++)
> +   ret += odp_packet_unshared_len(gbl_args->pkt_tbl[i]);
> +
> +   return ret;
> +}
> +
> +static int bench_packet_has_ref(void)
> +{
> +   int i;
> +   uint32_t ret = 0;
> +   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
> +
> +   for (i = 0; i < TEST_REPEAT_COUNT; i++)
> +   ret += odp_packet_has_ref(pkt_tbl[i]);
> +
> +   return i;
> +}
> +
>  /**
>   * Prinf usage information
>   */
> @@ -1445,6 +1521,16 @@ bench_info_t test_suite[] = {
> BENCH_INFO(bench_packet_ts, create_packets, free_packets,
> NULL),
> BENCH_INFO(bench_packet_ts_set, create_packets,
> free_packets,
>NULL),
> +   BENCH_INFO(bench_packet_ref_static, create_packets,
> +  free_packets_twice, NULL),
> +   BENCH_INFO(bench_packet_ref, create_packets,
> +  free_packets_twice, NULL),
> +   BENCH_INFO(bench_packet_ref_pkt, alloc_packets_twice,
> +  free_packets_twice, NULL),
> +   BENCH_INFO(bench_packet_unshared_len, alloc_ref_packets,
> +  free_packets_twice, NULL),
> +   BENCH_INFO(bench_packet_has_ref, alloc_ref_packets,
> +  free_packets_twice, NULL),
>  };
>
>  /**
> --
> 2.7.4
>
>

[lng-odp] [PATCH] test: bench_packet: add tests for reference functions

[Matias Elo]

Add microbenchmarks for the new packet reference functions.

Signed-off-by: Matias Elo 
---
 test/common_plat/performance/odp_bench_packet.c | 86 +
 1 file changed, 86 insertions(+)

diff --git a/test/common_plat/performance/odp_bench_packet.c 
b/test/common_plat/performance/odp_bench_packet.c
index 1aa9d81..d9aec76 100644
--- a/test/common_plat/performance/odp_bench_packet.c
+++ b/test/common_plat/performance/odp_bench_packet.c
@@ -338,6 +338,21 @@ static void alloc_concat_packets(void)
  TEST_REPEAT_COUNT);
 }
 
+static void alloc_ref_packets(void)
+{
+   int i;
+   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
+   odp_packet_t *ref_tbl = gbl_args->pkt2_tbl;
+
+   allocate_test_packets(gbl_args->pkt.len, pkt_tbl, TEST_REPEAT_COUNT);
+
+   for (i = 0; i < TEST_REPEAT_COUNT; i++) {
+   ref_tbl[i] = odp_packet_ref(pkt_tbl[i], gbl_args->pkt.len / 2);
+   if (ref_tbl[i] == ODP_PACKET_INVALID)
+   LOG_ABORT("Allocating packet reference failed\n");
+   }
+}
+
 static void alloc_packets_twice(void)
 {
allocate_test_packets(gbl_args->pkt.len, gbl_args->pkt_tbl,
@@ -1212,6 +1227,67 @@ static int bench_packet_ts_set(void)
return i;
 }
 
+static int bench_packet_ref_static(void)
+{
+   int i;
+   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
+   odp_packet_t *ref_tbl = gbl_args->pkt2_tbl;
+
+   for (i = 0; i < TEST_REPEAT_COUNT; i++)
+   ref_tbl[i] = odp_packet_ref_static(pkt_tbl[i]);
+
+   return i;
+}
+
+static int bench_packet_ref(void)
+{
+   int i;
+   uint32_t offset = gbl_args->pkt.len / 2;
+   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
+   odp_packet_t *ref_tbl = gbl_args->pkt2_tbl;
+
+   for (i = 0; i < TEST_REPEAT_COUNT; i++)
+   ref_tbl[i] = odp_packet_ref(pkt_tbl[i], offset);
+
+   return i;
+}
+
+static int bench_packet_ref_pkt(void)
+{
+   int i;
+   uint32_t offset = gbl_args->pkt.len / 2;
+   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
+   odp_packet_t *hdr_tbl = gbl_args->pkt2_tbl;
+
+   for (i = 0; i < TEST_REPEAT_COUNT; i++)
+   hdr_tbl[i] = odp_packet_ref_pkt(pkt_tbl[i], offset, hdr_tbl[i]);
+
+   return i;
+}
+
+static int bench_packet_unshared_len(void)
+{
+   int i;
+   uint32_t ret = 0;
+
+   for (i = 0; i < TEST_REPEAT_COUNT; i++)
+   ret += odp_packet_unshared_len(gbl_args->pkt_tbl[i]);
+
+   return ret;
+}
+
+static int bench_packet_has_ref(void)
+{
+   int i;
+   uint32_t ret = 0;
+   odp_packet_t *pkt_tbl = gbl_args->pkt_tbl;
+
+   for (i = 0; i < TEST_REPEAT_COUNT; i++)
+   ret += odp_packet_has_ref(pkt_tbl[i]);
+
+   return i;
+}
+
 /**
  * Prinf usage information
  */
@@ -1445,6 +1521,16 @@ bench_info_t test_suite[] = {
BENCH_INFO(bench_packet_ts, create_packets, free_packets, NULL),
BENCH_INFO(bench_packet_ts_set, create_packets, free_packets,
   NULL),
+   BENCH_INFO(bench_packet_ref_static, create_packets,
+  free_packets_twice, NULL),
+   BENCH_INFO(bench_packet_ref, create_packets,
+  free_packets_twice, NULL),
+   BENCH_INFO(bench_packet_ref_pkt, alloc_packets_twice,
+  free_packets_twice, NULL),
+   BENCH_INFO(bench_packet_unshared_len, alloc_ref_packets,
+  free_packets_twice, NULL),
+   BENCH_INFO(bench_packet_has_ref, alloc_ref_packets,
+  free_packets_twice, NULL),
 };
 
 /**
-- 
2.7.4