Re: [lng-odp] [PATCH 1/2] linux-generic: netmap: use default interface config

[Maxim Uvarov]

Merged,
Maxim.

On 10/12/2015 16:50, Savolainen, Petri (Nokia - FI/Espoo) wrote:

Both patches:

Reviewed-by: Petri Savolainen <petri.savolai...@nokia.com>




-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
Matias Elo
Sent: Friday, October 09, 2015 4:04 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [PATCH 1/2] linux-generic: netmap: use default interface
config

Don't override interface default configuration options.

Signed-off-by: Matias Elo <matias@nokia.com>
---
  platform/linux-generic/pktio/netmap.c | 12 
  1 file changed, 12 deletions(-)

diff --git a/platform/linux-generic/pktio/netmap.c b/platform/linux-
generic/pktio/netmap.c
index 54e7043..19dc697 100644
--- a/platform/linux-generic/pktio/netmap.c
+++ b/platform/linux-generic/pktio/netmap.c
@@ -151,22 +151,10 @@ static int netmap_open(odp_pktio_t id ODP_UNUSED,
pktio_entry_t *pktio_entry,
if ((pkt_nm->if_flags & IFF_UP) == 0)
ODP_DBG("%s is down\n", pktio_entry->s.name);

-   err = netmap_do_ioctl(pktio_entry, SIOCETHTOOL, ETHTOOL_SGSO);
-   if (err)
-   ODP_DBG("ETHTOOL_SGSO not supported\n");
-
-   err = netmap_do_ioctl(pktio_entry, SIOCETHTOOL, ETHTOOL_STSO);
-   if (err)
-   ODP_DBG("ETHTOOL_STSO not supported\n");
-
err = mac_addr_get_fd(sockfd, netdev, pkt_nm->if_mac);
if (err)
goto error;

-   err = netmap_do_ioctl(pktio_entry, SIOCETHTOOL, ETHTOOL_STXCSUM);
-   if (err)
-   ODP_DBG("ETHTOOL_STXCSUM not supported\n");
-
return 0;

  error:
--
1.9.1

___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp


___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

[lng-odp] [PATCH 1/2] linux-generic: netmap: use default interface config

[Matias Elo]

Don't override interface default configuration options.

Signed-off-by: Matias Elo 
---
 platform/linux-generic/pktio/netmap.c | 12 
 1 file changed, 12 deletions(-)

diff --git a/platform/linux-generic/pktio/netmap.c 
b/platform/linux-generic/pktio/netmap.c
index 54e7043..19dc697 100644
--- a/platform/linux-generic/pktio/netmap.c
+++ b/platform/linux-generic/pktio/netmap.c
@@ -151,22 +151,10 @@ static int netmap_open(odp_pktio_t id ODP_UNUSED, 
pktio_entry_t *pktio_entry,
if ((pkt_nm->if_flags & IFF_UP) == 0)
ODP_DBG("%s is down\n", pktio_entry->s.name);
 
-   err = netmap_do_ioctl(pktio_entry, SIOCETHTOOL, ETHTOOL_SGSO);
-   if (err)
-   ODP_DBG("ETHTOOL_SGSO not supported\n");
-
-   err = netmap_do_ioctl(pktio_entry, SIOCETHTOOL, ETHTOOL_STSO);
-   if (err)
-   ODP_DBG("ETHTOOL_STSO not supported\n");
-
err = mac_addr_get_fd(sockfd, netdev, pkt_nm->if_mac);
if (err)
goto error;
 
-   err = netmap_do_ioctl(pktio_entry, SIOCETHTOOL, ETHTOOL_STXCSUM);
-   if (err)
-   ODP_DBG("ETHTOOL_STXCSUM not supported\n");
-
return 0;
 
 error:
-- 
1.9.1

___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp