Re: [lng-odp] [PATCH v4 0/2] GCC 7 fixes

[Dmitry Eremin-Solenikov]

On 15 June 2017 at 16:20, Maxim Uvarov  wrote:
> On 06/15/17 11:50, Dmitry Eremin-Solenikov wrote:
>> On 15.06.2017 11:47, shally verma wrote:
>>> Does it mean that going further there would be certain limitation on
>>> gcc version to be used? I just tried to compile next branch and
>>> ./configure throws an error
>>>
>>> ./configure: line 22786: syntax error near unexpected token
>>> `-Wimplicit-fallthrough=0,'
>>> ./configure: line 22786: `AX_CHECK_COMPILE_FLAG(-Wimplicit-fallthrough=0,'
>>
>> Install autoconf-archive package and rerun aclocal.
>>
>> Maybe we should reconsider and include ax_check_compile_flag.m4 file?
>>
>
> I think ./configure has to fail with valid error, not just terminate in
> some code.

Try adding m4_pattern_forbid([^_?AX_[A-Z_]+$]) near the top of configure.ac

I did not test it myself, but it might help.


-- 
With best wishes
Dmitry

Re: [lng-odp] [PATCH v4 0/2] GCC 7 fixes

[Maxim Uvarov]

On 06/15/17 11:50, Dmitry Eremin-Solenikov wrote:
> On 15.06.2017 11:47, shally verma wrote:
>> Does it mean that going further there would be certain limitation on
>> gcc version to be used? I just tried to compile next branch and
>> ./configure throws an error
>>
>> ./configure: line 22786: syntax error near unexpected token
>> `-Wimplicit-fallthrough=0,'
>> ./configure: line 22786: `AX_CHECK_COMPILE_FLAG(-Wimplicit-fallthrough=0,'
> 
> Install autoconf-archive package and rerun aclocal.
> 
> Maybe we should reconsider and include ax_check_compile_flag.m4 file?
> 

I think ./configure has to fail with valid error, not just terminate in
some code.

Maxim.

Re: [lng-odp] [PATCH v4 0/2] GCC 7 fixes

[Dmitry Eremin-Solenikov]

On 15.06.2017 11:47, shally verma wrote:
> Does it mean that going further there would be certain limitation on
> gcc version to be used? I just tried to compile next branch and
> ./configure throws an error
> 
> ./configure: line 22786: syntax error near unexpected token
> `-Wimplicit-fallthrough=0,'
> ./configure: line 22786: `AX_CHECK_COMPILE_FLAG(-Wimplicit-fallthrough=0,'

Install autoconf-archive package and rerun aclocal.

Maybe we should reconsider and include ax_check_compile_flag.m4 file?

-- 
With best wishes
Dmitry

Re: [lng-odp] [PATCH v4 0/2] GCC 7 fixes

[shally verma]

Does it mean that going further there would be certain limitation on
gcc version to be used? I just tried to compile next branch and
./configure throws an error

./configure: line 22786: syntax error near unexpected token
`-Wimplicit-fallthrough=0,'
./configure: line 22786: `AX_CHECK_COMPILE_FLAG(-Wimplicit-fallthrough=0,'

I'm using gcc 4.8.4

Shally

On Thu, Jun 8, 2017 at 9:41 AM, Bill Fischofer
 wrote:
> For the v4 series:
>
> Reviewed-and-tested-by: Bill Fischofer 
>
> On Wed, Jun 7, 2017 at 10:40 PM, Brian Brooks  wrote:
>> The GCC 7 series introduces changes that expose ODP compilation
>> issues. These include case statement fall through warnings, and
>> stricter checks on potential string overflows and other semantic
>> analysis.
>>
>> Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027
>>
>> Brian Brooks (2):
>>   build: GCC 7 fixes
>>   pktio: GCC 7 fixes
>>
>>  DEPENDENCIES  |  5 +--
>>  configure.ac  | 13 
>>  platform/linux-generic/m4/configure.m4| 44 
>> +++
>>  test/common_plat/validation/api/pktio/pktio.c |  4 ++-
>>  4 files changed, 63 insertions(+), 3 deletions(-)
>>
>> --
>>
>> v4:
>>  - Add -Werror to AX_CHECK_COMPILE_FLAG for Clang (Bill)
>>
>> v3:
>>  - Split into multiple patches files (Maxim)
>>  - Disable warnings in favor of patching right now (Dmitry)
>>  - Improve libatomic detection in autoconf (Dmitry)
>>  - Add autoconf-arch to DEPENDENCIES file
>>
>> v2:
>>  - Add Bug id to commit message (Bill)
>>
>> 2.13.0
>>

Re: [lng-odp] [PATCH v4 0/2] GCC 7 fixes

[Bill Fischofer]

For the v4 series:

Reviewed-and-tested-by: Bill Fischofer 

On Wed, Jun 7, 2017 at 10:40 PM, Brian Brooks  wrote:
> The GCC 7 series introduces changes that expose ODP compilation
> issues. These include case statement fall through warnings, and
> stricter checks on potential string overflows and other semantic
> analysis.
>
> Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027
>
> Brian Brooks (2):
>   build: GCC 7 fixes
>   pktio: GCC 7 fixes
>
>  DEPENDENCIES  |  5 +--
>  configure.ac  | 13 
>  platform/linux-generic/m4/configure.m4| 44 
> +++
>  test/common_plat/validation/api/pktio/pktio.c |  4 ++-
>  4 files changed, 63 insertions(+), 3 deletions(-)
>
> --
>
> v4:
>  - Add -Werror to AX_CHECK_COMPILE_FLAG for Clang (Bill)
>
> v3:
>  - Split into multiple patches files (Maxim)
>  - Disable warnings in favor of patching right now (Dmitry)
>  - Improve libatomic detection in autoconf (Dmitry)
>  - Add autoconf-arch to DEPENDENCIES file
>
> v2:
>  - Add Bug id to commit message (Bill)
>
> 2.13.0
>

[lng-odp] [PATCH v4 0/2] GCC 7 fixes

[Brian Brooks]

The GCC 7 series introduces changes that expose ODP compilation
issues. These include case statement fall through warnings, and
stricter checks on potential string overflows and other semantic
analysis.

Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027

Brian Brooks (2):
  build: GCC 7 fixes
  pktio: GCC 7 fixes

 DEPENDENCIES  |  5 +--
 configure.ac  | 13 
 platform/linux-generic/m4/configure.m4| 44 +++
 test/common_plat/validation/api/pktio/pktio.c |  4 ++-
 4 files changed, 63 insertions(+), 3 deletions(-)

--

v4:
 - Add -Werror to AX_CHECK_COMPILE_FLAG for Clang (Bill)

v3:
 - Split into multiple patches files (Maxim)
 - Disable warnings in favor of patching right now (Dmitry)
 - Improve libatomic detection in autoconf (Dmitry)
 - Add autoconf-arch to DEPENDENCIES file

v2:
 - Add Bug id to commit message (Bill)

2.13.0