Re: [lng-odp] ODP install error with dpdk 16.07

2017-02-01 Thread Bill Fischofer
On Wed, Feb 1, 2017 at 8:24 AM, Elo, Matias (Nokia - FI/Espoo)
 wrote:
>>
>> Thanks, Matias. For your benchmarking it would be good to get a
>> comparison run without those options to better quantify the overhead
>> of ABI compatibility mode. Right now we're taking a strict approach to
>> ABI so as to minimize the coordination requirements between
>> implementations supporting that ABI, however it's possible to tighten
>> things up by allowing certain inline function expansions if the
>> members of the ABI agree on some common aspects of their respective
>> internals. These sort of comparisons would be the sort of
>> justification needed for doing that extra spec work.
>
>
> Sure, I can run the comparison benchmarks. The performance difference 
> correlates with the number of inline functions. Petri is currently working on 
> a patch set, which inlines a large set of commonly used packet functions. 
> It’s probably best to wait until his patch set is ready (probably tomorrow?) 
> before running the tests.

That sounds reasonable. Thanks.

>
> -Matias
>


Re: [lng-odp] ODP install error with dpdk 16.07

2017-02-01 Thread Elo, Matias (Nokia - FI/Espoo)
> 
> Thanks, Matias. For your benchmarking it would be good to get a
> comparison run without those options to better quantify the overhead
> of ABI compatibility mode. Right now we're taking a strict approach to
> ABI so as to minimize the coordination requirements between
> implementations supporting that ABI, however it's possible to tighten
> things up by allowing certain inline function expansions if the
> members of the ABI agree on some common aspects of their respective
> internals. These sort of comparisons would be the sort of
> justification needed for doing that extra spec work.


Sure, I can run the comparison benchmarks. The performance difference 
correlates with the number of inline functions. Petri is currently working on a 
patch set, which inlines a large set of commonly used packet functions. It’s 
probably best to wait until his patch set is ready (probably tomorrow?) before 
running the tests.

-Matias



Re: [lng-odp] ODP install error with dpdk 16.07

2017-01-31 Thread Bill Fischofer
On Tue, Jan 31, 2017 at 9:30 AM, Elo, Matias (Nokia - FI/Espoo)
 wrote:
>
>> Thanks, with this configuration it is working.
>> My doubt here is:
>> Why we are not using shared lib, and abi-compat ??
>
> With --disable-shared and --disable-abi-compat you get the best performance 
> but they are not mandatory. I'm doing a lot of benchmarking, so I use them 
> always.

Thanks, Matias. For your benchmarking it would be good to get a
comparison run without those options to better quantify the overhead
of ABI compatibility mode. Right now we're taking a strict approach to
ABI so as to minimize the coordination requirements between
implementations supporting that ABI, however it's possible to tighten
things up by allowing certain inline function expansions if the
members of the ABI agree on some common aspects of their respective
internals. These sort of comparisons would be the sort of
justification needed for doing that extra spec work.

>
> -Matias


Re: [lng-odp] ODP install error with dpdk 16.07

2017-01-31 Thread Elo, Matias (Nokia - FI/Espoo)

> Thanks, with this configuration it is working.
> My doubt here is:
> Why we are not using shared lib, and abi-compat ??

With --disable-shared and --disable-abi-compat you get the best performance but 
they are not mandatory. I'm doing a lot of benchmarking, so I use them always.

-Matias 

Re: [lng-odp] ODP install error with dpdk 16.07

2017-01-31 Thread Gyanesh Patra
Thanks, with this configuration it is working.

My doubt here is:

Why we are not using shared lib, and abi-compat ??

P Gyanesh Patra

On Mon, 30 Jan 2017 at 05:37 Elo Matias (Nokia - FI/Espoo)

<
mailto:Elo Matias (Nokia - FI/Espoo) 
> wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }

> make: *** [all-recursive] Error 1

>

> I have tried with ODP master branch with DPDK 17 and DPDK 16.07 . I am facing 
> the same problem.

>

> This is the ODP repo, not the odp-dpdk repo.

>

> P Gyanesh Patra

Hi Gyanesh,

Odp-linux currently supports DPDK v16.07. With these steps everything is 
working for me:

# DPDK install

cd

git checkout v16.07

make config T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc

cd x86_64-native-linuxapp-gcc/

sed -ri 's,(CONFIG_RTE_LIBRTE_PMD_PCAP=).*,\1y,' .config

cd ..

make install T=x86_64-native-linuxapp-gcc DESTDIR=./install EXTRA_CFLAGS="-fPIC"

# odp-linux install

cd

./bootstrap

./configure --with-dpdk-path=

/x86_64-native-linuxapp-gcc --disable-shared -disable-abi-compat

make

Were you doing something differently?

Regards,

Matias


Re: [lng-odp] ODP install error with dpdk 16.07

2017-01-29 Thread Elo, Matias (Nokia - FI/Espoo)

> make: *** [all-recursive] Error 1
> 
> I have tried with ODP master branch with DPDK 17 and DPDK 16.07 . I am facing 
> the same problem.
> 
> This is the ODP repo, not the odp-dpdk repo.
> 
> P Gyanesh Patra


Hi Gyanesh,

Odp-linux currently supports DPDK v16.07. With these steps everything is 
working for me:

# DPDK install
cd 
git checkout v16.07
make config T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc
cd x86_64-native-linuxapp-gcc/
sed -ri 's,(CONFIG_RTE_LIBRTE_PMD_PCAP=).*,\1y,' .config
cd ..
make install T=x86_64-native-linuxapp-gcc DESTDIR=./install EXTRA_CFLAGS="-fPIC"

# odp-linux install
cd 
./bootstrap
./configure --with-dpdk-path=/x86_64-native-linuxapp-gcc 
--disable-shared -disable-abi-compat
make


Were you doing something differently?


Regards,
Matias











[lng-odp] ODP install error with dpdk 16.07

2017-01-28 Thread Gyanesh Patra
ODP install “make” command gives the below error : 

make[1]: Entering directory 'odp/test'

Making all in common_plat

make[2]: Entering directory 'odp/test/common_plat'

Making all in performance

make[3]: Entering directory 'odp/test/common_plat/performance'

  CC       odp_bench_packet-odp_bench_packet.o

  CCLD     odp_bench_packet

../../../lib/.libs/libodp-linux.a(io_ops.o):(.rodata+0x8): undefined reference 
to `dpdk_pktio_ops'

collect2: error: ld returned 1 exit status

Makefile:797: recipe for target 'odp_bench_packet' failed

make[3]: *** [odp_bench_packet] Error 1

make[3]: Leaving directory 'odp/test/common_plat/performance'

Makefile:438: recipe for target 'all-recursive' failed

make[2]: *** [all-recursive] Error 1

make[2]: Leaving directory 'odp/test/common_plat'

Makefile:437: recipe for target 'all-recursive' failed

make[1]: *** [all-recursive] Error 1

make[1]: Leaving directory 'odp/test'

Makefile:497: recipe for target 'all-recursive' failed

make: *** [all-recursive] Error 1

I have tried with ODP master branch with DPDK 17 and DPDK 16.07 . I am facing 
the same problem.

This is the ODP repo, not the odp-dpdk repo.

P Gyanesh Patra