Re: [lng-odp] [PATCH] linux-generic: only enable pktout when egress kind is pktio

[Bala Manoharan]

Reviewed-by: Balasubramanian Manoharan 

On 2 December 2016 at 13:12,   wrote:
> From: Xuelin Shi 
>
> Signed-off-by: Xuelin Shi 
> ---
>  platform/linux-generic/odp_traffic_mngr.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/platform/linux-generic/odp_traffic_mngr.c 
> b/platform/linux-generic/odp_traffic_mngr.c
> index ffb149b..a1f990f 100644
> --- a/platform/linux-generic/odp_traffic_mngr.c
> +++ b/platform/linux-generic/odp_traffic_mngr.c
> @@ -2838,10 +2838,9 @@ odp_tm_t odp_tm_create(const char*name,
> return ODP_TM_INVALID;
> }
>
> -   if (odp_pktout_queue(egress->pktio, , 1) != 1)
> -   return ODP_TM_INVALID;
> +   if (egress->egress_kind == ODP_TM_EGRESS_PKT_IO)
> +   tm_system->pktout = pktout;
>
> -   tm_system->pktout = pktout;
> tm_system->name_tbl_id = name_tbl_id;
> max_tm_queues = requirements->max_tm_queues;
> memcpy(_system->egress, egress, sizeof(odp_tm_egress_t));
> --
> 1.8.3.1
>

Re: [lng-odp] [PATCH] linux-generic: only enable pktout when egress kind is pktio

[Forrest Shi]

Hi Bala,

Would you please review this small fix?

thanks,
Forrest

On 9 December 2016 at 20:31, Maxim Uvarov  wrote:

> Bala,
>
> please review TM patch.
>
> Thank you,
> Maxim.
>
> On 12/08/16 04:58, Forrest Shi wrote:
> > ping.
> >
> > This is a simple fix.
> > The original code skips the support of egress_kind as ODP_TM_EGRESS_FN
> >
> > On 2 December 2016 at 15:42,  wrote:
> >
> >> From: Xuelin Shi 
> >>
> >> Signed-off-by: Xuelin Shi 
> >> ---
> >>  platform/linux-generic/odp_traffic_mngr.c | 5 ++---
> >>  1 file changed, 2 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/platform/linux-generic/odp_traffic_mngr.c
> >> b/platform/linux-generic/odp_traffic_mngr.c
> >> index ffb149b..a1f990f 100644
> >> --- a/platform/linux-generic/odp_traffic_mngr.c
> >> +++ b/platform/linux-generic/odp_traffic_mngr.c
> >> @@ -2838,10 +2838,9 @@ odp_tm_t odp_tm_create(const char
> *name,
> >> return ODP_TM_INVALID;
> >> }
> >>
> >> -   if (odp_pktout_queue(egress->pktio, , 1) != 1)
> >> -   return ODP_TM_INVALID;
> >> +   if (egress->egress_kind == ODP_TM_EGRESS_PKT_IO)
> >> +   tm_system->pktout = pktout;
> >>
> >> -   tm_system->pktout = pktout;
> >> tm_system->name_tbl_id = name_tbl_id;
> >> max_tm_queues = requirements->max_tm_queues;
> >> memcpy(_system->egress, egress, sizeof(odp_tm_egress_t));
> >> --
> >> 1.8.3.1
> >>
> >>
>
>

Re: [lng-odp] [PATCH] linux-generic: only enable pktout when egress kind is pktio

[Maxim Uvarov]

Bala,

please review TM patch.

Thank you,
Maxim.

On 12/08/16 04:58, Forrest Shi wrote:
> ping.
> 
> This is a simple fix.
> The original code skips the support of egress_kind as ODP_TM_EGRESS_FN
> 
> On 2 December 2016 at 15:42,  wrote:
> 
>> From: Xuelin Shi 
>>
>> Signed-off-by: Xuelin Shi 
>> ---
>>  platform/linux-generic/odp_traffic_mngr.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/platform/linux-generic/odp_traffic_mngr.c
>> b/platform/linux-generic/odp_traffic_mngr.c
>> index ffb149b..a1f990f 100644
>> --- a/platform/linux-generic/odp_traffic_mngr.c
>> +++ b/platform/linux-generic/odp_traffic_mngr.c
>> @@ -2838,10 +2838,9 @@ odp_tm_t odp_tm_create(const char*name,
>> return ODP_TM_INVALID;
>> }
>>
>> -   if (odp_pktout_queue(egress->pktio, , 1) != 1)
>> -   return ODP_TM_INVALID;
>> +   if (egress->egress_kind == ODP_TM_EGRESS_PKT_IO)
>> +   tm_system->pktout = pktout;
>>
>> -   tm_system->pktout = pktout;
>> tm_system->name_tbl_id = name_tbl_id;
>> max_tm_queues = requirements->max_tm_queues;
>> memcpy(_system->egress, egress, sizeof(odp_tm_egress_t));
>> --
>> 1.8.3.1
>>
>>

Re: [lng-odp] [PATCH] linux-generic: only enable pktout when egress kind is pktio

[Forrest Shi]

ping.

This is a simple fix.
The original code skips the support of egress_kind as ODP_TM_EGRESS_FN

On 2 December 2016 at 15:42,  wrote:

> From: Xuelin Shi 
>
> Signed-off-by: Xuelin Shi 
> ---
>  platform/linux-generic/odp_traffic_mngr.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/platform/linux-generic/odp_traffic_mngr.c
> b/platform/linux-generic/odp_traffic_mngr.c
> index ffb149b..a1f990f 100644
> --- a/platform/linux-generic/odp_traffic_mngr.c
> +++ b/platform/linux-generic/odp_traffic_mngr.c
> @@ -2838,10 +2838,9 @@ odp_tm_t odp_tm_create(const char*name,
> return ODP_TM_INVALID;
> }
>
> -   if (odp_pktout_queue(egress->pktio, , 1) != 1)
> -   return ODP_TM_INVALID;
> +   if (egress->egress_kind == ODP_TM_EGRESS_PKT_IO)
> +   tm_system->pktout = pktout;
>
> -   tm_system->pktout = pktout;
> tm_system->name_tbl_id = name_tbl_id;
> max_tm_queues = requirements->max_tm_queues;
> memcpy(_system->egress, egress, sizeof(odp_tm_egress_t));
> --
> 1.8.3.1
>
>