Re: [lng-odp] [PATCHv7 0/3] changelog: summary of changes for odp v1.12.0.0

[Maxim Uvarov]

On 11/28/16 18:45, Bogdan Pricope wrote:

./configure --help | grep ABI
  --disable-abi-compat disables ABI compatible mode, enables 
inline code in header files


while in CHANGELOG:

+`--enable-abi-compat=yes`::
and
+`--enable-abi-compat=no`::

but no:
--disable-abi-compat


good find. v8 with change log correction.



I guess is common practice and --disable-abi-compat is equivalent with 
 --enable-abi-compat=no so I don't see it as a problem. Else is fine 
with me.

No "Review-by" as I am really not good at auto-tools...



No need to guess. You need to run ./configure --help and just follow 
instructions.


There are AC_ARG_ENABLE (our case) and  AC_ARG_ENABLE_WITH. I.e. that 
options should be set or not set without arguments.


Maxim.


On 28 November 2016 at 15:28, Maxim Uvarov > wrote:


Anders, Bogdan,

do you have any other comments or you can set your review-by?

Maxim.


On 11/24/16 23:24, Maxim Uvarov wrote:

v7: more accurate define disable option (Anders)

Bill Fischofer (1):
   changelog: summary of changes for odp v1.12.0.0

Maxim Uvarov (2):
configure.ac : disable shared library for
non abi compat mode
configure.ac  update version numbers

  CHANGELOG| 177
+++
configure.ac  |  15 +++--
  2 files changed, 184 insertions(+), 8 deletions(-)

Re: [lng-odp] [PATCHv7 0/3] changelog: summary of changes for odp v1.12.0.0

[Bogdan Pricope]

./configure --help | grep ABI
  --disable-abi-compat disables ABI compatible mode, enables inline
code in header files

while in CHANGELOG:

+`--enable-abi-compat=yes`::
and
+`--enable-abi-compat=no`::

but no:
--disable-abi-compat

I guess is common practice and --disable-abi-compat is equivalent with
 --enable-abi-compat=no so I don't see it as a problem. Else is fine with
me.
No "Review-by" as I am really not good at auto-tools...

On 28 November 2016 at 15:28, Maxim Uvarov  wrote:

> Anders, Bogdan,
>
> do you have any other comments or you can set your review-by?
>
> Maxim.
>
>
> On 11/24/16 23:24, Maxim Uvarov wrote:
>
>> v7: more accurate define disable option (Anders)
>>
>> Bill Fischofer (1):
>>changelog: summary of changes for odp v1.12.0.0
>>
>> Maxim Uvarov (2):
>>configure.ac: disable shared library for non abi compat mode
>>configure.ac update version numbers
>>
>>   CHANGELOG| 177 ++
>> +
>>   configure.ac |  15 +++--
>>   2 files changed, 184 insertions(+), 8 deletions(-)
>>
>>
>

Re: [lng-odp] [PATCHv7 0/3] changelog: summary of changes for odp v1.12.0.0

[Maxim Uvarov]

Anders, Bogdan,

do you have any other comments or you can set your review-by?

Maxim.

On 11/24/16 23:24, Maxim Uvarov wrote:

v7: more accurate define disable option (Anders)

Bill Fischofer (1):
   changelog: summary of changes for odp v1.12.0.0

Maxim Uvarov (2):
   configure.ac: disable shared library for non abi compat mode
   configure.ac update version numbers

  CHANGELOG| 177 +++
  configure.ac |  15 +++--
  2 files changed, 184 insertions(+), 8 deletions(-)