[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557387#comment-15557387 ] Gary Gregory commented on LOG4J2-1522: -- Not ATM. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * {{PatternLayout}} and {{EnhancedPatternLayout}} are mapped to > {{PatternLayout}}. We provide two new pattern conversions for the Log4j 1 > format of NDC and MDC. > * {{SimpleLayout}} is mapped to {{PatternLayout}} "%level - %m%n" > * {{TTCCLayout}} is mapped to {{PatternLayout}} > * {{HTMLLayout}} is mapped to {{HtmlLayout}} (will not look exactly the same, > but close enough) > * {{XMLLayout}} is ported ({{XmlLayout}} in Log4j 2 is different and will not > work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557334#comment-15557334 ] Ralph Goers commented on LOG4J2-1522: - Log4j1ConfigurationFactory only supports log4j.properties. But there are quite a few people who preferred to use the Log4j 1 xml format. Do you plan on supporting that too? > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * {{PatternLayout}} and {{EnhancedPatternLayout}} are mapped to > {{PatternLayout}}. We provide two new pattern conversions for the Log4j 1 > format of NDC and MDC. > * {{SimpleLayout}} is mapped to {{PatternLayout}} "%level - %m%n" > * {{TTCCLayout}} is mapped to {{PatternLayout}} > * {{HTMLLayout}} is mapped to {{HtmlLayout}} (will not look exactly the same, > but close enough) > * {{XMLLayout}} is ported ({{XmlLayout}} in Log4j 2 is different and will not > work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429646#comment-15429646 ] Mikael Ståldal commented on LOG4J2-1522: I added translation of the pattern to handle this seamless. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is mapped to PatternLayout > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429497#comment-15429497 ] Ralph Goers commented on LOG4J2-1522: - I have mixed feelings about this. Conceptually they do belong with Log4j-1.2-api. But that increases the requirement that log4j-1.2-api is dependent on log4j-core. There have been requests to make log4j-1.2-api only be dependent on log4j-api, but I have never figured out how to actually do that. Since I don't really see that happening soon I guess I am OK with they staying in the log4j-1.2-api module. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is mapped to PatternLayout > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429496#comment-15429496 ] Gary Gregory commented on LOG4J2-1522: -- In the 1.2 module IMO. Gary > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is mapped to PatternLayout > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429472#comment-15429472 ] Mikael Ståldal commented on LOG4J2-1522: Also updated the constant in PatternLayout. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is mapped to PatternLayout > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426374#comment-15426374 ] Mikael Ståldal commented on LOG4J2-1522: Yes, that works. Removed TTCCLayout and using PatternLayout instead now. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is ported (cannot be emulated exactly with PatternLayout) > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425109#comment-15425109 ] Gary Gregory commented on LOG4J2-1522: -- Maybe {{variablesNotEmpty{pattern}}} can be used here? Or a variation? > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is ported (cannot be emulated exactly with PatternLayout) > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425054#comment-15425054 ] Ralph Goers commented on LOG4J2-1522: - TTCC_CONVERSION_PATTERN is a static constant in the PatternLayout. It appears I didn't add a way to specify it or the SIMPLE_CONVERSION_PATTERN. I believe all that is required is for those to be able to be specified as the pattern to use. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is ported (cannot be emulated exactly with PatternLayout) > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425021#comment-15425021 ] Mikael Ståldal commented on LOG4J2-1522: Yes, maybe. What's missing is the possibility to add a space before/after a value if it exists. Like: {{foo bar baz}} when "bar" have a value but {{foo baz}} when "bar" is empty. (Used for the context stack.) Could be a useful generic feature to add to PatternLayout, and if we do then we would not need TTCCLayout. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is ported (cannot be emulated exactly with PatternLayout) > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424922#comment-15424922 ] Gary Gregory commented on LOG4J2-1522: -- Can't the {{PatternLayout}} be reasonably enhanced to support {{TTCCLayout}}? > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is ported (cannot be emulated exactly with PatternLayout) > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424673#comment-15424673 ] Mikael Ståldal commented on LOG4J2-1522: Only reaming issue is that the format is slightly different for %x (NDC) and %X (MDC), see comment in {{Log4j1ConfigurationFactory.java}}. I added support for the Log4j formats if you use %ndc or %properties instead. Don't want to change the behaviour of existing conversions in Log4j's 2 PatternLayout. I think this should be good enough if we document it. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is ported (cannot be emulated exactly with PatternLayout) > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424669#comment-15424669 ] Mikael Ståldal commented on LOG4J2-1522: We do not use the Log4j 1 layouts directly, we map them to a compatible layout in Log4j 2 if possible, or else port them to the Log4j 2 Layout interface. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is ported (cannot be emulated exactly with PatternLayout) > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424667#comment-15424667 ] Mikael Ståldal commented on LOG4J2-1522: The fact that Log4j 1 didn't support plugins makes this easier since we then have a fixed and limited set of layouts (six of them, see list in description) to handle. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. > * PatternLayout and EnhancedPatternLayout are mapped to PatternLayout. We > provide two new pattern conversions for the Log4j 1 format of NDC and MDC. > * SimpleLayout is mapped to PatternLayout "%level - %m%n" > * TTCCLayout is ported (cannot be emulated exactly with PatternLayout) > * HTMLLayout is mapped to HtmlLayout (will not look exactly the same, but > close enough) > * XMLLayout is ported (XmlLayout in Log4j 2 is different and will not work) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424610#comment-15424610 ] Mikael Ståldal commented on LOG4J2-1522: It is already done, see my recent commits to master branch. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424576#comment-15424576 ] Ralph Goers commented on LOG4J2-1522: - a) Why do we want to do this? b) How can this be done? Log4j 1 didn't support plugins and the interface was very different. I understand the motivation, but it would seem to me to be more reasonable to provide a tool to convert Log4j 1 configurations to the Log4j 2 configuration format, as much as possible. I'd like to see more of a description of what is intended and how it can be accomplished. > Log4j 1 layouts > --- > > Key: LOG4J2-1522 > URL: https://issues.apache.org/jira/browse/LOG4J2-1522 > Project: Log4j 2 > Issue Type: Sub-task > Components: Layouts >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > Fix For: 2.7 > > > Support all layouts in Log4j 1 to the extent possible an reasonable. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org