Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

[Matt Sicker]

If you move it to Loader, you can just use StatusLogger. LowLevelLogUtil is
there for the classes that have to load before StatusLogger can properly
load.

On 6 September 2016 at 21:08, Gary Gregory  wrote:

> Hm, that methods depends on the package private class LowLevelLogUtil. So
> moving the method to Core would mean making LowLevelLogUtil public. I'm not
> sure that's a good tradeoff...
>
> Gary
>
> On Tue, Sep 6, 2016 at 7:44 PM, Remko Popma  wrote:
>
> > Ah! I didn't look at the code. If there's no risk of breaking user code I
> > have no objection.
> >
> > Apologies.
> >
> > Sent from my iPhone
> >
> > > On 2016/09/07, at 8:11, Gary Gregory  wrote:
> > >
> > > How could moving an API marked @since 2.7 break user code?
> > >
> > > Gary
> > >
> > >> On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma 
> > wrote:
> > >>
> > >> Is there a problem that needs solving here?
> > >> I know we consider the API module's util package private, but I really
> > >> don't like making changes that could break user code for no good
> > reason...
> > >>
> > >> Sent from my iPhone
> > >>
> > >>> On 2016/09/07, at 6:36, Matt Sicker  wrote:
> > >>>
> > >>> Might as well. If we need it in api, we can move it back later.
> > >>>
> >  On 6 September 2016 at 15:54, Gary Gregory 
> > >> wrote:
> > 
> >  The API module method
> >  org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String)
> is
> >  @since
> >  2.7 and is only called from the Core module. I propose we move it to
> > >> Core.
> > 
> >  Gary
> > 
> >  --
> >  E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> >  Java Persistence with Hibernate, Second Edition
> >  
> >  JUnit in Action, Second Edition 
> >  Spring Batch in Action 
> >  Blog: http://garygregory.wordpress.com
> >  Home: http://garygregory.com/
> >  Tweet! http://twitter.com/GaryGregory
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Matt Sicker 
> > >>
> > >> -
> > >> To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org
> > >> For additional commands, e-mail: log4j-user-h...@logging.apache.org
> > >
> > >
> > > --
> > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> > > Java Persistence with Hibernate, Second Edition
> > > 
> > > JUnit in Action, Second Edition 
> > > Spring Batch in Action 
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> >
> > -
> > To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org
> > For additional commands, e-mail: log4j-user-h...@logging.apache.org
> >
> >
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker 

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

[Gary Gregory]

Hm, that methods depends on the package private class LowLevelLogUtil. So
moving the method to Core would mean making LowLevelLogUtil public. I'm not
sure that's a good tradeoff...

Gary

On Tue, Sep 6, 2016 at 7:44 PM, Remko Popma  wrote:

> Ah! I didn't look at the code. If there's no risk of breaking user code I
> have no objection.
>
> Apologies.
>
> Sent from my iPhone
>
> > On 2016/09/07, at 8:11, Gary Gregory  wrote:
> >
> > How could moving an API marked @since 2.7 break user code?
> >
> > Gary
> >
> >> On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma 
> wrote:
> >>
> >> Is there a problem that needs solving here?
> >> I know we consider the API module's util package private, but I really
> >> don't like making changes that could break user code for no good
> reason...
> >>
> >> Sent from my iPhone
> >>
> >>> On 2016/09/07, at 6:36, Matt Sicker  wrote:
> >>>
> >>> Might as well. If we need it in api, we can move it back later.
> >>>
>  On 6 September 2016 at 15:54, Gary Gregory 
> >> wrote:
> 
>  The API module method
>  org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
>  @since
>  2.7 and is only called from the Core module. I propose we move it to
> >> Core.
> 
>  Gary
> 
>  --
>  E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>  Java Persistence with Hibernate, Second Edition
>  
>  JUnit in Action, Second Edition 
>  Spring Batch in Action 
>  Blog: http://garygregory.wordpress.com
>  Home: http://garygregory.com/
>  Tweet! http://twitter.com/GaryGregory
> >>>
> >>>
> >>>
> >>> --
> >>> Matt Sicker 
> >>
> >> -
> >> To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org
> >> For additional commands, e-mail: log4j-user-h...@logging.apache.org
> >
> >
> > --
> > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> > Java Persistence with Hibernate, Second Edition
> > 
> > JUnit in Action, Second Edition 
> > Spring Batch in Action 
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> -
> To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org
> For additional commands, e-mail: log4j-user-h...@logging.apache.org
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

[Remko Popma]

Ah! I didn't look at the code. If there's no risk of breaking user code I have 
no objection. 

Apologies. 

Sent from my iPhone

> On 2016/09/07, at 8:11, Gary Gregory  wrote:
> 
> How could moving an API marked @since 2.7 break user code?
> 
> Gary
> 
>> On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma  wrote:
>> 
>> Is there a problem that needs solving here?
>> I know we consider the API module's util package private, but I really
>> don't like making changes that could break user code for no good reason...
>> 
>> Sent from my iPhone
>> 
>>> On 2016/09/07, at 6:36, Matt Sicker  wrote:
>>> 
>>> Might as well. If we need it in api, we can move it back later.
>>> 
 On 6 September 2016 at 15:54, Gary Gregory 
>> wrote:
 
 The API module method
 org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
 @since
 2.7 and is only called from the Core module. I propose we move it to
>> Core.
 
 Gary
 
 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 Java Persistence with Hibernate, Second Edition
 
 JUnit in Action, Second Edition 
 Spring Batch in Action 
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory
>>> 
>>> 
>>> 
>>> --
>>> Matt Sicker 
>> 
>> -
>> To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org
>> For additional commands, e-mail: log4j-user-h...@logging.apache.org
> 
> 
> -- 
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

-
To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-user-h...@logging.apache.org

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

[Gary Gregory]

How could moving an API marked @since 2.7 break user code?

Gary

On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma  wrote:

> Is there a problem that needs solving here?
> I know we consider the API module's util package private, but I really
> don't like making changes that could break user code for no good reason...
>
> Sent from my iPhone
>
> > On 2016/09/07, at 6:36, Matt Sicker  wrote:
> >
> > Might as well. If we need it in api, we can move it back later.
> >
> >> On 6 September 2016 at 15:54, Gary Gregory 
> wrote:
> >>
> >> The API module method
> >> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
> >> @since
> >> 2.7 and is only called from the Core module. I propose we move it to
> Core.
> >>
> >> Gary
> >>
> >> --
> >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> >> Java Persistence with Hibernate, Second Edition
> >> 
> >> JUnit in Action, Second Edition 
> >> Spring Batch in Action 
> >> Blog: http://garygregory.wordpress.com
> >> Home: http://garygregory.com/
> >> Tweet! http://twitter.com/GaryGregory
> >
> >
> >
> > --
> > Matt Sicker 
>
> -
> To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org
> For additional commands, e-mail: log4j-user-h...@logging.apache.org
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

[Remko Popma]

Is there a problem that needs solving here?
I know we consider the API module's util package private, but I really don't 
like making changes that could break user code for no good reason...

Sent from my iPhone

> On 2016/09/07, at 6:36, Matt Sicker  wrote:
> 
> Might as well. If we need it in api, we can move it back later.
> 
>> On 6 September 2016 at 15:54, Gary Gregory  wrote:
>> 
>> The API module method
>> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
>> @since
>> 2.7 and is only called from the Core module. I propose we move it to Core.
>> 
>> Gary
>> 
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> 
>> JUnit in Action, Second Edition 
>> Spring Batch in Action 
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
> 
> 
> 
> -- 
> Matt Sicker 

-
To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-user-h...@logging.apache.org

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

[Matt Sicker]

Might as well. If we need it in api, we can move it back later.

On 6 September 2016 at 15:54, Gary Gregory  wrote:

> The API module method
> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
> @since
> 2.7 and is only called from the Core module. I propose we move it to Core.
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker