[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support
Github user niemyjski commented on the issue: https://github.com/apache/log4net/pull/16 The lower the .net standard you can target the more places it will run. 1.0 can run every where (1.0, 1.6, etc). You should be targeting 1.3 here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support
Github user niemyjski commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70623307
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter :
LiteralPatternConverter, IOption
///
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+ if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
+ {
+ Option = "\r\n";
+ }
+ else if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
--- End diff --
ToLowerInvariant()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #16: [WIP] (LOG4NET-467) .NET Core support
Github user niemyjski commented on the issue: https://github.com/apache/log4net/pull/16 +1 I'm also needing this for our oss projects that depend on log4net. Would be great to get this on the lowest .net standard possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
