Re: String Equality Comparison, Broken Tests and .NET-1.x
Hi Jonas On 2016-08-23, wrote: > Stefan Bodewig wrote on 23.08.2016 06:14:32: >> On 2016-08-22, wrote: >>> Should we create some helper in SystemInfo that provides null-aware, >>> ordinal, casing-agnostic string equality comparison, with some #if's >>> .NET-1.x? >> +1 > Here you go. The attached patch introduces a ` > SystemInfo.EqualsIgnoringCase(string, string)`, some unit tests, and fixes > `NewLinePatternConverter.ActivateOptions` so that the test suite passes > again. Thanks a lot. I finally managed to apply it. I had to modify it slightly (a missing using statement and semicolon in the netstandard branch). Tests should all pass now. Stefan
[GitHub] log4net issue #34: NewLinePatternConverter: fix Option==null crash
Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/34 Thanks @rj2Skipper we've had about three alternative patches for this and I applied one with svn revision https://svn.apache.org/repos/asf/logging/log4net/trunk@1759541 which became commit 32b7a3e here. Could you please close this PR as I'm not able to do so on the github mirror myself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #33: tests fixed + nunit test runner for VS added
Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/33 The test has been fixed with a different patch (svn revision https://svn.apache.org/repos/asf/logging/log4net/trunk@1759541 which became commit 32b7a3e here). We can certainly add the NUnitTestAdapter dependency but I'd prefer to keep the license header :-) Also, given this is supposed to be the VS 2012 solution we might better stick with net4 as target. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
