[lttng-dev] [PATCH lttng-tools v2] Fix: free previous instance of url (alloc_url) on default live url assignation

[Jonathan Rajotte]

Signed-off-by: Jonathan Rajotte 
---
 src/bin/lttng/commands/create.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/bin/lttng/commands/create.c b/src/bin/lttng/commands/create.c
index 0f7d1a4..40d2a77 100644
--- a/src/bin/lttng/commands/create.c
+++ b/src/bin/lttng/commands/create.c
@@ -342,6 +342,10 @@ static int create_session(void)
 
/* Use default live URL if NO url is/are found. */
if ((opt_live_timer && !opt_url) && (opt_live_timer && !opt_data_url)) {
+   /* Override the url */
+   free(url);
+   url = NULL;
+
ret = asprintf(&alloc_url, "net://127.0.0.1");
if (ret < 0) {
PERROR("asprintf default live URL");
-- 
2.7.4

___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [lttng-dev] [PATCH lttng-tools] Fix: free previous instance of url (alloc_url) on default live url assignation

[Jonathan Rajotte Julien]

On 2016-12-12 04:24 PM, Philippe Proulx wrote:

On Mon, Dec 12, 2016 at 4:16 PM, Jonathan Rajotte
 wrote:

Signed-off-by: Jonathan Rajotte 
---
  src/bin/lttng/commands/create.c | 6 ++
  1 file changed, 6 insertions(+)

diff --git a/src/bin/lttng/commands/create.c b/src/bin/lttng/commands/create.c
index 0f7d1a4..e6f15c7 100644
--- a/src/bin/lttng/commands/create.c
+++ b/src/bin/lttng/commands/create.c
@@ -342,6 +342,12 @@ static int create_session(void)

 /* Use default live URL if NO url is/are found. */
 if ((opt_live_timer && !opt_url) && (opt_live_timer && !opt_data_url)) 
{
+   /* Override the url */
+   if (url) {
+   free(url);
+   url = NULL;
+   }

Just:


Sire, you are quite right.



+   free(url);
+   url = NULL;

if the project's coding style allows.

Phil


+
 ret = asprintf(&alloc_url, "net://127.0.0.1");
 if (ret < 0) {
 PERROR("asprintf default live URL");
--
2.7.4

___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


--
Jonathan R. Julien
Efficios

___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [lttng-dev] [PATCH lttng-tools] Fix: free previous instance of url (alloc_url) on default live url assignation

[Philippe Proulx]

On Mon, Dec 12, 2016 at 4:16 PM, Jonathan Rajotte
 wrote:
>
> Signed-off-by: Jonathan Rajotte 
> ---
>  src/bin/lttng/commands/create.c | 6 ++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/bin/lttng/commands/create.c b/src/bin/lttng/commands/create.c
> index 0f7d1a4..e6f15c7 100644
> --- a/src/bin/lttng/commands/create.c
> +++ b/src/bin/lttng/commands/create.c
> @@ -342,6 +342,12 @@ static int create_session(void)
>
> /* Use default live URL if NO url is/are found. */
> if ((opt_live_timer && !opt_url) && (opt_live_timer && 
> !opt_data_url)) {
> +   /* Override the url */
> +   if (url) {
> +   free(url);
> +   url = NULL;
> +   }

Just:

+   free(url);
+   url = NULL;

if the project's coding style allows.

Phil

> +
> ret = asprintf(&alloc_url, "net://127.0.0.1");
> if (ret < 0) {
> PERROR("asprintf default live URL");
> --
> 2.7.4
>
> ___
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[lttng-dev] [PATCH lttng-tools] Fix: free previous instance of url (alloc_url) on default live url assignation

[Jonathan Rajotte]

Signed-off-by: Jonathan Rajotte 
---
 src/bin/lttng/commands/create.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/src/bin/lttng/commands/create.c b/src/bin/lttng/commands/create.c
index 0f7d1a4..e6f15c7 100644
--- a/src/bin/lttng/commands/create.c
+++ b/src/bin/lttng/commands/create.c
@@ -342,6 +342,12 @@ static int create_session(void)
 
/* Use default live URL if NO url is/are found. */
if ((opt_live_timer && !opt_url) && (opt_live_timer && !opt_data_url)) {
+   /* Override the url */
+   if (url) {
+   free(url);
+   url = NULL;
+   }
+
ret = asprintf(&alloc_url, "net://127.0.0.1");
if (ret < 0) {
PERROR("asprintf default live URL");
-- 
2.7.4

___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev