[lxc-devel] [lxc/lxc] ea00a2: Update plamo template
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: ea00a202cde59a23daba00b64ec92fb9a748327a https://github.com/lxc/lxc/commit/ea00a202cde59a23daba00b64ec92fb9a748327a Author: TAMUKI Shoichi tam...@linet.gr.jp Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M templates/lxc-plamo.in Log Message: --- Update plamo template - If installpkg command does not exist, lxc-plamo temporarily install the command with static linked tar command into the lxc cache directory. The tar command does not refer to passwd/group files, which means that only a few files/directories are extracted with wrong user/group ownership. To avoid this, the installpkg command now uses the standard tar command in the system. - Change mode to 666 for $rootfs/dev/null to allow write access for all users. - Small fix in usage message. Signed-off-by: TAMUKI Shoichi tam...@linet.gr.jp Acked-by: Stéphane Graber stgra...@ubuntu.com Acked-by: KATOH Yasufumi ka...@jazz.email.ne.jp ___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel
Re: [lxc-devel] Building upstream lxc.spec on openSUSE OBS
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Mike,
I can't answer all your question in detail right now, I'll get back to
that. And I can try and split the patch in cosmetic and functional part.
On 17.08.2014 20:30 Michael H. Warfield wrote:
You have two external sources called out here:
+%if 0%{?suse_version} = 1210 +Source1:README.SUSE
+Source2:lxc-createconfig.in +%endif
I stole those from the pre-existing package for opensuse. I can
clarify with the original packagers, how to proceed.
Why this change in the License? I'm not saying either is right or
wrong or that they're not functionally equivalent, but there must
have been some reason for changing it and I would like to know what
it was...
Basically, licenses on openSUSE and/or the OBS should follow the
nomenclature at https://spdx.org/licenses. At least AFAIK.
+# openSUSE/SUSE +%if %{defined suse_version}
+%{_mandir}/man[^3]/* +# not openSUSE/SUSE +%else +%if %{undefined
rhel} +%{_mandir}/man[^3]/* +%{_mandir}/ja/* +%endif
Looks like the man dir is the same for Suse and not Suse other than
the Japanese pages (which I believe is what we need docbook2X for)
or when rhel is defined. I recall seeing a remark from you over
the use of that regex on rhel, as well. So you're NOT installing
any man pages on RHEL/CentOS? Why make this change (other than
excluding the ja pages under Suse)? Do you have some specific need
for that regex at all? What is the problem with the way it was
coded? Were we missing something in another section?
Using [^3] is another cosmetic thing, that cleans up nicely. But, as
that does not work on CentOS/RHEL 7 (at least in my tests), I had to
workaround like this. But this is not the bee's knees, if you ask me.
Needs more looking into.
Seems like there were a number of changes in here that were not
necessary to make it build under Suse (or it's unclear why they
were necessary). Can we split the functionally substantive changes
from the purely cosmetic changes and style changes?
I'll try to.
Right now, let's focus on getting the patch into an acceptable form
with minimal cosmetic changes and undo the use of that regex for
the man pages.
If you wish, I'll cut out the regex.
Give me a couple days, and I see what I can do.
Regards,
Johannes
- --
There are only two kinds of music: Rock and Roll.
(Keith Richards)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with SeaMonkey - http://www.enigmail.net/
iEYEARECAAYFAlPznR0ACgkQzi3gQ/xETbL8JwCgnOUVNkCVl+XZI4p5jMXsP7RY
T1kAn1z4XY10poCE4LJ0ywMGyJ2BnLeE
=XHqK
-END PGP SIGNATURE-
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel
Re: [lxc-devel] Building upstream lxc.spec on openSUSE OBS
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18.08.2014 18:29 Michael H. Warfield wrote: That's going to be my gold standard for merging your changes in. There have been some changes in the area of the %post sections of that spec file and your patch won't apply cleanly. I can cherry pick the Suse specific changes out of it but there still remains the issue of missing source files. See my other mail for the source issues. Of course the docbook2x-thing is an issue with the OBS, I never proposed building without just to workaround that. That was just to see if the spec builds at all. Regards, Johannes - -- Don't buy into bullshit. Don't admire false icons. We are just humans, not heroes. Think for yourself and stand up for what you believe is right. Don't be afraid to break stereotypes. Be true to yourself. Thank you. (The Used: In Love and Death) -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with SeaMonkey - http://www.enigmail.net/ iEYEARECAAYFAlPzndwACgkQzi3gQ/xETbK3/wCePqgrE/Thy7BJByDI2f/NRdz+ Cg8An10u05SdyKdq8mvrYht4B62JF1eX =/At0 -END PGP SIGNATURE- ___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel
Re: [lxc-devel] Building upstream lxc.spec on openSUSE OBS
On Tue, 2014-08-19 at 20:56 +0200, Johannes Kastl wrote: On 18.08.2014 18:29 Michael H. Warfield wrote: That's going to be my gold standard for merging your changes in. There have been some changes in the area of the %post sections of that spec file and your patch won't apply cleanly. I can cherry pick the Suse specific changes out of it but there still remains the issue of missing source files. See my other mail for the source issues. Of course the docbook2x-thing is an issue with the OBS, I never proposed building without just to workaround that. That was just to see if the spec builds at all. Yeah, while waiting for the dust to settle on some private conversations over the next round of patches and some reorganization, I've been working on this under SuSE 13.1. I've pretty much worked through the required changes but ran into some peculiar gotcha's. Still sorting out why but configure / configure.ac is not picking up on the SuSe distro properly for me (which affects where the new default config files live) and the apparmour things briefly threw me for a loop. I've got those sorted now and it is building on SuSe 13.1 native (in a container) for me. I may be able to get some or all of this rolled into the next patch set if it's not too involved (so far it's not). Regards, Johannes Regards, Mike -- Michael H. Warfield (AI4NB) | (770) 978-7061 | m...@wittsend.com /\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/ NIC whois: MHW9 | An optimist believes we live in the best of all PGP Key: 0x674627FF| possible worlds. A pessimist is sure of it! signature.asc Description: This is a digitally signed message part ___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel
Re: [lxc-devel] Building upstream lxc.spec on openSUSE OBS
On Tue, 2014-08-19 at 15:58 -0400, Michael H. Warfield wrote: On Tue, 2014-08-19 at 20:56 +0200, Johannes Kastl wrote: On 18.08.2014 18:29 Michael H. Warfield wrote: That's going to be my gold standard for merging your changes in. There have been some changes in the area of the %post sections of that spec file and your patch won't apply cleanly. I can cherry pick the Suse specific changes out of it but there still remains the issue of missing source files. See my other mail for the source issues. Of course the docbook2x-thing is an issue with the OBS, I never proposed building without just to workaround that. That was just to see if the spec builds at all. Yeah, while waiting for the dust to settle on some private conversations over the next round of patches and some reorganization, I've been working on this under SuSE 13.1. I've pretty much worked through the required changes but ran into some peculiar gotcha's. Still sorting out why but configure / configure.ac is not picking up on the SuSe distro properly for me (which affects where the new default config files live) and the apparmour things briefly threw me for a loop. I've got those sorted now and it is building on SuSe 13.1 native (in a container) for me. I may be able to get some or all of this rolled into the next patch set if it's not too involved (so far it's not). Got the distro recognition sorted. Seems that lsb_release was returning OpenSuSe Project and configure wasn't recognizing it resulting in an unknown. I'm surprised you didn't run into that. Required a couple of fixes to configured.ac for opensuse* but maybe you didn't have the impacted files in play for your build. Mostly affected where the default sysconfig config files resided which is not in 1.0.5 at all. I'm real close at this point. It's building on 13.1. Regards, Johannes Regards, Mike -- Michael H. Warfield (AI4NB) | (770) 978-7061 | m...@wittsend.com /\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/ NIC whois: MHW9 | An optimist believes we live in the best of all PGP Key: 0x674627FF| possible worlds. A pessimist is sure of it! signature.asc Description: This is a digitally signed message part ___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel
