Re: [lxc-devel] [PATCH] Discontinue the use of in-line comments (stable)

2014-09-20 Thread Guido Jäkel
Dear Stéphane,

referring to the discussion about the pivot config entry I would consider to 
make the parser print out a warning message (but no recect) if there is a 
no-supported inline-comment, i.e. a non-first-column hashmark. This might be a 
false positive of course, but in the moment i expect there might be a lot of 
wrong examples spread over the the internet which will brainless copy this 
style from our own (former) samples because it lucky works.

This kind of warnings might be dropped then in some far future.

greetings

Guido

On 20.09.2014 01:48, Serge Hallyn wrote:
 Quoting Stéphane Graber (stgra...@ubuntu.com):
 Those aren't supported, it's just a lucky coincidence that they weren't
 causing problems.

 Signed-off-by: Stéphane Graber stgra...@ubuntu.com
 
 Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com
 


___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


Re: [lxc-devel] [lxc-users] Compile fails under Fedora

2014-09-20 Thread Michael H. Warfield
On Sat, 2014-09-20 at 03:23 -0400, CDR wrote:
 I did a git pull and ´when I issued a make rpm, it failed
 
 error: Installed (but unpackaged) file(s) found:
/usr/lib/systemd/system/lxc-net.service
 RPM build errors:
 File listed twice:
 /usr/lib64/python3.3/site-packages/_lxc-0.1-py3.3.egg-info
 File listed twice: /usr/lib64/python3.3/site-packages/_lxc.cpython-33m.so
 File listed twice: /usr/lib64/python3.3/site-packages/lxc/__init__.py
 File listed twice: /usr/lib64/python3.3/site-packages/lxc/__pycache__
 File listed twice:
 /usr/lib64/python3.3/site-packages/lxc/__pycache__/__init__.cpython-33.pyc
 File listed twice:
 /usr/lib64/python3.3/site-packages/lxc/__pycache__/__init__.cpython-33.pyo
 File listed twice: /usr/libexec/lxc/lxc-autostart-helper
 File listed twice: /usr/libexec/lxc/lxc-devsetup
 File listed twice: /usr/libexec/lxc/lxc-user-nic
 Installed (but unpackaged) file(s) found:
/usr/lib/systemd/system/lxc-net.service
 make: *** [rpm] Error 1
 
 Any idea how can I compile the software?

You raised this issue on 08/09 for 1.1.0alpha1 under Fedora 20.  At that
time yours was the second report and I was already looking into it.  You
then raised the issue again on the -devel list on 09/05 for 1.1.0alpha1
under CentOS 7 - exact same issue.  At that time the patches had already
been submitted on 08/25 to Stéphane and were then under review.  I
responded to you to that effect on 09/09 along with the reason for the
original failure and a pointer to my patches that had been posted to the
list.

The patches are still being reviewed as he's been exceptionally busy
lately and the patches are fairly involved and involved some
disagreements in approach which were discussed in private E-Mail between
the involved parties.

The patches have not been committed to git master to date and he's
working on integrating the changes.  As a consequence, the answer I gave
to you on 09/09 on the -devel list remains the same and is equally
applicable to 1.1.0alpha1 and to git master...

i.e. ... You can either apply the patches I posted to the -devel list
several weeks ago or you can wait for Stéphane to commit the fully
integrated patches to git master.  At this time, applying my changes
will result in some patch warnings due to others submitting some warning
changes in parallel patches.

I would recommend monitoring the -devel list for further (cough)
developments (yes, pun intended).

Regards,
Mike

On Tue, 2014-09-09 at 12:06 -0400, Michael H. Warfield wrote:
 This was due to a refactoring of the upstart init network code nearly
 a
 month ago by someone, AFAIK, not currently on the list which created
 some files in an incorrect location and the creation of dependencies
 on
 it in the systemd code.  Patches for this fax paux have been submitted
 by me and Stéphane is currently evaluating my patch set to correct the
 problems that were created by the earlier submission by another that
 inadvertently broke all the rpm based systems.  This was reported
 several weeks ago and I submitted my fix, after some private
 discussion,
 on 08/25.
 
 Please review the following thread, starting on 08/25/2014, on this
 list
 for the patches and some discussion...


 Thanks,
 Philip
 ___
 lxc-users mailing list
 lxc-us...@lists.linuxcontainers.org
 http://lists.linuxcontainers.org/listinfo/lxc-users
 

-- 
Michael H. Warfield (AI4NB) | (770) 978-7061 |  m...@wittsend.com
   /\/\|=mhw=|\/\/  | (678) 463-0932 |  http://www.wittsend.com/mhw/
   NIC whois: MHW9  | An optimist believes we live in the best of all
 PGP Key: 0x674627FF| possible worlds.  A pessimist is sure of it!



signature.asc
Description: This is a digitally signed message part
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel