Re: [lxc-devel] [PATCH] Only bring up network interface if IFF_UP is set

2011-01-17 Thread Daniel Lezcano
On 01/17/2011 03:51 AM, David Ward wrote:
 Each network interface was brought up regardless of the configuration,
 as the wrong boolean operator was being used to test the IFF_UP flag.

 Signed-off-by: David Warddavid.w...@ll.mit.edu
 ---

Applied.

Thanks for the fix !

   -- Daniel

--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel


[lxc-devel] [PATCH] Only bring up network interface if IFF_UP is set

2011-01-16 Thread David Ward
Each network interface was brought up regardless of the configuration,
as the wrong boolean operator was being used to test the IFF_UP flag.

Signed-off-by: David Ward david.w...@ll.mit.edu
---
 src/lxc/conf.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lxc/conf.c b/src/lxc/conf.c
index 2f66e76..a0c5fee 100644
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -1217,7 +1217,7 @@ static int setup_netdev(struct lxc_netdev *netdev)
 
/* empty network namespace */
if (!netdev-ifindex) {
-   if (netdev-flags | IFF_UP) {
+   if (netdev-flags  IFF_UP) {
err = lxc_device_up(lo);
if (err) {
ERROR(failed to set the loopback up : %s,
@@ -1281,7 +1281,7 @@ static int setup_netdev(struct lxc_netdev *netdev)
}
 
/* set the network device up */
-   if (netdev-flags | IFF_UP) {
+   if (netdev-flags  IFF_UP) {
int err;
 
err = lxc_device_up(current_ifname);
-- 
1.7.1


--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel