Re: [Lynx-dev] buiid warning
On Mon, May 07, 2018 at 07:53:45AM -0600, russellb...@gmail.com wrote: > Thanks for fixing the saved-file-name discrepancy. > > I don't know whether this is new; I may have just noticed it: > > bison -y ./parsdate.y > ./parsdate.y: warning: 8 shift/reduce conflicts [-Wconflicts-sr] that's expected. bison and byacc have an extension to quiet the warning (rather pointless for bison, if you happen to turn on compiler warnings...), but that's nonstandard - doesn't appear here: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/yacc.html -- Thomas E. Dickeyhttps://invisible-island.net ftp://ftp.invisible-island.net signature.asc Description: Digital signature ___ Lynx-dev mailing list Lynx-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/lynx-dev
Re: [Lynx-dev] [PATCH] src/chrtrans: don't build host tools with target LDFLAGS
On Mon, May 07, 2018 at 10:02:51PM +0200, Thomas Petazzoni wrote: > In a cross-compilation context, the LDFLAGS variable contains linker > flags used when building things for the target. However, the makeuctb > tool is built for the host machine, and therefore should not use the > same LDFLAGS as the target, which is why BUILD_LDFLAGS exist. thanks - I didn't notice at the time - it was a packager's request, which should have been redone within the package scripts. -- Thomas E. Dickeyhttps://invisible-island.net ftp://ftp.invisible-island.net signature.asc Description: Digital signature ___ Lynx-dev mailing list Lynx-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/lynx-dev
[Lynx-dev] [PATCH] src/chrtrans: don't build host tools with target LDFLAGS
In a cross-compilation context, the LDFLAGS variable contains linker flags used when building things for the target. However, the makeuctb tool is built for the host machine, and therefore should not use the same LDFLAGS as the target, which is why BUILD_LDFLAGS exist. Using LDFLAGS when building a tool for the host can cause problems when some flags in LDFLAGS are not supported by the host machine. For example, if you're linking statically lynx for the target, but the build machine does not support static linking: gcc -I../.. -I../../src -I../../src/chrtrans -I../../WWW/Library/Implementation -I../../ -static -o makeuctb makeuctb.o /usr/bin/ld: cannot find -lc collect2: error: ld returned 1 exit status Signed-off-by: Thomas Petazzoni--- src/chrtrans/makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chrtrans/makefile.in b/src/chrtrans/makefile.in index aab358f..6e0ef03 100644 --- a/src/chrtrans/makefile.in +++ b/src/chrtrans/makefile.in @@ -123,7 +123,7 @@ OBJS= makeuctb$o C_SRC = $(OBJS:$o=.c) $(MAKEUCTB) : $(OBJS) - $(BUILD_CC) $(CC_OPTS) $(LDFLAGS) $(BUILD_LDFLAGS) -o $@ $(OBJS) $(INTLLIB) $(BUILD_LIBS) + $(BUILD_CC) $(CC_OPTS) $(BUILD_LDFLAGS) -o $@ $(OBJS) $(INTLLIB) $(BUILD_LIBS) makeuctb$o : $(srcdir)/UCkd.h $(srcdir)/makeuctb.c -- 2.14.3 ___ Lynx-dev mailing list Lynx-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/lynx-dev
Re: [Lynx-dev] buiid warning
> I change LYUtils.c to log lynx to its own level: [...] > If this interested others you could make it a parameter, say in > userdefs.h. I do not understand why lynx would syslog anything (probably a failure of my imagination), but I definitely think the facility of any logging it does should be configurable at least a build time, preferably at startup time. > Perhaps everybody else uses rsyslog these days. Certainly not _quite_ everybody; I, for example, don't, for multiple reasons not really relevant here. /~\ The ASCII Mouse \ / Ribbon Campaign X Against HTMLmo...@rodents-montreal.org / \ Email! 7D C8 61 52 5D E7 2D 39 4E F1 31 3E E8 B3 27 4B ___ Lynx-dev mailing list Lynx-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/lynx-dev
[Lynx-dev] buiid warning
Thanks for fixing the saved-file-name discrepancy. I don't know whether this is new; I may have just noticed it: bison -y ./parsdate.y ./parsdate.y: warning: 8 shift/reduce conflicts [-Wconflicts-sr] I change LYUtils.c to log lynx to its own level: LYUtils.c: openlog("lynx", LOG_PID | LOG_NDELAY, LOG_LOCAL5); LYUtils.c: openlog("lynx", LOG_PID, LOG_LOCAL5); LYUtils.c: syslog(LOG_INFO | LOG_LOCAL5, "%s", buf); LYUtils.c: syslog(LOG_INFO | LOG_LOCAL5, "%s", NONNULL(arg)); so I can separate its entries. If this interested others you could make it a parameter, say in userdefs.h. Perhaps everybody else uses rsyslog these days. russell bell ___ Lynx-dev mailing list Lynx-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/lynx-dev