Re: r37704 - lyx-devel/trunk/src/insets

[Edwin Leuven]

On Thu, Feb 17, 2011 at 01:26, Enrico Forestieri for...@lyx.org wrote:
 On Thu, Feb 17, 2011 at 01:09:04AM +0100, Pavel Sanda wrote:
 Vincent van Ravesteijn wrote:
  Which has no effect at all.
 
  It does.

 can both of you please come back to this point and in more than one sentence
 put down your arguments/analysis?

 I am sorry, this is a behavioural problem. I would not have any problem
 discussing and even acknowledging that I could be wrong, but
 there are ways to do things and the presuntuous way I cannot stand.

hehe, why do things always become fun after i go to bed?

as vincent wrote, with your patch you  can execute inset-modify tabular
set-tabular-width 7cm for a longtable, and it happily changes the
table, while this lfun should have been disabled.

i also see this, and it is because the function is enabled whenever
tabular.tabular_width.zero() and therefore also for longtables etc

as discussed in another thread, the problem was that only the 1st
argument got checked, and that was just an arbitrary one (the one
which just happened to be added first in the frontend code). which is
prone to errors as we saw. so it seems to me that vincent's fix is the
correct one.

cheers, ed.

Re: hebrew support in lyx 2.0?

[Pavel Sanda]

Richman Reuven wrote:
 i hope it's not too late into the release process to be reporting
 this... :S

please create bugzilla reports, either with recipy to reproduce
or with attached problematic .lyx files.
pavel

Re: r37704 - lyx-devel/trunk/src/insets

[Enrico Forestieri]

On Thu, Feb 17, 2011 at 09:33:44AM +0100, Edwin Leuven wrote:
 as discussed in another thread, the problem was that only the 1st
 argument got checked, and that was just an arbitrary one (the one
 which just happened to be added first in the frontend code). which is
 prone to errors as we saw. so it seems to me that vincent's fix is the
 correct one.

Well, even if vincent's fix is correct, he himself is not correct.

Q: Why are you reverting it?
A: Because I'm right and you're wrong.

End of discussion, begin to give vent to one's anger.
Only later I noticed the other thread.

-- 
Enrico

Q to Edwin (was Re: r37709 - lyx-devel/trunk/src/insets)

[Jürgen Spitzmüller]

spitz wrote:
 Modified: lyx-devel/trunk/src/insets/InsetTabular.cpp
 ===
 === --- lyx-devel/trunk/src/insets/InsetTabular.cpp Thu Feb 17 11:02:29
 2011(r37708) +++ lyx-devel/trunk/src/insets/InsetTabular.cpp Thu
 Feb 17 11:42:13 2011(r37709) @@ -1342,8 +1342,9 @@
  Tabular::idx_type Tabular::getLastCellInRow(row_type row) const
  {
 col_type c = ncols() - 1;
 -   while (cell_info[row][c].multirow == CELL_PART_OF_MULTIROW
 -   || cell_info[row][c].multicolumn ==
 CELL_PART_OF_MULTICOLUMN) +   while (c  0
 +   (cell_info[row][c].multirow == CELL_PART_OF_MULTIROW
 +  || cell_info[row][c].multicolumn ==
 CELL_PART_OF_MULTICOLUMN)) --c;
 return cell_info[row][c].cellno;
  }

Edwin, why does getLastCellInRow actually at all decrease c if it's part of a 
multirow? This does not strike me correct.

Jürgen

LyX2b4 using lots of memory on mac

[Kühnlenz Florian]

Hello, 

I hope that is the right place here. I‘ve tried the beta for my bachelor thesis 
(yes I know it‘s a beta) because of the nice spell checker. All in all it works 
great but there seams to be a huge memory leak when showing any graphics in the 
document. Know that I‘ve started to put the pictures in my document scrolling 
from top to bottom will blow up the usage of RAM to 1GB+ which is a bit to much 
even on a 4GB System if you ask me because sooner or later the system starts to 
swap and becomes unusable.

best Regards, 

Florian Kühnlenz

Re: LyX2b4 using lots of memory on mac

[Anders Ekberg]

On 2011-02-17 21.35, Kühnlenz Florian florian.kuehnl...@tu-ilmenau.de
wrote:

Hello, 

I hope that is the right place here. IŒve tried the beta for my bachelor
thesis (yes I know itŒs a beta) because of the nice spell checker. All in
all it works great but there seams to be a huge memory leak when showing
any graphics in the document. Know that IŒve started to put the pictures
in my document scrolling from top to bottom will blow up the usage of RAM
to 1GB+ which is a bit to much even on a 4GB System if you ask me because
sooner or later the system starts to swap and becomes unusable.

best Regards, 

Florian Kühnlenz

Can't confirm this. I get 100 MB with a 80 page document including many
pictures with LyX 2.0 beta 4.

/Anders

Re: LyX2b4 using lots of memory on mac

[Rob Oakes]

I can't confirm the error either. I've checked the text of my book (which has 
several thousand images in a variety of formats), and I'm only getting RAM 
usage of about 300 MB.  (This was done on both Mac and Linux).

Would it be possible to get a little bit more information about the problem? 
What platform are you using (Mac, Windows, Linus)? Is it with a particular type 
of image (jpeg, png, pdf)?

That might help other to duplicate and track down the issue.

Cheers,

Rob

Re: LyX2b4 using lots of memory on mac

[Kühnlenz Florian]

I‘m using a Mac BookPro with 10.6.6.
 
I maybe have to admit that I was a bit to fast with my conclusion but after it 
happened twice I thought it was reproducible. Which seams no longer the case 
because know it seams like it won‘t happen again even on my machine. Sorry for 
that!  Never the less if it will happen again I try to find out more.

I‘m using mostly png images.

Am 17.02.2011 um 21:55 schrieb Rob Oakes:

 I can't confirm the error either. I've checked the text of my book (which has 
 several thousand images in a variety of formats), and I'm only getting RAM 
 usage of about 300 MB.  (This was done on both Mac and Linux).
 
 Would it be possible to get a little bit more information about the problem? 
 What platform are you using (Mac, Windows, Linus)? Is it with a particular 
 type of image (jpeg, png, pdf)?
 
 That might help other to duplicate and track down the issue.
 
 Cheers,
 
 Rob

Re: LyX2b4 using lots of memory on mac

[Pavel Sanda]

Kühnlenz Florian wrote:
 I hope that is the right place here. I?ve tried the beta for my bachelor 
 thesis (yes I know it?s a beta) because of the nice spell checker. All in all 
 it works great but there seams to be a huge memory leak when showing any 
 graphics in the document. Know that I?ve started to put the pictures in my 
 document scrolling from top to bottom will blow up the usage of RAM to 1GB+ 
 which is a bit to much even on a 4GB System if you ask me because sooner or 
 later the system starts to swap and becomes unusable.

i doubt this has anything to do with lyx 2.0, since the huge memory consuption 
for large graphic files is there for ages.
if my guess is right, then its not leak in the sense of forgotten memory 
somewhere.
we just read _full_ bitmap of all pictures and even if you resize them to small 
thumbail, we still keep the whole image in memory.
so of you have few big bitmaps (note that i dont speak about their size on hard 
drive, but size when unpacked in memory) then getting 1 GB of RAM usage is 
going to happen easily.

easy workaround is to use child documents. 

pavel

Re: LyX2b4 using lots of memory on mac

[Pavel Sanda]

Kühnlenz Florian wrote:
 know it seams like it won?t happen again even on my machine. 

just try to go through the whole document, and let all png to be actually 
showed.
memory is allocated only then.

pavel

Re: r37704 - lyx-devel/trunk/src/insets

[Abdelrazak Younes]

On Thu, Feb 17, 2011 at 11:22 AM, Enrico Forestieri for...@lyx.org wrote:

 On Thu, Feb 17, 2011 at 09:33:44AM +0100, Edwin Leuven wrote:
  as discussed in another thread, the problem was that only the 1st
  argument got checked, and that was just an arbitrary one (the one
  which just happened to be added first in the frontend code). which is
  prone to errors as we saw. so it seems to me that vincent's fix is the
  correct one.

 Well, even if vincent's fix is correct, he himself is not correct.

 Q: Why are you reverting it?
 A: Because I'm right and you're wrong.

 End of discussion, begin to give vent to one's anger.
 Only later I noticed the other thread.


I am sure Vincent did not meant to hurt you with his revert. He explained in
the commit log why he was reverting this. He probably should have warned you
that he was going to, but this is not like there is a lot of disrespect. I
am actually pretty sure you he respects you.

Anyway, that was just my monthly two cents :-P

Abdel.

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

[Pavel Sanda]

v...@lyx.org wrote:
 Author: vfr
 Date: Thu Feb 17 00:09:29 2011
 New Revision: 37706
 URL: http://www.lyx.org/trac/changeset/37706
 
 Log:
 Fix bug #7308: Table settings dialog broken.
 
   // FIXME: We should use Tabular directly.
 - string param_str = tabular;
 + string param_str = tabular from-dialog;

Edwin, Vincent, please can you keep LyXAction.cpp doxies up to date if some 
lfun params
changed? (from-dialog, tabular width, decimal point feature, etc).

pavel

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

[Vincent van Ravesteijn]

 Op 17-2-2011 22:52, Pavel Sanda schreef:

v...@lyx.org wrote:

Author: vfr
Date: Thu Feb 17 00:09:29 2011
New Revision: 37706
URL: http://www.lyx.org/trac/changeset/37706

Log:
Fix bug #7308: Table settings dialog broken.

// FIXME: We should use Tabular directly.
-   string param_str = tabular;
+   string param_str = tabular from-dialog;

Edwin, Vincent, please can you keep LyXAction.cpp doxies up to date if some 
lfun params
changed? (from-dialog, tabular width, decimal point feature, etc).

pavel


Do you really want to document internal parameters that are basically a 
work-around for some messed up code ?


Vincent

disolving child docs

[Edwin Leuven]

i have a document with several child documents using 'input'

is there an easy way to promote the content of a child document to
the master document?

i.e. to get rid of the input and just have the text in the master doc?

there is unfortunately no remove and insert here in the context menu
or am i missing something?

thanks, ed.

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

[Pavel Sanda]

Vincent van Ravesteijn wrote:
  Op 17-2-2011 22:52, Pavel Sanda schreef:
 v...@lyx.org wrote:
 Author: vfr
 Date: Thu Feb 17 00:09:29 2011
 New Revision: 37706
 URL: http://www.lyx.org/trac/changeset/37706

 Log:
 Fix bug #7308: Table settings dialog broken.

 // FIXME: We should use Tabular directly.
 -   string param_str = tabular;
 +   string param_str = tabular from-dialog;
 Edwin, Vincent, please can you keep LyXAction.cpp doxies up to date if 
 some lfun params
 changed? (from-dialog, tabular width, decimal point feature, etc).

 pavel

 Do you really want to document internal parameters that are basically a 
 work-around for some messed up code ?

if they can be reasonably used by user or some 3rd party script which
communicates with lyx server then yes. dunno if its the case of from-dialog but
for sure we have documentation for tabular width/decimal point companions.

pavel

Icons

[Joost Verburg]

Hi all,

The current LyX toolbar icons are blurred because the default icon size is 
set to 20x20 pixels, although most of our icons actually are 22x22 (this is 
a standard size). Also some icons looks quite outdated and have jagged 
edges.


Is it OK if I increase the default size with 2 pixels and try to find some 
better public domain or GPL icons to replace some of the current ones? I'd 
be nice to have at least a little bit of UI refresh for 2.0 :)


Best,
Joost 

Re: Icons

[Vincent van Ravesteijn]

Is it OK if I increase the default size with 2 pixels and try to find 
some better public domain or GPL icons to replace some of the current 
ones? I'd be nice to have at least a little bit of UI refresh for 2.0 :)

+1

Vincent

Find replace in 2.0

[Joost Verburg]

Hi,

I was just checking out some new 2.0 features and noticed we got three find 
 replace dialogs now:

* Find  replace - Quick
* Find  replace - Advanced - Basic
* Find  replace - Advanced - Advanced
This really seems like too much. Could we get rid of the old Quick dialog 
and rename Advanced Find and Replace to Find and Replace?


Regards,
Joost 

Re: Icons

[Rob Oakes]

 Is it OK if I increase the default size with 2 pixels and try to find some 
 better public domain or GPL icons to replace some of the current ones? I'd be 
 nice to have at least a little bit of UI refresh for 2.0 :)


I think that would be fantastic.

+1

As a way of starting, you might take a look at some of the icons in the Oxygen 
set or in the faenza set.  We might also look at finding an artist to create a 
custom set for LyX?  Maybe for 2.1? The Ubuntu artwork team has recently been 
looking for better ways to become involved in upstream projects, perhaps they 
might be interested in this challenge? If so, I could send them an email and 
gauge enthusiasm?

Cheers,

Rob

Re: Icons

[Joost Verburg]

Rob Oakes lyx-de...@oak-tree.us wrote in message 
news:88f13752-72ca-4a77-83f1-13040e951...@oak-tree.us...
As a way of starting, you might take a look at some of the icons in the 
Oxygen set or in the faenza set.  We might also look at finding an artist 
to create a custom set for LyX?  Maybe for 2.1? The Ubuntu artwork team 
has recently been looking for better ways to become involved in upstream 
projects, perhaps they might be interested in this challenge? If so, I 
could send them an email and gauge enthusiasm?


I agree. For now we can replace some of the really bad icons with nicer ones 
from a standard set.
There will of course always be a need for LyX-specific icons for which it'd 
be great to have a good designer.

I'd say go ahead and ask the Ubuntu artwork team!

Joost 

Re: Icons

[Pavel Sanda]

Joost Verburg wrote:
 be nice to have at least a little bit of UI refresh for 2.0 :)

2.0 is good excuse, but it should happen before RC. i would like to
make freeze more strict once we enter it.

just side notes:
- there are related bugs #3149, #6540.
- also manuals need to be fixed.

pavel

Re: Find replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
  replace dialogs now:
 * Find  replace - Quick
 * Find  replace - Advanced - Basic

which one is this one?

 * Find  replace - Advanced - Advanced

 Could we get rid of the old Quick dialog 

Vincent had plan to move it to firefox-style onliner, but it didn't happened.
unless you show me where is the third, i think these two are fine.
advanced speed is still not enough.

pavel

Re: Icons

[Pavel Sanda]

Joost Verburg wrote:
 The current LyX toolbar icons are blurred because the default icon size is 
 set to 20x20 pixels, although most of our icons actually are 22x22 (this is 

btw aren't those 22 pixels what you get if you just switch to big icons via 
context menu?
pavel

Re: Icons

[Joost Verburg]

Pavel Sanda sa...@lyx.org wrote in message 
news:20110217224752.go26...@atrey.karlin.mff.cuni.cz...

2.0 is good excuse, but it should happen before RC. i would like to
make freeze more strict once we enter it.


OK. Let's update the main icons now and leave further updates for 2.1.


just side notes:
- there are related bugs #3149, #6540.
- also manuals need to be fixed.


Yes, for 2.1 I'd be good to add support for several icon sizes instead of a 
single fixed-size PNG.


Joost 

Re: Find replace in 2.0

[Joost Verburg]

Pavel Sanda sa...@lyx.org wrote in message 
news:20110217225227.gp26...@atrey.karlin.mff.cuni.cz...
Vincent had plan to move it to firefox-style onliner, but it didn't 
happened.

unless you show me where is the third, i think these two are fine.
advanced speed is still not enough.


The advanced mode has two windows - basic and advanced.
I didn't notice the performance issue of the advanced ones. UI wise it 
doesn't make sense to have both but I guess we have to wait for better 
performance then.


Joost 

Re: Icons

[Joost Verburg]

Pavel Sanda sa...@lyx.org wrote in message 
news:20110217230252.ga16...@atrey.karlin.mff.cuni.cz...
btw aren't those 22 pixels what you get if you just switch to big icons 
via context menu?

pavel


No, those are much bigger. 32 pixels I believe.

Joost 

Re: Icons

[Pavel Sanda]

Joost Verburg wrote:
 No, those are much bigger. 32 pixels I believe.

ah, ok. p

Re: Find replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
 The advanced mode has two windows - basic and advanced.

i must miss something very basic. what two windows are you talking about? :)
i see one panel with two workareas and one tab for special settings.

 I didn't notice the performance issue of the advanced ones. UI wise it 
 doesn't make sense to have both but I guess we have to wait for better 
 performance then.

just tried some search and no, speed looks fine now. anyway we are still
in a debug mode for this new feature.

pavel

Re: Find replace in 2.0

[Joost Verburg]

Pavel Sanda sa...@lyx.org wrote in message 
news:20110217231834.gr26...@atrey.karlin.mff.cuni.cz...
i must miss something very basic. what two windows are you talking about? 
:)

i see one panel with two workareas and one tab for special settings.


You're right, I was confused myself now by the UI. These texts on the tabs 
(Basic and Advanced) don't make sense to me. Shouldn't that be renamed 
to Search and Settings or something similar?



just tried some search and no, speed looks fine now. anyway we are still
in a debug mode for this new feature.


I guess if it's stable enough to go in 2.0, it can also replace the old one?

Joost 

Re: Find replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
 Pavel Sanda sa...@lyx.org wrote in message 
 news:20110217231834.gr26...@atrey.karlin.mff.cuni.cz...
 i must miss something very basic. what two windows are you talking about? 
 :)
 i see one panel with two workareas and one tab for special settings.

 You're right, I was confused myself now by the UI. These texts on the tabs 
 (Basic and Advanced) don't make sense to me. Shouldn't that be renamed 
 to Search and Settings or something similar?

yes, looks more correct to me.

 just tried some search and no, speed looks fine now. anyway we are still
 in a debug mode for this new feature.

 I guess if it's stable enough to go in 2.0, it can also replace the old one?

its pretty clear from the patch activity around find adv code, that we havent
reach the stable point.

secondly, in my usage of lyx 2, i still prefer small dialog for only-text search
just because its size. thats why was talking about the replacement with small 
widget,
perhaps in 2.1. so no, i dont agree with killing it now.

pavel

Re: Find replace in 2.0

[Pavel Sanda]

Pavel Sanda wrote:
  You're right, I was confused myself now by the UI. These texts on the tabs 
  (Basic and Advanced) don't make sense to me. Shouldn't that be renamed 
  to Search and Settings or something similar?
 
 yes, looks more correct to me.

Tommaso, is this fine with you?
pavel
diff --git a/src/frontends/qt4/ui/FindAndReplaceUi.ui 
b/src/frontends/qt4/ui/FindAndReplaceUi.ui
index caa08e1..a57a17b 100644
--- a/src/frontends/qt4/ui/FindAndReplaceUi.ui
+++ b/src/frontends/qt4/ui/FindAndReplaceUi.ui
@@ -17,7 +17,7 @@
   /property
   widget class=QWidget name=basicTab 
attribute name=title 
-stringBasiamp;c/string
+stringSearamp;ch/string
/attribute
layout class=QGridLayout name=gridLayout 
 item row=0 column=0 
@@ -160,7 +160,7 @@
   /widget
   widget class=QWidget name=advancedTab 
attribute name=title 
-stringAdamp;vanced/string
+stringSamp;ettings/string
/attribute
layout class=QGridLayout name=gridLayout_2 
 item row=0 column=0 colspan=2 

Re: Icons

[Stephan Witt]

Am 17.02.2011 um 23:47 schrieb Pavel Sanda:

 Joost Verburg wrote:
 be nice to have at least a little bit of UI refresh for 2.0 :)

+1

 2.0 is good excuse, but it should happen before RC. i would like to
 make freeze more strict once we enter it.
 

What about the hopping train image?

Stephan

Re: r37716 - lyx-devel/trunk/src

[Jürgen Spitzmüller]

switt wrote:
 +   string h_path = addName(hpath, lang-code() + - +
 lang-variety()); +   // first we try lang code+variety
 +   if (!lang-variety().empty()  haveLanguageFiles(h_path)) {
 +   hpath = h_path;
 +   return true;
 +   }
 +   // next we try lang code only
 +   h_path = addName(hpath, lang-code());
 +   if (haveLanguageFiles(h_path)) {
 +   hpath = h_path;
 +   return true;
 +   }

why don't you use lang-id() here?

Jürgen

Re: Icons

[Jürgen Spitzmüller]

Joost Verburg wrote:
 What about this to start with (see screenshot)?

These are too fanciful/colourish for my taste.

Jürgen

Re: Find replace in 2.0

[Jürgen Spitzmüller]

Joost Verburg wrote:
 Could we get rid of the old Quick dialog 
 and rename Advanced Find and Replace to Find and Replace?

-1. I think this simple and fast search method is still of much use besides 
the big, blown advanced dialog.

Jürgen

Re: r37704 - lyx-devel/trunk/src/insets

[Edwin Leuven]

On Thu, Feb 17, 2011 at 01:26, Enrico Forestieri  wrote:
> On Thu, Feb 17, 2011 at 01:09:04AM +0100, Pavel Sanda wrote:
>> Vincent van Ravesteijn wrote:
>> >> Which has no effect at all.
>> >>
>> > It does.
>>
>> can both of you please come back to this point and in more than one sentence
>> put down your arguments/analysis?
>
> I am sorry, this is a behavioural problem. I would not have any problem
> discussing and even acknowledging that I could be wrong, but
> there are ways to do things and the presuntuous way I cannot stand.

hehe, why do things always become fun after i go to bed?

as vincent wrote, with your patch you  can "execute "inset-modify tabular
set-tabular-width 7cm" for a longtable, and it happily changes the
table, while this lfun should have been disabled."

i also see this, and it is because the function is enabled whenever
tabular.tabular_width.zero() and therefore also for longtables etc

as discussed in another thread, the problem was that only the 1st
argument got checked, and that was just an arbitrary one (the one
which just happened to be added first in the frontend code). which is
prone to errors as we saw. so it seems to me that vincent's fix is the
correct one.

cheers, ed.

Re: hebrew support in lyx 2.0?

[Pavel Sanda]

Richman Reuven wrote:
> i hope it's not too late into the release process to be reporting
> this... :S

please create bugzilla reports, either with recipy to reproduce
or with attached problematic .lyx files.
pavel

Re: r37704 - lyx-devel/trunk/src/insets

[Enrico Forestieri]

On Thu, Feb 17, 2011 at 09:33:44AM +0100, Edwin Leuven wrote:
> as discussed in another thread, the problem was that only the 1st
> argument got checked, and that was just an arbitrary one (the one
> which just happened to be added first in the frontend code). which is
> prone to errors as we saw. so it seems to me that vincent's fix is the
> correct one.

Well, even if vincent's fix is correct, he himself is not correct.

Q: Why are you reverting it?
A: Because I'm right and you're wrong.

End of discussion, begin to give vent to one's anger.
Only later I noticed the other thread.

-- 
Enrico

Q to Edwin (was Re: r37709 - lyx-devel/trunk/src/insets)

[Jürgen Spitzmüller]

spitz wrote:
> Modified: lyx-devel/trunk/src/insets/InsetTabular.cpp
> ===
> === --- lyx-devel/trunk/src/insets/InsetTabular.cpp Thu Feb 17 11:02:29
> 2011(r37708) +++ lyx-devel/trunk/src/insets/InsetTabular.cpp Thu
> Feb 17 11:42:13 2011(r37709) @@ -1342,8 +1342,9 @@
>  Tabular::idx_type Tabular::getLastCellInRow(row_type row) const
>  {
> col_type c = ncols() - 1;
> -   while (cell_info[row][c].multirow == CELL_PART_OF_MULTIROW
> -   || cell_info[row][c].multicolumn ==
> CELL_PART_OF_MULTICOLUMN) +   while (c > 0
> +  && (cell_info[row][c].multirow == CELL_PART_OF_MULTIROW
> +  || cell_info[row][c].multicolumn ==
> CELL_PART_OF_MULTICOLUMN)) --c;
> return cell_info[row][c].cellno;
>  }

Edwin, why does getLastCellInRow actually at all decrease c if it's part of a 
multirow? This does not strike me correct.

Jürgen

LyX2b4 using lots of memory on mac

[Kühnlenz Florian]

Hello, 

I hope that is the right place here. I‘ve tried the beta for my bachelor thesis 
(yes I know it‘s a beta) because of the nice spell checker. All in all it works 
great but there seams to be a huge memory leak when showing any graphics in the 
document. Know that I‘ve started to put the pictures in my document scrolling 
from top to bottom will blow up the usage of RAM to 1GB+ which is a bit to much 
even on a 4GB System if you ask me because sooner or later the system starts to 
swap and becomes unusable.

best Regards, 

Florian Kühnlenz

Re: LyX2b4 using lots of memory on mac

[Anders Ekberg]

On 2011-02-17 21.35, "Kühnlenz Florian" 
wrote:

>Hello, 
>
>I hope that is the right place here. IŒve tried the beta for my bachelor
>thesis (yes I know itŒs a beta) because of the nice spell checker. All in
>all it works great but there seams to be a huge memory leak when showing
>any graphics in the document. Know that IŒve started to put the pictures
>in my document scrolling from top to bottom will blow up the usage of RAM
>to 1GB+ which is a bit to much even on a 4GB System if you ask me because
>sooner or later the system starts to swap and becomes unusable.
>
>best Regards, 
>
>Florian Kühnlenz

Can't confirm this. I get <100 MB with a 80 page document including many
pictures with LyX 2.0 beta 4.

/Anders

Re: LyX2b4 using lots of memory on mac

[Rob Oakes]

I can't confirm the error either. I've checked the text of my book (which has 
several thousand images in a variety of formats), and I'm only getting RAM 
usage of about 300 MB.  (This was done on both Mac and Linux).

Would it be possible to get a little bit more information about the problem? 
What platform are you using (Mac, Windows, Linus)? Is it with a particular type 
of image (jpeg, png, pdf)?

That might help other to duplicate and track down the issue.

Cheers,

Rob

Re: LyX2b4 using lots of memory on mac

[Kühnlenz Florian]

I‘m using a Mac BookPro with 10.6.6.
 
I maybe have to admit that I was a bit to fast with my conclusion but after it 
happened twice I thought it was reproducible. Which seams no longer the case 
because know it seams like it won‘t happen again even on my machine. Sorry for 
that!  Never the less if it will happen again I try to find out more.

I‘m using mostly png images.

Am 17.02.2011 um 21:55 schrieb Rob Oakes:

> I can't confirm the error either. I've checked the text of my book (which has 
> several thousand images in a variety of formats), and I'm only getting RAM 
> usage of about 300 MB.  (This was done on both Mac and Linux).
> 
> Would it be possible to get a little bit more information about the problem? 
> What platform are you using (Mac, Windows, Linus)? Is it with a particular 
> type of image (jpeg, png, pdf)?
> 
> That might help other to duplicate and track down the issue.
> 
> Cheers,
> 
> Rob

Re: LyX2b4 using lots of memory on mac

[Pavel Sanda]

Kühnlenz Florian wrote:
> I hope that is the right place here. I?ve tried the beta for my bachelor 
> thesis (yes I know it?s a beta) because of the nice spell checker. All in all 
> it works great but there seams to be a huge memory leak when showing any 
> graphics in the document. Know that I?ve started to put the pictures in my 
> document scrolling from top to bottom will blow up the usage of RAM to 1GB+ 
> which is a bit to much even on a 4GB System if you ask me because sooner or 
> later the system starts to swap and becomes unusable.

i doubt this has anything to do with lyx 2.0, since the huge memory consuption 
for large graphic files is there for ages.
if my guess is right, then its not leak in the sense of forgotten memory 
somewhere.
we just read _full_ bitmap of all pictures and even if you resize them to small 
thumbail, we still keep the whole image in memory.
so of you have few big bitmaps (note that i dont speak about their size on hard 
drive, but size when unpacked in memory) then getting 1 GB of RAM usage is 
going to happen easily.

easy workaround is to use child documents. 

pavel

Re: LyX2b4 using lots of memory on mac

[Pavel Sanda]

Kühnlenz Florian wrote:
> know it seams like it won?t happen again even on my machine. 

just try to go through the whole document, and let all png to be actually 
showed.
memory is allocated only then.

pavel

Re: r37704 - lyx-devel/trunk/src/insets

[Abdelrazak Younes]

On Thu, Feb 17, 2011 at 11:22 AM, Enrico Forestieri  wrote:

> On Thu, Feb 17, 2011 at 09:33:44AM +0100, Edwin Leuven wrote:
> > as discussed in another thread, the problem was that only the 1st
> > argument got checked, and that was just an arbitrary one (the one
> > which just happened to be added first in the frontend code). which is
> > prone to errors as we saw. so it seems to me that vincent's fix is the
> > correct one.
>
> Well, even if vincent's fix is correct, he himself is not correct.
>
> Q: Why are you reverting it?
> A: Because I'm right and you're wrong.
>
> End of discussion, begin to give vent to one's anger.
> Only later I noticed the other thread.
>

I am sure Vincent did not meant to hurt you with his revert. He explained in
the commit log why he was reverting this. He probably should have warned you
that he was going to, but this is not like there is a lot of disrespect. I
am actually pretty sure you he respects you.

Anyway, that was just my monthly two cents :-P

Abdel.

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

[Pavel Sanda]

v...@lyx.org wrote:
> Author: vfr
> Date: Thu Feb 17 00:09:29 2011
> New Revision: 37706
> URL: http://www.lyx.org/trac/changeset/37706
> 
> Log:
> Fix bug #7308: Table settings dialog broken.
> 
>   // FIXME: We should use Tabular directly.
> - string param_str = "tabular";
> + string param_str = "tabular from-dialog";

Edwin, Vincent, please can you keep LyXAction.cpp doxies up to date if some 
lfun params
changed? (from-dialog, tabular width, decimal point feature, etc).

pavel

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

[Vincent van Ravesteijn]

 Op 17-2-2011 22:52, Pavel Sanda schreef:

v...@lyx.org wrote:

Author: vfr
Date: Thu Feb 17 00:09:29 2011
New Revision: 37706
URL: http://www.lyx.org/trac/changeset/37706

Log:
Fix bug #7308: Table settings dialog broken.

// FIXME: We should use Tabular directly.
-   string param_str = "tabular";
+   string param_str = "tabular from-dialog";

Edwin, Vincent, please can you keep LyXAction.cpp doxies up to date if some 
lfun params
changed? (from-dialog, tabular width, decimal point feature, etc).

pavel


Do you really want to document internal parameters that are basically a 
work-around for some messed up code ?


Vincent

disolving child docs

[Edwin Leuven]

i have a document with several child documents using 'input'

is there an easy way to "promote" the content of a child document to
the master document?

i.e. to get rid of the input and just have the text in the master doc?

there is unfortunately no "remove and insert here" in the context menu
or am i missing something?

thanks, ed.

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

[Pavel Sanda]

Vincent van Ravesteijn wrote:
>  Op 17-2-2011 22:52, Pavel Sanda schreef:
>> v...@lyx.org wrote:
>>> Author: vfr
>>> Date: Thu Feb 17 00:09:29 2011
>>> New Revision: 37706
>>> URL: http://www.lyx.org/trac/changeset/37706
>>>
>>> Log:
>>> Fix bug #7308: Table settings dialog broken.
>>>
>>> // FIXME: We should use Tabular directly.
>>> -   string param_str = "tabular";
>>> +   string param_str = "tabular from-dialog";
>> Edwin, Vincent, please can you keep LyXAction.cpp doxies up to date if 
>> some lfun params
>> changed? (from-dialog, tabular width, decimal point feature, etc).
>>
>> pavel
>
> Do you really want to document internal parameters that are basically a 
> work-around for some messed up code ?

if they can be reasonably used by user or some 3rd party script which
communicates with lyx server then yes. dunno if its the case of from-dialog but
for sure we have documentation for tabular width/decimal point companions.

pavel

Icons

[Joost Verburg]

Hi all,

The current LyX toolbar icons are blurred because the default icon size is 
set to 20x20 pixels, although most of our icons actually are 22x22 (this is 
a standard size). Also some icons looks quite outdated and have jagged 
edges.


Is it OK if I increase the default size with 2 pixels and try to find some 
better public domain or GPL icons to replace some of the current ones? I'd 
be nice to have at least a little bit of UI refresh for 2.0 :)


Best,
Joost 

Re: Icons

[Vincent van Ravesteijn]

Is it OK if I increase the default size with 2 pixels and try to find 
some better public domain or GPL icons to replace some of the current 
ones? I'd be nice to have at least a little bit of UI refresh for 2.0 :)

+1

Vincent

Find & replace in 2.0

[Joost Verburg]

Hi,

I was just checking out some new 2.0 features and noticed we got three find 
& replace dialogs now:

* Find & replace - Quick
* Find & replace - Advanced - Basic
* Find & replace - Advanced - Advanced
This really seems like too much. Could we get rid of the old "Quick" dialog 
and rename "Advanced Find and Replace" to "Find and Replace"?


Regards,
Joost 

Re: Icons

[Rob Oakes]

> Is it OK if I increase the default size with 2 pixels and try to find some 
> better public domain or GPL icons to replace some of the current ones? I'd be 
> nice to have at least a little bit of UI refresh for 2.0 :)


I think that would be fantastic.

+1

As a way of starting, you might take a look at some of the icons in the Oxygen 
set or in the faenza set.  We might also look at finding an artist to create a 
custom set for LyX?  Maybe for 2.1? The Ubuntu artwork team has recently been 
looking for better ways to become involved in upstream projects, perhaps they 
might be interested in this challenge? If so, I could send them an email and 
gauge enthusiasm?

Cheers,

Rob

Re: Icons

[Joost Verburg]

"Rob Oakes"  wrote in message 
news:88f13752-72ca-4a77-83f1-13040e951...@oak-tree.us...
As a way of starting, you might take a look at some of the icons in the 
Oxygen set or in the faenza set.  We might also look at finding an artist 
to create a custom set for LyX?  Maybe for 2.1? The Ubuntu artwork team 
has recently been looking for better ways to become involved in upstream 
projects, perhaps they might be interested in this challenge? If so, I 
could send them an email and gauge enthusiasm?


I agree. For now we can replace some of the really bad icons with nicer ones 
from a standard set.
There will of course always be a need for LyX-specific icons for which it'd 
be great to have a good designer.

I'd say go ahead and ask the Ubuntu artwork team!

Joost 

Re: Icons

[Pavel Sanda]

Joost Verburg wrote:
> be nice to have at least a little bit of UI refresh for 2.0 :)

2.0 is good excuse, but it should happen before RC. i would like to
make freeze more strict once we enter it.

just side notes:
- there are related bugs #3149, #6540.
- also manuals need to be fixed.

pavel

Re: Find & replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
> & replace dialogs now:
> * Find & replace - Quick
> * Find & replace - Advanced - Basic

which one is this one?

> * Find & replace - Advanced - Advanced

> Could we get rid of the old "Quick" dialog 

Vincent had plan to move it to firefox-style onliner, but it didn't happened.
unless you show me where is the third, i think these two are fine.
advanced speed is still not enough.

pavel

Re: Icons

[Pavel Sanda]

Joost Verburg wrote:
> The current LyX toolbar icons are blurred because the default icon size is 
> set to 20x20 pixels, although most of our icons actually are 22x22 (this is 

btw aren't those 22 pixels what you get if you just switch to "big" icons via 
context menu?
pavel

Re: Icons

[Joost Verburg]

"Pavel Sanda"  wrote in message 
news:20110217224752.go26...@atrey.karlin.mff.cuni.cz...

2.0 is good excuse, but it should happen before RC. i would like to
make freeze more strict once we enter it.


OK. Let's update the main icons now and leave further updates for 2.1.


just side notes:
- there are related bugs #3149, #6540.
- also manuals need to be fixed.


Yes, for 2.1 I'd be good to add support for several icon sizes instead of a 
single fixed-size PNG.


Joost 

Re: Find & replace in 2.0

[Joost Verburg]

"Pavel Sanda"  wrote in message 
news:20110217225227.gp26...@atrey.karlin.mff.cuni.cz...
Vincent had plan to move it to firefox-style onliner, but it didn't 
happened.

unless you show me where is the third, i think these two are fine.
advanced speed is still not enough.


The advanced mode has two windows - basic and advanced.
I didn't notice the performance issue of the advanced ones. UI wise it 
doesn't make sense to have both but I guess we have to wait for better 
performance then.


Joost 

Re: Icons

[Joost Verburg]

"Pavel Sanda"  wrote in message 
news:20110217230252.ga16...@atrey.karlin.mff.cuni.cz...
btw aren't those 22 pixels what you get if you just switch to "big" icons 
via context menu?

pavel


No, those are much bigger. 32 pixels I believe.

Joost 

Re: Icons

[Pavel Sanda]

Joost Verburg wrote:
> No, those are much bigger. 32 pixels I believe.

ah, ok. p

Re: Find & replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
> The advanced mode has two windows - basic and advanced.

i must miss something very basic. what two windows are you talking about? :)
i see one panel with two workareas and one tab for special settings.

> I didn't notice the performance issue of the advanced ones. UI wise it 
> doesn't make sense to have both but I guess we have to wait for better 
> performance then.

just tried some search and no, speed looks fine now. anyway we are still
in a debug mode for this new feature.

pavel

Re: Find & replace in 2.0

[Joost Verburg]

"Pavel Sanda"  wrote in message 
news:20110217231834.gr26...@atrey.karlin.mff.cuni.cz...
i must miss something very basic. what two windows are you talking about? 
:)

i see one panel with two workareas and one tab for special settings.


You're right, I was confused myself now by the UI. These texts on the tabs 
("Basic" and "Advanced") don't make sense to me. Shouldn't that be renamed 
to "Search" and "Settings" or something similar?



just tried some search and no, speed looks fine now. anyway we are still
in a debug mode for this new feature.


I guess if it's stable enough to go in 2.0, it can also replace the old one?

Joost 

Re: Find & replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
> "Pavel Sanda"  wrote in message 
> news:20110217231834.gr26...@atrey.karlin.mff.cuni.cz...
>> i must miss something very basic. what two windows are you talking about? 
>> :)
>> i see one panel with two workareas and one tab for special settings.
>
> You're right, I was confused myself now by the UI. These texts on the tabs 
> ("Basic" and "Advanced") don't make sense to me. Shouldn't that be renamed 
> to "Search" and "Settings" or something similar?

yes, looks more correct to me.

>> just tried some search and no, speed looks fine now. anyway we are still
>> in a debug mode for this new feature.
>
> I guess if it's stable enough to go in 2.0, it can also replace the old one?

its pretty clear from the patch activity around find adv code, that we havent
reach the stable point.

secondly, in my usage of lyx 2, i still prefer small dialog for only-text search
just because its size. thats why was talking about the replacement with small 
widget,
perhaps in 2.1. so no, i dont agree with killing it now.

pavel

Re: Find & replace in 2.0

[Pavel Sanda]

Pavel Sanda wrote:
> > You're right, I was confused myself now by the UI. These texts on the tabs 
> > ("Basic" and "Advanced") don't make sense to me. Shouldn't that be renamed 
> > to "Search" and "Settings" or something similar?
> 
> yes, looks more correct to me.

Tommaso, is this fine with you?
pavel
diff --git a/src/frontends/qt4/ui/FindAndReplaceUi.ui 
b/src/frontends/qt4/ui/FindAndReplaceUi.ui
index caa08e1..a57a17b 100644
--- a/src/frontends/qt4/ui/FindAndReplaceUi.ui
+++ b/src/frontends/qt4/ui/FindAndReplaceUi.ui
@@ -17,7 +17,7 @@
   
   

-Basic
+Search


 
@@ -160,7 +160,7 @@
   
   

-Advanced
+Settings


 

Re: Icons

[Stephan Witt]

Am 17.02.2011 um 23:47 schrieb Pavel Sanda:

> Joost Verburg wrote:
>> be nice to have at least a little bit of UI refresh for 2.0 :)

+1

> 2.0 is good excuse, but it should happen before RC. i would like to
> make freeze more strict once we enter it.
> 

What about the hopping train image?

Stephan

Re: r37716 - lyx-devel/trunk/src

[Jürgen Spitzmüller]

switt wrote:
> +   string h_path = addName(hpath, lang->code() + "-" +
> lang->variety()); +   // first we try lang code+variety
> +   if (!lang->variety().empty() && haveLanguageFiles(h_path)) {
> +   hpath = h_path;
> +   return true;
> +   }
> +   // next we try lang code only
> +   h_path = addName(hpath, lang->code());
> +   if (haveLanguageFiles(h_path)) {
> +   hpath = h_path;
> +   return true;
> +   }

why don't you use lang->id() here?

Jürgen

Re: Icons

[Jürgen Spitzmüller]

Joost Verburg wrote:
> What about this to start with (see screenshot)?

These are too fanciful/colourish for my taste.

Jürgen

Re: Find & replace in 2.0

[Jürgen Spitzmüller]

Joost Verburg wrote:
> Could we get rid of the old "Quick" dialog 
> and rename "Advanced Find and Replace" to "Find and Replace"?

-1. I think this simple and fast search method is still of much use besides 
the big, blown advanced dialog.

Jürgen