Re: [patch] fix for trunk regression regarding view > hidden

2012-02-22 Thread Pavel Sanda 
Scott Kostyshak wrote:
> Attached is the updated patch.

Its in, thanks
Pavel

RE: [patch] fix for trunk regression regarding view > hidden

2012-02-22 Thread Scott Kostyshak 
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Pavel 
Sanda [sa...@lyx.org]
Sent: Wednesday, February 22, 2012 6:08 AM

> I don't see the whole context of the code but it seems to me that to
> get pre-r40585 logic, '!' shall be put ahead of the whole && clause, no?

Yes, you are right, Pavel. Attached is the updated patch.

Thanks,

ScottIndex: src/frontends/qt4/Menus.cpp
===
--- src/frontends/qt4/Menus.cpp	(revision 40791)
+++ src/frontends/qt4/Menus.cpp	(working copy)
@@ -949,8 +949,8 @@
 	Buffer * b = first;
 	// We cannot use a for loop as the buffer list cycles.
 	do {
-		if (guiApp->currentView()
-		&& guiApp->currentView()->workArea(*b)) {
+		if (!(guiApp->currentView()
+		&& guiApp->currentView()->workArea(*b))) {
 			QString label = toqstr(b->fileName().displayName(20));
 			if (!b->isClean())
 label += "*";

Re: google summer of code is starting

2012-02-22 Thread Tommaso Cucinotta 

Il 16/02/2012 08:02, Alessandro Di Federico ha scritto:

Hello, I plan to partecipate to GSoC as a student.

On Sun, 2012-02-12 at 00:49 +, Tommaso Cucinotta wrote:

2) distributed collaborative real-time editing

I found this one very interesting.


I also have to admit that I suspect this feature might be considered 
competitor of Google Docs, so I'd not expect it to be supported by GSoC 
too easily.


T.

Re: [patch] fix for trunk regression regarding view > hidden

2012-02-22 Thread Pavel Sanda 
Scott Kostyshak wrote:
> The attached patch fixes a regression introduced into trunk in r40585

I don't see the whole context of the code but it seems to me that to
get pre-r40585 logic, '!' shall be put ahead of the whole && clause, no?

> Should I send small fixes such as this to the list or make a ticket?

If nobody react on time, then file ticket and attach patch there.

Pavel

Re: Windows Installer could use work: must set miktex packages "on fly" to NO, or else LyX won't run

2012-02-22 Thread Vincent van Ravesteijn 

A LyX window does not appear on the screen, and Lyx does not appear as
an application.  However, in the second tab,  one can see processes
for LyxLauncher.exe and lyx.exe, and also processes for latex and
mf-config appear and disappear. LyX does not start, the processes stay
"stuck", but if you manually kill the latex.exe process, then the Lyx
window does appear, but none of its menus work and LyX is not
responding.


Are you sure the processes stay "stuck" ? Or does it just take a lot of 
time.



The LyX installer claims it is installing packages, but could that
list of  packages be expanded substantially so that LyX installs every
package that might be called on by any of the document types that LyX
tries to support?


We trigger MikTeX to install all the necessary packages. That's why you have to 
wait a long time before LyX is started.I've also run LyXLauncher.exe -dbg any 
in a terminal, but the output
just stops and waits while LyX seems to not start (processes are
stuck).


LyXLauncher.exe shouldn't be part of the installer anymore. Did you use 
the official installer ?


Vincent

Re: r40789 - in lyx-devel/trunk: . lib lib/doc lib/scripts src src/frontends/qt4 src/frontends/qt4/ui src/graphics src/support

2012-02-22 Thread Kornel Benko 
Am Dienstag, 21. Februar 2012 um 21:29:45, schrieb b...@lyx.org
> Author: baum
> Date: Tue Feb 21 21:29:44 2012
> New Revision: 40789
> URL: http://www.lyx.org/trac/changeset/40789
> 
> Log:
> Use libmagic for file format detection if available.
> 

Adapted to cmake.

Kornel

signature.asc
Description: This is a digitally signed message part.

[patch] fix for trunk regression regarding view > hidden

2012-02-22 Thread Scott Kostyshak 
The attached patch fixes a regression introduced into trunk in r40585

description of regression:
Non-hidden files are shown in the submenu view > hidden and hidden files are 
not shown there.
You can reproduce by opening a new file and seeing that it is listed under view 
> hidden. Additionally, open another new file, save it, hide it, and it will 
not be listed under view > hidden.

Should I send small fixes such as this to the list or make a ticket?

Scott
Index: src/frontends/qt4/Menus.cpp
===
--- src/frontends/qt4/Menus.cpp	(revision 40790)
+++ src/frontends/qt4/Menus.cpp	(working copy)
@@ -950,7 +950,7 @@
 	// We cannot use a for loop as the buffer list cycles.
 	do {
 		if (guiApp->currentView()
-		&& guiApp->currentView()->workArea(*b)) {
+		&& !guiApp->currentView()->workArea(*b)) {
 			QString label = toqstr(b->fileName().displayName(20));
 			if (!b->isClean())
 label += "*";