Re: [LyX master] Another attempt at Encoding::any (we don't compile at linux now).
Pavel Sanda wrote:
> commit 718eeba60f5cef7c91508a3472a7b78b73934386
> Author: Pavel Sanda
> Date: Fri Jan 25 21:10:44 2013 -0800
>
> Another attempt at Encoding::any (we don't compile at linux now).
Uwe, can you try now? Pavel
> diff --git a/src/Encoding.cpp b/src/Encoding.cpp
> index 1c5e93c..be6f93a 100644
> --- a/src/Encoding.cpp
> +++ b/src/Encoding.cpp
> @@ -37,6 +37,8 @@ using namespace lyx::support;
>
> namespace lyx {
>
> +int const Encoding::any = -1;
> +
> Encodings encodings;
>
> Encodings::MathCommandSet Encodings::mathcmd;
> diff --git a/src/Encoding.h b/src/Encoding.h
> index fb36e72..6a1f89c 100644
> --- a/src/Encoding.h
> +++ b/src/Encoding.h
> @@ -50,7 +50,7 @@ public:
> japanese = 8
> };
> /// Represent any of the above packages
> - static int const any = -1;
> + static int const any;
> ///
> Encoding() {}
> ///
>
CMake: target for lfundoc?
The CMake TODO.txt says it's done, but I don't think it's implemented. Scott
Using super key in local binds
Currently, the super key is equivalent to alt for me on Ubuntu. I'm guessing that this is true because Mac does not have a super key? Thus, it would not make sense to have bindings that cannot be used by Macs. However, I think that it would still be nice to be able to use it for my local binds. It's especially nice since I know that it won't conflict with any other binds. Would this be difficult to implement? Am I missing other reasons for not doing this? Scott
rule about committing when trunk is not compiling?
Is there a written or unwritten rule about committing when trunk is not compiling for some/all people? I don't have anything in particular in mind. For example, git bisect could be more of a pain. Scott
Re: [LyX master] Implement move row/column in tabular inset
OK, I applied both patches. Thanks, Scott On Fri, Jan 25, 2013 at 11:22 PM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> LFUN_INSET_MODIFY does not look nice in the LyX output. Would adding >> linebreaks like in the attached patch improve that? > > Do whatsoever looks better in LFUNs manual and its pdf counterpart. > Pavel
Re: [LyX master] Change an accelerator to a more intuitive letter
On Fri, Jan 25, 2013 at 10:29 PM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> commit 98a8c30dfac4813a5f4e3480ab38218a9e169604 >> Author: Scott Kostyshak >> Date: Sun Jan 20 21:55:43 2013 -0500 >> >> Change an accelerator to a more intuitive letter >> >> diff --git a/lib/ui/stdcontext.inc b/lib/ui/stdcontext.inc >> index f878685..60d8a26 100644 >> --- a/lib/ui/stdcontext.inc >> +++ b/lib/ui/stdcontext.inc >> @@ -425,7 +425,7 @@ Menuset >> Item "Move Column Right|v" "inset-modify tabular >> move-column-right" >> Item "Move Column Left" "inset-modify tabular move-column-left" >> Separator >> - Item "Settings...|g" "inset-settings tabular" >> + Item "Settings...|s" "inset-settings tabular" >> End > > s->S ? > P Good catch. I fixed this. I didn't know Qt worked like that. That's a nice feature. Scott
Re: [LyX master] initials.module: add the missing mandatory argument
Am 26.01.2013 05:23, schrieb Pavel Sanda: Jürgen Spitzmüller wrote: Am Sonntag 20 Januar 2013, 21:24:01 schrieb Uwe St??hr: + Argument 3 + Mandatory 1 + LabelString "Rest of Initial" + Tooltip "Rest of initial word or text" EndArgument File format change! Uwe, was this addressed in the later lyx2lyx commit? Pavel Yes. You can convert files including initials now without problems. regards Uwe
Re: [LyX master] initials.module: add the missing mandatory argument
Jürgen Spitzmüller wrote: > Am Sonntag 20 Januar 2013, 21:24:01 schrieb Uwe St??hr: > > + Argument 3 > > + Mandatory 1 > > + LabelString "Rest of Initial" > > + Tooltip "Rest of initial word or text" > > EndArgument > > File format change! Uwe, was this addressed in the later lyx2lyx commit? Pavel
Re: [LyX master] Implement move row/column in tabular inset
Scott Kostyshak wrote: > LFUN_INSET_MODIFY does not look nice in the LyX output. Would adding > linebreaks like in the attached patch improve that? Do whatsoever looks better in LFUNs manual and its pdf counterpart. Pavel
Re: CMake compilation of trunk in install mode fails for translations
Am 13.01.2013 21:26, schrieb Kornel Benko:
(Compiling the 2.1 trunk using the devel mode works without any errors or
warnings.)
That I do not understand.
1.) in build.bat cmake is called with '-DLYX_INSTALL=1'
2.) in development/cmake/po/CMakeLists.txt:191, _addALLOption is set to ALL
after examining LYX_INSTALL
3.) in development/cmake/po/CMakeLists.txt:193, GETTEXT_CREATE_TRANSLATIONS()
is called with ${_addALLOption}
4.) in development/cmake/modules/FindLyXGettext.cmake:39, this is examined
5.) in development/cmake/modules/FindLyXGettext.cmake:61, the target
translations is created so, that
it is visible from outside, e.g. there should be a way to build
this target from VC.
The translations.vcxproj file is created but it cannot be compiled. When I try to compile the file
manually using MSVC I get these 2 error messages:
CUSTOMBUILD : error : Unable to handle line:
Encoding big5 Bg5 "Chinese (traditional) (Big5)" BIG5 variableunsafe CJK
CUSTOMBUILD : error : Unable to handle line:
Encoding shift-jis SJIS "Japanese (CJK) (SJIS)" CP932 variableunsafe CJK
So to get LyX compilable in install mode I only need to remove the "variableunsafe" from the
encodings file.
But variableunsafe was recently added:
http://www.lyx.org/trac/changeset/ee3ce572a0b4fc2b71fcf7da0f1136174c2f4928/lyxgit
Georg, could you please have a look?
thanks and regards
Uwe
Re: [LyX master] Encoding.cpp: make it compilable again after [2eea1590/lyxgit]
Uwe StĂśhr wrote:
> commit 9e29dc2338842568de166cef8cee88de9210a84b
> Author: Uwe StĂśhr
> Date: Fri Jan 25 23:24:26 2013 +0100
>
> Encoding.cpp: make it compilable again after [2eea1590/lyxgit]
>
> diff --git a/src/Encoding.cpp b/src/Encoding.cpp
> index 3a27a7b..1c5e93c 100644
> --- a/src/Encoding.cpp
> +++ b/src/Encoding.cpp
> @@ -37,8 +37,6 @@ using namespace lyx::support;
>
> namespace lyx {
>
> -int const Encoding::any;
> -
> Encodings encodings;
Kaboom. Now we don't compile on Linux.
CXXLD lyx
liblyxcore.a(BufferParams.o): In function `lyx::BufferParams::encoding()
const':
BufferParams.cpp:(.text+0x42ed): undefined reference to `lyx::Encoding::any'
BufferParams.cpp:(.text+0x4415): undefined reference to `lyx::Encoding::any'
collect2: ld returned 1 exit status
make[4]: *** [lyx] Error 1
Pavel
Re: [LyX master] chkconfig.ltx: check for wasy
Am 23.01.2013 22:56, schrieb Georg Baum: chkconfig.ltx: check for wasy In unicodesymbols we use the wasy fonts intensively. So we also need to check for them. (wasysym is not the font package itself, only a package to support it: "LaTeX support file to use the WASY-2 fonts. The wasysym package implements and easy to use interface for these symbols.") This is wrong. wasy.sty does not exist. I know and I therefore check for the wasy font not the style file. When you install LyX for the first time and compile files you are informed that the wasy fonts are missing and must be installed. Note that I even removed the senseless check for a wasy.sty. Please revert, the old version worked perfectly. unicodesymbols does not list wasy, but wasysym (and BTW the requirements in unicodesymbols are not package names, but defined by LyX in LaTeXFeatures.cpp) I know this, but why are you against checking for the wasy fonts. wasysym addresses them, so without having them installed wasysym cannot help us. Also note that even if the check fails nothing is changed in LyX. regards Uwe
Re: Restart layout update discussion; was: Re: [patch] final layout patches for branch
Am 22.01.2013 15:45, schrieb Jürgen Spitzmüller: I now also reverted your changes locally, and it turns out that the (old) moderncv example file still works without any single problem with the old layout. This is with most recent TL (2012/12/04 v1.2.1 of moderncv.cls). Damn, you are right. I don't understand this anymore! With 1.2.0 it did definitively not compile. Give me a day and I'll fix it and also add some lyx2lyx code for trunk. thanks for being insisting here and best regards Uwe
Re: [patch] new VCS commands copy and rename
Georg Baum wrote: > The attached patch implements two new VCS commands which I already announced > some months ago. Only svn supports them fully, but I implemented a poor mans > version for CVS and RCS. These commands are useful i several cases, e.g. if > you give a lecture that is evolving each year, and want to keep your old > files for reference, but still retain version history for the new files. The > benefit of builtin support instead of using the VCS client of your choice is > the correct updating of relative paths of included files (as we do already > for save as). > > OK to go in? If yes, I would test CVS/RCS more thoroughly, and add > documentation to Additional.lyx. Generally I'm fine with the changes. I'm not sure about poor man solution for RCS rename. If we let history ,v on place it will be forgotten by the user, if we delete it user can be surprised that he lost the whole history after rename. I wonder if unimplemented RCS rename wouldn't be better in the end? Did you test whether svn move is allowed when file is locked by another user or similar? Pavel
Re: Restart layout update discussion; was: Re: [patch] final layout patches for branch
Am 22.01.2013 15:19, schrieb Jürgen Spitzmüller: You added 14 styles of "InPreamble" type (CVStyle, CVColor, FirstName, FamilyName, Title, Address, Mobile, Phone, Fax, Email, Homepage, ExtraInfo, Photo and Quote). None of these are needed to keep the layout working with recent releases of moderncv, since all these statements can still be given via the preamble, as it is the case in current LyX releases. This is correct. The problem I was facing was that modernCV could not be compiled. I played a long time to get it compilable but failed, I therefore started to rewrite the layout bit by bit. I therefore of course added new styles. I will have a look what can go and what styles are still necessary. On the contrary, I think such a huge number of new layouts require a file format change, and lyx2lyx should write those layouts into the preamble on reversion As said modernCV was not compilable using recent versions of modernCV. Therefore I cannot tell what needs to be reverted to what. It is dependent on the used version of modernCV. Since the changes are so multitude, this is clearly not something we would like to do just within a maintenance release cycle. I fully agree because it is annoying to be forced to update existing files. But I now several times tried to get it to work without success. I will have a final look tomorrow and either find a solution or revert and leave it broken. regards Uwe
Re: Restart layout update discussion; was: Re: [patch] final layout patches for branch
Am 21.01.2013 22:15, schrieb Georg Baum: That is what I always stated, non of my changes (except of that nasty modernCV beast) break the backward-compatibility in the strict sense but they introduce new commands and that is what this thread is about. Yes. In the beginning, I thought that these new commands are urgently needed, and that you therefore want them in the stable release. Now I learned that none of the new commands is urgently needed But this is not correct. For example the new commands for the ACM classes are needed and also the new commands in the IEEE class will soon be necessary to be able to submit papers. regards Uwe
Re: trunk no longer compilable
Am 26.01.2013 00:14, schrieb Julien Rioux: Uwe is using the merged build. No I am not. I use the build.bat that we have in Git and it compiles using this line: cmake %LYX_SOURCE% -G%USED_STUDIO% -DLYX_MERGE_REBUILD=0 -DLYX_MERGE_FILES=0 -DLYX_NLS=1 -DLYX_INSTALL=1 -DLYX_RELEASE=1 -DLYX_CONSOLE=OFF %DEPENDENCIES_DOWNLOAD% So merge is turned off. However, if we want to release the merge build must be compilable, right? Please revert this last change. And fix this without breaking compilation for others. The question is who broke what. Before Julien's patch everything was compilable in install as well as in devel mode and now it is not. So for the time being I propose to revert this commit and then start investigate why it failed. I mean LyX should be compilable for everybody. regards Uwe
Re: [LyX master] Implement move row/column in tabular inset
On Fri, Jan 25, 2013 at 10:23 PM, Pavel Sanda wrote:
> Scott Kostyshak wrote:
>> @@ -115,6 +116,10 @@ TabularFeature tabularFeature[] =
>> { Tabular::DELETE_COLUMN, "delete-column", false },
>> { Tabular::COPY_ROW, "copy-row", false },
>> { Tabular::COPY_COLUMN, "copy-column", false },
>> + { Tabular::MOVE_COLUMN_RIGHT, "move-column-right", false },
>> + { Tabular::MOVE_COLUMN_LEFT, "move-column-left", false },
>> + { Tabular::MOVE_ROW_DOWN, "move-row-down", false },
>> + { Tabular::MOVE_ROW_UP, "move-row-up", false },
>> { Tabular::SET_LINE_TOP, "set-line-top", true },
>> { Tabular::SET_LINE_BOTTOM, "set-line-bottom", true },
>> { Tabular::SET_LINE_LEFT, "set-line-left", true },
>
> I suppose these guys should appear in LyXAction.cpp / LFUN_INSET_MODIFY ?
> Pavel
Yes, thanks for catching that. Patch is attached. The output of
LFUN_INSET_MODIFY does not look nice in the LyX output. Would adding
linebreaks like in the attached patch improve that?
Scott
From 7d3ab15f7b9e4d6b875953b8cfa3b25963633d5c Mon Sep 17 00:00:00 2001
From: Scott Kostyshak
Date: Fri, 25 Jan 2013 22:33:49 -0500
Subject: [PATCH 1/2] LyXAction.cpp: add move row to LFUN_INSET_MODIFY
Same for move column.
---
src/LyXAction.cpp |1 +
1 file changed, 1 insertion(+)
diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp
index df22d07..8444fcd 100644
--- a/src/LyXAction.cpp
+++ b/src/LyXAction.cpp
@@ -2373,6 +2373,7 @@ void LyXAction::init()
In case that is "tabular" various math-environment
features
are handled as well, e.g. add-vline-left/right for the
Grid/Array environment.\n
:
append-row|append-column|delete-row|delete-column|copy-row|copy-column|
+
move-column-right|move-column-left|move-row-down|move-row-up|
toggle-line-top|toggle-line-bottom|toggle-line-left|toggle-line-right|
align-left|align-right|align-center|align-block|align-decimal|set-decimal-point|
valign-top|valign-bottom|valign-middle|longtabular-align-left|
--
1.7.9.5
From adb07fe13070cd35224a50bd3f4eb481909456c4 Mon Sep 17 00:00:00 2001
From: Scott Kostyshak
Date: Fri, 25 Jan 2013 22:38:47 -0500
Subject: [PATCH 2/2] Add some linebreaks to LyXAction.cpp
Should make the LyX output look better.
---
src/LyXAction.cpp | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp
index 8444fcd..39a5ff7 100644
--- a/src/LyXAction.cpp
+++ b/src/LyXAction.cpp
@@ -2372,22 +2372,22 @@ void LyXAction::init()
* \li Params: Generally see #LFUN_INSET_INSERT for further details.\n
In case that is "tabular" various math-environment
features
are handled as well, e.g. add-vline-left/right for the
Grid/Array environment.\n
- :
append-row|append-column|delete-row|delete-column|copy-row|copy-column|
-
move-column-right|move-column-left|move-row-down|move-row-up|
-
toggle-line-top|toggle-line-bottom|toggle-line-left|toggle-line-right|
-
align-left|align-right|align-center|align-block|align-decimal|set-decimal-point|
-
valign-top|valign-bottom|valign-middle|longtabular-align-left|
-
longtabular-align-center|longtabular-align-right|m-align-left|m-align-right|
-
m-align-center|m-valign-top|m-valign-bottom|m-valign-middle|multicolumn|
-
set-all-lines|unset-all-lines|set-longtabular|unset-longtabular|set-pwidth|
-
set-mpwidth|set-rotate-tabular|unset-rotate-tabular|toggle-rotate-tabular|
-
set-rotate-cell|unset-rotate-cell|toggle-rotate-cell|set-usebox|set-lthead|
-
unset-lthead|set-ltfirsthead|unset-ltfirsthead|set-ltfoot|unset-ltfoot|
-
set-ltlastfoot|unset-ltlastfoot|set-ltnewpage|toggle-ltcaption|
-
set-special-column|set-special-multicolumn|set-special-multirow|
-
set-booktabs|unset-booktabs|set-top-space|set-bottom-space|
- set-interline-space|set-border-lines|tabular-valign-top|
-
tabular-valign-middle|tabular-valign-bottom|set-tabular-width \n
+ :
append-row|append-column|delete-row|delete-column|copy-row|\n
+
copy-column|move-column-right|move-column-left|move-row-down|move-row-up|\n
+
toggle-line-top|toggle-line-bottom|toggle-line-left|toggle-line-right|\n
+
align-left|align-right|align-center|align-block|align-decimal|set-decimal-point|\n
+
valign-top|valign-bottom|valign-middle|longtabular-align-left|\n
+
longtabular-align-center|longtabular-align-right|m-align-left|m-align-right|\n
+
Re: trunk no longer compilable
Am 25.01.2013 23:51, schrieb Julien Rioux: Your latest change break the compilation for me, while I had no compilation problem beforehand: How can that be? I compile with autotools and gcc 4.6.2, and you? I am using MSVC 2010 and CMake. regards Uwe
Re: [LyX master] Change an accelerator to a more intuitive letter
Scott Kostyshak wrote: > commit 98a8c30dfac4813a5f4e3480ab38218a9e169604 > Author: Scott Kostyshak > Date: Sun Jan 20 21:55:43 2013 -0500 > > Change an accelerator to a more intuitive letter > > diff --git a/lib/ui/stdcontext.inc b/lib/ui/stdcontext.inc > index f878685..60d8a26 100644 > --- a/lib/ui/stdcontext.inc > +++ b/lib/ui/stdcontext.inc > @@ -425,7 +425,7 @@ Menuset > Item "Move Column Right|v" "inset-modify tabular > move-column-right" > Item "Move Column Left" "inset-modify tabular move-column-left" > Separator > - Item "Settings...|g" "inset-settings tabular" > + Item "Settings...|s" "inset-settings tabular" > End s->S ? P
Re: [LyX master] Implement move row/column in tabular inset
Scott Kostyshak wrote:
> @@ -115,6 +116,10 @@ TabularFeature tabularFeature[] =
> { Tabular::DELETE_COLUMN, "delete-column", false },
> { Tabular::COPY_ROW, "copy-row", false },
> { Tabular::COPY_COLUMN, "copy-column", false },
> + { Tabular::MOVE_COLUMN_RIGHT, "move-column-right", false },
> + { Tabular::MOVE_COLUMN_LEFT, "move-column-left", false },
> + { Tabular::MOVE_ROW_DOWN, "move-row-down", false },
> + { Tabular::MOVE_ROW_UP, "move-row-up", false },
> { Tabular::SET_LINE_TOP, "set-line-top", true },
> { Tabular::SET_LINE_BOTTOM, "set-line-bottom", true },
> { Tabular::SET_LINE_LEFT, "set-line-left", true },
I suppose these guys should appear in LyXAction.cpp / LFUN_INSET_MODIFY ?
Pavel
Re: keytest.py, undocumented controls
On Sat, Jan 12, 2013 at 4:35 AM, Kornel Benko wrote: > Hi Tommaso, > > I wanted to check the description of controls in hello-world-in.txt with the > script keytest.py. > > So far, there exist some non-described controls > > Sleep > > Loop > > RaiseLyx > > . > > OK, 'Sleep' was easy. > > But what should 'Loop' do? At least in keytest.py there you can find: > > ... > > elif c == 'Loop': > > outfile.close() > > ... > > ... > > elif c == 'Loop': > > RaiseWindow() > > ... > > For me it looks like the second check will never be reached. This two > sequences should somehow merge IMHO. > > Still I don't understand the desired usage. > > > > Kornel Do "Loop" and "RaiseLyx" still need to be documented? Scott
Re: trunk no longer compilable
On Fri, Jan 25, 2013 at 6:05 PM, Vincent van Ravesteijn wrote: > > Op 25 jan. 2013 23:51 schreef "Julien Rioux" het volgende: > > >> >> On Fri, Jan 25, 2013 at 5:36 PM, Uwe Stöhr wrote: >> > Am 25.01.2013 08:39, schrieb Kornel Benko: >> > >> >> This for sure is not my doing. Looks, like your compiler/linker >> >> finds "lyx::Encoding::any" in Encoding.obj and BiblioInfo.obj. >> >> >> >> The last change was Jan 19 by Julien Rioux. >> > >> > >> > Thanks for the pointer. This was indeed the bug and I corrected this >> > now: >> > >> > http://www.lyx.org/trac/changeset/9e29dc2338842568de166cef8cee88de9210a84b/lyxgit >> > >> > thanks and regards >> > Uwe >> > >> >> Your latest change break the compilation for me, while I had no >> compilation problem beforehand: >> >> make[5]: Entering directory `/home/jrioux/git/lyx/build-dirac/src' >> CXXEncoding.o >> AR liblyxcore.a >> CXXBiblioInfo.o >> CXXLD lyx >> liblyxcore.a(BufferParams.o): In function `lyx::BufferParams::encoding() >> const': >> /home/jrioux/git/lyx/build-dirac/src/../../src/BufferParams.cpp:2916: >> undefined reference to `lyx::Encoding::any' >> /home/jrioux/git/lyx/build-dirac/src/../../src/BufferParams.cpp:2919: >> undefined reference to `lyx::Encoding::any' >> collect2: ld returned 1 exit status >> >> I compile with autotools and gcc 4.6.2, and you? >> >> Regards, >> Julien > > Uwe is using the merged build. Please revert this last change. And fix this > without breaking compilation for others. > > I strongly advice not to use the merged build, especially if you don't > understand the stuff and expect others to fix it. > > Vincent Not sure if this was really meant towards me or if a cc:lyx-devel was missing. I honestly don't know much C++ in details, so it is possible that I broke something. In this case I would of course look to resolve the situation, but it's hard for me to debug the problem Uwe was having since I don't see it. Regards, Julien
Re: trunk no longer compilable
On Fri, Jan 25, 2013 at 5:36 PM, Uwe Stöhr wrote: > Am 25.01.2013 08:39, schrieb Kornel Benko: > >> This for sure is not my doing. Looks, like your compiler/linker >> finds "lyx::Encoding::any" in Encoding.obj and BiblioInfo.obj. >> >> The last change was Jan 19 by Julien Rioux. > > > Thanks for the pointer. This was indeed the bug and I corrected this now: > http://www.lyx.org/trac/changeset/9e29dc2338842568de166cef8cee88de9210a84b/lyxgit > > thanks and regards > Uwe > Your latest change break the compilation for me, while I had no compilation problem beforehand: make[5]: Entering directory `/home/jrioux/git/lyx/build-dirac/src' CXXEncoding.o AR liblyxcore.a CXXBiblioInfo.o CXXLD lyx liblyxcore.a(BufferParams.o): In function `lyx::BufferParams::encoding() const': /home/jrioux/git/lyx/build-dirac/src/../../src/BufferParams.cpp:2916: undefined reference to `lyx::Encoding::any' /home/jrioux/git/lyx/build-dirac/src/../../src/BufferParams.cpp:2919: undefined reference to `lyx::Encoding::any' collect2: ld returned 1 exit status I compile with autotools and gcc 4.6.2, and you? Regards, Julien
Re: [LyX 2.0.x] chkconfig.ltx: remove check for cbgreek
Am 25.01.2013 10:43, schrieb Jean-Marc Lasgouttes: Checking for fonts is not that difficult in latex. See the example from configure.py for ecrm (which can be removed now IMO): I see, but this requires more changes in branch. I am not an expert in these things and don't want to open Pandora's box for this minor branch issue. But if you can implement this quickly please do so, otherwise let's keep it as it is because checking for the font packages in branch is more a convenience issue for MiKTeX users. thanks and regards Uwe
Re: [LyX 2.0.x] chkconfig.ltx: remove check for cbgreek
Am 25.01.2013 13:52, schrieb Guenter Milde: What is the reason for testing cbgreek in the first place? If you install LyX for the first time on a PC and compile your first Greek document, MiKTeX comes up asking you to install cbgreek. In case you don't have an Internet connection, this package cannot be installed and you will get a LaTeX error. I therefore check for this package at the installation of LyX because that time we can assume an existing Internet connection. This check does not have any other influences. If it is not found you can of course still do anything with LyX. regards we
Re: [LyX master] chkconfig.ltx: correct check for cbgreek
Am 23.01.2013 22:04, schrieb Julien Rioux:
-\TestPackage{cbgreek}% for Greek
+\TestPackage[glic1000]{cbgreek}% for Greek
.tfm missing?
No, the extension must not be specified, see also the other occurrences of
\TestFont in chkconfig.ltx.
regards Uwe
Re: trunk no longer compilable
Am 25.01.2013 08:39, schrieb Kornel Benko: This for sure is not my doing. Looks, like your compiler/linker finds "lyx::Encoding::any" in Encoding.obj and BiblioInfo.obj. The last change was Jan 19 by Julien Rioux. Thanks for the pointer. This was indeed the bug and I corrected this now: http://www.lyx.org/trac/changeset/9e29dc2338842568de166cef8cee88de9210a84b/lyxgit thanks and regards Uwe
Re: autotests
On Fri, Jan 25, 2013 at 3:06 PM, Tommaso Cucinotta wrote: > On 25/01/13 08:32, Kornel Benko wrote: > >>> On CMake, there is no button. The good thing is that it's very easy to >> >>> stop the test with ctrl+C. Perhaps the bad thing is that this is why >> >>> some tests are failing? I'm not sure. > > When running run-tests.sh, the focus stays all time on the LyX window that is > launched each time. > If I Ctrl-C, then I reach the LyX window. Also, not sure I manage to properly > kill the Python or .sh script always. > > Anyway, the button created by stop_autotests.tcl can be pushed through the > mouse, and stops the whole thing (or, should stop, perhaps it needs some fix). > The button works well for me in terms of stopping the tests. But I remember having to restart my computer in order to run more tests. I think I remember you saying something about killing more tasks but that it would be risky. Scott
Re: autotests
On 25/01/13 08:32, Kornel Benko wrote: >> On CMake, there is no button. The good thing is that it's very easy to > >> stop the test with ctrl+C. Perhaps the bad thing is that this is why > >> some tests are failing? I'm not sure. When running run-tests.sh, the focus stays all time on the LyX window that is launched each time. If I Ctrl-C, then I reach the LyX window. Also, not sure I manage to properly kill the Python or .sh script always. Anyway, the button created by stop_autotests.tcl can be pushed through the mouse, and stops the whole thing (or, should stop, perhaps it needs some fix). T.
Re: Multirows & lines
Hi Rainer,
After updating LyX, are you able to reproduce the other bug you found?
(That "Multirow" is above the table)? I would like to fix this bug, but I
want to be able to reproduce it. I tried (with the attached .lyx file) but
it works fine. What settings or other things do I need to set?
Thanks,
Scott
On Fri, Jan 25, 2013 at 5:07 AM, Rilke Rainer Michael <
ri...@wiso.uni-koeln.de> wrote:
> Updated Lyx and now it works. Thanks for your help.
>
> ** **
>
> ** **
>
> - Rainer
>
> ** **
>
> *Von:* Scott Kostyshak [mailto:skost...@lyx.org]
> *Gesendet:* Freitag, 25. Januar 2013 10:51
>
> *An:* Rilke Rainer Michael
> *Betreff:* Re: Multirows & lines
>
> ** **
>
> This must be a bug that has been fixed since 2.0 was released. I thought
> it might alternatively be a bug in your TeX distribution (e.g. MiKTeX) but
> the .tex file you sent me is incorrect which means that it's LyX's fault.
> So you can either (1) install the newest LyX version or (2) add in
> the \cline{2-2} lines manually (see the correct .tex attached).
>
>
> Scott
>
> ** **
>
> On Fri, Jan 25, 2013 at 4:26 AM, Rilke Rainer Michael <
> ri...@wiso.uni-koeln.de> wrote:
>
> Hi,
>
>
>
> I use: Lyx 2.0, Windows 7.
>
>
>
> Attached you find the pdflatex export and the tex-file.
>
>
>
> - Rainer
>
>
>
> *Von:* Scott Kostyshak [mailto:skost...@lyx.org]
> *Gesendet:* Freitag, 25. Januar 2013 10:23
>
>
> *An:* Rilke Rainer Michael
> *Betreff:* Re: Multirows & lines
>
>
>
> If I understand correctly, I cannot reproduce the bug. Attached is the pdf
> that I get from your lyx file (without modification). The horizontal lines
> above and below the multi-rows seem to be correct for me. Do you get
> different pdf output than what I attached or did I misunderstand you (sorry
> if this is the case)?
>
>
> If you get different pdf output -- what is your LyX version? What
> operating system do you use? What to you get when you export to pdflatex?
> Send the .tex file and the pdf file if possible.
>
>
>
> Scott
>
>
>
> On Fri, Jan 25, 2013 at 4:08 AM, Rilke Rainer Michael <
> ri...@wiso.uni-koeln.de> wrote:
>
> Attached you find the bug that I wanted to produce. ;) Multirow and lines
> seem to work, when there is only one pair of multirows. But when two pairs
> of multirows are in one table lyx seems to omit the lines in between. Any
> suggestions?
>
>
>
>
>
> - Rainer
>
>
>
> *Von:* Scott Kostyshak [mailto:skost...@lyx.org]
> *Gesendet:* Freitag, 25. Januar 2013 09:56
>
>
> *An:* Rilke Rainer Michael
> *Betreff:* Re: Multirows & lines
>
>
>
> That is indeed strange.
>
>
> Well, I guess you did create an MWE for a bug -- just not the one you
> intended :)
>
>
>
> Let me know if there's anything else I can do.
>
>
>
> Best,
>
>
> Scott
>
>
>
> On Fri, Jan 25, 2013 at 3:47 AM, Rilke Rainer Michael <
> ri...@wiso.uni-koeln.de> wrote:
>
> Hallo Scott,
>
>
>
> Thank you for your reply. I am confused, too. But I have to mention that
> the lyx file differs a bit from the table I originally posted in the email.
>
>
>
>
> What I see is exactly what you described (1, MULTIROW above the table and
> 2, no lines for multirows. I created that MWE from my main document where I
> cannot find bug (1). I am not sure what to change …
>
>
>
>
>
> - Rainer
>
>
>
>
>
>
>
> - Rainer
>
>
>
> *Von:* [mailto:skost...@lyx.org] *Im Auftrag von *Scott Kostyshak
>
>
> *Gesendet:* Donnerstag, 24. Januar 2013 18:17
> *An:* Rilke Rainer Michael
>
> *Betreff:* Re: Multirows & lines
>
>
>
> Hi Rainer,
>
>
>
> I'm confused. The MWE is not like in the email you sent. In the email you
> sent there are "TEST1", "TEST", and "TEST2". In the LyX file I see 6
> "TESTS". What is your expected output for the LyX file?
>
>
>
> A separate bug I see is that the first "MULTIROW" shows up *above* the
> table. That is quite strange, right? That to me seems like a bug. Can you
> confirm?
>
>
>
> I did some recent work on handling tables and borders in LyX. There are a
> few known problems but I have not seen this one.
>
> Scott
>
> On Thu, Jan 24, 2013 at 11:54 AM, Rilke Rainer Michael <
> ri...@wiso.uni-koeln.de> wrote:
>
> Hi Scott,
>
>
>
> Thanks for your help! Attached you find a MWE.
>
>
>
> Thanks,
>
> - Rainer
>
>
>
> *Von:* skost...@lyx.org [mailto:skost...@lyx.org] *Im Auftrag von *Scott
> Kostyshak
> *Gesendet:* Donnerstag, 24. Januar 2013 17:49
> *An:* Rilke Rainer Michael
> *Cc:* lyx-us...@lists.lyx.org
> *Betreff:* Re: Multirows & lines
>
>
>
>
>
> On Thu, Jan 24, 2013 at 11:14 AM, Rilke Rainer Michael <
> ri...@wiso.uni-koeln.de> wrote:
>
> Hi Lyx-list,
>
>
>
> I have a problem that is … so to say: pissing me off (sorry my Fr
Re: Re: Re: Why are export tests autotests?
On Fri, Jan 25, 2013 at 5:00 AM, Kornel Benko wrote: > Am Freitag, 25. Januar 2013 um 03:59:29, schrieb Scott Kostyshak > > >> On Fri, Jan 25, 2013 at 3:20 AM, Kornel Benko wrote: > >> > Am Freitag, 25. Januar 2013 um 01:49:16, schrieb Scott Kostyshak > >> > > >> > > > ... > >> > inserted 'KK: \C\[Home]' at start of each consecutive subtest. > >> > > >> > >> Your new test still fails for me. It's strange that the [Home] fixed > >> this one and the other one for you but not for me. > >> > >> Scott > > > > All tests are passing now. I had also preferences file laying around in > build-dir, > > I removed it too. > > > > Try the committed. > That's great that the tests all pass for you. Nothing has changed for me. I still get the following failures: findadv-05 findadv-06 findadv-07 findadv-08 findadv-09 findadv-10 findadv-11 findadv-14 findadv-15 findadv-16 findadv-17 findadv-re-01 findadv-re-02 findadv-re-03 findadv-re-04 But as the tests work for you, I don't think there's any other debugging that you can do. I will try to look more into this. Thanks, Scott
Re: [LyX 2.0.x] chkconfig.ltx: remove check for cbgreek
On 2013-01-25, Jean-Marc Lasgouttes wrote: > Le 23/01/2013 23:24, Uwe Stöhr a écrit : >> commit 873d5ebc27d7c0f8949d1f6abef1d396b67498a2 >> Author: Uwe Stöhr >> Date: Wed Jan 23 23:24:53 2013 +0100 >> chkconfig.ltx: remove check for cbgreek >> - we would need to check for a font but this doesn't work in >>branch. To Thus the current check is senseless because it will >>always fail, see #8522. Therefore I revert its addition to keep >>branch clean. What is the reason for testing cbgreek in the first place? The CB-Fonts are LGR-encoded Greek fonts matching Computer Modern. However, there are alternative LGR-encoded Greek fonts available, so please do not disable Greek support if these are missing. Günter
Re: [LyX master] Make sure that inset-forall does not skip insets
Le 25/01/2013 12:17, Jean-Marc Lasgouttes a écrit :
The branch, master, has been updated.
- Log -
commit f7548ae2cd1172a84b71a0190558e40722537e63
Author: Jean-Marc Lasgouttes
Date: Wed Jan 23 23:02:05 2013 +0100
Make sure that inset-forall does not skip insets
Wolfgang, please test if you can. Richard, this is candidate for branch.
This could happen with
inset-forall Note:Note char-delete-forward
when there where consecutive note insets.
diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 4aa3360..4342020 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -1809,7 +1809,7 @@ void BufferView::dispatch(FuncRequest const & cmd,
DispatchResult & dr)
cur.forwardInset();
cur.beginUndoGroup();
while(cur && iterations < max_iter) {
- Inset * ins = cur.nextInset();
+ Inset * const ins = cur.nextInset();
if (!ins)
break;
docstring insname = ins->layoutName();
@@ -1825,7 +1825,9 @@ void BufferView::dispatch(FuncRequest const & cmd,
DispatchResult & dr)
break;
insname = insname.substr(0, i);
}
- cur.forwardInset();
+ // if we did not delete the inset, skip it
+ if (!cur.nextInset() || cur.nextInset() == ins)
+ cur.forwardInset();
}
cur.endUndoGroup();
cur = savecur;
---
Summary of changes:
src/BufferView.cpp |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
hooks/post-receive
Re: Re: Re: Why are export tests autotests?
Am Freitag, 25. Januar 2013 um 03:59:29, schrieb Scott Kostyshak > On Fri, Jan 25, 2013 at 3:20 AM, Kornel Benko wrote: > > Am Freitag, 25. Januar 2013 um 01:49:16, schrieb Scott Kostyshak > > > > ... > > inserted 'KK: \C\[Home]' at start of each consecutive subtest. > > > > Your new test still fails for me. It's strange that the [Home] fixed > this one and the other one for you but not for me. > > Scott All tests are passing now. I had also preferences file laying around in build-dir, I removed it too. Try the committed. Kornel signature.asc Description: This is a digitally signed message part.
Re: [LyX 2.0.x] chkconfig.ltx: remove check for cbgreek
Le 23/01/2013 23:24, Uwe Stöhr a écrit :
The branch, 2.0.x, has been updated.
- Log -
commit 873d5ebc27d7c0f8949d1f6abef1d396b67498a2
Author: Uwe Stöhr
Date: Wed Jan 23 23:24:53 2013 +0100
chkconfig.ltx: remove check for cbgreek
- we would need to check for a font but this doesn't work in branch. To
Thus the current check is senseless because it will always fail, see #8522.
Therefore I revert its addition to keep branch clean.
Note the check for wasy in branch shows the same problematic but it is
there for ages.
Checking for fonts is not that difficult in latex. See the example from
configure.py for ecrm (which can be removed now IMO):
\font\test=ecrm1000\relax
\ifx\test\nullfont
\message{^^J\prefix\prefix checking for ec fonts... no^^J}
[...]
\else
[...]
\fi
JMarc
Re: Re: Re: Why are export tests autotests?
Am Freitag, 25. Januar 2013 um 09:20:25, schrieb Kornel Benko
> Am Freitag, 25. Januar 2013 um 01:49:16, schrieb Scott Kostyshak
>
> > On Thu, Jan 24, 2013 at 9:26 PM, Tommaso Cucinotta wrote:
> > > On 25/01/13 02:01, Scott Kostyshak wrote:
> > >> And I still can't
> > >> get the tests to run under autotools.
> > >
> > > what problems were u experiencing ?
> > >
> > > T.
> > >
> >
> > [note: I solved this by using XVKBD_HACKED, but I will still send this
> > in case you are interested in trying to debug using a system xvkbd]
> > I just tried again, and I am having the same problems as reported here:
> > http://marc.info/?l=lyx-devel&m=135715423332292&w=3
> > The log is at the bottom of that thread (don't read past
> > ["log_cmake.txt" (text/plain)]).
> > The only difference is that the first line after the traceback is now
> > on line 371 instead of 367 (this must be because of Kornel's patch).
> >
> > So it looks like the problem is here:
> > if not xvkbd_hacked:
> > subprocess.call([xvkbd_exe, "-xsendevent", "-window",
> > lyx_window_name,
> > "-delay", actual_delay, "-text", keystr],
> > stdout = FNULL, stderr = FNULL)
>
> Oh, thanks for pointing at this one. It turned out, that I forgot to set
> the environment "XVKBD_HACKED" (in single-test.cmake)
>
> > It turns out that kvkbd_exe doesn't seem to work. If I set it manually
> > in keytest.py:
> > xvkbd_exe = '/usr/bin/xvkbd'
> > then things work fine. I can't seem to set this via exporting an
> > environment variable: executing this command befor 'make' does not
> > work:
> > export XVKBD_EXE='/usr/bin/xvkbd'
>
> Because it is overwritten by single-test.cmake:61
>
> > Also, not thet xvkbd is in my path, so it doesn't seem like any of
> > that should be necessary anyway because of:
> > if xvkbd_exe is None:
> > xvkbd_exe = "xvkbd"
> >
> > Thus, I'm stumped.
> >
> > All of the above is true for an apt-get installed xvkbd and the
> > system-installed custom version of xvkbd.
> >
> > I just now tried with the custom xvkbd and XVKBD_HACKED and now the
> > autotests are all OK (thus, to be clear -- I can run the autotests now
> > and they all pass).
> >
> > Another question:
> >
> > In the README, it says
> > < > set to autotests/out-home, in order to rely on clean preferences
> > settings (use make clean or make without arguments in order to let
> > that folder be created again).>>
> >
> > But why then in keytest.py it seems like it tries to get it from the
> > environment variable?
> > lyx_userdir = os.environ.get('LYX_USERDIR')
>
> Set in single-test.cmake:56
>
> > Also, how do I have it create the directory out-home/.lyx without the
> > dialog?
>
> This is done from lyx itself.
>
> > Thanks for your help,
> >
> > Scott
>
> Now, most of the tests are OK.
> The following tests FAILED:
> 38 - autotests/findadv-15 (Failed)
> 39 - autotests/findadv-16 (Failed)
> 40 - autotests/findadv-17 (Failed)
> 44 - autotests/findadv-re-01 (Failed)
> 45 - autotests/findadv-re-02 (Failed)
> 46 - autotests/findadv-re-03 (Failed)
>
>
> Scott, please try the attached, this is one of the tests, which did not work,
> unless
> inserted 'KK: \C\[Home]' at start of each consecutive subtest.
>
> Kornel
It can't be that easy!! I removed the "session" file in the build-directory,
and now all tests
pass.
Kornel
signature.asc
Description: This is a digitally signed message part.
Re: Re: [PATCH] Add an autotest for #8523 (but how can I get a path for a helper lyx file?)
On Fri, Jan 25, 2013 at 3:30 AM, Kornel Benko wrote: > Am Donnerstag, 24. Januar 2013 um 21:02:52, schrieb Scott Kostyshak > > >> On Thu, Jan 24, 2013 at 8:50 PM, Tommaso Cucinotta >> wrote: > >> > On 24/01/13 04:42, Scott Kostyshak wrote: > >> >> I am trying to add an autotest for #8523, but how can I open a .lyx > >> >> file that I need to reproduce the crash? > >> >> > >> >> Two solutions come to mind: > >> >> > >> >> 1. Allow for a macro [autotest-dir] that key-test.py will replace with > >> >> the autotest directory. > >> > > >> > As of now, when launched through run-tests.sh, the tests execute in a >> > child > >> > directory of the autotests/ folder, named after out-/. > >> > > >> > Therefore, this works: > >> > > >> > TestBegin ../bug-8523.lyx > lyx-log.txt 2>&1 > >> > > >> > Though, the test should not try to modify the file (e.g., forcing Ctrl-S >> > or similar). > >> > > >> > Also, don't know whether it works when launched through the cmake >> > infrastructure. > >> > > >> > Would that suffice/work with cmake? > >> > >> Not currently. The tests are run in the CMake user build directory, > >> which can be anywhere and is specified by the user. CMake must know > >> where the source path is though because it knows this information when > >> building so hopefully Kornel will have an idea. > > > > "test.lyx" already is in the build directory (autotests/out-home/), so > ../bug-8523.lyx > > would be in build directory "autotests". What is the problem? Copy an > existing .lyx-files to build-dir? > > Should be easy. Ah yes you're right. You are convincing me more and more that out-of-source builds have many advantages and no disadvantages. So all is needed is just to copy the .lyx file there. Scott
Re: Re: Why are export tests autotests?
On Fri, Jan 25, 2013 at 3:20 AM, Kornel Benko wrote:
> Am Freitag, 25. Januar 2013 um 01:49:16, schrieb Scott Kostyshak
>
>
>> On Thu, Jan 24, 2013 at 9:26 PM, Tommaso Cucinotta
>> wrote:
>
>> > On 25/01/13 02:01, Scott Kostyshak wrote:
>
>> >> And I still can't
>
>> >> get the tests to run under autotools.
>
>> >
>
>> > what problems were u experiencing ?
>
>> >
>
>> > T.
>
>> >
>
>>
>
>> [note: I solved this by using XVKBD_HACKED, but I will still send this
>
>> in case you are interested in trying to debug using a system xvkbd]
>
>> I just tried again, and I am having the same problems as reported here:
>
>> http://marc.info/?l=lyx-devel&m=135715423332292&w=3
>
>> The log is at the bottom of that thread (don't read past
>
>> ["log_cmake.txt" (text/plain)]).
>
>> The only difference is that the first line after the traceback is now
>
>> on line 371 instead of 367 (this must be because of Kornel's patch).
>
>>
>
>> So it looks like the problem is here:
>
>> if not xvkbd_hacked:
>
>> subprocess.call([xvkbd_exe, "-xsendevent", "-window", lyx_window_name,
>
>> "-delay", actual_delay, "-text", keystr],
>
>> stdout = FNULL, stderr = FNULL)
>
>
>
> Oh, thanks for pointing at this one. It turned out, that I forgot to set
>
> the environment "XVKBD_HACKED" (in single-test.cmake)
>
>
>
>> It turns out that kvkbd_exe doesn't seem to work. If I set it manually
>
>> in keytest.py:
>
>> xvkbd_exe = '/usr/bin/xvkbd'
>
>> then things work fine. I can't seem to set this via exporting an
>
>> environment variable: executing this command befor 'make' does not
>
>> work:
>
>> export XVKBD_EXE='/usr/bin/xvkbd'
>
>
>
> Because it is overwritten by single-test.cmake:61
>
>
>
>> Also, not thet xvkbd is in my path, so it doesn't seem like any of
>
>> that should be necessary anyway because of:
>
>> if xvkbd_exe is None:
>
>> xvkbd_exe = "xvkbd"
>
>>
>
>> Thus, I'm stumped.
>
>>
>
>> All of the above is true for an apt-get installed xvkbd and the
>
>> system-installed custom version of xvkbd.
>
>>
>
>> I just now tried with the custom xvkbd and XVKBD_HACKED and now the
>
>> autotests are all OK (thus, to be clear -- I can run the autotests now
>
>> and they all pass).
>
>>
>
>> Another question:
>
>>
>
>> In the README, it says
>
>> <
>> set to autotests/out-home, in order to rely on clean preferences
>
>> settings (use make clean or make without arguments in order to let
>
>> that folder be created again).>>
>
>>
>
>> But why then in keytest.py it seems like it tries to get it from the
>
>> environment variable?
>
>> lyx_userdir = os.environ.get('LYX_USERDIR')
>
>
>
> Set in single-test.cmake:56
>
>
>
>> Also, how do I have it create the directory out-home/.lyx without the
>> dialog?
>
>
>
> This is done from lyx itself.
>
>
>
>> Thanks for your help,
>
>>
>
>> Scott
>
>
>
> Now, most of the tests are OK.
>
> The following tests FAILED:
>
> 38 - autotests/findadv-15 (Failed)
>
> 39 - autotests/findadv-16 (Failed)
>
> 40 - autotests/findadv-17 (Failed)
>
> 44 - autotests/findadv-re-01 (Failed)
>
> 45 - autotests/findadv-re-02 (Failed)
>
> 46 - autotests/findadv-re-03 (Failed)
>
>
>
>
>
> Scott, please try the attached, this is one of the tests, which did not
> work, unless
>
> inserted 'KK: \C\[Home]' at start of each consecutive subtest.
>
Your new test still fails for me. It's strange that the [Home] fixed
this one and the other one for you but not for me.
Scott
Re: Re: autotests
Am Freitag, 25. Januar 2013 um 01:50:28, schrieb Scott Kostyshak > On Thu, Jan 24, 2013 at 8:37 PM, Tommaso Cucinotta wrote: > > On 11/01/13 09:48, Scott Kostyshak wrote: > >> > >> I guess we should wait for Tommaso. > > > > FYI [1]. > > > > Perhaps, if you're playing with these tests, you may have needed to stop > > them via the GUI button. Now, that doesn't really work too well, and often > > we have stale lyx processes / .sh/python scripts running in the background > > that keep spawning further LyX instances, etc under such conditions, > > running further tests starts failing miserably. A "ps aux | grep lyx" > > normally catches such stale processes, if any. A run of "killall lyx python > > sh bash" (not as root!) might help in such regard, but beware that you can > > kill other possibly useful stuff that's running on the system (e.g., > > applets in the topbar?) > > > > Any fix to the proper action to run when hitting that button is very > > welcome. > > > > On CMake, there is no button. The good thing is that it's very easy to > stop the test with ctrl+C. Perhaps the bad thing is that this is why > some tests are failing? I'm not sure. I doubt, but don't know either. > Scott Kornel signature.asc Description: This is a digitally signed message part.
Re: Re: [PATCH] Add an autotest for #8523 (but how can I get a path for a helper lyx file?)
Am Donnerstag, 24. Januar 2013 um 21:02:52, schrieb Scott Kostyshak > On Thu, Jan 24, 2013 at 8:50 PM, Tommaso Cucinotta wrote: > > On 24/01/13 04:42, Scott Kostyshak wrote: > >> I am trying to add an autotest for #8523, but how can I open a .lyx > >> file that I need to reproduce the crash? > >> > >> Two solutions come to mind: > >> > >> 1. Allow for a macro [autotest-dir] that key-test.py will replace with > >> the autotest directory. > > > > As of now, when launched through run-tests.sh, the tests execute in a child > > directory of the autotests/ folder, named after out-/. > > > > Therefore, this works: > > > > TestBegin ../bug-8523.lyx > lyx-log.txt 2>&1 > > > > Though, the test should not try to modify the file (e.g., forcing Ctrl-S or > > similar). > > > > Also, don't know whether it works when launched through the cmake > > infrastructure. > > > > Would that suffice/work with cmake? > > Not currently. The tests are run in the CMake user build directory, > which can be anywhere and is specified by the user. CMake must know > where the source path is though because it knows this information when > building so hopefully Kornel will have an idea. "test.lyx" already is in the build directory (autotests/out-home/), so ../bug-8523.lyx would be in build directory "autotests". What is the problem? Copy an existing .lyx-files to build-dir? Should be easy. > Thanks, > > Scott Kornel signature.asc Description: This is a digitally signed message part.
Re: Re: Why are export tests autotests?
Am Freitag, 25. Januar 2013 um 01:49:16, schrieb Scott Kostyshak
> On Thu, Jan 24, 2013 at 9:26 PM, Tommaso Cucinotta wrote:
> > On 25/01/13 02:01, Scott Kostyshak wrote:
> >> And I still can't
> >> get the tests to run under autotools.
> >
> > what problems were u experiencing ?
> >
> > T.
> >
>
> [note: I solved this by using XVKBD_HACKED, but I will still send this
> in case you are interested in trying to debug using a system xvkbd]
> I just tried again, and I am having the same problems as reported here:
> http://marc.info/?l=lyx-devel&m=135715423332292&w=3
> The log is at the bottom of that thread (don't read past
> ["log_cmake.txt" (text/plain)]).
> The only difference is that the first line after the traceback is now
> on line 371 instead of 367 (this must be because of Kornel's patch).
>
> So it looks like the problem is here:
> if not xvkbd_hacked:
> subprocess.call([xvkbd_exe, "-xsendevent", "-window", lyx_window_name,
> "-delay", actual_delay, "-text", keystr],
> stdout = FNULL, stderr = FNULL)
Oh, thanks for pointing at this one. It turned out, that I forgot to set
the environment "XVKBD_HACKED" (in single-test.cmake)
> It turns out that kvkbd_exe doesn't seem to work. If I set it manually
> in keytest.py:
> xvkbd_exe = '/usr/bin/xvkbd'
> then things work fine. I can't seem to set this via exporting an
> environment variable: executing this command befor 'make' does not
> work:
> export XVKBD_EXE='/usr/bin/xvkbd'
Because it is overwritten by single-test.cmake:61
> Also, not thet xvkbd is in my path, so it doesn't seem like any of
> that should be necessary anyway because of:
> if xvkbd_exe is None:
> xvkbd_exe = "xvkbd"
>
> Thus, I'm stumped.
>
> All of the above is true for an apt-get installed xvkbd and the
> system-installed custom version of xvkbd.
>
> I just now tried with the custom xvkbd and XVKBD_HACKED and now the
> autotests are all OK (thus, to be clear -- I can run the autotests now
> and they all pass).
>
> Another question:
>
> In the README, it says
> < set to autotests/out-home, in order to rely on clean preferences
> settings (use make clean or make without arguments in order to let
> that folder be created again).>>
>
> But why then in keytest.py it seems like it tries to get it from the
> environment variable?
> lyx_userdir = os.environ.get('LYX_USERDIR')
Set in single-test.cmake:56
> Also, how do I have it create the directory out-home/.lyx without the dialog?
This is done from lyx itself.
> Thanks for your help,
>
> Scott
Now, most of the tests are OK.
The following tests FAILED:
38 - autotests/findadv-15 (Failed)
39 - autotests/findadv-16 (Failed)
40 - autotests/findadv-17 (Failed)
44 - autotests/findadv-re-01 (Failed)
45 - autotests/findadv-re-02 (Failed)
46 - autotests/findadv-re-03 (Failed)
Scott, please try the attached, this is one of the tests, which did not work,
unless
inserted 'KK: \C\[Home]' at start of each consecutive subtest.
Kornel
# Finding numbered maths with ignore-format on&off (might affect #7596)
#
Lang it_IT.utf8
TestBegin test.lyx -dbg find > lyx-log.txt 2>&1
KK: \CM\Axmath-number-toggle\[Return]
KK: x^2 +x^2\C\[Home]
KK: \Cs
KK: \CF
# Uncheck ignore format
KK: \Az\Ag\Ae
KK: \CM\Axmath-number-toggle\[Return]
KK: x^2\[Return]
TestEnd
Assert pcregrep -M 'Putting selection at .*idx: 0 par: 0 pos: 0\n.*idx: 0 par:
0 pos: 0\n with len: 1' lyx-log.txt
TestBegin test.lyx -dbg find > lyx-log2.txt 2>&1
KK: \C\[Home]
KK: \CF
# Uncheck ignore format
KK: \Az\Ag\Ae
KK: \CM\Axmath-number-toggle\[Return]
KK: x^2\[Return]\[Return]
TestEnd
Assert pcregrep -M 'Putting selection at .*idx: 0 par: 0 pos: 0\n.*idx: 0 par:
0 pos: 2\n with len: 1' lyx-log2.txt
TestBegin test.lyx -dbg find > lyx-log3.txt 2>&1
KK: \C\[Home]
KK: \CF
KK: \CM\Axmath-number-toggle\[Return]
KK: x^2\[Return]
TestEnd
Assert pcregrep -M 'Putting selection at .*idx: 0 par: 0 pos: 0\n.*idx: 0 par:
0 pos: 0\n with len: 1' lyx-log3.txt
TestBegin test.lyx -dbg find > lyx-log4.txt 2>&1
KK: \C\[Home]
KK: \CF
KK: \CM\Axmath-number-toggle\[Return]
KK: x^2\[Return]\[Return]
TestEnd
Assert pcregrep -M 'Putting selection at .*idx: 0 par: 0 pos: 0\n.*idx: 0 par:
0 pos: 2\n with len: 1' lyx-log4.txt
signature.asc
Description: This is a digitally signed message part.
