Re: Changing trac defaults

[Richard Heck]

On 03/16/2015 07:43 PM, Scott Kostyshak wrote:

I am curious what others think of two changes to defaults for
reporting a new bug:

1. milestone. Currently it defaults to 2.1.4. I propose to have it
default to blank.
- Georg proposed a way of dealing with milestones a couple of months
(?) ago that made sense. Part of what I remember is: don't assign
milestones unless there is a reason to.


This doesn't seem to be possible, at least from the admin screen. We 
could make it 2.1.x,
though, which would make more sense. It'd also be easy to search for 
those and triage

them.


2. version. Currently it defaults to 2.1.3. I propose to have it
default to blank.
- I prefer to have the user choose the version. Otherwise they might
just have skipped choosing it or did not want or know how to find the
version they are using.


Same issue. If there has to be a default, then current version makes sense.

If there's some way to have a blank default that I'm not seeing, I'm 
not opposed.


Richard

Re: Contribution license

[Jürgen Spitzmüller]

2015-03-15 18:34 GMT+01:00 Stefan Swerk:

 I hereby grant permission to license my contributions to LyX
 under the GNU General Public License, version 2 or any later version.


Thanks. I have committed the stuff to master and added you to the credits.

Jürgen



 Stefan Swerk

Re: [LyX/master] Fix bug #9453

[Jürgen Spitzmüller]

2015-03-16 11:09 GMT+01:00 Enrico Forestieri:

 Incidentally, It seems I cannot CC people anymore in the track system.


Fixed.

Jürgen

Re: [LyX/master] Move font encoding information to languages.

[Jürgen Spitzmüller]

2015-03-15 18:47 GMT+01:00 Jean-Marc Lasgouttes:

 We do not have a use case yet, but you commit that minus the part that
 defines the set version.


I am not really sure it makes sense if we just need VectorFromString, since
the change replaces push_back with insert in the template (since Set does
not have push_back), and this operation is apparently a bit more expensive
(so I learned).


 Actually, it seems to me that you do not Need the String template
 parameter. Container::value_type should do the trick, IMO.


OK. This somewhat exceeds my current C++ expertise, so I'd rather let you
(or someone else) do that change.

Jürgen



 JMarc

Re: New layout for package europasscv

[Jürgen Spitzmüller]

2015-03-16 3:05 GMT+01:00 Richard Heck:


 That's fine with me.



Done (the inputenc thing, that is).

Jürgen

Re: [LyX/master] Move font encoding information to languages.

[Jean-Marc Lasgouttes]

Indeed. Let's forget about it, then.

JMarc.

Le 16 mars 2015 12:32:08 CET, Jürgen Spitzmüller sp...@lyx.org a écrit :
2015-03-15 18:47 GMT+01:00 Jean-Marc Lasgouttes:

 We do not have a use case yet, but you commit that minus the part
that
 defines the set version.

I am not really sure it makes sense if we just need VectorFromString,
since
the change replaces push_back with insert in the template (since Set
does
not have push_back), and this operation is apparently a bit more
expensive
(so I learned).

Re: [LyX/master] Fix bug #9453

[Enrico Forestieri]

On Mon, Mar 16, 2015 at 12:36:18AM +0100, Enrico Forestieri wrote:

 commit 0a5e1f20fc807535dd83ddc52d65a22548e478e8
 Author: Enrico Forestieri for...@lyx.org
 Date:   Mon Mar 16 00:34:35 2015 +0100
 
 Fix bug #9453
 
 This was due to a problem with the QProcess parser.
 See #9453 for details.

Richard, this one and 1af2242c should go to stable.
Incidentally, It seems I cannot CC people anymore in the track system.

 diff --git a/src/support/filetools.cpp b/src/support/filetools.cpp
 index 5704aa1..229dd2e 100644
 --- a/src/support/filetools.cpp
 +++ b/src/support/filetools.cpp
 @@ -733,15 +733,10 @@ string latexEnvCmdPrefix(string const  path)
   return env TEXINPUTS=\. + sep + texinputs_prefix
 + sep + texinputs + \ ;
   else
 -#ifndef USE_QPROCESS
 + // NOTE: *any* space in the last string matters! (see bug 9453)
   return cmd /d /c set \TEXINPUTS=.
   + sep + texinputs_prefix
 - + sep + texinputs + \;
 -#else
 - return cmd /d /c set \\\TEXINPUTS=.
 - + sep + texinputs_prefix
 - + sep + texinputs + \\\;
 -#endif
 + + sep + texinputs +  \  ;
  }
  
  

-- 
Enrico

Re: [LyX/master] Fix bug #9453

[Richard Heck]

On 03/16/2015 06:09 AM, Enrico Forestieri wrote:

On Mon, Mar 16, 2015 at 12:36:18AM +0100, Enrico Forestieri wrote:


commit 0a5e1f20fc807535dd83ddc52d65a22548e478e8
Author: Enrico Forestieri for...@lyx.org
Date:   Mon Mar 16 00:34:35 2015 +0100

 Fix bug #9453
 
 This was due to a problem with the QProcess parser.

 See #9453 for details.

Richard, this one and 1af2242c should go to stable.


OK.

rh

Changing trac defaults

[Scott Kostyshak]

I am curious what others think of two changes to defaults for
reporting a new bug:

1. milestone. Currently it defaults to 2.1.4. I propose to have it
default to blank.
- Georg proposed a way of dealing with milestones a couple of months
(?) ago that made sense. Part of what I remember is: don't assign
milestones unless there is a reason to.

2. version. Currently it defaults to 2.1.3. I propose to have it
default to blank.
- I prefer to have the user choose the version. Otherwise they might
just have skipped choosing it or did not want or know how to find the
version they are using.

Scott

Re: [patch] Prefer svg icons

[Enrico Forestieri]

On Sun, Mar 15, 2015 at 08:54:33AM +0100, Abdelrazak Younes wrote:

 Hi Enrico,
 
 On 16/02/2015 15:21, Enrico Forestieri wrote:
 The attached patch let LyX use svg icons (if they exist) in preference
 to png ones. The svg icons automatically scale to the wanted dimension
 and the patch introduces 2 more resolutions (huge and giant icons) that
 should be useful to people with hires displays.
 
 Some svg icons were already added by Jürgen to the lib/images/svg subdir.
 However, they are not seen there and should be copied in the normal places.
 To this end, I also attach a shell script that symlinks them properly.
 The script works like a toggle, i.e., the first time it is launched
 the symlinks are created. When it launched a second time, the symlinks
 are removed.
 
 If no svg icons exist, LyX will use pngs, as usual. In my testing,
 it turns out that some svgs are problematic and give warnings on
 the console while they are loaded. Apart from that, everything seems
 to work for me, but you never know, so I am asking for comments before
 committing.
 
 One general comment from my old souvenirs:
 
 Qt supports SVG tiny standard and, IIRC, there were talk to
 deprecate that support in some 5.X version.

But it will not be removed
http://blog.qt.io/blog/2011/05/12/qt-modules-maturity-level-the-list/#comment-12784

 At some point in the past, we did mostly the same thing as your
 patch (not sure if this was André, Peter or me); we also had all
 icons embedded in resource for faster loading and easier
 distribution. IIRC there were some valid arguments that got this
 patch  rejected at the end so you might want to look at the
 archives.

Sorry, neither I remember nor can find it in the archives.

 But I like your patch ;-)

Thanks.

-- 
Enrico

Re: [LyX/master] Fix stmaryrd operators with limits (bug 9458)

[Georg Baum]

Georg Baum wrote:

 commit 5ee6172b7b203a5fd019b55e7f71b454be763139
 Author: Georg Baum b...@lyx.org
 Date:   Fri Mar 13 18:34:39 2015 +0100
 
 Fix stmaryrd operators with limits (bug 9458)
 
 LyX did not display the limits of the big math operators defined by
 stmaryrd.sty correctly. The reason for this was a missing check in
 InsetMathSymbol::metrics(), where it is hardcoded which symbols use
 display style limits and which symbols use inline limits. In an ideal
 world this information would be contained explicitly in lib/symbols.
 
 This should go to branch as well.
 
 diff --git a/src/mathed/InsetMathSymbol.cpp
 b/src/mathed/InsetMathSymbol.cpp index 0bd61d9..8b2d1a2 100644
 --- a/src/mathed/InsetMathSymbol.cpp
 +++ b/src/mathed/InsetMathSymbol.cpp
 @@ -87,7 +87,8 @@ void InsetMathSymbol::metrics(MetricsInfo  mi,
 Dimension  dim) const
  scriptable_ = false;
  if (mi.base.style == LM_ST_DISPLAY)
  if (sym_-inset == cmex || sym_-inset == esint ||
 - sym_-extra == funclim)
 + sym_-extra == funclim ||
 + (sym_-inset == stmry  sym_-extra == mathop))
  scriptable_ = true;
  }
  
 @@ -144,7 +145,8 @@ bool InsetMathSymbol::takesLimits() const
  sym_-inset == cmex ||
  sym_-inset == lyxboldsymb ||
  sym_-inset == esint ||
 - sym_-extra == funclim;
 + sym_-extra == funclim ||
 + (sym_-inset == stmry  sym_-extra == mathop);
  }

Richard, OK for branch? This is about LyX display only btw, document 
input/output is correct and not changed.


Georg

Re: [patch] Prefer svg icons

[Enrico Forestieri]

On Sun, Mar 15, 2015 at 08:54:33AM +0100, Abdelrazak Younes wrote:

> Hi Enrico,
> 
> On 16/02/2015 15:21, Enrico Forestieri wrote:
> >The attached patch let LyX use svg icons (if they exist) in preference
> >to png ones. The svg icons automatically scale to the wanted dimension
> >and the patch introduces 2 more resolutions (huge and giant icons) that
> >should be useful to people with hires displays.
> >
> >Some svg icons were already added by Jürgen to the lib/images/svg subdir.
> >However, they are not seen there and should be copied in the normal places.
> >To this end, I also attach a shell script that symlinks them properly.
> >The script works like a toggle, i.e., the first time it is launched
> >the symlinks are created. When it launched a second time, the symlinks
> >are removed.
> >
> >If no svg icons exist, LyX will use pngs, as usual. In my testing,
> >it turns out that some svgs are problematic and give warnings on
> >the console while they are loaded. Apart from that, everything seems
> >to work for me, but you never know, so I am asking for comments before
> >committing.
> 
> One general comment from my old souvenirs:
> 
> Qt supports SVG tiny standard and, IIRC, there were talk to
> deprecate that support in some 5.X version.

But it will not be removed
http://blog.qt.io/blog/2011/05/12/qt-modules-maturity-level-the-list/#comment-12784

> At some point in the past, we did mostly the same thing as your
> patch (not sure if this was André, Peter or me); we also had all
> icons embedded in resource for faster loading and easier
> distribution. IIRC there were some valid arguments that got this
> patch  rejected at the end so you might want to look at the
> archives.

Sorry, neither I remember nor can find it in the archives.

> But I like your patch ;-)

Thanks.

-- 
Enrico

Re: Contribution license

[Jürgen Spitzmüller]

2015-03-15 18:34 GMT+01:00 Stefan Swerk:

> I hereby grant permission to license my contributions to LyX
> under the GNU General Public License, version 2 or any later version.
>

Thanks. I have committed the stuff to master and added you to the credits.

Jürgen


>
> Stefan Swerk
>
>
>

Re: New layout for package europasscv

[Jürgen Spitzmüller]

2015-03-16 3:05 GMT+01:00 Richard Heck:

>
> That's fine with me.
>


Done (the inputenc thing, that is).

Jürgen

Re: [LyX/master] Fix bug #9453

[Enrico Forestieri]

On Mon, Mar 16, 2015 at 12:36:18AM +0100, Enrico Forestieri wrote:

> commit 0a5e1f20fc807535dd83ddc52d65a22548e478e8
> Author: Enrico Forestieri 
> Date:   Mon Mar 16 00:34:35 2015 +0100
> 
> Fix bug #9453
> 
> This was due to a problem with the QProcess parser.
> See #9453 for details.

Richard, this one and 1af2242c should go to stable.
Incidentally, It seems I cannot CC people anymore in the track system.

> diff --git a/src/support/filetools.cpp b/src/support/filetools.cpp
> index 5704aa1..229dd2e 100644
> --- a/src/support/filetools.cpp
> +++ b/src/support/filetools.cpp
> @@ -733,15 +733,10 @@ string latexEnvCmdPrefix(string const & path)
>   return "env TEXINPUTS=\"." + sep + texinputs_prefix
> + sep + texinputs + "\" ";
>   else
> -#ifndef USE_QPROCESS
> + // NOTE: *any* space in the last string matters! (see bug 9453)
>   return "cmd /d /c set \"TEXINPUTS=."
>   + sep + texinputs_prefix
> - + sep + texinputs + "\"&";
> -#else
> - return "cmd /d /c set \"\"\"TEXINPUTS=."
> - + sep + texinputs_prefix
> - + sep + texinputs + "\"\"\"&";
> -#endif
> + + sep + texinputs + " \" & ";
>  }
>  
>  

-- 
Enrico

Re: [LyX/master] Fix bug #9453

[Jürgen Spitzmüller]

2015-03-16 11:09 GMT+01:00 Enrico Forestieri:

> Incidentally, It seems I cannot CC people anymore in the track system.
>

Fixed.

Jürgen

Re: [LyX/master] Move font encoding information to languages.

[Jürgen Spitzmüller]

2015-03-15 18:47 GMT+01:00 Jean-Marc Lasgouttes:

> We do not have a use case yet, but you commit that minus the part that
> defines the set<> version.


I am not really sure it makes sense if we just need VectorFromString, since
the change replaces push_back with insert in the template (since Set does
not have push_back), and this operation is apparently a bit more expensive
(so I learned).


> Actually, it seems to me that you do not Need the String template
> parameter. Container::value_type should do the trick, IMO.
>

OK. This somewhat exceeds my current C++ expertise, so I'd rather let you
(or someone else) do that change.

Jürgen


>
> JMarc
>
>

Re: [LyX/master] Move font encoding information to languages.

[Jean-Marc Lasgouttes]

Indeed. Let's forget about it, then.

JMarc.

Le 16 mars 2015 12:32:08 CET, "Jürgen Spitzmüller"  a écrit :
>2015-03-15 18:47 GMT+01:00 Jean-Marc Lasgouttes:
>
>> We do not have a use case yet, but you commit that minus the part
>that
>> defines the set<> version.
>
>I am not really sure it makes sense if we just need VectorFromString,
>since
>the change replaces push_back with insert in the template (since Set
>does
>not have push_back), and this operation is apparently a bit more
>expensive
>(so I learned).

Re: [LyX/master] Fix bug #9453

[Richard Heck]

On 03/16/2015 06:09 AM, Enrico Forestieri wrote:

On Mon, Mar 16, 2015 at 12:36:18AM +0100, Enrico Forestieri wrote:


commit 0a5e1f20fc807535dd83ddc52d65a22548e478e8
Author: Enrico Forestieri 
Date:   Mon Mar 16 00:34:35 2015 +0100

 Fix bug #9453
 
 This was due to a problem with the QProcess parser.

 See #9453 for details.

Richard, this one and 1af2242c should go to stable.


OK.

rh

Re: [LyX/master] Fix stmaryrd operators with limits (bug 9458)

[Georg Baum]

Georg Baum wrote:

> commit 5ee6172b7b203a5fd019b55e7f71b454be763139
> Author: Georg Baum 
> Date:   Fri Mar 13 18:34:39 2015 +0100
> 
> Fix stmaryrd operators with limits (bug 9458)
> 
> LyX did not display the limits of the big math operators defined by
> stmaryrd.sty correctly. The reason for this was a missing check in
> InsetMathSymbol::metrics(), where it is hardcoded which symbols use
> display style limits and which symbols use inline limits. In an ideal
> world this information would be contained explicitly in lib/symbols.
> 
> This should go to branch as well.
> 
> diff --git a/src/mathed/InsetMathSymbol.cpp
> b/src/mathed/InsetMathSymbol.cpp index 0bd61d9..8b2d1a2 100644
> --- a/src/mathed/InsetMathSymbol.cpp
> +++ b/src/mathed/InsetMathSymbol.cpp
> @@ -87,7 +87,8 @@ void InsetMathSymbol::metrics(MetricsInfo & mi,
> Dimension & dim) const
>  scriptable_ = false;
>  if (mi.base.style == LM_ST_DISPLAY)
>  if (sym_->inset == "cmex" || sym_->inset == "esint" ||
> - sym_->extra == "funclim")
> + sym_->extra == "funclim" ||
> + (sym_->inset == "stmry" && sym_->extra == "mathop"))
>  scriptable_ = true;
>  }
>  
> @@ -144,7 +145,8 @@ bool InsetMathSymbol::takesLimits() const
>  sym_->inset == "cmex" ||
>  sym_->inset == "lyxboldsymb" ||
>  sym_->inset == "esint" ||
> - sym_->extra == "funclim";
> + sym_->extra == "funclim" ||
> + (sym_->inset == "stmry" && sym_->extra == "mathop");
>  }

Richard, OK for branch? This is about LyX display only btw, document 
input/output is correct and not changed.


Georg

Changing trac defaults

[Scott Kostyshak]

I am curious what others think of two changes to defaults for
reporting a new bug:

1. milestone. Currently it defaults to 2.1.4. I propose to have it
default to blank.
- Georg proposed a way of dealing with milestones a couple of months
(?) ago that made sense. Part of what I remember is: don't assign
milestones unless there is a reason to.

2. version. Currently it defaults to 2.1.3. I propose to have it
default to blank.
- I prefer to have the user choose the version. Otherwise they might
just have skipped choosing it or did not want or know how to find the
version they are using.

Scott

Re: Changing trac defaults

[Richard Heck]

On 03/16/2015 07:43 PM, Scott Kostyshak wrote:

I am curious what others think of two changes to defaults for
reporting a new bug:

1. milestone. Currently it defaults to 2.1.4. I propose to have it
default to blank.
- Georg proposed a way of dealing with milestones a couple of months
(?) ago that made sense. Part of what I remember is: don't assign
milestones unless there is a reason to.


This doesn't seem to be possible, at least from the admin screen. We 
could make it 2.1.x,
though, which would make more sense. It'd also be easy to search for 
those and triage

them.


2. version. Currently it defaults to 2.1.3. I propose to have it
default to blank.
- I prefer to have the user choose the version. Otherwise they might
just have skipped choosing it or did not want or know how to find the
version they are using.


Same issue. If there has to be a default, then current version makes sense.

If there's some way to have a "blank" default that I'm not seeing, I'm 
not opposed.


Richard