Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Kornel Benko 
Am Montag, 5. Juni 2017 um 03:50:47, schrieb Enrico Forestieri 
> On Sun, Jun 04, 2017 at 01:08:06PM +0200, Guillaume MM wrote:
>
> > Le 04/06/2017 à 02:27, Enrico Forestieri a écrit :
> > > On Sat, Jun 03, 2017 at 11:27:25PM +0200, Guillaume MM wrote:
> > >
> > > > I am wondering since this results in a different vertical spacing.
> > >
> > > No, this will not change the vertical spacing.
> > It actually does, as shown with diffpdf.
>
> I don't see any difference,

Have you used diffpdf?
Here the snapshot of 'diffpdf -a'

> but, if it is so, then the commit corrected
> another bug. If there is no size change between paragraphs, adding
> {\small\par} is gratuitous.
>

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: Commit 52eee8e5 not sent to lyx-cvs because too large?

2017-06-04 Thread Richard Heck 
On 06/04/2017 09:02 PM, Scott Kostyshak wrote:
> Commit 52eee8e5 ("Fix .po files") was not sent to lyx-cvs. I imagine it
> is because the commit is 13MB. I think it is a good decision not to send
> patches that are too large, but it would be nice to receive at least the
> commit message and the stats (which files were changed), and possibly a
> message at the end that says the patch is too large to include.

I'm guessing the SMTP server rejected the message. There's nothing in
the email sending script, so far as I'm aware, that would stop its being
sent. I'm not sure if there's some way to see how big the commit is and
omit the diff in some cases. That'd maybe be a good feature anyway,
since remerges are just annoying in that regard. If someone wants to
look at this, I can provide some pointers.

Richard

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Enrico Forestieri 
On Sun, Jun 04, 2017 at 01:08:06PM +0200, Guillaume MM wrote:

> Le 04/06/2017 à 02:27, Enrico Forestieri a écrit :
> > On Sat, Jun 03, 2017 at 11:27:25PM +0200, Guillaume MM wrote:
> > 
> > > I am wondering since this results in a different vertical spacing.
> > 
> > No, this will not change the vertical spacing.
> It actually does, as shown with diffpdf.

I don't see any difference, but, if it is so, then the commit corrected
another bug. If there is no size change between paragraphs, adding
{\small\par} is gratuitous.

-- 
Enrico

Re: Update: polyglossia in 2.2.3

2017-06-04 Thread Scott Kostyshak 
On Fri, May 26, 2017 at 12:35:09PM +0200, Jürgen Spitzmüller wrote:
> Am Freitag, den 26.05.2017, 12:23 +0200 schrieb N. Andrew Walsh:
> 
> > Or rather, the file will compile with 2.2.2, but not with 2.2.3
> > (giving back the error about deleting a closing bracket as previously
> > described).
> 
> You mean 2.2.3 not 2.3alpha, right? In any case, the file compiles fine
> for me both with recent stable (what will become 2.2.4) and master
> (what will become 2.3.0).
> 
> Could you also post the LaTeX export (to LaTeX (XeTeX)) of this MWE?

Andrew, I just wanted to make sure you saw the above message.

Scott


signature.asc
Description: PGP signature

Commit 52eee8e5 not sent to lyx-cvs because too large?

2017-06-04 Thread Scott Kostyshak 
Commit 52eee8e5 ("Fix .po files") was not sent to lyx-cvs. I imagine it
is because the commit is 13MB. I think it is a good decision not to send
patches that are too large, but it would be nice to receive at least the
commit message and the stats (which files were changed), and possibly a
message at the end that says the patch is too large to include.

Scott


signature.asc
Description: PGP signature

Re: Fix for vertical table border for added column

2017-06-04 Thread Scott Kostyshak 
On Thu, May 25, 2017 at 09:45:52AM -0400, Scott Kostyshak wrote:
> On Wed, May 24, 2017 at 08:07:52AM +0200, racoon wrote:
> 
> > Thanks. Yes, it is still not patched in latest master so I guess it is
> > pending.
> > 
> > Feel free to take a look.
> 
> OK I'll put this on my list of things to look at.

Patch is in at b1ddae05. Your patch fixed #9306 and #10538.

Thanks,

Scott


signature.asc
Description: PGP signature

Re: Copying translations from 2.2.x to master?

2017-06-04 Thread Kornel Benko 
Am Sonntag, 4. Juni 2017 um 10:33:02, schrieb Scott Kostyshak 
> On Sun, Jun 04, 2017 at 12:17:27PM +0200, Kornel Benko wrote:
> 
> > > Unless someone has a different idea, I will replace the Windows
> > > linebreaks with non-Windows linebreaks, update the strings on master,
> > > and try the mergepo.py call above again.
> > 
> > I made a perl-script for this purpose (created and used for commit 52eee8e).
> > Should I add it to repo?
> 
> For the purpose of fixing the linebreaks

This one.

> or merging from branch? Either
> way, yes please commit.

OK.

> Scott

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: Copying translations from 2.2.x to master?

2017-06-04 Thread Scott Kostyshak 
On Sun, Jun 04, 2017 at 12:17:27PM +0200, Kornel Benko wrote:

> > Unless someone has a different idea, I will replace the Windows
> > linebreaks with non-Windows linebreaks, update the strings on master,
> > and try the mergepo.py call above again.
> 
> I made a perl-script for this purpose (created and used for commit 52eee8e).
> Should I add it to repo?

For the purpose of fixing the linebreaks or merging from branch? Either
way, yes please commit.

Scott

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Scott Kostyshak 
On Sun, Jun 04, 2017 at 12:33:10PM +0200, Kornel Benko wrote:

> All of the above pass here now.

+1 All ctests are back to where they were before.

Scott

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Guillaume MM 

Le 04/06/2017 à 02:27, Enrico Forestieri a écrit :

On Sat, Jun 03, 2017 at 11:27:25PM +0200, Guillaume MM wrote:


I am wondering since this results in a different vertical spacing.


No, this will not change the vertical spacing.

It actually does, as shown with diffpdf.

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Kornel Benko 
Am Sonntag, 4. Juni 2017 um 03:15:42, schrieb Enrico Forestieri 
> On Sun, Jun 04, 2017 at 02:17:20AM +0200, Enrico Forestieri wrote:
> 
> > On Sat, Jun 03, 2017 at 05:25:44PM -0400, Scott Kostyshak wrote:
> > 
> > > On Sat, Jun 03, 2017 at 05:26:52PM +0200, Enrico Forestieri wrote:
> > > > commit 55bbd67cde18184082b074f669a6b81cc48257b6
> > > > Author: Enrico Forestieri 
> > > > Date:   Sat Jun 3 17:26:05 2017 +0200
> > > > 
> > > > Fix bugs #10650 and #9598
> > > 
> > > I think this commit broke the following tests:
> > > 
> > > export/doc/de/Additional_dvi (Failed)
> > > export/doc/de/Additional_dvi3_texF (Failed)
> > > export/doc/de/Additional_pdf (Failed)
> > > DEFAULTOUTPUT_export/doc/de/Additional_pdf2 (Failed)
> > > export/doc/de/Additional_pdf3 (Failed)
> > > export/doc/de/Additional_pdf5_texF (Failed)
> > > export/doc/es/Additional_dvi (Failed)
> > > UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_dvi3_texF (Failed)
> > > export/doc/es/Additional_pdf (Failed)
> > > DEFAULTOUTPUT_export/doc/es/Additional_pdf2 (Failed)
> > > export/doc/es/Additional_pdf3 (Failed)
> > > UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_pdf5_texF (Failed)
> > > 
> > > When exporting de/Additional manually to pdflatex, I get the following 
> > > error:
> > > 
> > > ! Paragraph ended before \foreignlanguage  was complete.
> > 
> > Thanks, I'll have a look.
> 
> Please, can you try again?
> 

All of the above pass here now.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: Copying translations from 2.2.x to master?

2017-06-04 Thread Kornel Benko 
Am Samstag, 3. Juni 2017 um 20:07:39, schrieb Scott Kostyshak 
> On Mon, May 29, 2017 at 11:09:55PM -0400, Scott Kostyshak wrote:
> > Uwe,
> > 
> > Do you have time to copy the translations from 2.2.x to master? From
> > what I understand, you've done this in the past.
> > 
> > If Uwe doesn't have time, hopefully someone else can help or can tell me
> > what I should do.
> 
> I think Uwe is very busy. Does anyone else know how to do this? I'm not
> sure what to do.
> 
> I imagine I also need to solve the Windows linebreaks issue [1] before
> proceeding?
> 
> Georg, is your mergepo.py script meant for this purpose? I tested it by
> checking out zh_CN.po and de.po from 2.2.x, putting them in a directory
> ~/Desktop/2.2.x, and running
> 
>   ./mergepo.py ~/Desktop/2.2.x
> 
> But it appears that nothing was updated:
> 
>   Merging /home/scott/Desktop/2.2.x/de.po into ../../po/de.po: Updated 0
>   translations with minimal diff.
> 
>   Merging /home/scott/Desktop/2.2.x/zh_CN.po into ../../po/zh_CN.po:
>   Updated 0 translations with minimal diff.
> 
> Unless someone has a different idea, I will replace the Windows
> linebreaks with non-Windows linebreaks, update the strings on master,
> and try the mergepo.py call above again.

I made a perl-script for this purpose (created and used for commit 52eee8e).
Should I add it to repo?

> Scott

Kornel

signature.asc
Description: This is a digitally signed message part.