Re: [LyX/master] Sort the language nesting mess with polyglossia

[Enrico Forestieri]

On Sun, Oct 08, 2017 at 02:41:03PM -0400, Scott Kostyshak wrote:
> On Sun, Oct 08, 2017 at 12:48:36PM +, Enrico Forestieri wrote:
> 
> > Thanks Scott. I'll have a look when I find some time. This kind of bugs
> > can be very time consuming.
> 
> Thanks, there is no rush and I don't consider this a blocker for 2.3.0.

Please, try the attached patch. This seems to be an issue related to
argument insets only. However, I think the patch should be thoroughly
tested to ensure that it introduces no regression.

-- 
Enrico
diff --git a/src/output_latex.cpp b/src/output_latex.cpp
index e0163ad2fa..02667aae9f 100644
--- a/src/output_latex.cpp
+++ b/src/output_latex.cpp
@@ -882,7 +882,7 @@ void TeXOnePar(Buffer const & buf,
}
// With CJK, the CJK tag has to be closed first (see 
below)
if (runparams.encoding->package() != Encoding::CJK
-   && par_lang != openLanguageName(state)
+   && (par_lang != openLanguageName(state) || 
localswitch)
&& !par_lang.empty()) {
string bc = use_polyglossia ?
  
getPolyglossiaBegin(lang_begin_command, par_lang, 
par_language->polyglossiaOpts())

Re: Another caret ghost (master, qt5)

[Jean-Marc Lasgouttes]

Le 10/10/2017 à 17:58, Kornel Benko a écrit :

I could. There is more:
Selecting subsection and the first line creates small remainder
Selecting section and the first line creates bigger remainder
Selecting title and the first line creates biggest remainder

Seems to depend on the font size of the first selected object?


It does. And if you start in a normal paragraph and select up to a 
title, you will see a ridiculously small blinking cursor.


JMarc

Re: Another caret ghost (master, qt5)

[Jean-Marc Lasgouttes]

Le 10/10/2017 à 17:34, Pavel Sanda a écrit :

Hi JMarc,

this is more cosmetical issue, but there is another instance of old carret
being left painted on previous position, this time in connection with
selection.

1. load introduction manual
2. select the text via mouse; start selecting on top of the screen and continue 
to the first paragraph
3. as you reach first line of the paragraph continue horizontally to the end of 
the line
4. you should see the remainder of old caret position on top and bottom of the 
line
The problem is that the hight of cursor depends on cursor 
real_current_font value, and this value is not reset properly when using 
mouse to select. So the size of the cursor is the size it had when 
starting selection. This bug has probably been here forever, also it doe 
snot cause caret droppings.


The attached patch cures the issue for the case of mouse selection.

However, the problem also exists when selecting with keyboard. I have to 
understand how to fix it without analysing 50 code paths.


JMarc
diff --git a/src/Text3.cpp b/src/Text3.cpp
index f6930aa..5b6e438 100644
--- a/src/Text3.cpp
+++ b/src/Text3.cpp
@@ -1713,6 +1713,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
 		// reset the anchor.
 		bvcur.setCursor(cur);
 		bvcur.selection(true);
+		bvcur.setCurrentFont();
 		if (cur.top() == old) {
 			// We didn't move one iota, so no need to update the screen.
 			cur.screenUpdateFlags(Update::SinglePar | Update::FitCursor);

Re: Another caret ghost (master, qt5)

[Kornel Benko]

Am Dienstag, 10. Oktober 2017 um 17:34:40, schrieb Pavel Sanda 
> Hi JMarc, 
> 
> this is more cosmetical issue, but there is another instance of old carret
> being left painted on previous position, this time in connection with
> selection.
> 
> 1. load introduction manual
> 2. select the text via mouse; start selecting on top of the screen and 
> continue to the first paragraph
> 3. as you reach first line of the paragraph continue horizontally to the end 
> of the line
> 4. you should see the remainder of old caret position on top and bottom of 
> the line
> 
> Can you reproduce?
> Pavel

I could. There is more:
Selecting subsection and the first line creates small remainder
Selecting section and the first line creates bigger remainder
Selecting title and the first line creates biggest remainder

Seems to depend on the font size of the first selected object?

Kornel

signature.asc
Description: This is a digitally signed message part.

Another caret ghost (master, qt5)

[Pavel Sanda]

Hi JMarc, 

this is more cosmetical issue, but there is another instance of old carret
being left painted on previous position, this time in connection with
selection.

1. load introduction manual
2. select the text via mouse; start selecting on top of the screen and continue 
to the first paragraph
3. as you reach first line of the paragraph continue horizontally to the end of 
the line
4. you should see the remainder of old caret position on top and bottom of the 
line

Can you reproduce?
Pavel

Re: additional manual - link correction for elyxer

[Pavel Sanda]

Guenter Milde wrote:
> How can we get this as default entries with configure.py?

Two steps:
1. Rename current HTML format to 'HTML (elyxer)' and setting
   converter appropriately.
2. Rename LyXHTML to HTML.

I am not sure we would get enough support for this, as I understood
Uwe still want to use elyxer as the primary html target.

Pavel

Re: additional manual - link correction for elyxer

[Pavel Sanda]

Guenter Milde wrote:
> On 2017-10-08, Pavel Sanda wrote:
> > Uwe Stöhr wrote:
> >> Yes. Our HTML export is still not usable. I opened some bug reports:
> >> http://www.lyx.org/trac/query?status=accepted=assigned=new=reopened=~html=~uwestoehr=id=summary=reporter=status=type=severity=keywords=reporter
> 
> > I see. So we will wait for a little more until elyxer chokes completely ;)
> 
> Why not fix the native HTML export *before* elyxer chokes completely?

Manpower problem I guess. If you were willing to spent time fixing the issues
mentioned by Uwe everyone would be happy :)

Pavel