Re: [LyX/master] Fixup 7f1b1729: restore lazy caret handling
On Sun, Jun 25, 2023 at 12:43:52PM +0200, Kornel Benko wrote: > Am Sun, 25 Jun 2023 06:18:26 -0400 > schrieb Scott Kostyshak : > > > > It is the opposite: my eyes are overly sensitive. I suggest you ignore the > > issue :). If > > you still want to see it, it occurs just at the beginning of the 6th second > > (maybe the > > end of the 5th?). Here is a screenshot. There is a faint black line where > > the cursor > > is, but that line shouldn't be there since actually this is when the cursor > > blinked off. > > > > Scott > > OK, so I saw it now too. Good eyes. My main motivation is to annoy JMarc with issues that no one else notices :) Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fixup 7f1b1729: restore lazy caret handling
Am Sun, 25 Jun 2023 06:18:26 -0400 schrieb Scott Kostyshak : > On Sun, Jun 25, 2023 at 12:12:23PM +0200, Kornel Benko wrote: > > Am Sun, 25 Jun 2023 05:36:33 -0400 > > schrieb Scott Kostyshak : > > > > > On Sun, Jun 25, 2023 at 11:28:18AM +0200, Kornel Benko wrote: > > > > Am Sun, 25 Jun 2023 04:54:01 -0400 > > > > schrieb Scott Kostyshak : > > > > > > > > > On Thu, May 11, 2023 at 09:06:10AM +0200, Jean-Marc Lasgouttes wrote: > > > > > > > > > > > > > > > > > commit 6fbc8c6352a965231a35ee8b052e3a6b80b5ce57 > > > > > > Author: Jean-Marc Lasgouttes > > > > > > Date: Wed May 3 12:55:44 2023 +0200 > > > > > > > > > > > > Fixup 7f1b1729: restore lazy caret handling > > > > > > > > > > > > For some reason, the code that should have been put in > > > > > > updateCaretGeometry() went to resetCaret(). I do not see how > > > > > > that made > > > > > > sense. > > > > > > > > > > > > I am not totally sure what the consequences of the patch are, > > > > > > though. > > > > > > It just "looks right". > > > > > > --- > > > > > > > > > > Small regression: > > > > > > > > > > 1. Open the attached cursor-example.23.lyx. > > > > > 2. Put the cursor inside the chunk at the beginning of the line with > > > > > " #hello". > > > > > 3. Press , then . > > > > > > > > > > Result: the cursor leaves some painted part behind on its first > > > > > blink. You have > > > > > to look very carefully to see it. > > > > > > > > > > Can anyone reproduce? > > > > > > > > > > Scott > > > > > > > > I do not see it. Neither with lyx2.3 nor with lyx2.4. > > > > > > Thanks for trying to reproduce. Here is a screencast of what I see: > > > > > > https://www.dropbox.com/s/2jid0kfmgqp3n9q/screencast-LQ-911498.ogv?dl=0 > > > > > > Note that it is very subtle and only occurs for the first blink. > > > > > > Scott > > > > I am probably blind ... I cannot see it even on the provided screencast. > > It is the opposite: my eyes are overly sensitive. I suggest you ignore the > issue :). If > you still want to see it, it occurs just at the beginning of the 6th second > (maybe the > end of the 5th?). Here is a screenshot. There is a faint black line where the > cursor > is, but that line shouldn't be there since actually this is when the cursor > blinked off. > > Scott OK, so I saw it now too. Good eyes. Kornel pgpybO8Yno6Ld.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fixup 7f1b1729: restore lazy caret handling
On Sun, Jun 25, 2023 at 12:12:23PM +0200, Kornel Benko wrote: > Am Sun, 25 Jun 2023 05:36:33 -0400 > schrieb Scott Kostyshak : > > > On Sun, Jun 25, 2023 at 11:28:18AM +0200, Kornel Benko wrote: > > > Am Sun, 25 Jun 2023 04:54:01 -0400 > > > schrieb Scott Kostyshak : > > > > > > > On Thu, May 11, 2023 at 09:06:10AM +0200, Jean-Marc Lasgouttes wrote: > > > > > > > > > > commit 6fbc8c6352a965231a35ee8b052e3a6b80b5ce57 > > > > > Author: Jean-Marc Lasgouttes > > > > > Date: Wed May 3 12:55:44 2023 +0200 > > > > > > > > > > Fixup 7f1b1729: restore lazy caret handling > > > > > > > > > > For some reason, the code that should have been put in > > > > > updateCaretGeometry() went to resetCaret(). I do not see how that > > > > > made > > > > > sense. > > > > > > > > > > I am not totally sure what the consequences of the patch are, > > > > > though. > > > > > It just "looks right". > > > > > --- > > > > > > > > Small regression: > > > > > > > > 1. Open the attached cursor-example.23.lyx. > > > > 2. Put the cursor inside the chunk at the beginning of the line with " > > > > #hello". > > > > 3. Press , then . > > > > > > > > Result: the cursor leaves some painted part behind on its first blink. > > > > You have to > > > > look very carefully to see it. > > > > > > > > Can anyone reproduce? > > > > > > > > Scott > > > > > > I do not see it. Neither with lyx2.3 nor with lyx2.4. > > > > Thanks for trying to reproduce. Here is a screencast of what I see: > > > > https://www.dropbox.com/s/2jid0kfmgqp3n9q/screencast-LQ-911498.ogv?dl=0 > > > > Note that it is very subtle and only occurs for the first blink. > > > > Scott > > I am probably blind ... I cannot see it even on the provided screencast. It is the opposite: my eyes are overly sensitive. I suggest you ignore the issue :). If you still want to see it, it occurs just at the beginning of the 6th second (maybe the end of the 5th?). Here is a screenshot. There is a faint black line where the cursor is, but that line shouldn't be there since actually this is when the cursor blinked off. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fixup 7f1b1729: restore lazy caret handling
Am Sun, 25 Jun 2023 05:36:33 -0400 schrieb Scott Kostyshak : > On Sun, Jun 25, 2023 at 11:28:18AM +0200, Kornel Benko wrote: > > Am Sun, 25 Jun 2023 04:54:01 -0400 > > schrieb Scott Kostyshak : > > > > > On Thu, May 11, 2023 at 09:06:10AM +0200, Jean-Marc Lasgouttes wrote: > > > > > > > > commit 6fbc8c6352a965231a35ee8b052e3a6b80b5ce57 > > > > Author: Jean-Marc Lasgouttes > > > > Date: Wed May 3 12:55:44 2023 +0200 > > > > > > > > Fixup 7f1b1729: restore lazy caret handling > > > > > > > > For some reason, the code that should have been put in > > > > updateCaretGeometry() went to resetCaret(). I do not see how that > > > > made > > > > sense. > > > > > > > > I am not totally sure what the consequences of the patch are, > > > > though. > > > > It just "looks right". > > > > --- > > > > > > Small regression: > > > > > > 1. Open the attached cursor-example.23.lyx. > > > 2. Put the cursor inside the chunk at the beginning of the line with " > > > #hello". > > > 3. Press , then . > > > > > > Result: the cursor leaves some painted part behind on its first blink. > > > You have to > > > look very carefully to see it. > > > > > > Can anyone reproduce? > > > > > > Scott > > > > I do not see it. Neither with lyx2.3 nor with lyx2.4. > > Thanks for trying to reproduce. Here is a screencast of what I see: > > https://www.dropbox.com/s/2jid0kfmgqp3n9q/screencast-LQ-911498.ogv?dl=0 > > Note that it is very subtle and only occurs for the first blink. > > Scott I am probably blind ... I cannot see it even on the provided screencast. Kornel pgp9dXVUEBlLW.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fixup 7f1b1729: restore lazy caret handling
On Sun, Jun 25, 2023 at 11:28:18AM +0200, Kornel Benko wrote: > Am Sun, 25 Jun 2023 04:54:01 -0400 > schrieb Scott Kostyshak : > > > On Thu, May 11, 2023 at 09:06:10AM +0200, Jean-Marc Lasgouttes wrote: > > > > > > commit 6fbc8c6352a965231a35ee8b052e3a6b80b5ce57 > > > Author: Jean-Marc Lasgouttes > > > Date: Wed May 3 12:55:44 2023 +0200 > > > > > > Fixup 7f1b1729: restore lazy caret handling > > > > > > For some reason, the code that should have been put in > > > updateCaretGeometry() went to resetCaret(). I do not see how that made > > > sense. > > > > > > I am not totally sure what the consequences of the patch are, though. > > > It just "looks right". > > > --- > > > > Small regression: > > > > 1. Open the attached cursor-example.23.lyx. > > 2. Put the cursor inside the chunk at the beginning of the line with " > > #hello". > > 3. Press , then . > > > > Result: the cursor leaves some painted part behind on its first blink. You > > have to look > > very carefully to see it. > > > > Can anyone reproduce? > > > > Scott > > I do not see it. Neither with lyx2.3 nor with lyx2.4. Thanks for trying to reproduce. Here is a screencast of what I see: https://www.dropbox.com/s/2jid0kfmgqp3n9q/screencast-LQ-911498.ogv?dl=0 Note that it is very subtle and only occurs for the first blink. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fixup 7f1b1729: restore lazy caret handling
Am Sun, 25 Jun 2023 04:54:01 -0400 schrieb Scott Kostyshak : > On Thu, May 11, 2023 at 09:06:10AM +0200, Jean-Marc Lasgouttes wrote: > > > > commit 6fbc8c6352a965231a35ee8b052e3a6b80b5ce57 > > Author: Jean-Marc Lasgouttes > > Date: Wed May 3 12:55:44 2023 +0200 > > > > Fixup 7f1b1729: restore lazy caret handling > > > > For some reason, the code that should have been put in > > updateCaretGeometry() went to resetCaret(). I do not see how that made > > sense. > > > > I am not totally sure what the consequences of the patch are, though. > > It just "looks right". > > --- > > Small regression: > > 1. Open the attached cursor-example.23.lyx. > 2. Put the cursor inside the chunk at the beginning of the line with " > #hello". > 3. Press , then . > > Result: the cursor leaves some painted part behind on its first blink. You > have to look > very carefully to see it. > > Can anyone reproduce? > > Scott I do not see it. Neither with lyx2.3 nor with lyx2.4. Kornel pgptI8lg6bkce.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fixup 7f1b1729: restore lazy caret handling
On Thu, May 11, 2023 at 09:06:10AM +0200, Jean-Marc Lasgouttes wrote: > > commit 6fbc8c6352a965231a35ee8b052e3a6b80b5ce57 > Author: Jean-Marc Lasgouttes > Date: Wed May 3 12:55:44 2023 +0200 > > Fixup 7f1b1729: restore lazy caret handling > > For some reason, the code that should have been put in > updateCaretGeometry() went to resetCaret(). I do not see how that made > sense. > > I am not totally sure what the consequences of the patch are, though. > It just "looks right". > --- Small regression: 1. Open the attached cursor-example.23.lyx. 2. Put the cursor inside the chunk at the beginning of the line with " #hello". 3. Press , then . Result: the cursor leaves some painted part behind on its first blink. You have to look very carefully to see it. Can anyone reproduce? Scott cursor-example.23.lyx Description: application/lyx signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
