Re: Breakdown of remaining 2.4 bugs
On 7/27/23 10:13, Pavel Sanda wrote: I think it's time for the breakdown of remaining bugs which hinder us from 2.4 release. Thanks, Pavel, for taking the initiative here. I was going to write separately about format freeze. Is there anything anyone really wants to get in before we do that? I'd like to add the BufferParam needed for #10049 even though I don't have the code ready to use it---and even if I did, it would need a lot of testing. But that would allow us to fix the bug during the 2.4 series, and it's a really annoying one that keeps biting me. Yuriy/Riki? #12814 - nesting in Outliner; there is a patch, but needs either clarification or review I've posted a comment there. I think the patch is right. Juergen/Enrico? #12831 - Udi proposes changing order how we output LaTeX font options. Has a patch which looks legit to me, but I would like someone to look over and give +1 It looks sensible to me, but I don't know that stuff well. * Enhacements, easy to retarget Riki? #11822 - Counters/ PrettyFormat; accept / retarget? Fixed. #12577 - complex code to improve source editor within LyX; only JMarc tried to understand and failed; anyone wants to engage? This is too big for 2.4.0. I've retargeted to 2.4.1. But I'm not really sure about it. I'll have a look at it between now and then. We need to freeze, then remerge strings and notify translators. I can handle the review of layouttranslation for 2.4. Riki, do you have preference when to proceed? Before RC release or after? Remerge should be committed by you, otherwise we'll spend megabytes in large commits due to different outputs of different polib versions (tested). What did we do last time? Scott, do you remember? I guess my instinct would be to get translations into RC1, since that's one thing we'd want to have checked. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: \S
On 7/27/23 17:00, Enrico Forestieri wrote: On Thu, Jul 27, 2023 at 01:27:09AM -0400, Richard Kimberly Heck wrote: This is really a special case, so I'm inclined just to handle it as one via the attached hack-ish patch. But maybe someone else knows how to fix Encodings::fromLaTeXCommand? It has been a long time and I don't remember anymore the details. However, for such a special case I do not recommend touching that method and your alternative approach is preferable, IMHO. Committed. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Joining newlines in paste (was: Pasting latex in a lyx file)
On 7/27/23 12:07, Pavel Sanda wrote: On Thu, Apr 22, 2021 at 12:38:32PM -0400, Scott Kostyshak wrote: On Tue, Apr 20, 2021 at 12:15:56AM +0200, Dr Eberhard W Lisse wrote: On 2021-04-19 14:47 , Christoph Schmitz wrote: Am 19.04.2021 um 14:43 schrieb Daniel : On 10/4/21 16:07, Mario D wrote: Paul, Ctrl+Shift+V works just fine for me, thanks! My fault, and I beg your pardon for this, for not having tried the relative option in "Edit -> Paste Special" : I just tried the "Paste from LaTeX", which doesn't work in my case (I am pasting tikz figures, so @rich: I was referring to the second option). Thank you everybody. :) Actually, I am wondering whether preserving newlines should be the default. I don't think one can expect that the default paste command changes the format that way. Instead the "special" option should be paste with removing newlines, I think. -- Daniel [...] I want to second this proposal! I do not know how much work it would be to create a new setting, which would allow users to use whatever method they prefer. If I have to chose between the two options, Daniel's proposal is my preference. Chris Me three :-)-O I also get confused by this and I think new LyX users are especially confused. I also vote for considering a change of the default behavior. Dear all, this is one of my last items on the TODO list for the 2.4 release. Bunch of people expressed their opinion that our default for paste operation should preserve newlines. I do not have strong opinion but agree that in my experience I have to go to Paste Special sub menu quite often to preserve the newlines. Before looking what would need change, is there reasonable unanimous agreement that this should be the default or are there folks who prefer current behaviour which joins the lines by default? I agree that the default should be to preserve newlines. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Display equation/theorem numbers in insert cross reference dialog.
On 7/27/23 04:21, José Matos wrote: On Wed, 2023-07-26 at 18:22 +0200, Richard Kimberly Heck wrote: Display equation/theorem numbers in insert cross reference dialog. Fixes bug #11466, This is nice but eventually it could be improved further. My use case is the following, I am using the module "Standard Theorems", in the document I am using Propositions. In the cross-references menu I get, for example, eq:three-terms | Equation 2 prop:orth-mult | 3 (Theorem counter) ideally the last entry should be "Proposition 3". There's a similar problem with item counters that I've asked the author to try to solve. Probably that will solve this problem too. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: \S
On Thu, Jul 27, 2023 at 01:27:09AM -0400, Richard Kimberly Heck wrote: This is really a special case, so I'm inclined just to handle it as one via the attached hack-ish patch. But maybe someone else knows how to fix Encodings::fromLaTeXCommand? It has been a long time and I don't remember anymore the details. However, for such a special case I do not recommend touching that method and your alternative approach is preferable, IMHO. -- Enrico -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Breakdown of remaining 2.4 bugs
On Thu, Jul 27, 2023 at 09:54:41PM +0200, Enrico Forestieri wrote: > >#12842 - UTF-8 in math label; patch from Koji needs review > > In its current form the patch is incomplete and produces wrong output. I'll > have a look when time permits. Thanks Enrico. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Breakdown of remaining 2.4 bugs
On Thu, Jul 27, 2023 at 04:13:37PM +0200, Pavel Sanda wrote: Juergen/Enrico? #12831 - Udi proposes changing order how we output LaTeX font options. Has a patch which looks legit to me, but I would like someone to look over and give +1 I am leaving this to Jürgen. #12842 - UTF-8 in math label; patch from Koji needs review In its current form the patch is incomplete and produces wrong output. I'll have a look when time permits. -- Enrico -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Breakdown of remaining 2.4 bugs
On Thu, Jul 27, 2023 at 06:38:30PM +0200, Jean-Marc Lasgouttes wrote: > If reverting the patch solves the issue, do that. Anyway it was partialbaked > solution to another bug (#10468) I did not really understand either :) I can confirm that reverting solves the issue. For now I'll revert and reopen #10468 - still bug but not 2.4 blocker. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Joining newlines in paste (was: Pasting latex in a lyx file)
On Thu, Jul 27, 2023 at 06:07:30PM +0200, Pavel Sanda wrote:
> current behaviour which joins the lines by default?
As it turns out, the current behaviour is more subtle:
the newlines are actually preserved for some layouts
(those having parbreakIsNewline set to 1).
The patch for newline preservation by default is trivial
(see attachment). Let's wait for the feedback now.
Pavel
diff --git a/src/Text.cpp b/src/Text.cpp
index 9dff2b37ab..9e5bf5ff75 100644
--- a/src/Text.cpp
+++ b/src/Text.cpp
@@ -4891,8 +4891,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
if (theClipboard().isInternal())
pasteFromStack(cur,
bv->buffer().errorList("Paste"), 0);
else if (theClipboard().hasTextContents()) {
- if (pasteClipboardText(cur,
bv->buffer().errorList("Paste"),
-
!cur.paragraph().parbreakIsNewline(),
+ if (pasteClipboardText(cur,
bv->buffer().errorList("Paste"), 0,
Clipboard::AnyTextType))
tryGraphics = false;
}
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Breakdown of remaining 2.4 bugs
Le 27/07/2023 à 16:13, Pavel Sanda a écrit : *Normal bugs JMarc is unf gone for quite some time, anyone willing to look? #12841 - regression with math selection I am still here for 10 minutes :) For the record, I spend some time trying to understand the code and failed. I trust Enrico's analysis the my patch a9c6fb0c is the culprit (did not try to revert it), but I fail to see why. If reverting the patch solves the issue, do that. Anyway it was partialbaked solution to another bug (#10468) I did not really understand either :) However I remember that at the time I was confident that the patch made sense. It may be that it interferes with assumptions in other parts of the code. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Joining newlines in paste (was: Pasting latex in a lyx file)
Le 27/07/2023 à 18:07, Pavel Sanda a écrit : Bunch of people expressed their opinion that our default for paste operation should preserve newlines. I do not have strong opinion but agree that in my experience I have to go to Paste Special sub menu quite often to preserve the newlines. Before looking what would need change, is there reasonable unanimous agreement that this should be the default or are there folks who prefer current behaviour which joins the lines by default? I do not care much, but I am OK with the change. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Joining newlines in paste (was: Pasting latex in a lyx file)
On Thu, Apr 22, 2021 at 12:38:32PM -0400, Scott Kostyshak wrote: > On Tue, Apr 20, 2021 at 12:15:56AM +0200, Dr Eberhard W Lisse wrote: > > On 2021-04-19 14:47 , Christoph Schmitz wrote: > > >> Am 19.04.2021 um 14:43 schrieb Daniel : > > >> > > >> On 10/4/21 16:07, Mario D wrote: > > >>> Paul, > > >>> Ctrl+Shift+V works just fine for me, thanks! > > >>> My fault, and I beg your pardon for this, for not having tried the > > >>> relative option in "Edit -> Paste Special" : I just tried the "Paste > > >>> from LaTeX", which doesn't work in my case (I am pasting tikz > > >>> figures, so @rich: I was referring to the second option). Thank you > > >>> everybody. :) > > >> > > >> Actually, I am wondering whether preserving newlines should be the > > >> default. I don't think one can expect that the default paste command > > >> changes the format that way. Instead the "special" option should be > > >> paste with removing newlines, I think. > > >> -- > > >> Daniel > > [...] > > > > > > I want to second this proposal! > > > > > > I do not know how much work it would be to create a new setting, which > > > would allow users to use whatever method they prefer. If I have to > > > chose between the two options, Daniel's proposal is my preference. > > > > > > Chris > > > > > Me three :-)-O > > I also get confused by this and I think new LyX users are especially confused. > I also vote for considering a change of the default behavior. Dear all, this is one of my last items on the TODO list for the 2.4 release. Bunch of people expressed their opinion that our default for paste operation should preserve newlines. I do not have strong opinion but agree that in my experience I have to go to Paste Special sub menu quite often to preserve the newlines. Before looking what would need change, is there reasonable unanimous agreement that this should be the default or are there folks who prefer current behaviour which joins the lines by default? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Breakdown of remaining 2.4 bugs
Hi all, I think it's time for the breakdown of remaining bugs which hinder us from 2.4 release. I might have been somewhat obnoxious to some of you in the trac during the past week(s) (sorry for that), but the good news is that we got to less than 20 bugs on our 2.4.0 radar! I see only two major bugs (both in Mac world), and 1 regression left. The rest would be nice if anyone of you have time to look in the next days, but most can be retargeted. * Mac bugs: #12576 - major, but close to be solved by Stephan #12279, #12820, #12418 - all point to probably the same issue; major, but it's the same with 2.3.x; we have no clue and manpower ATM #12641 - major, but can be avoided by releasing with Qt5 #11921 - cosmetics, request to change default font, no input from Stephan yet #12001 - cosmetics, request for modal font, no input from Stephan yet #11765 - cosmetics, we can just change binding, waiting for Stepahn input *Normal bugs JMarc is unf gone for quite some time, anyone willing to look? #12841 - regression with math selection Juergen? #12779 - "Search as you type" issue; the original report is imho borderline invalid, but the additional report in comment 2 looks like real issue Yuriy/Riki? #12814 - nesting in Outliner; there is a patch, but needs either clarification or review Juergen/Enrico? #12831 - Udi proposes changing order how we output LaTeX font options. Has a patch which looks legit to me, but I would like someone to look over and give +1 #12842 - UTF-8 in math label; patch from Koji needs review * Cosmetics, we can retarget #12214 - docking/painting of search dialog; not essential we have worse issues with widgets #12776 - cosmetics - needs someone with Qt6 on linux to reproduce. Anyone at least to reproduce? * Enhacements, easy to retarget Riki? #11822 - Counters/ PrettyFormat; accept / retarget? #12577 - complex code to improve source editor within LyX; only JMarc tried to understand and failed; anyone wants to engage? #12713 - non-linear zoom-slider. Other opinions whether we need it? Someone to check the code? Apart from this we need strings freeze and translators to start working. I see only two bugs left which might want to touch the strings: #11765, #12577 both non-essential. We need to freeze, then remerge strings and notify translators. I can handle the review of layouttranslation for 2.4. Riki, do you have preference when to proceed? Before RC release or after? Remerge should be committed by you, otherwise we'll spend megabytes in large commits due to different outputs of different polib versions (tested). Cheers! Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Display equation/theorem numbers in insert cross reference dialog.
On Wed, 2023-07-26 at 18:22 +0200, Richard Kimberly Heck wrote: > Display equation/theorem numbers in insert cross reference > dialog. > > Fixes bug #11466, This is nice but eventually it could be improved further. My use case is the following, I am using the module "Standard Theorems", in the document I am using Propositions. In the cross-references menu I get, for example, eq:three-terms | Equation 2 prop:orth-mult | 3 (Theorem counter) ideally the last entry should be "Proposition 3". Thanks to the author of the patch and to Riki for applying it. Best regards, -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
