Re: [LyX/master] Remove hebrew letter document class

2024-06-11 Thread jspitzm
Am Dienstag, dem 11.06.2024 um 18:15 + schrieb Udi Fogiel:
> commit 3854086e59db47a38f61ae94b08c5bc9e207767a
> Author: Udi Fogiel 
> Date:   Tue Jun 11 21:14:27 2024 +0300
> 
>     Remove hebrew letter document class
>     
>     The only difference from regular letter is the alignment of
>     "Send To Address" layout, but it no longer reflect the output
>     corrctly, probably because LyX revert the alignment of layouts
>     in RTL context now.

I don't think we want to remove layouts. This breaks old documents.
Rather than that, mark it as obsolete, please.

Jürgen




signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/2.4.1-devel] Defer construction of temporary cursor.

2024-04-21 Thread jspitzm
Am Dienstag, dem 16.04.2024 um 16:40 + schrieb Richard Kimberly
Heck:
> commit 365ff71e2319673c2685be79963443fee13c333b
> Author: Richard Kimberly Heck
> Date:   Tue Apr 16 12:15:50 2024 -0400
> 
>     Defer construction of temporary cursor.

Doesn't this (and also the biginsets backports that happened) deserve
status.24 entries?

Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX 2.4.0 RC3

2024-04-19 Thread jspitzm
Am Freitag, dem 19.04.2024 um 17:11 +0200 schrieb jspi...@gmail.com:
> I am currently traveling, so I cannot test. But does the attached
> patch help and provide a sufficient clues?

Take this. The first one didn't link.

Jürgen

diff --git a/src/LaTeXPackages.cpp b/src/LaTeXPackages.cpp
index e708df1dfe..d2f2c4c71b 100644
--- a/src/LaTeXPackages.cpp
+++ b/src/LaTeXPackages.cpp
@@ -35,7 +35,7 @@ namespace lyx {
 LaTeXPackages::Packages LaTeXPackages::packages_;
 
 
-void LaTeXPackages::getAvailable()
+void LaTeXPackages::getAvailable(bool retry)
 {
 	Lexer lex;
 	support::FileName const real_file = libFileSearch("", "packages.lst");
@@ -73,10 +73,17 @@ void LaTeXPackages::getAvailable()
 		}
 	}
 	// Check if the pkglist has current format.
-	// Reconfigure and re-parse if not.
+	// Reconfigure once and re-parse if not.
+	// If we have already reconfigured, give a warning and stop.
 	if (lstformat != "2") {
-		package().reconfigureUserLyXDir("");
-		getAvailable();
+		if (retry) {
+			LYXERR0("ERROR: Invalid package list format!\n"
+			"Please make sure there is no outdated configure.py file in your user directory");
+			return;
+		} else {
+			package().reconfigureUserLyXDir("");
+			getAvailable(true);
+		}
 	}
 }
 
diff --git a/src/LaTeXPackages.h b/src/LaTeXPackages.h
index dba6d039f6..12f3e4ec0b 100644
--- a/src/LaTeXPackages.h
+++ b/src/LaTeXPackages.h
@@ -25,7 +25,7 @@ namespace lyx {
 class LaTeXPackages {
 public:
 	/// Which of the required packages are installed?
-	static void getAvailable();
+	static void getAvailable(bool retry = false);
 	/// Is the (required) package available?
 	static bool isAvailable(std::string const & name);
 	/// Is the (required) package available at least as of
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX 2.4.0 RC3

2024-04-19 Thread jspitzm
Am Freitag, dem 19.04.2024 um 13:22 +0200 schrieb Stephan Witt:
> Now I got a clue how it happens.
> 
> In LaTeXPackages::getAvailable() is a recursion implemented and in
> our case it happens to be endless.
> 
> The reconfigure fails at first and in getAvailable() it is retried
> but fails again (and again and again).

I am currently traveling, so I cannot test. But does the attached patch
help and provide a sufficient clues?

Best,
Jürgen

diff --git a/src/LaTeXPackages.cpp b/src/LaTeXPackages.cpp
index e708df1dfe..7d38a87511 100644
--- a/src/LaTeXPackages.cpp
+++ b/src/LaTeXPackages.cpp
@@ -35,7 +35,7 @@ namespace lyx {
 LaTeXPackages::Packages LaTeXPackages::packages_;
 
 
-void LaTeXPackages::getAvailable()
+void LaTeXPackages::getAvailable(bool const retry)
 {
 	Lexer lex;
 	support::FileName const real_file = libFileSearch("", "packages.lst");
@@ -75,8 +75,14 @@ void LaTeXPackages::getAvailable()
 	// Check if the pkglist has current format.
 	// Reconfigure and re-parse if not.
 	if (lstformat != "2") {
-		package().reconfigureUserLyXDir("");
-		getAvailable();
+		if (retry) {
+			LYXERR0("ERROR: Invalid package list format!\n"
+			"Please make sure there is no outdated configure.py file in your user directory");
+			return;
+		} else {
+			package().reconfigureUserLyXDir("");
+			getAvailable(true);
+		}
 	}
 }
 
diff --git a/src/LaTeXPackages.h b/src/LaTeXPackages.h
index dba6d039f6..e3acb3371b 100644
--- a/src/LaTeXPackages.h
+++ b/src/LaTeXPackages.h
@@ -25,7 +25,7 @@ namespace lyx {
 class LaTeXPackages {
 public:
 	/// Which of the required packages are installed?
-	static void getAvailable();
+	static void getAvailable(bool const retry = false);
 	/// Is the (required) package available?
 	static bool isAvailable(std::string const & name);
 	/// Is the (required) package available at least as of
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Copy files to tmp

2024-03-19 Thread jspitzm
Am Montag, dem 18.03.2024 um 18:26 -0400 schrieb Richard Kimberly Heck:
> On 3/18/24 13:01, Jürgen Spitzmüller wrote:
> > I am trying to set up a private external template for the inclusion
> > of
> > sound files to beamer slides. Could somebody please remind me what
> > needs to be done to get those files (e.g., mp3's) copied to the tmp
> > with their mangled file name?
> 
> I think this is done in the validation routine, by calling 
> features.includeFile().

Thanks, this does not seem to be related to external material, AFAICS.
However, what would help me is a new placeholder, $$OrigAbsName, that
outputs the absolute path to the original filename (see attached). I
know that documenting this for 2.4 is too late, but would you be OK if
I submitted this as a hidden feature and document later?

Jürgen
diff --git a/src/insets/ExternalSupport.cpp b/src/insets/ExternalSupport.cpp
index 33c14d38be..5893a5d454 100644
--- a/src/insets/ExternalSupport.cpp
+++ b/src/insets/ExternalSupport.cpp
@@ -106,8 +106,10 @@ string const doSubstitution(InsetExternalParams const & params,
 		params.filename.mangledFileName() :
 		params.filename.outputFileName(parentpath);
 	string const basename = changeExtension(
-			onlyFileName(filename), string());
+		onlyFileName(filename), string());
 	string const absname = makeAbsPath(filename, parentpath).absFileName();
+	string const origabsname = makeAbsPath(params.filename.outputFileName(parentpath),
+	   parentpath).absFileName();
 
 	if (what != ALL_BUT_PATHS) {
 		string const filepath = onlyPath(filename);
@@ -136,6 +138,10 @@ string const doSubstitution(InsetExternalParams const & params,
 use_latex_path,
 PROTECT_EXTENSION,
 ESCAPE_DOTS);
+		result = subst_path(result, "$$OrigAbsName", origabsname,
+use_latex_path,
+PROTECT_EXTENSION,
+ESCAPE_DOTS);
 		result = subst_path(result, "$$RelPathMaster",
 relToMasterPath, use_latex_path,
 PROTECT_EXTENSION,
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.4.0 plan for #12215 [LyX crashes with async processes (Qt6 only)] ?

2022-11-23 Thread jspitzm
Am Dienstag, dem 22.11.2022 um 22:13 -0500 schrieb Richard Kimberly
Heck:
> Here's the program to check:
> 
> #define _GLIBCXX_DEBUG 1
> #include 
> 
> int main()
> {
>    std::unordered_set::iterator it{};
>    it == it;
> }
> 
> That's what was crashing in GCC.

Does not crash for me.

> 
> I did notice, too, though in the Qt report that it says:
> 
> 
> In general, from the LyX bug report, it looks like they're building
> LyX 
> but not Qt with debug iterators enabled.
> 
> That is a bad idea. libstdc++ debug mode breaks ABI. I don't think we
> ever return any QMap in Qt across its library boundary, but if we
> did, they couldn't use it.
> 
> If you want to turn on debug mode globally, you need to rebuild any
> 3rd 
> party dependency with it. Of course there are the containers in the 
> debug namespace, but I haven't found a good solution to use them at 
> large in a project. I've tried to isolate them in a local namespace,
> but 
> people won't use MyNS::vector (which is either std::vector or 
> stddebug::vector), they'll just use std::vector.
> 
> 
> So, maybe the problem is very specific to --enable-stdlib-debug and
> has to do with the way we use external libraries.

I hope this is not the answer, and I don't need to compile qt myself in
order to use stdlib-debug.

Jürgen

> 
> Riki

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.7 release

2022-11-15 Thread jspitzm
Am Dienstag, dem 15.11.2022 um 13:56 -0500 schrieb Richard Kimberly
Heck:
> OK, I'll find some time to go through the tickets on trac and see
> what might be included.

Please let me know if you need help identifying them.

Thanks,
Jürgen

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Missing icons

2022-08-08 Thread jspitzm
Am Montag, dem 08.08.2022 um 10:14 +0200 schrieb jspi...@gmail.com:
> I corrected this for autotools. Something similar probably needs to
> be
> done for cmake.

Actually, I think cmake is already correct.

Jürgen

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Missing icons

2022-08-08 Thread jspitzm
Am Montag, dem 08.08.2022 um 03:26 +0200 schrieb Daniel:
> > The problem is present with installed LyX but not with LyX running
> > from source, AFAICS.
> > 
> > Stephan
> 
> Indeed, I am always using the installed version (since I never got it
> running from source).

The file icon.aliases was installed in the top dir, whereas it is
searched in images/

I corrected this for autotools. Something similar probably needs to be
done for cmake.

Jürgen

> 
> Daniel
> 
> 
> 

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-08-06 Thread jspitzm
Am Dienstag, dem 26.07.2022 um 10:25 -0400 schrieb Scott Kostyshak:
> See the attached example. The text "text part 2" is output as bold in
> 2.3.x, but is not output as bold in master (although it is displayed
> as bold in the LyX display).

Should be fixed at 8ac177f656da9db2 as far as I can tell. But since
this is so tricky to track, testing would be very welcome.

Thanks,
Jürgen


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel