Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 05.08.2020 um 12:39 schrieb Stephan Witt :
> 
> Am 02.08.2020 um 19:17 schrieb Daniel :
>> 
>> On 2020-08-02 18:10, Stephan Witt wrote:
>>> Am 02.08.2020 um 13:25 schrieb Daniel :
 
 On 2020-08-02 10:55, Stephan Witt wrote:
> Am 01.08.2020 um 16:51 schrieb Stephan Witt :
>> 
>> Am 01.08.2020 um 09:35 schrieb Daniel :
>>> 
>>> On 2020-08-01 09:32, Stephan Witt wrote:
 Am 31.07.2020 um 07:13 schrieb Daniel :
> 
> On 2020-07-30 21:21, Stephan Witt wrote:
>> Am 29.07.2020 um 22:59 schrieb Daniel :
>>> 
>>> On 2020-07-29 21:03, Stephan Witt wrote:
 Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :
> 
> #10571: Tabs not showing properly in macOS full (and split) screen
> ---+-
> Reporter:  racoon |   Owner:  lasgouttes
>   Type:  defect |  Status:  new
> Priority:  normal |   Milestone:
> Component:  general| Version:  2.2.2
> Severity:  normal |  Resolution:
> Keywords:  os=macosx  |
> ---+-
> 
> Comment (by racoon):
>>> 
>>> …
>>> 
> Okay, tested again. It happens under a special condition: when the 
> LyX window is previously maximized (not in fullscreen but maximized 
> by double clicking the title bar). So:
> 
> 1. Double click the title bar (maximizes the window)
 
 This one is configurable. Alternatively the double click sends it to 
 the dock (minimize it).
 
> 2. Click on View > Fullscreen (enters fullscreen)
> 3. Click on View > Fullscreen (exits fullscreen)
 
 I don’t understand what’s not working. It looks like maximizing the 
 window is not full-screen.
>>> 
>>> What I see here (Catalina) is that after existing the fullscreen via
>>> LyX's dedicated function (Step 3), the fullscreen is immediately
>>> re-activated. The only way to get out of it is using the WM's fullscreen
>>> button.
>> 
>> I see. This isn’t the case with my latests (not published) patch anymore 
>> (hopefully).
> Here is the current state of my patch to improve switch to/from 
> full-screen.
> It contains additional code to detect switch to/from window maximize 
> state.
> This is actually not used yet. On Mac it could be a possibility to 
> implement
> the switch to/from the state you’ve called „focus mode“. That’s why I 
> left it
> as is ATM. The final patch will be without it and the maximize state can 
> be done
> later. For now I’d like to ask Pavel how this is different and/or managed 
> on Linux.
> Perhaps it doesn’t work the same way as on Mac.
> Does it work as expected for you and on Linux? Can anyone test it on 
> Windows, please?
 
 Very nice!
 
 You haven't asked explicitly for macOS feedback but I guess that is 
 welcome as well.
>>> 
>>> Yes, thank you.
>>> 
 Seems to work almost perfectly on macOS now. There is one small exception: 
 when doing the last three steps mentioned above, the window gets out of 
 the maximized state. But it's really small. And maybe it's just a Qt bug.
>>> 
>>> There is a difference between maximized and full-screen state.
>>> 
>>> To be sure I understand your recipe:
>>> 
>>> 1. Maximize window (alt green dot)
>>> 2. Switch to full-screen (Command-Control-f)
>>> 3. Switch back from full-screen (Command-Control-f)
>>> 
>>> With these steps I can reproduce that LyX doesn’t return to maximized 
>>> state. This is correct - „code wise“,
>>> but the WM remembers the previous maximized state. So the behavior is 
>>> different when using the green dot to
>>> switch to and from full-screen. With the latter LyX returns to maximized 
>>> state.
>>> 
>>> The effect of the really small window I cannot reproduce. But it’s reported 
>>> already as ticket 11909 here:
>>> https://www.lyx.org/trac/ticket/11909 (IMO).
>> 
>> Oh, I am sorry. The reference of the "really small" was to "small
>> exception". I don't get a really small window. (Just the
>> pre-maximization state.)
> 
> I’ve checked this effect with Qt 5.9 on Mac.
> 
> This works for me. So I’d say it’s a Qt problem and we have to live with it.

Interestingly there is a bug QTBUG-57882 fixed with 5.10.0.

https://bugreports.qt.io/browse/QTBUG-57882 (Cannot show maximized window 
minimized)

Perhaps they’ve fixed something and now full-screen is broken.

I tried to use the new setWindowStates() method of QWindow but that doesn’t 
work either.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[racoon]

On 2020-08-05 12:39, Stephan Witt wrote:

Am 02.08.2020 um 19:17 schrieb Daniel :


On 2020-08-02 18:10, Stephan Witt wrote:

Am 02.08.2020 um 13:25 schrieb Daniel :


On 2020-08-02 10:55, Stephan Witt wrote:

Am 01.08.2020 um 16:51 schrieb Stephan Witt :


Am 01.08.2020 um 09:35 schrieb Daniel :


On 2020-08-01 09:32, Stephan Witt wrote:

Am 31.07.2020 um 07:13 schrieb Daniel :


On 2020-07-30 21:21, Stephan Witt wrote:

Am 29.07.2020 um 22:59 schrieb Daniel :


On 2020-07-29 21:03, Stephan Witt wrote:

Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :


#10571: Tabs not showing properly in macOS full (and split) screen
---+-
Reporter:  racoon |   Owner:  lasgouttes
Type:  defect |  Status:  new
Priority:  normal |   Milestone:
Component:  general| Version:  2.2.2
Severity:  normal |  Resolution:
Keywords:  os=macosx  |
---+-

Comment (by racoon):


…


Okay, tested again. It happens under a special condition: when the LyX window 
is previously maximized (not in fullscreen but maximized by double clicking the 
title bar). So:

1. Double click the title bar (maximizes the window)


This one is configurable. Alternatively the double click sends it to the dock 
(minimize it).


2. Click on View > Fullscreen (enters fullscreen)
3. Click on View > Fullscreen (exits fullscreen)


I don’t understand what’s not working. It looks like maximizing the window is 
not full-screen.


What I see here (Catalina) is that after existing the fullscreen via
LyX's dedicated function (Step 3), the fullscreen is immediately
re-activated. The only way to get out of it is using the WM's fullscreen
button.


I see. This isn’t the case with my latests (not published) patch anymore 
(hopefully).

Here is the current state of my patch to improve switch to/from full-screen.
It contains additional code to detect switch to/from window maximize state.
This is actually not used yet. On Mac it could be a possibility to implement
the switch to/from the state you’ve called „focus mode“. That’s why I left it
as is ATM. The final patch will be without it and the maximize state can be done
later. For now I’d like to ask Pavel how this is different and/or managed on 
Linux.
Perhaps it doesn’t work the same way as on Mac.
Does it work as expected for you and on Linux? Can anyone test it on Windows, 
please?


Very nice!

You haven't asked explicitly for macOS feedback but I guess that is welcome as 
well.


Yes, thank you.


Seems to work almost perfectly on macOS now. There is one small exception: when 
doing the last three steps mentioned above, the window gets out of the 
maximized state. But it's really small. And maybe it's just a Qt bug.


There is a difference between maximized and full-screen state.

To be sure I understand your recipe:

1. Maximize window (alt green dot)
2. Switch to full-screen (Command-Control-f)
3. Switch back from full-screen (Command-Control-f)

With these steps I can reproduce that LyX doesn’t return to maximized state. 
This is correct - „code wise“,
but the WM remembers the previous maximized state. So the behavior is different 
when using the green dot to
switch to and from full-screen. With the latter LyX returns to maximized state.

The effect of the really small window I cannot reproduce. But it’s reported 
already as ticket 11909 here:
https://www.lyx.org/trac/ticket/11909 (IMO).


Oh, I am sorry. The reference of the "really small" was to "small
exception". I don't get a really small window. (Just the
pre-maximization state.)


I’ve checked this effect with Qt 5.9 on Mac.

This works for me. So I’d say it’s a Qt problem and we have to live with it.

Stephan



Thanks for checking. As I said, it seem like a very small problem anyway.

Daniel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 04.08.2020 um 15:52 schrieb Jürgen Spitzmüller :
> 
> Am Dienstag, den 04.08.2020, 15:42 +0200 schrieb Stephan Witt:
>>> It would be good if someone on more standard linux environment like
>>> GNOME/KDE
>>> could test as well.
>> 
>> 
>> That would be good.
> 
> On GNOME I see no difference between master and stable.

Thank you.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 02.08.2020 um 19:17 schrieb Daniel :
> 
> On 2020-08-02 18:10, Stephan Witt wrote:
>> Am 02.08.2020 um 13:25 schrieb Daniel :
>>> 
>>> On 2020-08-02 10:55, Stephan Witt wrote:
 Am 01.08.2020 um 16:51 schrieb Stephan Witt :
> 
> Am 01.08.2020 um 09:35 schrieb Daniel :
>> 
>> On 2020-08-01 09:32, Stephan Witt wrote:
>>> Am 31.07.2020 um 07:13 schrieb Daniel :
 
 On 2020-07-30 21:21, Stephan Witt wrote:
> Am 29.07.2020 um 22:59 schrieb Daniel :
>> 
>> On 2020-07-29 21:03, Stephan Witt wrote:
>>> Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :
 
 #10571: Tabs not showing properly in macOS full (and split) screen
 ---+-
 Reporter:  racoon |   Owner:  lasgouttes
Type:  defect |  Status:  new
 Priority:  normal |   Milestone:
 Component:  general| Version:  2.2.2
 Severity:  normal |  Resolution:
 Keywords:  os=macosx  |
 ---+-
 
 Comment (by racoon):
>> 
>> …
>> 
 Okay, tested again. It happens under a special condition: when the LyX 
 window is previously maximized (not in fullscreen but maximized by 
 double clicking the title bar). So:
 
 1. Double click the title bar (maximizes the window)
>>> 
>>> This one is configurable. Alternatively the double click sends it to 
>>> the dock (minimize it).
>>> 
 2. Click on View > Fullscreen (enters fullscreen)
 3. Click on View > Fullscreen (exits fullscreen)
>>> 
>>> I don’t understand what’s not working. It looks like maximizing the 
>>> window is not full-screen.
>> 
>> What I see here (Catalina) is that after existing the fullscreen via
>> LyX's dedicated function (Step 3), the fullscreen is immediately
>> re-activated. The only way to get out of it is using the WM's fullscreen
>> button.
> 
> I see. This isn’t the case with my latests (not published) patch anymore 
> (hopefully).
 Here is the current state of my patch to improve switch to/from 
 full-screen.
 It contains additional code to detect switch to/from window maximize state.
 This is actually not used yet. On Mac it could be a possibility to 
 implement
 the switch to/from the state you’ve called „focus mode“. That’s why I left 
 it
 as is ATM. The final patch will be without it and the maximize state can 
 be done
 later. For now I’d like to ask Pavel how this is different and/or managed 
 on Linux.
 Perhaps it doesn’t work the same way as on Mac.
 Does it work as expected for you and on Linux? Can anyone test it on 
 Windows, please?
>>> 
>>> Very nice!
>>> 
>>> You haven't asked explicitly for macOS feedback but I guess that is welcome 
>>> as well.
>> 
>> Yes, thank you.
>> 
>>> Seems to work almost perfectly on macOS now. There is one small exception: 
>>> when doing the last three steps mentioned above, the window gets out of the 
>>> maximized state. But it's really small. And maybe it's just a Qt bug.
>> 
>> There is a difference between maximized and full-screen state.
>> 
>> To be sure I understand your recipe:
>> 
>> 1. Maximize window (alt green dot)
>> 2. Switch to full-screen (Command-Control-f)
>> 3. Switch back from full-screen (Command-Control-f)
>> 
>> With these steps I can reproduce that LyX doesn’t return to maximized state. 
>> This is correct - „code wise“,
>> but the WM remembers the previous maximized state. So the behavior is 
>> different when using the green dot to
>> switch to and from full-screen. With the latter LyX returns to maximized 
>> state.
>> 
>> The effect of the really small window I cannot reproduce. But it’s reported 
>> already as ticket 11909 here:
>> https://www.lyx.org/trac/ticket/11909 (IMO).
> 
> Oh, I am sorry. The reference of the "really small" was to "small
> exception". I don't get a really small window. (Just the
> pre-maximization state.)

I’ve checked this effect with Qt 5.9 on Mac.

This works for me. So I’d say it’s a Qt problem and we have to live with it.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Jürgen Spitzmüller]

Am Dienstag, den 04.08.2020, 15:42 +0200 schrieb Stephan Witt:
> > It would be good if someone on more standard linux environment like
> > GNOME/KDE
> > could test as well.
> 
> 
> That would be good.

On GNOME I see no difference between master and stable.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 03.08.2020 um 23:45 schrieb Pavel Sanda :
> 
> On Sun, Aug 02, 2020 at 10:55:55AM +0200, Stephan Witt wrote:
>> Here is the current state of my patch to improve switch to/from full-screen.
>> 
>> It contains additional code to detect switch to/from window maximize state.
>> This is actually not used yet. On Mac it could be a possibility to implement
>> the switch to/from the state you???ve called ???focus mode???. That???s why 
>> I left it
>> as is ATM. The final patch will be without it and the maximize state can be 
>> done
>> later. For now I???d like to ask Pavel how this is different and/or managed 
>> on Linux.
>> Perhaps it doesn???t work the same way as on Mac.
> 
> With this patch I don't see any loss of functionality for our innate 
> fullscreen lfun
> and improvement with handling of WM's signal. Few strange differences remain 
> (like
> the command buffer appearance mentioned earlier), but I consider the current 
> patch
> as an improvement already  - so please go on.

Thank you for the test.
I’ve put it in with change https://www.lyx.org/trac/changeset/6dcd4ca4/lyxgit.

In GuiWorkArea::setFullScreen I simplified the code and closed a gap in code 
path.
The setFrameStyle calls were redundant.

> It would be good if someone on more standard linux environment like GNOME/KDE
> could test as well.

That would be good.

Stephan

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Pavel Sanda]

On Sun, Aug 02, 2020 at 10:55:55AM +0200, Stephan Witt wrote:
> Here is the current state of my patch to improve switch to/from full-screen.
> 
> It contains additional code to detect switch to/from window maximize state.
> This is actually not used yet. On Mac it could be a possibility to implement
> the switch to/from the state you???ve called ???focus mode???. That???s why I 
> left it
> as is ATM. The final patch will be without it and the maximize state can be 
> done
> later. For now I???d like to ask Pavel how this is different and/or managed 
> on Linux.
> Perhaps it doesn???t work the same way as on Mac.

With this patch I don't see any loss of functionality for our innate fullscreen 
lfun
and improvement with handling of WM's signal. Few strange differences remain 
(like
the command buffer appearance mentioned earlier), but I consider the current 
patch
as an improvement already  - so please go on.

It would be good if someone on more standard linux environment like GNOME/KDE
could test as well.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Daniel]

On 2020-08-02 18:10, Stephan Witt wrote:

Am 02.08.2020 um 13:25 schrieb Daniel :


On 2020-08-02 10:55, Stephan Witt wrote:

Am 01.08.2020 um 16:51 schrieb Stephan Witt :


Am 01.08.2020 um 09:35 schrieb Daniel :


On 2020-08-01 09:32, Stephan Witt wrote:

Am 31.07.2020 um 07:13 schrieb Daniel :


On 2020-07-30 21:21, Stephan Witt wrote:

Am 29.07.2020 um 22:59 schrieb Daniel :


On 2020-07-29 21:03, Stephan Witt wrote:

Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :


#10571: Tabs not showing properly in macOS full (and split) screen
---+-
Reporter:  racoon |   Owner:  lasgouttes
Type:  defect |  Status:  new
Priority:  normal |   Milestone:
Component:  general| Version:  2.2.2
Severity:  normal |  Resolution:
Keywords:  os=macosx  |
---+-

Comment (by racoon):


…


Okay, tested again. It happens under a special condition: when the LyX window 
is previously maximized (not in fullscreen but maximized by double clicking the 
title bar). So:

1. Double click the title bar (maximizes the window)


This one is configurable. Alternatively the double click sends it to the dock 
(minimize it).


2. Click on View > Fullscreen (enters fullscreen)
3. Click on View > Fullscreen (exits fullscreen)


I don’t understand what’s not working. It looks like maximizing the window is 
not full-screen.


What I see here (Catalina) is that after existing the fullscreen via
LyX's dedicated function (Step 3), the fullscreen is immediately
re-activated. The only way to get out of it is using the WM's fullscreen
button.


I see. This isn’t the case with my latests (not published) patch anymore 
(hopefully).

Here is the current state of my patch to improve switch to/from full-screen.
It contains additional code to detect switch to/from window maximize state.
This is actually not used yet. On Mac it could be a possibility to implement
the switch to/from the state you’ve called „focus mode“. That’s why I left it
as is ATM. The final patch will be without it and the maximize state can be done
later. For now I’d like to ask Pavel how this is different and/or managed on 
Linux.
Perhaps it doesn’t work the same way as on Mac.
Does it work as expected for you and on Linux? Can anyone test it on Windows, 
please?


Very nice!

You haven't asked explicitly for macOS feedback but I guess that is welcome as 
well.


Yes, thank you.


Seems to work almost perfectly on macOS now. There is one small exception: when 
doing the last three steps mentioned above, the window gets out of the 
maximized state. But it's really small. And maybe it's just a Qt bug.


There is a difference between maximized and full-screen state.

To be sure I understand your recipe:

1. Maximize window (alt green dot)
2. Switch to full-screen (Command-Control-f)
3. Switch back from full-screen (Command-Control-f)

With these steps I can reproduce that LyX doesn’t return to maximized state. 
This is correct - „code wise“,
but the WM remembers the previous maximized state. So the behavior is different 
when using the green dot to
switch to and from full-screen. With the latter LyX returns to maximized state.

The effect of the really small window I cannot reproduce. But it’s reported 
already as ticket 11909 here:
https://www.lyx.org/trac/ticket/11909 (IMO).


Oh, I am sorry. The reference of the "really small" was to "small
exception". I don't get a really small window. (Just the
pre-maximization state.)

Daniel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 02.08.2020 um 17:52 schrieb Yu Jin :
> 
> Am So., 2. Aug. 2020 um 10:56 Uhr schrieb Stephan Witt :
> Does it work as expected for you and on Linux? Can anyone test it on Windows, 
> please?
> 
> I have tested on Windows. First I want to mention that your patch was 
> corrupted, git said "error: corrupted patch at line 21", I had to add a 
> whitespace at every empty line, then it worked.

Sorry for thank - but the patch file is a result of „git diff“ and not modified 
afterwards.

> Then I compiled the current master with your patch, tested all cases with the 
> steps I found reading this thread and the ticket on track; everything seems 
> to be working fine here, I have not found any suspicious behavior.

Thank you! I’ll put the basic change for full-screen switch in if Pavel 
confirms it.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 02.08.2020 um 13:25 schrieb Daniel :
> 
> On 2020-08-02 10:55, Stephan Witt wrote:
>> Am 01.08.2020 um 16:51 schrieb Stephan Witt :
>>> 
>>> Am 01.08.2020 um 09:35 schrieb Daniel :
 
 On 2020-08-01 09:32, Stephan Witt wrote:
> Am 31.07.2020 um 07:13 schrieb Daniel :
>> 
>> On 2020-07-30 21:21, Stephan Witt wrote:
>>> Am 29.07.2020 um 22:59 schrieb Daniel :
 
 On 2020-07-29 21:03, Stephan Witt wrote:
> Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :
>> 
>> #10571: Tabs not showing properly in macOS full (and split) screen
>> ---+-
>> Reporter:  racoon |   Owner:  lasgouttes
>>Type:  defect |  Status:  new
>> Priority:  normal |   Milestone:
>> Component:  general| Version:  2.2.2
>> Severity:  normal |  Resolution:
>> Keywords:  os=macosx  |
>> ---+-
>> 
>> Comment (by racoon):

…

>> Okay, tested again. It happens under a special condition: when the LyX 
>> window is previously maximized (not in fullscreen but maximized by 
>> double clicking the title bar). So:
>> 
>> 1. Double click the title bar (maximizes the window)
> 
> This one is configurable. Alternatively the double click sends it to the 
> dock (minimize it).
> 
>> 2. Click on View > Fullscreen (enters fullscreen)
>> 3. Click on View > Fullscreen (exits fullscreen)
> 
> I don’t understand what’s not working. It looks like maximizing the 
> window is not full-screen.
 
 What I see here (Catalina) is that after existing the fullscreen via
 LyX's dedicated function (Step 3), the fullscreen is immediately
 re-activated. The only way to get out of it is using the WM's fullscreen
 button.
>>> 
>>> I see. This isn’t the case with my latests (not published) patch anymore 
>>> (hopefully).
>> Here is the current state of my patch to improve switch to/from full-screen.
>> It contains additional code to detect switch to/from window maximize state.
>> This is actually not used yet. On Mac it could be a possibility to implement
>> the switch to/from the state you’ve called „focus mode“. That’s why I left it
>> as is ATM. The final patch will be without it and the maximize state can be 
>> done
>> later. For now I’d like to ask Pavel how this is different and/or managed on 
>> Linux.
>> Perhaps it doesn’t work the same way as on Mac.
>> Does it work as expected for you and on Linux? Can anyone test it on 
>> Windows, please?
> 
> Very nice!
> 
> You haven't asked explicitly for macOS feedback but I guess that is welcome 
> as well.

Yes, thank you.

> Seems to work almost perfectly on macOS now. There is one small exception: 
> when doing the last three steps mentioned above, the window gets out of the 
> maximized state. But it's really small. And maybe it's just a Qt bug.

There is a difference between maximized and full-screen state.

To be sure I understand your recipe:

1. Maximize window (alt green dot)
2. Switch to full-screen (Command-Control-f)
3. Switch back from full-screen (Command-Control-f)

With these steps I can reproduce that LyX doesn’t return to maximized state. 
This is correct - „code wise“,
but the WM remembers the previous maximized state. So the behavior is different 
when using the green dot to
switch to and from full-screen. With the latter LyX returns to maximized state.

The effect of the really small window I cannot reproduce. But it’s reported 
already as ticket 11909 here:
https://www.lyx.org/trac/ticket/11909 (IMO).

I tried it inside my almost virgin Catalina virtual machine…

> (While reading the fullscreen code, I also noticed a little strangeness, but 
> I guess it is not relevant here:
> 
> void GuiWorkArea::setFullScreen(bool full_screen)
> {
>   d->buffer_view_->setFullScreen(full_screen);
>   setFrameStyle(QFrame::NoFrame);
>   if (full_screen) {
>   setFrameStyle(QFrame::NoFrame);
>   if (lyxrc.full_screen_scrollbar)
>   setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
>   } else
>   setVerticalScrollBarPolicy(Qt::ScrollBarAsNeeded);
> }
> 
> Isn't the frame style applied independent of full_screen?

Yes, these setFrameStyle calls are completely redundant and can be removed.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Yu Jin]

Am So., 2. Aug. 2020 um 10:56 Uhr schrieb Stephan Witt :

> Does it work as expected for you and on Linux? Can anyone test it on
> Windows, please?
>

I have tested on Windows. First I want to mention that your patch was
corrupted, git said "error: corrupted patch at line 21", I had to add a
whitespace at every empty line, then it worked.
Then I compiled the current master with your patch, tested all cases with
the steps I found reading this thread and the ticket on track; everything
seems to be working fine here, I have not found any suspicious behavior.

-- 
Eugene
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Joel Kulesza]

On Sun, Aug 2, 2020 at 2:56 AM Stephan Witt  wrote:

>
> Does it work as expected for you and on Linux? Can anyone test it on
> Windows, please?
>

I can test on Windows 10 with a 4K display, but I cannot build.  If you can
send an installer, I'll give it a try.

Thanks,
Joel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Daniel]

On 2020-08-02 10:55, Stephan Witt wrote:

Am 01.08.2020 um 16:51 schrieb Stephan Witt :


Am 01.08.2020 um 09:35 schrieb Daniel :


On 2020-08-01 09:32, Stephan Witt wrote:

Am 31.07.2020 um 07:13 schrieb Daniel :


On 2020-07-30 21:21, Stephan Witt wrote:

Am 29.07.2020 um 22:59 schrieb Daniel :


On 2020-07-29 21:03, Stephan Witt wrote:

Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :


#10571: Tabs not showing properly in macOS full (and split) screen
---+-
Reporter:  racoon |   Owner:  lasgouttes
Type:  defect |  Status:  new
Priority:  normal |   Milestone:
Component:  general| Version:  2.2.2
Severity:  normal |  Resolution:
Keywords:  os=macosx  |
---+-

Comment (by racoon):

Replying to [comment:8 stwitt]:

Replying to [comment:7 racoon]:

Thanks. Yes, that is a better default given how LyX works currently.

Still '''if''' one activates to hide things in fullscreen there is a bug.
I'll try to take a look at it.


What is the effect of the bug? Are you talking about a new problem?


I am referring to the issue explained in comment:4. The bug is that UI
elements don't disappear when the WM's fullscreen mode is activated (and
the preferences set such that they should disappear). Quick steps to see
it:

1. Make sure tabs are set to show in fullscreen mode
2. In normal mode create two new document (so the tabs will show)
3. Enter the WM's fullscreen mode (click on green maximize button)
Result: The tabs are still there
4. Create another new document
Result: The tabs disappear

- Same for scrollbars.
- Toolbars never disappear.

So, the LyX's fullscreen mode seems not to be properly linked the WM's
fullscreen mode.

--
Ticket URL: 
The LyX Project 
LyX -- The Document Processor

The attached patch improves the situation on Mac. I’m confident that this is 
the right move.
But I’m unable to tell if it works on other platforms or if it breaks the 
current state.
Furthermore I’m not sure what to do with the remaining code in 
GuiView::toggleFullScreen().
Any comments on this, please?
Stephan


Thanks. I see two strange things:

1. Toolbars get reset after disabling the WM's fullscreen
Steps:
1.1 Move a toolbar to a non-default position
1.2 Enter the WM's fullscreen mode
1.3 leave the WM's fullscreen mode

Yes, the patch was not perfect. I posted it to get some feedback if the 
strategy works on other platforms.
I’ll improve it now I know it works in principle. Pavel tested it on Linux and 
saw some problems but confirmed it’s general function.

2. It is not possible to leave fullscreen using LyX's Fullscreen menu entry
Steps:
2.1 Click on menu View > Fullscreen
2.2 Click again on menu View > Fullscreen

This one I cannot see. Here it simply works.


Okay, tested again. It happens under a special condition: when the LyX window 
is previously maximized (not in fullscreen but maximized by double clicking the 
title bar). So:

1. Double click the title bar (maximizes the window)


This one is configurable. Alternatively the double click sends it to the dock 
(minimize it).


2. Click on View > Fullscreen (enters fullscreen)
3. Click on View > Fullscreen (exits fullscreen)


I don’t understand what’s not working. It looks like maximizing the window is 
not full-screen.


What I see here (Catalina) is that after existing the fullscreen via
LyX's dedicated function (Step 3), the fullscreen is immediately
re-activated. The only way to get out of it is using the WM's fullscreen
button.


I see. This isn’t the case with my latests (not published) patch anymore 
(hopefully).


Here is the current state of my patch to improve switch to/from full-screen.

It contains additional code to detect switch to/from window maximize state.
This is actually not used yet. On Mac it could be a possibility to implement
the switch to/from the state you’ve called „focus mode“. That’s why I left it
as is ATM. The final patch will be without it and the maximize state can be done
later. For now I’d like to ask Pavel how this is different and/or managed on 
Linux.
Perhaps it doesn’t work the same way as on Mac.

Does it work as expected for you and on Linux? Can anyone test it on Windows, 
please?


Very nice!

You haven't asked explicitly for macOS feedback but I guess that is 
welcome as well. Seems to work almost perfectly on macOS now. There is 
one small exception: when doing the last three steps mentioned above, 
the window gets out of the maximized state. But it's really small. And 
maybe it's just a Qt bug.


(While reading the fullscreen code, I also noticed a little strangeness, 
but I guess it is not relevant here:


void GuiWorkArea::setFullScreen(bool full_screen)
{
d->buffer_view_->setFullScreen(full_screen);
setFrameStyle(QFrame::NoFrame);
if (full_screen) {
setFrameStyle(QFrame::NoFrame);

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 01.08.2020 um 16:51 schrieb Stephan Witt :
> 
> Am 01.08.2020 um 09:35 schrieb Daniel :
>> 
>> On 2020-08-01 09:32, Stephan Witt wrote:
>>> Am 31.07.2020 um 07:13 schrieb Daniel :
 
 On 2020-07-30 21:21, Stephan Witt wrote:
> Am 29.07.2020 um 22:59 schrieb Daniel :
>> 
>> On 2020-07-29 21:03, Stephan Witt wrote:
>>> Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :
 
 #10571: Tabs not showing properly in macOS full (and split) screen
 ---+-
 Reporter:  racoon |   Owner:  lasgouttes
Type:  defect |  Status:  new
 Priority:  normal |   Milestone:
 Component:  general| Version:  2.2.2
 Severity:  normal |  Resolution:
 Keywords:  os=macosx  |
 ---+-
 
 Comment (by racoon):
 
 Replying to [comment:8 stwitt]:
> Replying to [comment:7 racoon]:
>> Thanks. Yes, that is a better default given how LyX works currently.
 Still '''if''' one activates to hide things in fullscreen there is a 
 bug.
 I'll try to take a look at it.
> 
> What is the effect of the bug? Are you talking about a new problem?
 
 I am referring to the issue explained in comment:4. The bug is that UI
 elements don't disappear when the WM's fullscreen mode is activated 
 (and
 the preferences set such that they should disappear). Quick steps to 
 see
 it:
 
 1. Make sure tabs are set to show in fullscreen mode
 2. In normal mode create two new document (so the tabs will show)
 3. Enter the WM's fullscreen mode (click on green maximize button)
 Result: The tabs are still there
 4. Create another new document
 Result: The tabs disappear
 
 - Same for scrollbars.
 - Toolbars never disappear.
 
 So, the LyX's fullscreen mode seems not to be properly linked the WM's
 fullscreen mode.
 
 --
 Ticket URL: 
 The LyX Project 
 LyX -- The Document Processor
>>> The attached patch improves the situation on Mac. I’m confident that 
>>> this is the right move.
>>> But I’m unable to tell if it works on other platforms or if it breaks 
>>> the current state.
>>> Furthermore I’m not sure what to do with the remaining code in 
>>> GuiView::toggleFullScreen().
>>> Any comments on this, please?
>>> Stephan
>> 
>> Thanks. I see two strange things:
>> 
>> 1. Toolbars get reset after disabling the WM's fullscreen
>> Steps:
>> 1.1 Move a toolbar to a non-default position
>> 1.2 Enter the WM's fullscreen mode
>> 1.3 leave the WM's fullscreen mode
> Yes, the patch was not perfect. I posted it to get some feedback if the 
> strategy works on other platforms.
> I’ll improve it now I know it works in principle. Pavel tested it on 
> Linux and saw some problems but confirmed it’s general function.
>> 2. It is not possible to leave fullscreen using LyX's Fullscreen menu 
>> entry
>> Steps:
>> 2.1 Click on menu View > Fullscreen
>> 2.2 Click again on menu View > Fullscreen
> This one I cannot see. Here it simply works.
 
 Okay, tested again. It happens under a special condition: when the LyX 
 window is previously maximized (not in fullscreen but maximized by double 
 clicking the title bar). So:
 
 1. Double click the title bar (maximizes the window)
>>> 
>>> This one is configurable. Alternatively the double click sends it to the 
>>> dock (minimize it).
>>> 
 2. Click on View > Fullscreen (enters fullscreen)
 3. Click on View > Fullscreen (exits fullscreen)
>>> 
>>> I don’t understand what’s not working. It looks like maximizing the window 
>>> is not full-screen.
>> 
>> What I see here (Catalina) is that after existing the fullscreen via
>> LyX's dedicated function (Step 3), the fullscreen is immediately
>> re-activated. The only way to get out of it is using the WM's fullscreen
>> button.
> 
> I see. This isn’t the case with my latests (not published) patch anymore 
> (hopefully).

Here is the current state of my patch to improve switch to/from full-screen.

It contains additional code to detect switch to/from window maximize state.
This is actually not used yet. On Mac it could be a possibility to implement
the switch to/from the state you’ve called „focus mode“. That’s why I left it
as is ATM. The final patch will be without it and the maximize state can be done
later. For now I’d like to ask Pavel how this is different and/or managed on 
Linux.
Perhaps it doesn’t work the same way as on Mac.

Does it work as expected for you and on Linux? Can anyone test it 

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 01.08.2020 um 09:35 schrieb Daniel :
> 
> On 2020-08-01 09:32, Stephan Witt wrote:
>> Am 31.07.2020 um 07:13 schrieb Daniel :
>>> 
>>> On 2020-07-30 21:21, Stephan Witt wrote:
 Am 29.07.2020 um 22:59 schrieb Daniel :
> 
> On 2020-07-29 21:03, Stephan Witt wrote:
>> Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :
>>> 
>>> #10571: Tabs not showing properly in macOS full (and split) screen
>>> ---+-
>>> Reporter:  racoon |   Owner:  lasgouttes
>>> Type:  defect |  Status:  new
>>> Priority:  normal |   Milestone:
>>> Component:  general| Version:  2.2.2
>>> Severity:  normal |  Resolution:
>>> Keywords:  os=macosx  |
>>> ---+-
>>> 
>>> Comment (by racoon):
>>> 
>>> Replying to [comment:8 stwitt]:
 Replying to [comment:7 racoon]:
> Thanks. Yes, that is a better default given how LyX works currently.
>>> Still '''if''' one activates to hide things in fullscreen there is a 
>>> bug.
>>> I'll try to take a look at it.
 
 What is the effect of the bug? Are you talking about a new problem?
>>> 
>>> I am referring to the issue explained in comment:4. The bug is that UI
>>> elements don't disappear when the WM's fullscreen mode is activated (and
>>> the preferences set such that they should disappear). Quick steps to see
>>> it:
>>> 
>>> 1. Make sure tabs are set to show in fullscreen mode
>>> 2. In normal mode create two new document (so the tabs will show)
>>> 3. Enter the WM's fullscreen mode (click on green maximize button)
>>> Result: The tabs are still there
>>> 4. Create another new document
>>> Result: The tabs disappear
>>> 
>>> - Same for scrollbars.
>>> - Toolbars never disappear.
>>> 
>>> So, the LyX's fullscreen mode seems not to be properly linked the WM's
>>> fullscreen mode.
>>> 
>>> --
>>> Ticket URL: 
>>> The LyX Project 
>>> LyX -- The Document Processor
>> The attached patch improves the situation on Mac. I’m confident that 
>> this is the right move.
>> But I’m unable to tell if it works on other platforms or if it breaks 
>> the current state.
>> Furthermore I’m not sure what to do with the remaining code in 
>> GuiView::toggleFullScreen().
>> Any comments on this, please?
>> Stephan
> 
> Thanks. I see two strange things:
> 
> 1. Toolbars get reset after disabling the WM's fullscreen
> Steps:
> 1.1 Move a toolbar to a non-default position
> 1.2 Enter the WM's fullscreen mode
> 1.3 leave the WM's fullscreen mode
 Yes, the patch was not perfect. I posted it to get some feedback if the 
 strategy works on other platforms.
 I’ll improve it now I know it works in principle. Pavel tested it on Linux 
 and saw some problems but confirmed it’s general function.
> 2. It is not possible to leave fullscreen using LyX's Fullscreen menu 
> entry
> Steps:
> 2.1 Click on menu View > Fullscreen
> 2.2 Click again on menu View > Fullscreen
 This one I cannot see. Here it simply works.
>>> 
>>> Okay, tested again. It happens under a special condition: when the LyX 
>>> window is previously maximized (not in fullscreen but maximized by double 
>>> clicking the title bar). So:
>>> 
>>> 1. Double click the title bar (maximizes the window)
>> 
>> This one is configurable. Alternatively the double click sends it to the 
>> dock (minimize it).
>> 
>>> 2. Click on View > Fullscreen (enters fullscreen)
>>> 3. Click on View > Fullscreen (exits fullscreen)
>> 
>> I don’t understand what’s not working. It looks like maximizing the window 
>> is not full-screen.
> 
> What I see here (Catalina) is that after existing the fullscreen via
> LyX's dedicated function (Step 3), the fullscreen is immediately
> re-activated. The only way to get out of it is using the WM's fullscreen
> button.

I see. This isn’t the case with my latests (not published) patch anymore 
(hopefully).

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Daniel]

On 2020-08-01 09:32, Stephan Witt wrote:

Am 31.07.2020 um 07:13 schrieb Daniel :


On 2020-07-30 21:21, Stephan Witt wrote:

Am 29.07.2020 um 22:59 schrieb Daniel :


On 2020-07-29 21:03, Stephan Witt wrote:

Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :


#10571: Tabs not showing properly in macOS full (and split) screen
---+-
Reporter:  racoon |   Owner:  lasgouttes
 Type:  defect |  Status:  new
Priority:  normal |   Milestone:
Component:  general| Version:  2.2.2
Severity:  normal |  Resolution:
Keywords:  os=macosx  |
---+-

Comment (by racoon):

Replying to [comment:8 stwitt]:

Replying to [comment:7 racoon]:

Thanks. Yes, that is a better default given how LyX works currently.

Still '''if''' one activates to hide things in fullscreen there is a bug.
I'll try to take a look at it.


What is the effect of the bug? Are you talking about a new problem?


I am referring to the issue explained in comment:4. The bug is that UI
elements don't disappear when the WM's fullscreen mode is activated (and
the preferences set such that they should disappear). Quick steps to see
it:

1. Make sure tabs are set to show in fullscreen mode
2. In normal mode create two new document (so the tabs will show)
3. Enter the WM's fullscreen mode (click on green maximize button)
Result: The tabs are still there
4. Create another new document
Result: The tabs disappear

- Same for scrollbars.
- Toolbars never disappear.

So, the LyX's fullscreen mode seems not to be properly linked the WM's
fullscreen mode.

--
Ticket URL: 
The LyX Project 
LyX -- The Document Processor

The attached patch improves the situation on Mac. I’m confident that this is 
the right move.
But I’m unable to tell if it works on other platforms or if it breaks the 
current state.
Furthermore I’m not sure what to do with the remaining code in 
GuiView::toggleFullScreen().
Any comments on this, please?
Stephan


Thanks. I see two strange things:

1. Toolbars get reset after disabling the WM's fullscreen
Steps:
1.1 Move a toolbar to a non-default position
1.2 Enter the WM's fullscreen mode
1.3 leave the WM's fullscreen mode

Yes, the patch was not perfect. I posted it to get some feedback if the 
strategy works on other platforms.
I’ll improve it now I know it works in principle. Pavel tested it on Linux and 
saw some problems but confirmed it’s general function.

2. It is not possible to leave fullscreen using LyX's Fullscreen menu entry
Steps:
2.1 Click on menu View > Fullscreen
2.2 Click again on menu View > Fullscreen

This one I cannot see. Here it simply works.


Okay, tested again. It happens under a special condition: when the LyX window 
is previously maximized (not in fullscreen but maximized by double clicking the 
title bar). So:

1. Double click the title bar (maximizes the window)


This one is configurable. Alternatively the double click sends it to the dock 
(minimize it).


2. Click on View > Fullscreen (enters fullscreen)
3. Click on View > Fullscreen (exits fullscreen)


I don’t understand what’s not working. It looks like maximizing the window is 
not full-screen.


What I see here (Catalina) is that after existing the fullscreen via
LyX's dedicated function (Step 3), the fullscreen is immediately
re-activated. The only way to get out of it is using the WM's fullscreen
button.

Daniel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 31.07.2020 um 07:13 schrieb Daniel :
> 
> On 2020-07-30 21:21, Stephan Witt wrote:
>> Am 29.07.2020 um 22:59 schrieb Daniel :
>>> 
>>> On 2020-07-29 21:03, Stephan Witt wrote:
 Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :
> 
> #10571: Tabs not showing properly in macOS full (and split) screen
> ---+-
> Reporter:  racoon |   Owner:  lasgouttes
> Type:  defect |  Status:  new
> Priority:  normal |   Milestone:
> Component:  general| Version:  2.2.2
> Severity:  normal |  Resolution:
> Keywords:  os=macosx  |
> ---+-
> 
> Comment (by racoon):
> 
> Replying to [comment:8 stwitt]:
>> Replying to [comment:7 racoon]:
>>> Thanks. Yes, that is a better default given how LyX works currently.
> Still '''if''' one activates to hide things in fullscreen there is a bug.
> I'll try to take a look at it.
>> 
>> What is the effect of the bug? Are you talking about a new problem?
> 
> I am referring to the issue explained in comment:4. The bug is that UI
> elements don't disappear when the WM's fullscreen mode is activated (and
> the preferences set such that they should disappear). Quick steps to see
> it:
> 
> 1. Make sure tabs are set to show in fullscreen mode
> 2. In normal mode create two new document (so the tabs will show)
> 3. Enter the WM's fullscreen mode (click on green maximize button)
> Result: The tabs are still there
> 4. Create another new document
> Result: The tabs disappear
> 
> - Same for scrollbars.
> - Toolbars never disappear.
> 
> So, the LyX's fullscreen mode seems not to be properly linked the WM's
> fullscreen mode.
> 
> -- 
> Ticket URL: 
> The LyX Project 
> LyX -- The Document Processor
 The attached patch improves the situation on Mac. I’m confident that this 
 is the right move.
 But I’m unable to tell if it works on other platforms or if it breaks the 
 current state.
 Furthermore I’m not sure what to do with the remaining code in 
 GuiView::toggleFullScreen().
 Any comments on this, please?
 Stephan
>>> 
>>> Thanks. I see two strange things:
>>> 
>>> 1. Toolbars get reset after disabling the WM's fullscreen
>>> Steps:
>>> 1.1 Move a toolbar to a non-default position
>>> 1.2 Enter the WM's fullscreen mode
>>> 1.3 leave the WM's fullscreen mode
>> Yes, the patch was not perfect. I posted it to get some feedback if the 
>> strategy works on other platforms.
>> I’ll improve it now I know it works in principle. Pavel tested it on Linux 
>> and saw some problems but confirmed it’s general function.
>>> 2. It is not possible to leave fullscreen using LyX's Fullscreen menu entry
>>> Steps:
>>> 2.1 Click on menu View > Fullscreen
>>> 2.2 Click again on menu View > Fullscreen
>> This one I cannot see. Here it simply works.
> 
> Okay, tested again. It happens under a special condition: when the LyX window 
> is previously maximized (not in fullscreen but maximized by double clicking 
> the title bar). So:
> 
> 1. Double click the title bar (maximizes the window)

This one is configurable. Alternatively the double click sends it to the dock 
(minimize it).

> 2. Click on View > Fullscreen (enters fullscreen)
> 3. Click on View > Fullscreen (exits fullscreen)

I don’t understand what’s not working. It looks like maximizing the window is 
not full-screen.

Stephan

> 
> (It's on Catalina macOS Catalina, 10.15.6.)
> 
> Daniel
> 
> -- 
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Daniel]

On 2020-07-30 21:21, Stephan Witt wrote:

Am 29.07.2020 um 22:59 schrieb Daniel :


On 2020-07-29 21:03, Stephan Witt wrote:

Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :


#10571: Tabs not showing properly in macOS full (and split) screen
---+-
Reporter:  racoon |   Owner:  lasgouttes
 Type:  defect |  Status:  new
Priority:  normal |   Milestone:
Component:  general| Version:  2.2.2
Severity:  normal |  Resolution:
Keywords:  os=macosx  |
---+-

Comment (by racoon):

Replying to [comment:8 stwitt]:

Replying to [comment:7 racoon]:

Thanks. Yes, that is a better default given how LyX works currently.

Still '''if''' one activates to hide things in fullscreen there is a bug.
I'll try to take a look at it.


What is the effect of the bug? Are you talking about a new problem?


I am referring to the issue explained in comment:4. The bug is that UI
elements don't disappear when the WM's fullscreen mode is activated (and
the preferences set such that they should disappear). Quick steps to see
it:

1. Make sure tabs are set to show in fullscreen mode
2. In normal mode create two new document (so the tabs will show)
3. Enter the WM's fullscreen mode (click on green maximize button)
Result: The tabs are still there
4. Create another new document
Result: The tabs disappear

- Same for scrollbars.
- Toolbars never disappear.

So, the LyX's fullscreen mode seems not to be properly linked the WM's
fullscreen mode.

--
Ticket URL: 
The LyX Project 
LyX -- The Document Processor

The attached patch improves the situation on Mac. I’m confident that this is 
the right move.
But I’m unable to tell if it works on other platforms or if it breaks the 
current state.
Furthermore I’m not sure what to do with the remaining code in 
GuiView::toggleFullScreen().
Any comments on this, please?
Stephan


Thanks. I see two strange things:

1. Toolbars get reset after disabling the WM's fullscreen
Steps:
1.1 Move a toolbar to a non-default position
1.2 Enter the WM's fullscreen mode
1.3 leave the WM's fullscreen mode


Yes, the patch was not perfect. I posted it to get some feedback if the 
strategy works on other platforms.

I’ll improve it now I know it works in principle. Pavel tested it on Linux and 
saw some problems but confirmed it’s general function.


2. It is not possible to leave fullscreen using LyX's Fullscreen menu entry
Steps:
2.1 Click on menu View > Fullscreen
2.2 Click again on menu View > Fullscreen


This one I cannot see. Here it simply works.


Okay, tested again. It happens under a special condition: when the LyX 
window is previously maximized (not in fullscreen but maximized by 
double clicking the title bar). So:


1. Double click the title bar (maximizes the window)
2. Click on View > Fullscreen (enters fullscreen)
3. Click on View > Fullscreen (exits fullscreen)

(It's on Catalina macOS Catalina, 10.15.6.)

Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 29.07.2020 um 22:59 schrieb Daniel :
> 
> On 2020-07-29 21:03, Stephan Witt wrote:
>> Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :
>>> 
>>> #10571: Tabs not showing properly in macOS full (and split) screen
>>> ---+-
>>> Reporter:  racoon |   Owner:  lasgouttes
>>> Type:  defect |  Status:  new
>>> Priority:  normal |   Milestone:
>>> Component:  general| Version:  2.2.2
>>> Severity:  normal |  Resolution:
>>> Keywords:  os=macosx  |
>>> ---+-
>>> 
>>> Comment (by racoon):
>>> 
>>> Replying to [comment:8 stwitt]:
 Replying to [comment:7 racoon]:
> Thanks. Yes, that is a better default given how LyX works currently.
>>> Still '''if''' one activates to hide things in fullscreen there is a bug.
>>> I'll try to take a look at it.
 
 What is the effect of the bug? Are you talking about a new problem?
>>> 
>>> I am referring to the issue explained in comment:4. The bug is that UI
>>> elements don't disappear when the WM's fullscreen mode is activated (and
>>> the preferences set such that they should disappear). Quick steps to see
>>> it:
>>> 
>>> 1. Make sure tabs are set to show in fullscreen mode
>>> 2. In normal mode create two new document (so the tabs will show)
>>> 3. Enter the WM's fullscreen mode (click on green maximize button)
>>> Result: The tabs are still there
>>> 4. Create another new document
>>> Result: The tabs disappear
>>> 
>>> - Same for scrollbars.
>>> - Toolbars never disappear.
>>> 
>>> So, the LyX's fullscreen mode seems not to be properly linked the WM's
>>> fullscreen mode.
>>> 
>>> -- 
>>> Ticket URL: 
>>> The LyX Project 
>>> LyX -- The Document Processor
>> The attached patch improves the situation on Mac. I’m confident that this is 
>> the right move.
>> But I’m unable to tell if it works on other platforms or if it breaks the 
>> current state.
>> Furthermore I’m not sure what to do with the remaining code in 
>> GuiView::toggleFullScreen().
>> Any comments on this, please?
>> Stephan
> 
> Thanks. I see two strange things:
> 
> 1. Toolbars get reset after disabling the WM's fullscreen
> Steps:
> 1.1 Move a toolbar to a non-default position
> 1.2 Enter the WM's fullscreen mode
> 1.3 leave the WM's fullscreen mode

Yes, the patch was not perfect. I posted it to get some feedback if the 
strategy works on other platforms.

I’ll improve it now I know it works in principle. Pavel tested it on Linux and 
saw some problems but confirmed it’s general function.

> 2. It is not possible to leave fullscreen using LyX's Fullscreen menu entry
> Steps:
> 2.1 Click on menu View > Fullscreen
> 2.2 Click again on menu View > Fullscreen

This one I cannot see. Here it simply works.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 30.07.2020 um 16:33 schrieb Pavel Sanda :
> 
> On Wed, Jul 29, 2020 at 09:03:27PM +0200, Stephan Witt wrote:
>> The attached patch improves the situation on Mac. I???m confident that this 
>> is the right move.
>> But I???m unable to tell if it works on other platforms or if it breaks the 
>> current state.
>> 
>> Furthermore I???m not sure what to do with the remaining code in 
>> GuiView::toggleFullScreen().
> 
> Why you did not move it inside the signal handler with the rest of the code?

Because of the save layout operation being too late after switch to 
full-screen. 

>> Any comments on this, please?
> 
> Didn't test extensively, but I can confirm that with this patch my wm (e16) 
> signal to full
> screen is now handled and is more similar to what lyx's innate full screen 
> lfun does.

Thank you, that’s encouraging.

> When called via wm signal I see two issues here - small white border around 
> the screen
> (the same as before) and the visibility status of command buffer is forgotten
> the area (new issue).

Sorry, I didn't tell you explicitly that it was a proof-of-concept patch.

With a real patch LyX should act on structure change events of the window with 
the layout save operation. 
After return from fullscreen the layout restore can happen. I’ll see how it 
goes and present another patch.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Pavel Sanda]

On Wed, Jul 29, 2020 at 09:03:27PM +0200, Stephan Witt wrote:
> The attached patch improves the situation on Mac. I???m confident that this 
> is the right move.
> But I???m unable to tell if it works on other platforms or if it breaks the 
> current state.
> 
> Furthermore I???m not sure what to do with the remaining code in 
> GuiView::toggleFullScreen().

Why you did not move it inside the signal handler with the rest of the code?

> Any comments on this, please?

Didn't test extensively, but I can confirm that with this patch my wm (e16) 
signal to full
screen is now handled and is more similar to what lyx's innate full screen lfun 
does.

When called via wm signal I see two issues here - small white border around the 
screen
(the same as before) and the visibility status of command buffer is forgotten
the area (new issue).

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Daniel]

On 2020-07-29 21:03, Stephan Witt wrote:

Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :


#10571: Tabs not showing properly in macOS full (and split) screen
---+-
Reporter:  racoon |   Owner:  lasgouttes
 Type:  defect |  Status:  new
Priority:  normal |   Milestone:
Component:  general| Version:  2.2.2
Severity:  normal |  Resolution:
Keywords:  os=macosx  |
---+-

Comment (by racoon):

Replying to [comment:8 stwitt]:

Replying to [comment:7 racoon]:

Thanks. Yes, that is a better default given how LyX works currently.

Still '''if''' one activates to hide things in fullscreen there is a bug.
I'll try to take a look at it.


What is the effect of the bug? Are you talking about a new problem?


I am referring to the issue explained in comment:4. The bug is that UI
elements don't disappear when the WM's fullscreen mode is activated (and
the preferences set such that they should disappear). Quick steps to see
it:

1. Make sure tabs are set to show in fullscreen mode
2. In normal mode create two new document (so the tabs will show)
3. Enter the WM's fullscreen mode (click on green maximize button)
Result: The tabs are still there
4. Create another new document
Result: The tabs disappear

- Same for scrollbars.
- Toolbars never disappear.

So, the LyX's fullscreen mode seems not to be properly linked the WM's
fullscreen mode.

--
Ticket URL: 
The LyX Project 
LyX -- The Document Processor


The attached patch improves the situation on Mac. I’m confident that this is 
the right move.
But I’m unable to tell if it works on other platforms or if it breaks the 
current state.

Furthermore I’m not sure what to do with the remaining code in 
GuiView::toggleFullScreen().

Any comments on this, please?

Stephan




Thanks. I see two strange things:

1. Toolbars get reset after disabling the WM's fullscreen
Steps:
1.1 Move a toolbar to a non-default position
1.2 Enter the WM's fullscreen mode
1.3 leave the WM's fullscreen mode

2. It is not possible to leave fullscreen using LyX's Fullscreen menu entry
Steps:
2.1 Click on menu View > Fullscreen
2.2 Click again on menu View > Fullscreen

Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

[Stephan Witt]

Am 29.07.2020 um 10:15 schrieb LyX Ticket Tracker :
> 
> #10571: Tabs not showing properly in macOS full (and split) screen
> ---+-
> Reporter:  racoon |   Owner:  lasgouttes
> Type:  defect |  Status:  new
> Priority:  normal |   Milestone:
> Component:  general| Version:  2.2.2
> Severity:  normal |  Resolution:
> Keywords:  os=macosx  |
> ---+-
> 
> Comment (by racoon):
> 
> Replying to [comment:8 stwitt]:
>> Replying to [comment:7 racoon]:
>>> Thanks. Yes, that is a better default given how LyX works currently.
> Still '''if''' one activates to hide things in fullscreen there is a bug.
> I'll try to take a look at it.
>> 
>> What is the effect of the bug? Are you talking about a new problem?
> 
> I am referring to the issue explained in comment:4. The bug is that UI
> elements don't disappear when the WM's fullscreen mode is activated (and
> the preferences set such that they should disappear). Quick steps to see
> it:
> 
> 1. Make sure tabs are set to show in fullscreen mode
> 2. In normal mode create two new document (so the tabs will show)
> 3. Enter the WM's fullscreen mode (click on green maximize button)
> Result: The tabs are still there
> 4. Create another new document
> Result: The tabs disappear
> 
> - Same for scrollbars.
> - Toolbars never disappear.
> 
> So, the LyX's fullscreen mode seems not to be properly linked the WM's
> fullscreen mode.
> 
> -- 
> Ticket URL: 
> The LyX Project 
> LyX -- The Document Processor

The attached patch improves the situation on Mac. I’m confident that this is 
the right move.
But I’m unable to tell if it works on other platforms or if it breaks the 
current state.

Furthermore I’m not sure what to do with the remaining code in 
GuiView::toggleFullScreen().

Any comments on this, please?

Stephan



ticket-10571.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel