Re: [LyX/master] Collect the outliner names for the children's tocs

[Guillaume Munch]

Le 21/01/2017 à 04:23, Scott Kostyshak a écrit :

LyX places the cursor at the correct spot, but the outliner is collapsed.
Before, the outliner was not collapsed.

There are other changes of behavior that can be seen, using this file.
For example, just clicking on "Section 2" or "Section 5", the outliner
does not highlight the section anymore like it used to.


For the record this is fixed at 15f64f84.

Re: [LyX/master] Collect the outliner names for the children's tocs

[Guillaume Munch]

Le 21/01/2017 à 04:23, Scott Kostyshak a écrit :

On Sat, Jan 14, 2017 at 11:16:29PM +0100, Guillaume Munch wrote:

commit 461fda9ca9a8079f235fe6d26031aa6b9c5ff36e
Author: Guillaume Munch 
Date:   Sat Jan 14 18:40:58 2017 +0100

Collect the outliner names for the children's tocs

Fixes missing outliner names in various situations. Now if the warning 
"Missing
outliner name" appears in the console, this correctly hints at an actual 
issue
with the layout.


I think this commit caused a change in behavior that I'm not sure was
intended.


Rather, it is the fault of 3391fed3




Can you reproduce?


Yes



I imagine you will have higher priority issues to look at when you come back
before this one, so no worries if you don't get to it for a while.



Indeed, not today. Thanks for your patience.

Re: [LyX/master] Collect the outliner names for the children's tocs

[Scott Kostyshak]

On Sat, Jan 14, 2017 at 11:16:29PM +0100, Guillaume Munch wrote:
> commit 461fda9ca9a8079f235fe6d26031aa6b9c5ff36e
> Author: Guillaume Munch 
> Date:   Sat Jan 14 18:40:58 2017 +0100
> 
> Collect the outliner names for the children's tocs
> 
> Fixes missing outliner names in various situations. Now if the warning 
> "Missing
> outliner name" appears in the console, this correctly hints at an actual 
> issue
> with the layout.

I think this commit caused a change in behavior that I'm not sure was
intended.

To reproduce, do the following:

1. Open examples/beamer-article.lyx
2. Open the outliner
3. Click on the arrow in the outliner next to the left of "Section 3"
4. Click on the first item in the outliner under "Section 3", titled "Frame: 
What are overlays?"

LyX places the cursor at the correct spot, but the outliner is collapsed.
Before, the outliner was not collapsed.

There are other changes of behavior that can be seen, using this file.
For example, just clicking on "Section 2" or "Section 5", the outliner
does not highlight the section anymore like it used to.

I believe the issue is particular to having a child document.

Can you reproduce?

I imagine you will have higher priority issues to look at when you come back
before this one, so no worries if you don't get to it for a while.

Scott


signature.asc
Description: PGP signature