Re: [LyX/master] Zoom slider

2021-04-06 Thread Pavel Sanda
On Tue, Apr 06, 2021 at 10:30:12AM +0200, Jürgen Spitzmüller wrote:
> I prefer the disabled version

Ok, I leave it the way it is.

> every thing I change on this UI triggers a new bag of requests.

To be clear I was not asking you to do it.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-04-06 Thread Jean-Marc Lasgouttes

Le 06/04/2021 à 10:30, Jürgen Spitzmüller a écrit :

Am Dienstag, dem 06.04.2021 um 09:07 +0200 schrieb Pavel Sanda:

Juergen, would you mind if slider and its buttons were toggling
between
visible/invisible rather than enabled/disabled?
It would look imho better when no document is loaded.


Ping.


I prefer the disabled version, but on the other hand, I begin to
develop indifference since every thing I change on this UI triggers a
new bag of requests.


A new preference maybe ? :-P

JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-04-06 Thread Jürgen Spitzmüller
Am Dienstag, dem 06.04.2021 um 09:07 +0200 schrieb Pavel Sanda:
> > Juergen, would you mind if slider and its buttons were toggling
> > between
> > visible/invisible rather than enabled/disabled?
> > It would look imho better when no document is loaded.
> 
> Ping.

I prefer the disabled version, but on the other hand, I begin to
develop indifference since every thing I change on this UI triggers a
new bag of requests.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-04-06 Thread Pavel Sanda
On Thu, Mar 25, 2021 at 01:18:24PM +0100, Pavel Sanda wrote:
> On Sun, Mar 07, 2021 at 01:24:29PM +0100, Juergen Spitzmueller wrote:
> > commit bdb006543b43f71a06fc5b9915d0df19aae0ef68
> > Author: Juergen Spitzmueller 
> > Date:   Sun Mar 7 13:29:23 2021 +0100
> > 
> > Zoom slider
> 
> Juergen, would you mind if slider and its buttons were toggling between
> visible/invisible rather than enabled/disabled?
> It would look imho better when no document is loaded.

Ping.

> Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-03-25 Thread Pavel Sanda
On Sun, Mar 07, 2021 at 01:24:29PM +0100, Juergen Spitzmueller wrote:
> commit bdb006543b43f71a06fc5b9915d0df19aae0ef68
> Author: Juergen Spitzmueller 
> Date:   Sun Mar 7 13:29:23 2021 +0100
> 
> Zoom slider

Juergen, would you mind if slider and its buttons were toggling between
visible/invisible rather than enabled/disabled?
It would look imho better when no document is loaded.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-03-07 Thread Jürgen Spitzmüller
Am Sonntag, dem 07.03.2021 um 13:53 +0100 schrieb Jean-Marc Lasgouttes:
> In libreoffice I see two difference that are IMO very useful:
> 1/ the zoom value is shown beside the slider. Seeing the zoom is very
> useful. At the very least, the tool tip should show the value instead
> of 
> explaining what it does.
> 
> 2/ having a small vertical line at the default level is nice.

This is now both done.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-03-07 Thread Kornel Benko
Am Sun, 07 Mar 2021 14:33:50 +0100
schrieb Jürgen Spitzmüller :

> Am Sonntag, dem 07.03.2021 um 14:18 +0100 schrieb Kornel Benko:
> > I get
> >   
> > > ---/usr2/src/lyx/lyx-git/src/frontends/qt/GuiView.cpp:633:31:
> > > error:  
> > ‘const class  
> > > QFontMetrics’ has no member named ‘horizontalAdvance’  
> >   zoomslider->setFixedWidth(fm.horizontalAdvance('x') * 15);  
> 
> Fixed.
> 
> Jürgen
> 

Yes, thanks.

Kornel


pgpVROgdq0_C2.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-03-07 Thread Jürgen Spitzmüller
Am Sonntag, dem 07.03.2021 um 14:18 +0100 schrieb Kornel Benko:
> I get
> 
> > ---/usr2/src/lyx/lyx-git/src/frontends/qt/GuiView.cpp:633:31:
> > error:
> ‘const class
> > QFontMetrics’ has no member named ‘horizontalAdvance’
>   zoomslider->setFixedWidth(fm.horizontalAdvance('x') * 15);

Fixed.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-03-07 Thread Kornel Benko
Am Sun,  7 Mar 2021 13:24:29 +0100 (CET)
schrieb Juergen Spitzmueller :

> commit bdb006543b43f71a06fc5b9915d0df19aae0ef68
> Author: Juergen Spitzmueller 
> Date:   Sun Mar 7 13:29:23 2021 +0100
> 
> Zoom slider

I get

> ---/usr2/src/lyx/lyx-git/src/frontends/qt/GuiView.cpp:633:31: error: ‘const 
> class
> QFontMetrics’ has no member named ‘horizontalAdvance’
  zoomslider->setFixedWidth(fm.horizontalAdvance('x') * 15);

This is with Qt5.9

Korneel


pgp6NB_9wCefb.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-03-07 Thread Jürgen Spitzmüller
Am Sonntag, dem 07.03.2021 um 13:53 +0100 schrieb Jean-Marc Lasgouttes:
> Looks like nothing is stopping you! I thought we were supposed to
> calm down on features...

Sorry about that. I'll stop it now.

> In libreoffice I see two difference that are IMO very useful:
> useful. At the very least, the tool tip should show the value instead
> of explaining what it does.

I thought about it. Wouldn't it be overkill to display it all the time,
as in writer? (this is a real question, I am undecided on that).

> 2/ having a small vertical line at the default level is nice.

I'll see what I can do.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Zoom slider

2021-03-07 Thread Jean-Marc Lasgouttes

Le 07/03/2021 à 13:24, Juergen Spitzmueller a écrit :

commit bdb006543b43f71a06fc5b9915d0df19aae0ef68
Author: Juergen Spitzmueller 
Date:   Sun Mar 7 13:29:23 2021 +0100

 Zoom slider


Looks like nothing is stopping you! I thought we were supposed to calm 
down on features...


In libreoffice I see two difference that are IMO very useful:
1/ the zoom value is shown beside the slider. Seeing the zoom is very 
useful. At the very least, the tool tip should show the value instead of 
explaining what it does.


2/ having a small vertical line at the default level is nice.

JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel