Re: [LyX/master] special character "allowbreak" (ZWSP), fileformat change

2017-04-21 Thread Scott Kostyshak 
On Fri, Apr 21, 2017 at 12:06:46PM +, Guenter Milde wrote:

> Fixed at f5ac0580ff8f4f1fd3.

Thanks for the quick fix. All tex2lyx tests pass on current master.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] special character "allowbreak" (ZWSP), fileformat change

2017-04-21 Thread Guenter Milde 
On 2017-04-21, Scott Kostyshak wrote:
> On Thu, Apr 20, 2017 at 11:29:55PM +0200, Günter Milde wrote:

>> commit f5ac0580ff8f4f1fd34d792f7952fb05d182e162
>> Author: Günter Milde 
>> Date:   Mon Mar 6 14:49:30 2017 +0100

>> special character "allowbreak" (ZWSP), fileformat change

...

> A bisect suggests that this commit broke the following test:

>   tex2lyx/roundtrip/box-color-size-space-align.tex (Failed)

> I'm guessing that the following test was also broken by this commit (but
> I only bisected based on the above test):

>   tex2lyx/cmplyx/box-color-size-space-align.tex (Failed)

> Günter will you have time to look into this today?

A sample files was saved with the wrong encoding after editing the
fileformat number.

Fixed at f5ac0580ff8f4f1fd3.

Sorry for the invonvenience,

Günter

Re: [LyX/master] special character "allowbreak" (ZWSP), fileformat change

2017-04-20 Thread Scott Kostyshak 
On Thu, Apr 20, 2017 at 11:29:55PM +0200, Günter Milde wrote:
> commit f5ac0580ff8f4f1fd34d792f7952fb05d182e162
> Author: Günter Milde 
> Date:   Mon Mar 6 14:49:30 2017 +0100
> 
> special character "allowbreak" (ZWSP), fileformat change
> 
> New special character to mark an optional line break
> without inserting a hyphen (ZWSP). See #10585.
> 
> Corresponds to the Unicode character U+200B ZERO WIDTH SPACE
> 
>  This isn't a “space”. It is an invisible character that can be used
>  to provide line break opportunities.
>  ​http://unicode.org/notes/tn27/
> 
> While the literal Unicode character can be used in the LyX
> file, it is invisible in the GUI.
> 
> For visible feedback, the patch adds a new special character "allowbreak".
> 
> The small mark is inspired by LibereOffice.
> A tooltip is added.

A bisect suggests that this commit broke the following test:

  tex2lyx/roundtrip/box-color-size-space-align.tex (Failed)

I'm guessing that the following test was also broken by this commit (but
I only bisected based on the above test):

  tex2lyx/cmplyx/box-color-size-space-align.tex (Failed)

Günter will you have time to look into this today?

Scott


signature.asc
Description: PGP signature